Commit Graph

109 Commits

Author SHA1 Message Date
Michel Weststrate
6b8eea8011 Bump example project deps to 0.79
Summary: This should have been automated, but I think the diff that landed the script and the actual release missed each other, so next time this should be automated

Reviewed By: passy

Differential Revision: D26782442

fbshipit-source-id: 205ab2e63bdff33f1ecea0a041d88a0a6ec6ae2d
2021-03-03 16:17:48 -08:00
Michel Weststrate
c1ce2fad90 Fix ReactNativeFlipperExample build
Summary: The React Native example project was broken for iOS. Fixed this by upgrading cocoapods locally, and bumping the Flipper version.

Reviewed By: passy, priteshrnandgaonkar

Differential Revision: D26777641

fbshipit-source-id: 889ff4f9de7c44240fe0a1b5d7d3c7c0b688d8ad
2021-03-03 05:05:05 -08:00
Michel Weststrate
d836b80273 Fix network plugin not working in example
Summary: Two diffs ago network plugin didn't seem to work correctly, fixed it by explicitly bumping / verifying that the latest SDK is used

Reviewed By: passy

Differential Revision: D25755993

fbshipit-source-id: 7cc0def113a84b0a66c728b479247f5c18ce79b8
2021-01-04 12:17:56 -08:00
Michel Weststrate
5471b844bc Apply react-native migration 0.62.2 -> 0.63.4
Summary:
In D25244631 (92bd68a371) we bumped the react-native dep of Flipper but we didn't apply the migration guide (sorry for missing that in the review), so the ReactNativeExample fell apart when trying to build for iOS. This diff applies the migration guide which nicely fixes that:

https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4

Recreating the Podfile.lock and running `./gradlew clean` fixed all build problems after that.

Verified that `yarn ios` and `yarn android`, and building from XCode all work.

Found (probably unrelated / existing) issues:
* custom plugins only show up after initial app start after refreshing the plugin list by navigating to another diffs first, so this seems to be a UI staleness bug
* Network plugin doesn't seem to work ion iOS (either not showing traffic or not showing data at all)

Reviewed By: passy

Differential Revision: D25755490

fbshipit-source-id: baea8b152fb252deda04291ec197ab87c2fbe3eb
2021-01-04 12:17:56 -08:00
Michel Weststrate
febb3deed9 Some dep bumps
Summary: Some dependency updates, mostly to prepare for next diff and update the podfile with the newest RN template

Reviewed By: passy

Differential Revision: D21749214

fbshipit-source-id: 0af10e404901a7522253136dc8c03020e7c813f8
2020-05-28 09:59:53 -07:00
Michel Weststrate
8a7e0578ff Update to rc.5
Summary:
* Followed plan of D20221558
* Manually bumped Flipper version on iOS to 0.33.1, which contains https://github.com/facebook/flipper/pull/874/files (make Flipper compatible with iOS 9).
* Will submit a PR on RN to bump the iOS template

Reviewed By: passy

Differential Revision: D20361824

fbshipit-source-id: 4f013b731b40e2d4f941742f9201bf2bb4382ec3
2020-03-10 09:02:30 -07:00
Michel Weststrate
f3fd8646e3 Upgrade example app to 0.62.0-rc.3
Summary:
^

1. Remove entire `react-native/ReactNativeExampleFlipper` folder
2. Run `npx react-native init --version 0.62.0-rc.3 ReactNativeExampleFlipper`
4. restore the `package.json` and `TicTacToe` file and import
5. removed `.eslintrc`, `_BUCK` and `build_defz.bzl`, `.watchmenconfig`

Added comments below to highlight the non-generated changes

Reviewed By: passy

Differential Revision: D20221558

fbshipit-source-id: da1c895a2b0e7ce48092e64cdb5ffdb9e4a1a10b
2020-03-04 19:00:20 -08:00
Janic Duplessis
44f5e35675 Implement react-native-flipper on iOS (#795)
Summary:
Implement the react-native-flipper native module on iOS. Uses very similar abstractions as on Android.

## Changelog

[react-native-flipper] Support iOS
Pull Request resolved: https://github.com/facebook/flipper/pull/795

Test Plan:
Tested using the RN TicTacToe example app

{F228406333}

Reviewed By: mweststrate

Differential Revision: D19853017

Pulled By: priteshrnandgaonkar

fbshipit-source-id: d93d35ff984b9ba75f812c4c8e3c82e4d550f0c0
2020-02-14 21:17:11 -08:00
Michel Weststrate
0fa0899299 Create React Native example project
Summary:
This diff creates a sample React Native project (based on the 0.62-rc.0 template).

This example is created like:
(Documenting this here as in the future this might be easier than upgrading the project itself)

1. Run `npx react-native init ReactNativeFlipperExample --version 0.62.0-rc.0`
2. Follow the installation steps to enable Flipper, that is, call `initializeFlipper(this, getReactNativeHost().getReactInstanceManager());` at the end of the `onCreate` method in `MainApplication.java`
3. Put `FlipperTicTacToe` in the root of the project, and call it from `App.js` as a component
4. install `react-native-flipper` as dependency
5. install `relative-deps` as dev dependency, and set it up as shown in `package.json`. This tool make sure that we build and test this project against the version of react-native-flipper in this repository, rather than against the one on NPM.
6. removed some stuff, like tests and linting, which is just in the way in this repo

This PR does not support iOS, as Flipper + RN iOS is still broken in 0.62.0-rc.0, and the current version of react-native-flipper doesn't support iOS yet either.

Documentation on how to set up Flipper in general is not part of this Diff

_N.B. since this is a **public** project, to be visible and runnable by our OSS community, the build setup is kept plain, vanilla, react-native, and **not** wired up to our normal / internal build processes. This is also the reason that lint suggestions beyond the license headers have been ignored. If any others should be applied, it is probably the official react native template that requires updating_

Reviewed By: passy

Differential Revision: D19449295

fbshipit-source-id: 2aeb6044f8dd01f09a95350c84fff2419d685a65
2020-01-23 04:47:52 -08:00