Summary:
This is only really an issue in theUIDebugger where we have a dynamic number of tabs. on some nodes you have 3 tabs, on others you have 2. if you select the 3rd tab and move to a node with 2 tabs nothing will be selected.
With this fix we will fallback to the first tab
Reviewed By: lblasa
Differential Revision: D50595977
fbshipit-source-id: 25c36a5609f774c2d3fd650eb6520104864fbe95
Summary: This seems to be (no longer) in use.
Reviewed By: lblasa
Differential Revision: D50659072
fbshipit-source-id: 0fde643711ee4859a5d270a878d858694337d6a5
Summary:
Key fix is
```diff
- 'Tabs:' + localStorageKeyOverride ?? keys.join(','),
+ 'Tabs:' + (localStorageKeyOverride ?? keys.join(',')),
```
Previously it worked like `('Tabs:' + localStorageKeyOverride) ?? keys.join(','),` which always evaluated to `"Tabs:undefined"`. This means that all tabs that were not using localStorageKeyOverride were reusing the same localstorage key. If you open some tabs with A, B, and C tabs. And open tab B. Then open other tabs with D, E, and F. No tab would be selected as the default value would be B.
The second part it extracing keys from `items` prop instead of children.
Reviewed By: lblasa
Differential Revision: D50411422
fbshipit-source-id: 30f70c4347649f29e8c8ff1f2f38fdca7e826198
Summary: When a user pastes anything, it is treated as an input for a search through the entire row
Reviewed By: lblasa
Differential Revision: D49948975
fbshipit-source-id: 2dd23d4ee0819623549d88eb077c7b2d2fdf604f
Summary:
When a user enters any arbitrary text, we will treat as an input for the search through the entire row.
Based on feedback from https://fb.workplace.com/groups/flippersupport/permalink/1703929480087703/
Reviewed By: lblasa
Differential Revision: D49911868
fbshipit-source-id: 4c569e4b01e468f0ca112ea4b00fe143b30bed2a
Summary: Old MasterDetail and DataTable (pre-power search) are using `extraActions` prop which no longer exists in teh new components. This diff adds a fallback.
Reviewed By: ivanmisuno
Differential Revision: D49869730
fbshipit-source-id: 4c1a658aa94acc770836f9bf296a3df7d6cdcb3e
Summary: Some columns set title to an empty string
Reviewed By: lblasa
Differential Revision: D49826852
fbshipit-source-id: 3661394323dade813295420a1186d9297a8be153
Summary: We treat every column without the power search config as if it contains strings. Sometimes that might bite us, for instance, when the column contains an object.
Reviewed By: lblasa
Differential Revision: D49822511
fbshipit-source-id: 18dadb5abe624fae510663fc26668b2b594899c3
Summary: Having default and extra actions at the bottom is not actionable. Users are used to haveing table controls on the top.
Reviewed By: LukeDefeo, aigoncharov
Differential Revision: D49538205
fbshipit-source-id: 724a31dc44de79cb0e09efae48dd2135450b34ae
Summary: Make non-interactive elements non-focusable and disable hover styles for them
Reviewed By: LukeDefeo
Differential Revision: D49455532
fbshipit-source-id: a047e1a149ab4131feef70b80a4995b455441701
Summary: Each search term renderer handles its "editing" state internally now. As a result, we can simplify switch-case
Reviewed By: antonk52
Differential Revision: D49454252
fbshipit-source-id: 297ce73f53772b0112ed338c6aac0583f3807ec8
Summary: For the purposes of the demo I added power search config for a float field to the summary field
Reviewed By: lblasa
Differential Revision: D49452844
fbshipit-source-id: 26aaadd07a1a8a67dfcf3cb9d8e487f8f4ee2214
Summary: For the purposes of the demo I added power search config for an integer field to the summary field
Reviewed By: lblasa
Differential Revision: D49452729
fbshipit-source-id: 78b8fdccfd799a0f71f652d90d10e11db237cbae
Summary:
At the end of the stack we are going to unify two branches of the switch-case in PowerSearchTerm.tsx.
Each search term is going to handle the finalized and "editing" mode internally
Reviewed By: lblasa
Differential Revision: D49451975
fbshipit-source-id: 587ba332d1fbfbaefb368e37965543575e64062f
