Commit Graph

3077 Commits

Author SHA1 Message Date
Pascal Hartig
d8be529307 Add docs for verifying changes (#802)
Summary:
Per title.
Pull Request resolved: https://github.com/facebook/flipper/pull/802

Test Plan: corgi_eyes

Reviewed By: mweststrate

Differential Revision: D19903845

Pulled By: passy

fbshipit-source-id: 8bd1c05d6b73f4d270bc5944983c24276dc5bfdd
2020-02-14 12:58:59 -08:00
Pascal Hartig
b4fa7be97c Upload Flipper artifacts from GH Actions (#801)
Summary:
This makes testing and verifying of PRs much easier as you can directly download the resulting artifact from GitHub.

Close https://github.com/facebook/flipper/issues/796.
Pull Request resolved: https://github.com/facebook/flipper/pull/801

Test Plan: https://github.com/facebook/flipper/runs/446036416

Reviewed By: mweststrate

Differential Revision: D19903724

Pulled By: passy

fbshipit-source-id: 9efe37e93b2373d1ec98640496322ad85ea9a21b
2020-02-14 12:55:48 -08:00
Pascal Hartig
96c4d24cb9 Add boilerplate test
Summary: To verify that the infra is working.

Reviewed By: mweststrate

Differential Revision: D19881083

fbshipit-source-id: 92d5f55ecbef84003b6000b4c95df1fe0518719c
2020-02-14 12:52:49 -08:00
Michael Lefkowitz
cadf0fc6d7 Update network-plugin.md (#797)
Summary:
fixes typo

## Changelog

- fixes typo on network page
Pull Request resolved: https://github.com/facebook/flipper/pull/797

Test Plan: n/a

Reviewed By: priteshrnandgaonkar

Differential Revision: D19902534

Pulled By: passy

fbshipit-source-id: fc25d8a1fc0889a1b4e5003c724781f54d01f65d
2020-02-14 10:11:46 -08:00
John Knox
a24b043df0 Allow websocket connections from browser
Summary: Gets flipper to open up a websocket server for web browser connections.

Reviewed By: passy, priteshrnandgaonkar

Differential Revision: D19501123

fbshipit-source-id: e506f35d7ddce622128932494e8bb10802d3747b
2020-02-13 13:56:37 -08:00
Pascal Hartig
9f899c7026 Upgrade to SoLoader 0.8.2
Summary: No changes that should impact us in any way.

Reviewed By: priteshrnandgaonkar

Differential Revision: D19856578

fbshipit-source-id: 35113b4b9e56b6c0b09681ac5649705cf840f60c
2020-02-13 12:06:53 -08:00
Pascal Hartig
6f15e29b99 Set up project skeleton for flipper-pkg
Summary: TypeScript cli tool basics.

Reviewed By: jknoxville, nikoant

Differential Revision: D19856513

fbshipit-source-id: da148d1435c09221f74dc94285b655bed53d0494
2020-02-13 09:08:41 -08:00
Sarah Dong
00bfa39992 Integrate bloks into flipper and monitor state updates
Summary: Client implementation for the flipper send data lispy api

Reviewed By: adamjernst

Differential Revision: D19862378

fbshipit-source-id: 7a5cc8b47772bdbc0e89d723d0099ff824a81ed5
2020-02-13 08:58:06 -08:00
Pritesh Nandgaonkar
d99635c85e Update getting started docs
Summary: This diff updates the getting started docs for the pure Objective-C project

Reviewed By: passy

Differential Revision: D19878236

fbshipit-source-id: 3898f28214072e89c46f1bcd9443b61b8a639cab
2020-02-13 08:51:58 -08:00
Pritesh Nandgaonkar
db6edb9eee Remove dummy swift file
Summary: Removed the swift files in Sample app and instead added swift library paths in search paths

Reviewed By: passy

Differential Revision: D19877848

fbshipit-source-id: fdaeba8ba4ed58216e413125b29fe20bad9d03f5
2020-02-13 08:51:58 -08:00
Andres Suarez
58caa91fa4 Daily arc lint --take GOOGLEJAVAFORMAT
Summary:
Changelog:
[Internal]

Differential Revision: D19875191

fbshipit-source-id: 3a1e22a4342d523f556c847a9fa780a898a96771
2020-02-13 05:50:13 -08:00
greenkeeper[bot]
eeabb5dd13 Update react-debounce-render to the latest version � (#778)
Summary:
## The dependency [react-debounce-render](https://github.com/podefr/react-debounce-render) was updated from `5.0.0` to `6.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

 ---

**Publisher:** [podefr](https://www.npmjs.com/~podefr)
**License:** MIT

[Find out more about this release](https://github.com/podefr/react-debounce-render).

 ---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

 ---

Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/778

Reviewed By: jknoxville

Differential Revision: D19854350

Pulled By: passy

fbshipit-source-id: f874123004e8551cd041eb4a1b3fe77ce187921c
2020-02-13 04:12:28 -08:00
Anton Nikolaev
707759f096 Install pre-bundled packages 2/N
Summary: A first simple version of pre-bundled plugin installation. Currently both pre-bundled and source-only plugins are supported. Pre-bundled plugins should have folder "dist" inside and package.json's "main" field should point to the entry point script there.

Reviewed By: passy

Differential Revision: D19834020

fbshipit-source-id: 7e0b495fb9666acbb22fc32ca2382339cd9dc72f
2020-02-12 04:57:31 -08:00
Andres Suarez
c315691b2d Apply clang-format
Differential Revision: D19843069

fbshipit-source-id: af3f3998e2259ca5070b43ffb19933cf9304319d
2020-02-11 19:29:23 -08:00
Anton Nikolaev
71928fdf08 Install pre-bundled packages 1/N
Summary: No functional changes in this diff. This is just plugin manager refactoring before implementing  new functionality for installing pre-bundled packages.

Reviewed By: passy

Differential Revision: D19832078

fbshipit-source-id: 56b7ff1c68b6beb4abb2941da607651268e5f71a
2020-02-11 12:54:06 -08:00
Michel Weststrate
463e8a7984 Show progress bar during metro rebuilds
Summary: Tiny detail, but this shows a progress bar in the reload button, just like the console.logs of metro do normally

Reviewed By: jknoxville

Differential Revision: D19813243

fbshipit-source-id: 70b360d55776fab08c81664c6cabf998402bbba6
2020-02-11 07:29:40 -08:00
Michel Weststrate
6fe69f6fc0 Make sure Metro's own messages are logged as well
Summary: This diff logs the Metro messages as well so that the logs also show it Metro dies or something

Reviewed By: jknoxville

Differential Revision: D19791112

fbshipit-source-id: 477ccdd291df90e49b016d4aeae121d4d81a3835
2020-02-11 07:29:39 -08:00
Michel Weststrate
535ed88bc3 Unwrap device plugins in sidebar in certain scenarios
Summary:
This diff removes the 'device plugins' section, and shows plugin at top level in certain scenarios:

- there are no other clients
- there is only one device plugin
- the device has been imported

This removes visual clutter

Reviewed By: nikoant

Differential Revision: D19789511

fbshipit-source-id: 6a5fce120ac811428662828ee43f7ab7f3331362
2020-02-11 07:29:39 -08:00
Michel Weststrate
3dcfe9f3ae Move Metro control buttons to titlebar
Summary:
The Metro control buttons are now in the titlebar. This has a few benefits:
- the buttons are accessible if you are inspecting other metro plugins
- the buttons are even usuable if you selected an app on the actual device. This should help with reducing the cognitive dissonance of having apps both as 'android' app and metro device
- killed the Metro plugin again :)

Reviewed By: nikoant

Differential Revision: D19789455

fbshipit-source-id: 476fd0af1d3fc7b51a33f1af6d3fc3578aeeefae
2020-02-11 07:29:39 -08:00
Michel Weststrate
182b2a629d Fixed bug where location bar remained active but empty on apps / devices that don't have nav
Summary: Fixed bug where location bar remained active but empty on apps / devices that don't have nav

Reviewed By: nikoant

Differential Revision: D19788337

fbshipit-source-id: c5f7299945783672164ed03d487a023ddaadc082
2020-02-11 07:29:38 -08:00
Michel Weststrate
dfcfca4370 Support logging in metro plugin
Summary: Show metro logs using the standard logs plugin

Reviewed By: passy

Differential Revision: D19697439

fbshipit-source-id: 032a9a6aa2d987945d2058e0ea494d74e5aa310e
2020-02-11 07:29:38 -08:00
Michel Weststrate
437ec11ca7 Introduce Metro device and plugin
Summary: Introduced Metro device and the possibility to directly connect to running Metro instances

Reviewed By: jknoxville

Differential Revision: D19445623

fbshipit-source-id: 31978d966a56007c48f795076d6651e23de0e38d
2020-02-11 07:29:38 -08:00
Jonathan Thomas
014524ec26 Introduce way to clear SearchableTable search term on mount
Summary:
In order to link to this plugin multiple times, we want to be able to clear the existing search term on entry.

This change adds a check to the `componentDidMount` section of `Searchable` to see if we want to update the existing search term from the saved state, or use the one inherited from props.

We call it from the Network tab depending on if an explicit default search term has been set, so normal navigation to and from the plugin still preserves the default behavior -- only when we enter from a `selectPlugin` call does this overwrite the existing term.

Reviewed By: mweststrate

Differential Revision: D19794860

fbshipit-source-id: 4a2b1221acc0732ffc321a16a5eee8348da019f5
2020-02-11 07:22:18 -08:00
Pascal Hartig
9cc5158975 Flipper Bump: v0.31.2-SNAPSHOT
Summary: Back to snapshots.

Reviewed By: cekkaewnumchai

Differential Revision: D19832702

fbshipit-source-id: 680451a85cc718b9cb933d7cea9f1208d0770a03
2020-02-11 06:09:59 -08:00
Pascal Hartig
effa2ec5a5 Flipper Release: v0.31.1
Summary: Bugfix release for startup problem.

Reviewed By: cekkaewnumchai

Differential Revision: D19832703

fbshipit-source-id: 75451e39f53b2d231e1ad10219b37620593f0998
2020-02-11 06:09:58 -08:00
Pritesh Nandgaonkar
c8548e8063 Always allow user to select group
Summary: This diff always allows user to select the group irrespective of the validation error. We will show the validation error at the bottom before letting them submit.

Reviewed By: passy

Differential Revision: D19816805

fbshipit-source-id: ff576a2101a5ed548c56a2f08da8d27457ebf332
2020-02-11 05:48:47 -08:00
greenkeeper[bot]
17e6e454f5 Greenkeeper/immer 5.3.5
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/788

Reviewed By: passy

Differential Revision: D19815556

Pulled By: jknoxville

fbshipit-source-id: 22c20765b812588b27e005fafc8857cc5a9e7036
2020-02-11 05:22:15 -08:00
John Knox
7a31dd103d Upgrade @types/jest
Summary: Fixes #781

Reviewed By: passy, nikoant

Differential Revision: D19815319

fbshipit-source-id: c491ebb391e8d8508b339483d0e3708bce1c8cf6
2020-02-11 05:03:13 -08:00
greenkeeper[bot]
dae1caee29 chore(package): update @typescript-eslint/parser to version 2.19.2 (#792)
Summary:
Close https://github.com/facebook/flipper/issues/789
Pull Request resolved: https://github.com/facebook/flipper/pull/792

Reviewed By: mweststrate

Differential Revision: D19832374

Pulled By: passy

fbshipit-source-id: 3c13e621905e13e705a7399731fc7b9b23d22e25
2020-02-11 04:15:51 -08:00
greenkeeper[bot]
94ac63dc48 chore(package): update @typescript-eslint/eslint-plugin to version 2.… (#791)
Summary:
Fixes https://github.com/facebook/flipper/issues/790
Pull Request resolved: https://github.com/facebook/flipper/pull/791

Reviewed By: mweststrate

Differential Revision: D19832361

Pulled By: passy

fbshipit-source-id: 88ae5e63ce3c6403650032df83df69e1d6b4d001
2020-02-11 04:15:51 -08:00
John Knox
c2ed83c70d Upgrade react-docgen
Summary: Fixes #781

Reviewed By: passy

Differential Revision: D19815114

fbshipit-source-id: 2c223ceaaa5d9b5e47bdaf8c705db2eef527339f
2020-02-10 18:43:00 -08:00
Pritesh Nandgaonkar
b75c52bd49 Newer versions of mkdirp return promise by default
Summary: Newer versions of mkdirp return promise by default, no need to promisify it.

Reviewed By: passy

Differential Revision: D19815799

fbshipit-source-id: 9e339021f2be8a82cd23c87d2b3248fea591779c
2020-02-10 12:03:14 -08:00
greenkeeper[bot]
018b074ec3 Update flow-bin to the latest version � (#780)
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.117.0` to `0.118.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

 ---

**Publisher:** [samwgoldman](https://www.npmjs.com/~samwgoldman)
**License:** MIT

[Find out more about this release](https://github.com/flowtype/flow-bin).

 ---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

 ---

Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/780

Reviewed By: jknoxville

Differential Revision: D19813983

Pulled By: passy

fbshipit-source-id: 34265730b8d5ae48568f92421344835b557660fd
2020-02-10 08:59:52 -08:00
Pascal Hartig
80442e2f38 Flipper Bump: v0.31.1-SNAPSHOT
Reviewed By: priteshrnandgaonkar

Differential Revision: D19813090

fbshipit-source-id: 94d34e5af8adbc5a7d28782f6c70f16fee4844d7
2020-02-10 07:03:07 -08:00
Pascal Hartig
72a140bd96 Flipper Release: v0.31.0
Summary:
== Highlights ==

- Database query favourites are now persisted across sessions (b0caaa7)
- Allow disabling iOS development in Settings
(aab004a)
- Various improvements to the sidebar
- FPS graph to visualize slow UIs for plugin developers (31df1db)
- Window theme attributes when clicking on a window in the inspector (c430fc3)
- Removed Stetho dependency (48d6ea4). Thanks, ZacSweers!
- Install plugins directly from package files (b9e7f5d6d1)

== Fixes ==

-  Mac plugins not showing up (02e0233)
- Doctor: log both shown and suppressed warnings (35d62e70cb). Thanks, mateosilguero!
- Fix default SDK path on Windows (e178221)
-  Doctor complains Android SDK is not installed
(b625efe)
-  Update welcome screen links (33ad41c)
- Fix 'Timed out waiting for device' error (060e8c0)

Reviewed By: priteshrnandgaonkar

Differential Revision: D19813089

fbshipit-source-id: 8b1fc6fb140d02b7f78adcadd7c45a3ed1755f2f
2020-02-10 07:03:07 -08:00
Anton Nikolaev
29258c3168 VSCode task to attach to both Main and Renderer processes simultaneously
Summary: The task for attaching to both Main and Renderer processes makes debugging in certain scenarios easier.

Reviewed By: passy

Differential Revision: D19813764

fbshipit-source-id: d81e07e5fb135b5bb904a3f6532347eca1a9bbb1
2020-02-10 06:26:51 -08:00
John Knox
6712182fd1 Capture screenshot during export
Summary:
^

context: https://fb.workplace.com/groups/flippersupport/permalink/804152663398727/

Reviewed By: passy

Differential Revision: D19747718

fbshipit-source-id: 30a06446ba3d7d103332580ab5baad59bbc2481c
2020-02-10 06:05:17 -08:00
Janic Duplessis
912bfed0f8 Allow Flipper module instances to be created by applications (#786)
Summary:
This allows using the flipper RN module with TurboModules instead of using FlipperPackage.

## Changelog

[react-native-flipper] Allow Flipper module instances to be created by applications
Pull Request resolved: https://github.com/facebook/flipper/pull/786

Test Plan:
An instance of the Flipper module can now be created like this when using TurboModules:

```java
  Override
  public NativeModule getModule(String name, ReactApplicationContext reactContext) {
    switch (name) {
      ...
      case FlipperModule.NAME:
        return new FlipperModule(FlipperReactNativeJavaScriptPluginManager.getInstance(), reactContext);
      ...
    }
  }
```

Tested that it builds

Reviewed By: mweststrate

Differential Revision: D19812912

Pulled By: passy

fbshipit-source-id: 401b3e4552ea0cdb7444a2cf5d170c408edab4db
2020-02-10 05:54:55 -08:00
Pascal Hartig
63c8a3a417 Icon update
Summary: ^

Reviewed By: mweststrate

Differential Revision: D19813331

fbshipit-source-id: c1aaff5f624520b9a4dfae59c74080cb82e627ec
2020-02-10 05:51:55 -08:00
Anton Nikolaev
611870e344 Some plugin dependencies are not installed on plugin installation (#787)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/787

https://github.com/facebook/flipper/issues/785

Reviewed By: jknoxville

Differential Revision: D19813491

fbshipit-source-id: 3ae99720fc85d5bd46e91779cc8b10c2853e581f
2020-02-10 05:49:30 -08:00
greenkeeper[bot]
000ef9e8fd Update @types/rsocket-core to the latest version � (#784)
Summary:
## The devDependency [types/rsocket-core](https://github.com/DefinitelyTyped/DefinitelyTyped) was updated from `0.0.3` to `0.0.4`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

 ---

**Publisher:** [types](https://www.npmjs.com/~types)
**License:** MIT

[Find out more about this release](https://github.com/DefinitelyTyped/DefinitelyTyped).

 ---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

 ---

Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/784

Reviewed By: cekkaewnumchai

Differential Revision: D19805486

Pulled By: passy

fbshipit-source-id: 7f5168669f571b31da81225fd6736facdc1c7cee
2020-02-10 04:45:58 -08:00
Anton Nikolaev
99d4d44957 VSCode debug task for debugging main process
Summary: Just a small task to make debugging of the main process easier

Reviewed By: jknoxville

Differential Revision: D19792592

fbshipit-source-id: 9d1060dbb58a01615230bff2361144cfc88e41b7
2020-02-10 03:44:55 -08:00
Jonathan Thomas
991b00f163 Expand deepLinkPayload format for Network tab
Summary: In order to select IDs in a different manner, I am introducing functionality to the Network plugin to allow it to accept more than just IDs that it has assigned, and add the ability to select this plugin with a default search term. I hope to use this to allow for selecting rows by request name.

Reviewed By: mweststrate

Differential Revision: D19702494

fbshipit-source-id: 58ea397fa30eb7d80e9640a4c92905de22bb27d4
2020-02-07 15:16:32 -08:00
John Knox
2acf81027e Refactor screenshot capturing
Summary: Adding a utility for capturing screenshots to the configured location without having to worry about where to store it or use buffers etc.

Reviewed By: mweststrate

Differential Revision: D19765926

fbshipit-source-id: d6b51c4ffafab7450e97a60468926d84a25a8c0f
2020-02-07 12:52:52 -08:00
Sabrina Seibel
f0a482af2f NTState Flipper Plugin starter code
Summary: Barebones outline for the NTState Flipper Plugin

Differential Revision: D19667842

fbshipit-source-id: 484476da8fbed3ff80c063652b62296d91425bfe
2020-02-07 12:48:57 -08:00
John Knox
652a95b664 Fix plugin to plugin deeplinking
Summary:
Plugin to plugin deeplinking was broken because the state reducer was ignoring the parameter.

This fixes it.

Reviewed By: jonathoma

Differential Revision: D19791230

fbshipit-source-id: 158b3a6278f5e634093c4284018458883e9aa5ca
2020-02-07 09:49:09 -08:00
Anton Nikolaev
c62127e56a Flipper does not reload plugin when source code is modified in a custom folder (#783)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/783

https://github.com/facebook/flipper/issues/756

Reviewed By: mweststrate

Differential Revision: D19788859

fbshipit-source-id: 524ea36fc72ae84b68cda7922a74bbbbfe06663f
2020-02-07 06:36:08 -08:00
Pritesh Nandgaonkar
c52ca255bb Remove the gk
Summary: We have already rolled out `support_requests_v2` to 100% of FB employees. Thus removing the unneeded checks for the GK.

Reviewed By: jknoxville

Differential Revision: D19770930

fbshipit-source-id: 06fcf7b6b7c1305ab1b5b3c8df344e2877251e65
2020-02-07 03:44:51 -08:00
Pritesh Nandgaonkar
b9fafb0e61 Remove older support request form
Summary: This diff removes the older support form as we no longer use it.

Reviewed By: jknoxville

Differential Revision: D19769541

fbshipit-source-id: ca2088e721f2895f2c8a1205889b0670477cc2d2
2020-02-07 03:44:50 -08:00
Pascal Hartig
0af9065225 Upgrade rsocket packages (#779)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/779

Close https://github.com/facebook/flipper/pull/773
Close https://github.com/facebook/flipper/pull/774

Reviewed By: nikoant

Differential Revision: D19771979

fbshipit-source-id: c56b655a3cfb428d60f221a653b2d689d2a71fb0
2020-02-07 02:55:43 -08:00