Summary:
The current '--mac' arg builds all supported architectures. This is great when generating release builds but not so much when testing a release for the current architecture.
Not modifying the existing '--mac' arg as to not update our current CI.
Reviewed By: antonk52
Differential Revision: D50497211
fbshipit-source-id: 3e4d9728adc822c48788556e2ea47f4dd1c21b05
Summary:
Currently we download a bunch of FB icons and we normally use the smallest one available.
In this diff I change the download logic so we try to download from the largest to the smallest icon and use the first one available. One the client we no longer provide the icon of the same size that is requested, instead we provide the only one we have which will typically be larger than needed. This is a good thing because
1. flipper is a local application and we do not need to worry about icons take up broadband and downloading
2. People have high density displayed
I also stopped using density(rest of related code removed in the next diff) for icons as it the icons themselves did not support it.
Reviewed By: lblasa
Differential Revision: D50495194
fbshipit-source-id: f569c2f3b8ee424a67c6d21136e7e113868b8f6a
Summary: The token will be generated if one doesn't exist, so always call get token.
Reviewed By: antonk52
Differential Revision: D50494884
fbshipit-source-id: b93ba8ab5ba0c8b48766af3b06e8de94944d08e7
Summary:
Previously we had requested non existing icons. This fixes missing icons on pixel dense screens (macbook pro, 4k screens).
I could add x4, x5 icons as well. Though they are no better than x3. Even x3 is pretty raterized. Ideally we should be serving icons with higher resolution and scaling them down instead of doing this. Even better use SVG icons which we do not have.
Reviewed By: LukeDefeo
Differential Revision: D50454271
fbshipit-source-id: cda90972abb56069e160ddefdc6de460c49d06c0
Summary: By sending a message to the desktop we can report to log view and inform the user what happened
Reviewed By: lblasa
Differential Revision: D50369853
fbshipit-source-id: b4852d736232477261bfdf6f94c9395ce29cceaf
Summary:
Every time the token is returned, export it to the manifest.
This covers the case in which the token found in the manifest has already expired.
Reviewed By: antonk52
Differential Revision: D50419458
fbshipit-source-id: 8eefa0e97e234985b34f824190b208bf74e2d8ec
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/5222
No longer used and hasn't been updated in 2+ years.
Reviewed By: LukeDefeo
Differential Revision: D50409395
fbshipit-source-id: 4d64f31cce457737c6954834107a73dd6d1103bd
Summary:
Key fix is
```diff
- 'Tabs:' + localStorageKeyOverride ?? keys.join(','),
+ 'Tabs:' + (localStorageKeyOverride ?? keys.join(',')),
```
Previously it worked like `('Tabs:' + localStorageKeyOverride) ?? keys.join(','),` which always evaluated to `"Tabs:undefined"`. This means that all tabs that were not using localStorageKeyOverride were reusing the same localstorage key. If you open some tabs with A, B, and C tabs. And open tab B. Then open other tabs with D, E, and F. No tab would be selected as the default value would be B.
The second part it extracing keys from `items` prop instead of children.
Reviewed By: lblasa
Differential Revision: D50411422
fbshipit-source-id: 30f70c4347649f29e8c8ff1f2f38fdca7e826198
Summary: If the token has already expired, generate another one.
Reviewed By: aigoncharov
Differential Revision: D50410431
fbshipit-source-id: 108a3b344a1bcafd93a8d9bc94cba5c133d099d7
Summary: This can be provided as an override, but is not needed for regular usage.
Reviewed By: antonk52
Differential Revision: D50405097
fbshipit-source-id: 7238f99ef08bfdf5c7adda0e8c3294341ae86e89
Summary: You can now descriminate based on `hasProblem`. Thus removing asserting operator
Reviewed By: LukeDefeo
Differential Revision: D50366398
fbshipit-source-id: a16a5419ce946831bd2d1624b1baa75c89a47aa3
Summary:
I am working in Horizon Worlds and I would like to integrate Flipper with HzW app.
Currently FlipperPlugin C++ code won't compile on Windows since it uses Linux-only headers like `netdb.h` and `sys/fcntl.h`, I posted here and looks like it is not currently supported: https://fb.workplace.com/groups/flippersupport/posts/1704837183330266
The problem seem to be in only in `FlipperConnectionEndpointVerifier.cpp`, and I'm updating it to make it compatible with Windows.
Also apparently there's some issue with `#include` of few files and namespaces, leading to "struct redefinition" errors where `#pragma once` does not help https://fb.workplace.com/groups/474291069286180/posts/25313067014981908/
Solving it with manual #define
Reviewed By: lblasa
Differential Revision: D50337573
fbshipit-source-id: affdf1aee2b9dfe615227827fedf324a5f17d8b0
Summary: This is the immediate follow-up from the previous diff which aims to integrate the MacOS app into our release build script, meta only.
Reviewed By: antonk52, aigoncharov
Differential Revision: D50301369
fbshipit-source-id: 23a4842666c3a7aa9616c6237e16b71bae87ba36
Summary: If the server is offline, the fetch request will fail and this was not properly handled.
Reviewed By: antonk52
Differential Revision: D50299455
fbshipit-source-id: dab8336dedaf93db049dc703a23f9e33935212be
Summary: Changelog: When requesting Keychain Access, you will now see "flipper-runtime" instead of a generic "node" process.
Reviewed By: lblasa
Differential Revision: D50261830
fbshipit-source-id: ef6fd7d5099c4ff7370f0401a5de3fde1659f1f3
Summary: Do not use mutex for device listing.
Reviewed By: antonk52
Differential Revision: D50265112
fbshipit-source-id: 9b3bf4f9351e28dfb6366b6b787ec8b466b9bc47
Summary: This is more reliable and follows redirect which we need for GitHub downloads.
Reviewed By: antonk52
Differential Revision: D50263976
fbshipit-source-id: d001b6eb460510b0b673ea66651e7c39cac3092f
Summary:
Copying files will randomly fail with something akin to
```
Error: Cannot copy '../acirb/bin/acorn' to a subdirectory of itself, '../acorn/bin/acorn'.
```
See https://github.com/jprichardson/node-fs-extra/issues/708
Reviewed By: antonk52
Differential Revision: D50263977
fbshipit-source-id: 39091ef57b79c692ec89e7a250595509839e2af8
Summary:
**Issue**
From passy:
when one of the app server ports is occupied, Flipper PWA is stuck at the loading screen
Reviewed By: passy
Differential Revision: D50261985
fbshipit-source-id: 8ce90cd6d515c26a824645f642dacbe92e7f4105
Summary:
As discussed with lblasa. This solves a few issues:
- Confusing names in `ps` and Activity Monitor related to Flipper.
- Permission requests for the Keychain from "node" lead users to deny it.
- Seeing "node" as allowed apps for an entry in Keychain is confusing.
Reviewed By: lblasa
Differential Revision: D50232337
fbshipit-source-id: 3bc92aae0ca31d1a80582fb8a794bbc64fc2f2e5
Summary:
Even though node docs state
> Assigning a value to process.title might not result in an accurate label within process manager applications such as macOS Activity Monitor or Windows Services Manager.
Locally this worked for me on M1 machine. Will test on intel as well.
Reviewed By: lblasa
Differential Revision: D50228844
fbshipit-source-id: 69937ded7da259e05335df50332ea114ff566f21
Summary:
Use an URLProvider paired with a token provider for attempts to establish a websocket connection.
This gives extra flexibility whenever a token is not available or changes as the ReconnectingWebSocket will call the URLProvider after each unsuccessful connection.
Reviewed By: antonk52
Differential Revision: D50220329
fbshipit-source-id: f53993a90c9c0f64bf213019b6b8af5fa818048d
