Summary: Ideally, this wouldn't fire at all as it's a timeout but removing the ID will at least allow de-duplication.
Reviewed By: ivanmisuno
Differential Revision: D42800581
fbshipit-source-id: 605f2e81c326a3203c72b253362cb0b27139a134
Summary:
This code path is when a send results in an error being returned from the client. We reject the promise but also raise an error on the message bus.
There is a handler for this 'error' event that is raised that is over zelous and reports a crash to the crash reporter. This should not happen
Reviewed By: lblasa
Differential Revision: D42385292
fbshipit-source-id: f668a396b0d266ee9d1c7c1ca740e7bb5ae9608a
Summary: We were incorrectly assuming a client did not support a plugin because it was not fully initialized. This issue was only apparant on start deep links
Reviewed By: mweststrate
Differential Revision: D40477503
fbshipit-source-id: 5fd9db765f559b8eb80cc3680ee694dfd2cf9a37
Summary:
flipper-server-companion depends on flipper-plugin. flipper-plugin includes dependencies that run only in a browser. Splitting flipper-plugin into core and browser packages helps to avoid including browser-only dependencies into flipper-server bundle.
As a result, bundle size could be cut in half. Subsequently, RSS usage drops as there is twice as less code to process for V8.
Note: it currently breaks external flipper-data-source package. It will be restored in subsequent diffs
Reviewed By: lblasa
Differential Revision: D38658285
fbshipit-source-id: 751b11fa9f3a2d938ce166687b8310ba8b059dee
Summary:
Historically, RSocket used to raise an error when there was an error during send, most likely because the connection was dead.
With WS, this is no longer the case.
WS connection issues are raised through the according handlers.
Reviewed By: passy
Differential Revision: D37825821
fbshipit-source-id: 7fcda8cf26fb42eb0d8ca03b62482f11c931777f
Summary: We frequently get support requests asking why a certain plugin is not enabled for an app. This diff makes it easy to reason which plugins are enabled on the device
Differential Revision: D37381316
fbshipit-source-id: 148d6d8b6f51cb161eb625cabe0fa629b8a00cf5
Summary: This stack attempts to start using flipper-frontend-core from flipper-ui-core. Currently, flipper-frontend-core contains lots of copy-pasted code from flipper-ui-core.
Reviewed By: lblasa
Differential Revision: D37139198
fbshipit-source-id: 042db7492c550e10ea72c32fd15001c141bf53f9