Summary: This is suggested as a fix for the consistency issue (https://github.com/facebook/flipper/issues/1638) when interdependent packages published together and one of them cannot find another because it takes time to synchronise published packages to CDN. This fix is suggested here: https://github.com/CocoaPods/CocoaPods/issues/9497.
Reviewed By: mweststrate
Differential Revision: D25184732
fbshipit-source-id: d8d58b33f65ff7e87f935fb7cb85964dbf95dd13
Summary:
Honestly not sure what's causing the new NDK to be pulled in
but at least locally installing it fixes the failure we see here:
https://github.com/facebook/flipper/runs/1424681947
Pull Request resolved: https://github.com/facebook/flipper/pull/1693
Test Plan: Wait for the Actions on the PR
Reviewed By: nikoant
Differential Revision: D25093335
Pulled By: passy
fbshipit-source-id: e7af63fcf3c5270c869acc3d094234d15968aeda
Summary: Just a small mispelling in step specification
Reviewed By: mweststrate
Differential Revision: D25053437
fbshipit-source-id: 39e7c9c578a448495b92f8aa3632b2843d79490c
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1687
I cleaned up and tagged both of the custom actions.
It's much better to pin them down properly so that
future changes on `main` don't break anything.
Reviewed By: nikoant
Differential Revision: D24996462
fbshipit-source-id: 6d63e76b758439ba8df4ef2f5b77992789744e7b
Summary:
GitHub only issues one push event for multiple commits.
This causes things to behave weirdly. My action now
looks for a commit with a certain message and runs
the subsequent steps on it. If there's more than one
matching commit, it uses the last one. Not great, not terrible.
Pull Request resolved: https://github.com/facebook/flipper/pull/1678
Test Plan: Ran it on my fork: https://github.com/passy/flipper-1/actions/runs/360332680
Reviewed By: nikoant
Differential Revision: D24955986
Pulled By: passy
fbshipit-source-id: 6dcbe11e69bf77c803e3907ced3185ca85483ec8
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1673
XCode 12 starts building for apple hardware, but that fails on x86, so only build x86_64.
Reviewed By: nikoant
Differential Revision: D24857260
fbshipit-source-id: 30c0e021d4f809fd3a8ad72537a2627a43e589eb
Summary: Had the `PERSONAL_TOKEN` put in place by the OSS oncall. Still won't know if it has the right permissions until we run this. :/
Reviewed By: nikoant
Differential Revision: D24833829
fbshipit-source-id: 4fbf6e0b0abbc50d0b9a1e9b7ca8b02f6e1f5171
Summary:
No longer necessary as this is now taken care of by the new unified release Action.
Pull Request resolved: https://github.com/facebook/flipper/pull/1655
Test Plan: Next release, I'm afraid.
Reviewed By: nikoant
Differential Revision: D24782070
Pulled By: passy
fbshipit-source-id: 36ce0db814ad60fa04e4ed81b3657323bc5c983b
Summary:
Noticed that the icon download fails occasionally from GitHub.
This adds a few retries in case that happens.
Reviewed By: nikoant
Differential Revision: D24647690
fbshipit-source-id: 3ed84cb0972b7715fd87c8b1e1e1bca9f89485a9
Summary:
As part of our release confidence effort, this replaces the flaky internal task that creates the tag, promotes it to a release and uploads the artifacts to it.
Instead, we do all this in one lengthy GitHub Action. There seems to be some duplication here but this is because of the unfortunate restriction GitHub Actions imposes to avoid recursive Actions. I.e. we cannot create a tag/release and have another, independent Action pick up from there to do the building and releasing.
The `passy/` references were necessary because existing Actions didn't quite what we wanted to:
- `tag-version-commit` expected the title of the commit to match the precise tag to create. However, we want to use a regex to *extract* from the "Flipper Release: vA.B.C". My fork allows specifying a grouping regex for that.
- `github-upload-release-artifacts-action` relied on being triggered by a tag. As described above, that's not possible with this setup. Instead, this takes an existing tag and attaches to it.
Reviewed By: nikoant
Differential Revision: D24627518
fbshipit-source-id: 8121df6aa7bd36bda28e0d3cb207a002cd127647
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1532
Upgrade to Electron 10, in an attempt to fix random hard Electron crashes. Didn't fix it, but given the changelog of Electron with all the bug fixes, seems to be a good idea nonetheless :)
Changelog: Flipper now uses Electron 10
Reviewed By: nikoant
Differential Revision: D23565000
fbshipit-source-id: 3f07b8cf8c438147bde5314698d20046ac9f94cf
Summary:
This adds some pretty nice unit test coverage analysis for our codebase. Especially useful for external pull requests as a gentle nudge to make sure they don't regress the topline number.
To learn more, check out https://github.com/coverallsapp/github-action
Pull Request resolved: https://github.com/facebook/flipper/pull/1392
Test Plan:
{F245038134}
{F245038132}
https://coveralls.io/builds/32250084
Reviewed By: jknoxville
Differential Revision: D22664361
Pulled By: passy
fbshipit-source-id: 4dc1fc79677da41a9d3ea198224c5678ae156ad4
Summary:
This diff updates the Github workflow to update pod versions after the release is published on Cocoapods.
## Changelog
- Update Github workflow to update the pod versions till the release is published in Cocoapods.
Pull Request resolved: https://github.com/facebook/flipper/pull/1338
Test Plan:
A PR got created with the updated pod versions after the release was pushed.
https://github.com/facebook/flipper/pull/1365
Reviewed By: passy
Differential Revision: D22456857
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 335996bc1ebb6da309d3f60a8f3401559e0a83c7
Summary:
Move to `versioning-strategy: increase-if-necessary`. I'm not sure if that's what we want, but it's really annoying right now where if you include a lockfile, it will update every single patch release, whether or not it's covered by your version range right now.
Let's try this and revert if it doesn't do what I think it does.
Config description here: https://help.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates#versioning-strategy
Pull Request resolved: https://github.com/facebook/flipper/pull/1277
Reviewed By: nikoant
Differential Revision: D22118718
Pulled By: passy
fbshipit-source-id: 450c022fb2a17b68561bb2d9796976dddec002e2
Summary:
Following some advice to add debugging steps from here: https://github.com/skx/github-action-publish-binaries/issues/19
Also adding an alternative upload action as the issue clearly stems from
something specific to the cURL version on the Action host. This uses
a completely different tool (ghr) for uploading.
Pull Request resolved: https://github.com/facebook/flipper/pull/1199
Test Plan: testinprod
Reviewed By: jknoxville
Differential Revision: D21723887
Pulled By: passy
fbshipit-source-id: cbbc9555283a89e3152c602b87d64976e8dbf4f9
Summary:
This PR adds GH action to create PR with the updated Podfile.lock when a new tag is released.
## Changelog
- Add GH action to automatically create PR with updated Podfile.lock.
Pull Request resolved: https://github.com/facebook/flipper/pull/1097
Test Plan: I was not able to test it on a release of tag. But I tested it by triggering the workflow on a push to the branch. It created a PR like [this](https://github.com/facebook/flipper/pull/1110).
Reviewed By: jknoxville
Differential Revision: D21381996
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 2dffa0f71f7e211541728acb06aea5763ae53f47
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1096
Disable cancelling all Node CI jobs if one of them failed. This will help to detect whether build is failing on all OSes (linux, mac, windows) or only some of them.
Reviewed By: mweststrate
Differential Revision: D21370606
fbshipit-source-id: 86cb3f1a2eb45e2832c5770414c0ca58e0869b66
Summary:
This PR adds a github action to publish pods on a new tag. It also tries to fix a race condition which happens when we try to publish FlipperKit pod. During the release of FlipperKit pod, we rely on the newly published Flipper Pod, and sometimes the release of Flipper Pod takes a time to get updated in the cocoapods trunk.
This is a known issue by the Cocoapods and they will be shipping a fix to this in Cocoapods 1.10. Till then we can keep retrying for 5 times.
Ref: https://github.com/CocoaPods/CocoaPods/issues/9502#issuecomment-579486258
## Changelog
- Adds Github actions to publish cocoapods.
- Removes the Circle CI config to publish on cocoapods
Pull Request resolved: https://github.com/facebook/flipper/pull/1083
Test Plan: I tested this action by running it on this PR and it worked fine.
Reviewed By: jknoxville
Differential Revision: D21348084
Pulled By: priteshrnandgaonkar
fbshipit-source-id: f33f3cdef43ae032ad42c94db72323212e40ec67
Summary:
Setting up a [stale bot](https://github.com/probot/stale) to help us stay on top of all our issues.
Pull Request resolved: https://github.com/facebook/flipper/pull/1038
Test Plan: testinprod
Reviewed By: jknoxville
Differential Revision: D21228297
Pulled By: mweststrate
fbshipit-source-id: 0668eb3de9e888799a7904305dccf1862bbca759
Summary:
Really no clue why this isn't working. Manually running the exact
same curl command works just fine. Adding an `ls` and removing paths
because why not.
Pull Request resolved: https://github.com/facebook/flipper/pull/1044
Test Plan: Next release, sadly.
Reviewed By: nikoant
Differential Revision: D21202248
Pulled By: passy
fbshipit-source-id: e6298e8f8f191f7864e5e48ef1a1ad18b71bf3ab
Summary:
This PR adds Github Action to validate the podspec file. Validation is crucial, if it podspecs don't validate then we won't be able publish pods to the trunk.
## Changelog
Add Github Action to validate FlipperKit and Flipper pod
Pull Request resolved: https://github.com/facebook/flipper/pull/1026
Test Plan: Github Action passes.
Reviewed By: mweststrate
Differential Revision: D21130523
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 0116120b9bbb073516798d4d7f08b347ed9755a3
Summary:
This PR adds Github actions to verify that the Sample Objective-C, Swift and Tutorial app build successfully.
## Changelog
Add Github Actions for building Sample Objective-C, Swift and Tutorial app.
Pull Request resolved: https://github.com/facebook/flipper/pull/1025
Test Plan: Github Action passes successfully.
Reviewed By: jknoxville
Differential Revision: D21098106
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 6edd5a3cba74b5ea843abba366c4ad9dc550cf4e
Summary:
Adds a GitHub action that applies a label to issues where the original
author has responded to.
Pull Request resolved: https://github.com/facebook/flipper/pull/1022
Test Plan: Try it out?
Reviewed By: jknoxville
Differential Revision: D21089462
Pulled By: passy
fbshipit-source-id: 6a728d1acf710d36835bfc5966648936ceb5586e
Summary:
This is in line with the most recent stable Android Studio Release.
Pull Request resolved: https://github.com/facebook/flipper/pull/958
Test Plan:
Used it myself.
Open Source CI required a higher NDK, so let's first check what CI says to that internally now.
Reviewed By: jknoxville
Differential Revision: D20794634
Pulled By: passy
fbshipit-source-id: c32f934634b036ad3c1cad9fc49541e585d64329
Summary:
The current upload process is broken because the publish step only works on Linux.
This first uploads the binary to artifact storage, then downloads it on Linux and runs the publish step.
Pull Request resolved: https://github.com/facebook/flipper/pull/984
Test Plan:
@public
https://github.com/facebook/flipper/pull/984/checks?check_run_id=563996817
Everything here works apart from the publish action which throws a 400, which is expected as there's no tag/release associated with the PR. We can only really test the entire thing on a new release.
Reviewed By: nikoant
Differential Revision: D20868825
Pulled By: passy
fbshipit-source-id: 97304328ec7eb1243280ca7a9f26e8049869d33b
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/983
This diff fixes broken test jobs on GitHub. Tests for all the packages are already being run by the "yarn test" in the root package, so I'm disabling running them separately.
Reviewed By: jknoxville
Differential Revision: D20868138
fbshipit-source-id: 04a86a8127481fecaee63af1f9fd9c7ad0f4269b
Summary:
Still had the old paths referenced.
Pull Request resolved: https://github.com/facebook/flipper/pull/929
Test Plan: Next release, I guess?
Reviewed By: nikoant
Differential Revision: D20669327
Pulled By: passy
fbshipit-source-id: e268259065df5a48336ec09b81776771e1124fd0
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/872
Move all the JS code related to desktop app to "desktop" subfolder.
The structure of "desktop" folder:
- `src` - JS code of Flipper desktop app executing in Electron Renderer (Chrome) process. This folder also contains all the Flipper plugins in subfolder "src/plugins".
- `static` - JS code of Flipper desktop app bootstrapping executing in Electron Main (Node.js) process
- `pkg` - Flipper packaging lib and CLI tool
- `doctor` - Flipper diagnostics lib and CLI tool
- `scripts` - Build scripts for Flipper desktop app
- `headless` - Headless version of Flipper app
- `headless-tests` - Integration tests running agains Flipper headless version
Reviewed By: passy
Differential Revision: D20249304
fbshipit-source-id: 9a51c63b51b92b758a02fc8ebf7d3d116770efe9
Summary:
`build --mac` no longer implies building the DMG so the upload step currently fails.
Pull Request resolved: https://github.com/facebook/flipper/pull/869
Reviewed By: mweststrate
Differential Revision: D20283002
Pulled By: passy
fbshipit-source-id: c255ae3a7e4e006e198b79ad8ce79cfd5e80b6a3
Summary:
This seems to only encourage snark. I've yet to see this being used productively.
Pull Request resolved: https://github.com/facebook/flipper/pull/871
Reviewed By: mweststrate
Differential Revision: D20283096
Pulled By: passy
fbshipit-source-id: 1f5d8553505eb41ef8d4000e55cacf510e46949b
Summary:
We're no longer building this internally because it requires a Mac to build and we only use it in OSS.
Pull Request resolved: https://github.com/facebook/flipper/pull/852
Reviewed By: mweststrate
Differential Revision: D20250521
Pulled By: passy
fbshipit-source-id: c1691c62b2db3bc22cb0231040f593a35ec4f17e
Summary:
This workflow is currently building the android app and then trying to upload the mac app (which isn't built) which is failing.
I think it should be uploading the android app instead.
Pull Request resolved: https://github.com/facebook/flipper/pull/820
Reviewed By: passy
Differential Revision: D20035055
Pulled By: jknoxville
fbshipit-source-id: 08367d464a045b47cf1b8b5395fd2151793a23cf
Summary:
Getting really pissed off with Travis and this has significantly shorter queue times.
Mind that this probably won't work until the Folly PR is merged.
Pull Request resolved: https://github.com/facebook/flipper/pull/810
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D19951126
Pulled By: passy
fbshipit-source-id: ed51ad5ec6d4df3a59784dbd31e7c1667593d04f
