Summary:
There used to be a flag to control whether we wanted to replace an existing running instance.
No longer in use so safe to delete.
Reviewed By: antonk52
Differential Revision: D50077975
fbshipit-source-id: 8d7bad1f85e4520fd006cdcabe6e9899468688cc
Summary:
Get the authentication token before an open as either browser or PWA.
There could be cases whereas the PWA gets launched first before the token is exported to the manifest and thus it makes it not possible to connect on a first launch.
Reviewed By: antonk52
Differential Revision: D50004992
fbshipit-source-id: d58b7a75dcb9aaf7fadd3e3c3a773581441f9d92
Summary: Set a timeout period to become ready. It is better to kill the server if not ready, than keeping it alive.
Reviewed By: antonk52
Differential Revision: D50004605
fbshipit-source-id: be1d2c022c634ece059fc03eb6faea695431ba95
Summary: Change the button title when clicked.
Reviewed By: mweststrate
Differential Revision: D49954493
fbshipit-source-id: 3d689effc0cc5587ab8a07901b66139577b21837
Summary: Track whenever the server is unable to bind to the specified port.
Reviewed By: antonk52
Differential Revision: D49951304
fbshipit-source-id: 971d7c324f27c287036707d21bb51d26acbd6615
Summary:
Simplify how messages (state updates) are shown in Flipper UI.
This main change was introduced as a way to show the 'Start' server button whenever we were in a disconnected state. This is not as simple as the server may be restarting or the client may be even have reset the WS connection. Hence you the experience where this UI is shown and immediately dismissed.
This UI is only ever shown if at one point the server was alive, period. So, in this case, either the server becomes available again OR the user quits the PWA/tab/browser and launches again.
IMHO, this is a better experience that totally assuming the server is dead.
In a next iteration, we can be more clever and have a timeout such that if after a set period of time the server doesn't become online, then we show a button to start (or force kill) the server.
Reviewed By: aigoncharov
Differential Revision: D49915698
fbshipit-source-id: 03fcc150ed1f1303d1d727c82a71eb32616208e8
Summary:
^
Also, if an error happens, do not swallow it, rethrow.
Reviewed By: passy
Differential Revision: D49912780
fbshipit-source-id: 30451110d8c5776e2b0826d6e924ab5fe98cd7e2
Summary: Also remove the suppress error usage as is it was never used.
Reviewed By: aigoncharov
Differential Revision: D49910876
fbshipit-source-id: 7267eaddadb73ab2b6e2aab0045157271ceed427
Summary: When a user pastes anything, it is treated as an input for a search through the entire row
Reviewed By: lblasa
Differential Revision: D49948975
fbshipit-source-id: 2dd23d4ee0819623549d88eb077c7b2d2fdf604f
Summary:
When a user enters any arbitrary text, we will treat as an input for the search through the entire row.
Based on feedback from https://fb.workplace.com/groups/flippersupport/permalink/1703929480087703/
Reviewed By: lblasa
Differential Revision: D49911868
fbshipit-source-id: 4c569e4b01e468f0ca112ea4b00fe143b30bed2a
Summary: If we are unable to bind to the specified port, exit process.
Reviewed By: passy
Differential Revision: D49908107
fbshipit-source-id: 6d76f3d661ec61867be5307c756e372a7b20a9f6
Summary:
The icon was not shown in the past as it was indefinitely bouncing on the dock.
This is fixed now by asynchronously initiating the Node server process and then waiting until it becomes ready.
Reviewed By: passy
Differential Revision: D49907976
fbshipit-source-id: cdeaa578be42d9f5308e2e0df50872858b8248c3
Summary: One log was misplaced, also added another one.
Reviewed By: passy
Differential Revision: D49873310
fbshipit-source-id: b391e2be600070eb96e6cd53846f5665f8400edc
Summary:
Metamate says:
This diff adds documentation for VPN-less Interngraph requests in Flipper. The changes include adding a new file to the Flipper documentation with information on how to use VPN-less Interngraph requests and updating the sidebar to include the new documentation.
Reviewed By: lblasa
Differential Revision: D49907281
fbshipit-source-id: 9e541e0c6e64215db1c3b899df45d5f9fbdaa0da
Summary: Old MasterDetail and DataTable (pre-power search) are using `extraActions` prop which no longer exists in teh new components. This diff adds a fallback.
Reviewed By: ivanmisuno
Differential Revision: D49869730
fbshipit-source-id: 4c1a658aa94acc770836f9bf296a3df7d6cdcb3e
Summary:
Original commit changeset: 9d09d9660dfa
This breaks the build on GitHub.
Original Phabricator Diff: D49772851
Reviewed By: antonk52
Differential Revision: D49829328
fbshipit-source-id: 88f4a29abe148b1427ed9af5bd8b6d0c14066343
Summary:
If no version information is obtained, check if port is in use.
This is for the cases in which an older server which may not have implemented this endpoint fails to return version information.
In this case, send the shutdown command.
Reviewed By: antonk52
Differential Revision: D49830759
fbshipit-source-id: 6c9763d01f335ecc8a28df3b90d319f98016c2da
Summary: Currently, we are not interested in these errors. Let's add some logging as a way of knowing if they take place and why.
Reviewed By: antonk52
Differential Revision: D49828378
fbshipit-source-id: f741a45e1ba9892aa54dca85f97bcc419e0b5e25
Summary: Some columns set title to an empty string
Reviewed By: lblasa
Differential Revision: D49826852
fbshipit-source-id: 3661394323dade813295420a1186d9297a8be153
Summary: We treat every column without the power search config as if it contains strings. Sometimes that might bite us, for instance, when the column contains an object.
Reviewed By: lblasa
Differential Revision: D49822511
fbshipit-source-id: 18dadb5abe624fae510663fc26668b2b594899c3
