Summary: This resolves a crash related to the contents of certain CKComponents, which was apparently introduced by D15266478
Differential Revision: D15406260
fbshipit-source-id: efd1ad1a1bcb41451c56b74c240ad2dca069deb0
Summary: Splits the utility into a public and private part - just for the opaque types to work. The private part validates arguments and does the command running. Both are safe to use, but the non-internal one is easier, you don't have to validate anything.
Reviewed By: passy
Differential Revision: D15393477
fbshipit-source-id: 92f63180fb94af4337fdf8c7dace5bc5a85d5a54
Summary: This commit doesn't change anything, just moves the android command running stuff into its own utility.
Reviewed By: passy
Differential Revision: D15393476
fbshipit-source-id: de93bbd88fa62bddff8d9ea56cfbc33bfd854d53
Summary: I added column size persistence when resizing manually, but broke initial column sizing when a prop is provided. This fixes it.
Reviewed By: passy
Differential Revision: D15392145
fbshipit-source-id: 53f79c520917cd571302502c8b75aa0475567cb9
Summary: This diff adds support to pass a path to the trace file to the headless Flipper. The headless Flipper then exports the metrics out of it.
Reviewed By: passy
Differential Revision: D15337067
fbshipit-source-id: 61aca1ffd58e879dafe6aa176f058f7b11460952
Summary: Checking in a new binary pre-compiled for MacOS.
Reviewed By: jknoxville
Differential Revision: D15374540
fbshipit-source-id: a69e6f497a8c8b9f08144e1482450ff43b85f5da
Summary: This is the one used on sandcastle, built statically.
Reviewed By: jknoxville
Differential Revision: D15374415
fbshipit-source-id: 7b200e8630ce0a3a336cc46df26df367ed712fa1
Summary:
When running bump, also update the docs references to the noop package.
Will update binaries in subsequent diffs.
Reviewed By: jknoxville
Differential Revision: D15374370
fbshipit-source-id: 5558d33a91dc5e690f5754891b2e5aa29385646a
Summary: Making a release to test the automated pods publishing. The last one failed, due to the wierd Sandcastle bug
Reviewed By: passy
Differential Revision: D15373866
fbshipit-source-id: 644bf24e28d712c40a053623fc2b80bf6b011fde
Summary: Making a release to test the automated pods publishing. The last one failed, due to the wierd Sandcastle bug
Reviewed By: passy
Differential Revision: D15373868
fbshipit-source-id: a4e0eb0720f634c5667304f84b0fdaf26060d563
Summary: Want to make a release to test out the automated release of pods to cocoapods.
Reviewed By: jknoxville
Differential Revision: D15358712
fbshipit-source-id: 9430b7d2f16e3a2df498cc2359bbef7e7d1a3f18
Summary: Want to make a release to test out the automated release of pods to cocoapods.
Reviewed By: jknoxville
Differential Revision: D15358714
fbshipit-source-id: 08971164cb7c4a27646f3614669ae7cb9e4d6265
Summary: Previously "Create your own plugin" in welcome screen and "Create Plugins" in menu were directing to a URL https://fbflipper.com/docs/create-plugin.html which doesn't exist anymore. So pointing the URL to page for plugin creation tutorial https://fbflipper.com/docs/tutorial/intro.html
Reviewed By: jknoxville
Differential Revision: D15362962
fbshipit-source-id: 82a9dedb21911607f20884c9bb36e58d622e8431
Summary: Noticed that this is still spamming the warning logs during build.
Reviewed By: danielbuechele
Differential Revision: D15354006
fbshipit-source-id: f34b99267d946ccb9ae0704beebbd48d39e9723a
Summary: You're not supposed to be here.
Reviewed By: SidharthGuglani
Differential Revision: D15353936
fbshipit-source-id: f389aeaff71f940d96dfc0422694fb0020dee05c
Summary:
It looked like the "..." was meant as a placeholder?
Pull Request resolved: https://github.com/facebook/flipper/pull/446
Reviewed By: danielbuechele
Differential Revision: D15337644
Pulled By: passy
fbshipit-source-id: 89d4d15d1448d8c61997341b5bfd67f2adb6a021
Summary:
This PR sets up Circle CI to publish pods when github release is made. This PR also updates the Flipper-Folly pod as it didn't build on 32 bit architecture, because `thread_local` was not supported.
Automated publish of cocoapods through Circle CI.
Pull Request resolved: https://github.com/facebook/flipper/pull/445
Reviewed By: danielbuechele
Differential Revision: D15333975
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 7db68efeeebbe344213917f10f9f3ce4132e8cbc
Summary:
The main goal is to update visitation id for our targeted tabs requirements (https://fb.quip.com/2jZiA97DTATi). In doing so, we want an easier way to debug whether everything is working as expected.
I've been meaning to add something like this for a while since it's a pain to explain what the visitation id and HSM look like as you navigate the app, so this should help the other teams who're using visitation id as well.
Will probably also start adding navigation events and any other data that we feel is useful.
Run:
```
fbsource/xplat/sonar/scripts/facebook/create-plugin.py Navigation --android
```
Then clean a few things up and fix lints.
Differential Revision: D14759995
fbshipit-source-id: 066dcbf70eed7056f995053cc9ba80dcbbafdb03
Summary:
BUG:
{F158264042}
Context: The code entered an infinite loop till it crashed. In the implementation of `- (SKSearchResultNode *)searchForQuery:(NSString *)query fromNode:(id)node withElementsAlreadyAdded:(NSMutableSet<NSString *> *)alreadyAdded`, we recurse through the child. In the case when the view was `CKRootComponent` it created a `SKComponentLayoutWrapper` in the call to `[descriptor childForNode: node atIndex: i];`. This wrapper's descriptor used to return the very same view from which it was created when it's children were asked. So this led to an infinite loop.
Reviewed By: kfirapps
Differential Revision: D15266478
fbshipit-source-id: 8035209746b7cb4b8773e2fcbdd4c0a148191304
Summary: Add option to focus a view from the context menu.
Reviewed By: passy
Differential Revision: D15294182
fbshipit-source-id: f03db136e8365833beee3b4883d2114e98a280bd
Summary: This was already implemented in the old versin of layout inspector and got lost during the refactoring. When using talkback, the focused view is highlighted in green in the a11y inspector.
Reviewed By: passy
Differential Revision: D15294025
fbshipit-source-id: 92cc015e4bc726515e433b7b96f924246916972d
Summary: This is to unblock our mobile lab build target that adds Flipper to a redex-able build. Redex currently crashes when it tries to optimise Rhino. This could probably be fixed but we don't have any real use-cases for the console plugin right now. It should be fairly easy to unland this even partially if we want to revive this in the future.
Reviewed By: danielbuechele
Differential Revision: D15044539
fbshipit-source-id: f0857274aa046f5be935a342cf91b6a390fcb3dc
Summary: Iterative version of the custom serializer. The recursive implementation led to call stack overflow for news feed surface in fb4a.
Reviewed By: danielbuechele
Differential Revision: D15251643
fbshipit-source-id: b8af921b1a4d85c52d4d45a7abf95a5bb5f283f7
Summary:
This is because `doLast` may happen after the cleanup came around to undo `createNativeDepsDirectories` specified as dependency.
Pull Request resolved: https://github.com/facebook/flipper/pull/436
Reviewed By: jknoxville
Differential Revision: D15260597
Pulled By: passy
fbshipit-source-id: b752af2b71217ebc1d802b43f1585e858a41fc00
Summary:
Previously you could only copy the entire row.
Now you can choose which cell to copy.
Not the perfect UI admittedly, but that would require a big change to make individual cells selectable. I think it's a definite improvement.
Reviewed By: passy
Differential Revision: D15231784
fbshipit-source-id: 0d52192a5bf4e8ea1ebee74988c749d3f602fea9
Summary: Quick fix for layout plugin and export crashing when encountering nullable props for colors and drawables like `refreshProgressBarBackgroundColor` on `RecyclerSpec`. The rendered view in the inspector is not great right now, but better than a crash. Working on the correct representation next.
Reviewed By: jknoxville
Differential Revision: D15241151
fbshipit-source-id: 3754dee8861a442127a34d7c3211d223c5f390c1
Summary: This was causing resizing to trigger onClick every time, which isn't wanted.
Reviewed By: passy
Differential Revision: D15219039
fbshipit-source-id: ea5d9221b0ce8fa7a050a8410876cf78bfee2bc6
Summary: The "next" link at the bottom right now leads to a 404 (was the old data page).
Reviewed By: jknoxville
Differential Revision: D15237635
fbshipit-source-id: 67ee7ace933d270b9e85b012e9128e1003c73ece
Summary: Fix the format of the export. Due to unknown reason the changes done in the D14933499 was [reverted back](https://our.intern.facebook.com/intern/diff/D14933499/?src_number=80619316) on the same diff. Thus this diff fixes the format of the metrics export
Reviewed By: passy
Differential Revision: D15239653
fbshipit-source-id: b9416f89e1b0022000d6201eb08ca1f456d5ed2e
Summary:
I copied the wordings from Pascal's android setup and changed the API's to match the iOS one. 🙈
This doc explains how to build custom plugin in iOS
Reviewed By: passy
Differential Revision: D15200426
fbshipit-source-id: 0a3c966f7c74aae410c6b3ee643e5a38d33880de
Summary: Update according to changes in D15200794
Reviewed By: jknoxville
Differential Revision: D15200901
fbshipit-source-id: ef0e0895f30d6eb98536c9a7df7a0d46bb4af8d2
