Summary:
Bumps [metro-react-native-babel-preset](https://github.com/facebook/metro) from 0.71.0 to 0.72.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro-react-native-babel-preset's releases</a>.</em></p>
<blockquote>
<h2>Release v0.72.0</h2>
<ul>
<li><strong>[Breaking]</strong> Enable React 17 new JSX transform (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/848">facebook/metro#848</a> by <a href="https://github.com/danilobuerger"><code>@danilobuerger</code></a>)</li>
<li><strong>[Breaking]</strong> Add <code>watcher.additionalExts</code> option, enable inclusion of <code>.cjs</code> and <code>.mjs</code> files by default (c1c6d9c09fa92aa2ba71d803fdfa480e4dbb6a51)</li>
<li><strong>[Breaking]</strong> <code>.json</code> files will no longer be implicitly resolved if removed from <code>resolver.sourceExts</code> (a3dc30aa0d54d65d6dbd426662f59b0ec398a612)</li>
<li><strong>[Breaking]</strong> With a default config, any <code>.jsx</code> files will now be resolved before <code>.json</code>, <code>.ts</code>, <code>.tsx</code> (1b479314dc08f2a2e2f76438971f32fcf431ee89)</li>
<li><strong>[Breaking]</strong> Enable strict CLI validation when <code>metro</code> is passed an invalid subcommand or argument (19c4f7edb85f5b61b056580515348ca9715dd361)</li>
<li><strong>[Feature]</strong> Add <code>start</code> alias for <code>serve</code> CLI command (19c4f7edb85f5b61b056580515348ca9715dd361)</li>
</ul>
<p><strong>Full Changelog:</strong> <a href="https://github.com/facebook/metro/compare/v0.71.3%E2%80%A6v0.72.0"><code>v0.71.3...v0.72.0</code></a></p>
<h2>Release v0.71.3</h2>
<ul>
<li><strong>[Fix]</strong> End watchman client on calling MetroFileMap end. (fc042d06bb6db98dd819bb0d22b7d536ee396c24)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/metro/compare/v0.71.2...v0.71.3">https://github.com/facebook/metro/compare/v0.71.2...v0.71.3</a></p>
<h2>Release v0.71.2</h2>
<ul>
<li><strong>[Feature]</strong> Add <a href="https://facebook.github.io/metro/docs/configuration/#requirecycleignorepatterns"><code>requireCycleIgnorePatterns</code></a> option to suppress warnings for require cycles, suppress <code>node_modules</code> by default (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/707">facebook/metro#707</a> by <a href="https://github.com/hsource"><code>@hsource</code></a>)</li>
<li><strong>[Feature]</strong> Add <a href="https://facebook.github.io/metro/docs/configuration/#watchmandeferstates"><code>deferStates</code></a> option for Watchman (570c38039abc32b758f8d241896b21e28ca4ba83)</li>
<li><strong>[Fix]</strong> Incremental build bug with parallel edges to the same module (fc29a1177f883144674cf85a813b58567f69d545)</li>
</ul>
<blockquote>
<p>NOTE: Experimental features are not covered by semver and can change at any time.</p>
</blockquote>
<ul>
<li><strong>[Experimental]</strong> Add <code>unstable_allowRequireContext</code> config option, implement transformer support for <a href="https://webpack.js.org/guides/dependency-management/#requirecontext"><code>require.context</code></a> (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/821">facebook/metro#821</a> by <a href="https://github.com/EvanBacon"><code>@EvanBacon</code></a>)</li>
</ul>
<p><strong>Full Changelog:</strong> <a href="https://github.com/facebook/metro/compare/v0.71.1%E2%80%A6v0.71.2"><code>v0.71.1...v0.71.2</code></a></p>
<h2>Release v0.71.1</h2>
<ul>
<li><strong>[Fix]</strong> Add missing <code>.npmignore</code> files (e8bb8fb4035699c83fce4b35aabcaec208513f3c)</li>
<li><strong>[Fix]</strong> Rewrite DeltaBundler garbage collection (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/820">facebook/metro#820</a>)</li>
<li><strong>[Fix]</strong> Remove deprecated Prop Types from lazy imports (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/824">facebook/metro#824</a> by <a href="https://github.com/ecreeth"><code>@ecreeth</code></a>)</li>
</ul>
<blockquote>
<p>NOTE: Experimental features are not covered by semver and can change at any time.</p>
</blockquote>
<ul>
<li><strong>[Experimental]</strong> Expose <code>unstable_fileMapCacheManagerFactory</code> config option (e7419900d2e063f2d531313f810d18c487f807f8)</li>
<li><strong>[Experimental]</strong> Add <code>unstable_perfLogger</code> config option (eec0d7bf00aa707ae210b25218501b3e17dc4bf2)</li>
<li><strong>[Experimental]</strong> Remove <code>unstable_hasteMapModulePath</code> from Metro config (1cae8d8007d04ba62a739a6c4dff991c69af26e4)</li>
</ul>
<p><strong>Full Changelog:</strong> <a href="https://github.com/facebook/metro/compare/v0.70.2%E2%80%A6v0.71.0"><code>v0.71.0...v0.71.1</code></a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d699f9d141"><code>d699f9d</code></a> Release 0.72.0</li>
<li><a href="c1c6d9c09f"><code>c1c6d9c</code></a> Add watcher.additionalExts option, enable inclusion of .cjs and .mjs files by...</li>
<li><a href="a3dc30aa0d"><code>a3dc30a</code></a> Replace hard default of 'json' in sourceExts with package.json WatcherImpl glob</li>
<li><a href="1b479314dc"><code>1b47931</code></a> Add 'jsx' to resolver.sourceExts defaults</li>
<li><a href="75ac509182"><code>75ac509</code></a> update staticdocs</li>
<li><a href="d0ea806173"><code>d0ea806</code></a> Fixed typo causing option to not be applied (<a href="https://github-redirect.dependabot.com/facebook/metro/issues/849">https://github.com/facebook/flipper/issues/849</a>)</li>
<li><a href="1b6dd6f05a"><code>1b6dd6f</code></a> Enable react 17 new jsx transform (<a href="https://github-redirect.dependabot.com/facebook/metro/issues/848">https://github.com/facebook/flipper/issues/848</a>)</li>
<li><a href="b8252d866a"><code>b8252d8</code></a> Added isTurboModule helper function</li>
<li><a href="b6ebccf9e6"><code>b6ebccf</code></a> Remove MaskedViewIOS from react-native-github</li>
<li><a href="419caf7565"><code>419caf7</code></a> Release resolved-env</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/metro/compare/v0.71.0...v0.72.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3954
Reviewed By: lblasa
Differential Revision: D38315036
Pulled By: LukeDefeo
fbshipit-source-id: 63b08fc89c808951ff159b75fed0693a11322867
Summary:
Resolves https://github.com/facebook/flipper/issues/3926. Open to suggestions on the tag value, just sort of picked one that could be pointed to for anyone that wants to track these in their apps.
## Changelog
Tag sockets used by Flipper to fix strict mode warnings about untagged sockets.
Pull Request resolved: https://github.com/facebook/flipper/pull/3928
Test Plan:
Edit FlipperSampleApplication.java with the following:
```
public class FlipperSampleApplication extends Application {
Override
public void onCreate() {
StrictMode.setThreadPolicy(
new StrictMode.ThreadPolicy.Builder()
.detectAll()
.penaltyLog()
.build()
);
StrictMode.setVmPolicy(
new StrictMode.VmPolicy.Builder()
.detectAll()
.penaltyLog()
.build()
);
...
```
That will enable strict mode. Now build/launch the sample application.
Use adb logcat to inspect warnings:
```
adb logcat -s StrictMode
```
Without tagging the socket, the following warning should be observed:
```
D/StrictMode: StrictMode policy violation: android.os.strictmode.UntaggedSocketViolation: Untagged socket detected; use TrafficStats.setTrafficStatsTag() to track all network usage
```
After applying the fix, that warning should go away.
Reviewed By: lblasa
Differential Revision: D38280819
Pulled By: passy
fbshipit-source-id: 0c841b13237cbcb0ff8b8226fb44655a74b775c6
Summary:
This is the second part of the feature which enables data/log persistence by adding a global setting which controls whether the data is wiped when the same device is disconnected and reconnected.
Building on the previous diff, this diff uses the setting from the Redux Store to determine whether to "wipe" the data or not.
Changelog: Added option in Flipper settings to persist device data upon reconnection instead of wiping everything.
Reviewed By: mweststrate
Differential Revision: D38076567
fbshipit-source-id: 83658ac09bc88921a56517e1a1f624d4a4bbc2c5
Summary:
This is the first diff to implement the feature for the Flipper logs plugin to have an option to persist logs in the table between crashes, disconnections, etc.
Since this is not a local change, the UI option for persistence will be located in the settings for the Flipper UI(as seen in the test plan). The setting is associated with the Redux Store `Settings` and is stored globally to be used across all plugins. So the plan is making the persistence pertain to all plugins.
Reviewed By: mweststrate
Differential Revision: D37786988
fbshipit-source-id: 7ffc6077cbca559b3401b16770eda657a6c45620
Summary:
This diff updates the Flipper plugin for UIQR+DDR to upsell people to use `arc uiqr` on the "Upload and Get Link" tab. At the moment I'm not showing the upsell on the "Upload Screens to Diff" tab since this functionality isn't really supported through `arc uiqr` yet.
The upsell uses localstorage to maintain its open/close state so it will show up by default but will be permanently dismissed (unless localstorage is cleared somehow :) ).
NOTE: I hacked out this UI using some existing reusable UIQR Flipper components and some extra styling for the background, but definitely open to feedback on the UI!
Differential Revision: D38232117
fbshipit-source-id: e1745e32974bd9e750bbbaaa2f47bafdd0ac87eb
Summary:
A codemod removed a GK which resulted in this...
This change removes the unused code.
Reviewed By: mweststrate
Differential Revision: D38239893
fbshipit-source-id: 01163e9f5adcc77fff572b47ce1d902dbdadff4d
Summary:
1. Added icon to search bar to manually trigger the hide/show search context/results functionality, which was only triggerable by ctrl(now migrated to ctrl+t) before.
2. Added tool tips to increase visibility of keyboard shortcuts
Changelog: Added icon for showing search result context(only triggered by keyboard shortcut before). Added tool tips to search bar icons.
Reviewed By: mweststrate
Differential Revision: D38207087
fbshipit-source-id: a34c1322294ed8091ea3f90d2f1f206af981c9ca
Summary:
Currently there's no way of quickly selecting recent searches other than manually opening the recent search history and then clicking one of the search terms. This diff seeks to add a new feature that would allow not only a keyboard short cut to open the recent search history drop down but also number the most recent 5 search terms so that the user could quickly select them with a number on their keyboard
Additionally, fixed bug found in terms of the search bar not showing the current search value correctly
`Changelog`: Introduced keyboard shortcut(ctrl + f) option to toggle the search history dropdown along with numbers attached to the options in order to quickly navigate to recent search terms. Have to first enable the option(search shortcut) in menu in order to use the feature. Also added a new button in the options menu that would trigger the search result toggle as triggered by the keyboard shortcut `ctrl` before(`ctrl` + `t` now)
WARNING: The current behavior of "ctrl" toggling back and forth to focus the selected item has been migrated to "ctrl + t" key combo
Reviewed By: mweststrate
Differential Revision: D37685738
fbshipit-source-id: a7ac4dd3dceb846a98258de2d884ebc279ee5995
Summary: Follow-up to D38155922. This was done almost entirely by just following suggestions from the compiler. No behaviour changes, just fewer bit-copies in memory.
Reviewed By: lblasa
Differential Revision: D38199244
fbshipit-source-id: 777e9d833d25cb660307380ab88b12a1d4eedf09
Summary:
The limitation to two types is arbitrary and limiting. Instead, we want to be able to create as many cache artifacts as is sensible to improve the caching behaviour.
A lot of unnecessary cloning in here. I might optimise this a bit in the future but it's not really perf critical as this is highly I/O bound.
Reviewed By: lblasa
Differential Revision: D38155922
fbshipit-source-id: 78b86ebff54269c5049e59197f1c25fedfad0111
Summary: This is needed so we can roll out releases of Flipper Server for Linux.
Reviewed By: lawrencelomax
Differential Revision: D38155968
fbshipit-source-id: 2be032466cb8da867fa555fa545d1f236724461f
Summary: A few small adjustments and updates.
Reviewed By: lawrencelomax
Differential Revision: D38155923
fbshipit-source-id: 1aea5f9b64a6b5e4783fe7bad214df6a74be7d45
Summary: In a previous diff D32278523 (8764da7c0b) The desktop request was changed from send to call. Call expects a response and not all code paths return a response. Most calls to set highlight are timing out.
Reviewed By: mweststrate
Differential Revision: D38074704
fbshipit-source-id: 6e85416d6b6470efaa177ad1b74420c8237366d5
Summary:
In order to accomplish multi-panel mode, we need to use multiple data views on the same data source so that the filters can be applied differently, etc.
This diff serves to refactor DataTable and some of its associated classes to use DataView as the primary driver for data management. Additionally, the diff refactored the state to allow multi-paneling to be on the DataPanel layer instead of the DataTable layer for ease of usage
This is the last diff of the larger stack which introduces the multi-panel mode feature. A possible next step could be allowing infinite(up to a certain limit) panels to be populated.
Changelog: Introduced side by side view feature for `DataTable`. There is now a new boolean for `DataTable` props called `enableMultiPanels`. If this is passed in, then the table will have an option to open a different "side panel" using a completely different dataview which allows different filters, searches, etc.
Reviewed By: mweststrate
Differential Revision: D37685390
fbshipit-source-id: 51e35f59da1ceba07ba8d379066970b57ab1734e
Summary:
Quoting lblasa:
History trip:
- It was used at the beginning of times with RSocket.
- RSocket introduced an RPC mechanism so a new responder was introduced which used it, thus making this responder legacy.
- WebSockets is introduced which doesn't have an RPC mechanism by default so this responder became the new non-legacy responder
Reviewed By: lblasa
Differential Revision: D37994288
fbshipit-source-id: 2458aed129058a5bfaafd607e73c52867d9713cf
Summary: SidebarInteractiveContainer sets mousedown/mouseup handlers. Whenever user tries to select text in child element those are triggered.
Reviewed By: passy
Differential Revision: D37994014
fbshipit-source-id: 5dcf5642b3a92ec50008aa4aad6b9522a09c1527
Summary:
There are many files across fbobjc relying on -include_pch and therefore they miss Foundation.h and UIKit.h includes. This diff was generated by a codemod and fixes these missing includes.
More details on the missing imports https://fb.workplace.com/groups/929548250966094/permalink/981237982463787/
Changelog: [Internal]
Reviewed By: yannickl
Differential Revision: D37282740
fbshipit-source-id: 0f419025b3cf2f811e96ff464cb19e8e5a25aa09
Summary:
Some old welcome links are 'Page Not Found'.
## Changelog
Some old links are 'Page Not Found', so update them as follows:
1. Update "Using Flipper" link to 'https://fbflipper.com/docs/features'
2. Update "Add Flipper Support to Your App" link to 'https://fbflipper.com/docs/getting-started'
Pull Request resolved: https://github.com/facebook/flipper/pull/3902
Test Plan: Pass the test on a Mac.
Reviewed By: lblasa
Differential Revision: D37927376
Pulled By: passy
fbshipit-source-id: 0aac129932395e3f2ce3afa8c47cc637f3e814a8
Summary:
^
Ignore the errors as otherwise it may cause unhandled rejection errors.
Reviewed By: aigoncharov
Differential Revision: D37926740
fbshipit-source-id: 50476378b4d254e28af953979fbedad1113e43aa
Summary:
When upgrading to RN 0.68, the upgrade helper removes the old Flipper initialization in favor of importing `RCTAppSetupUtils` which abstracts the Flipper initialization.
To be consistent, we should show in the docs that for 0.68 the preferred way is to import `RCTAppSetupUtils` in the AppDelegate.
## Changelog
- RN iOS setup docs has been updated to include the new way to initialize Flipper on React Native 0.68.
Pull Request resolved: https://github.com/facebook/flipper/pull/3905
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
**Static Docs Preview: flipper**
|[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D37927365/V2/flipper/)|
|**Modified Pages**|
|[docs/getting-started/react-native-ios](https://our.intern.facebook.com/intern/staticdocs/eph/D37927365/V2/flipper/docs/getting-started/react-native-ios/)|
Reviewed By: lblasa, cortinico
Differential Revision: D37927365
Pulled By: passy
fbshipit-source-id: c6799e91a217d341eb817abb175ce63ea70c9597
Summary:
Observed that a few requests tend to timeout when using Flipper with flipper-server.
Increasing timeout to 45s as to be a bit more flexible.
'exec' operations don't have a timeout when not using flipper-server.
Reviewed By: antonk52
Differential Revision: D37955108
fbshipit-source-id: 5d8ef7f066d6b316e4b485b281a015794b5bd2de
Summary:
Client calls return a promise. Not dealing with the error causes promise unhandled rejection errors.
This change adds a catch block and logs the error instead.
Reviewed By: antonk52
Differential Revision: D37955029
fbshipit-source-id: 50cac5a5339961d16868ab2102d3c77790e6943c
Summary:
Historically, RSocket used to raise an error when there was an error during send, most likely because the connection was dead.
With WS, this is no longer the case.
WS connection issues are raised through the according handlers.
Reviewed By: passy
Differential Revision: D37825821
fbshipit-source-id: 7fcda8cf26fb42eb0d8ca03b62482f11c931777f
Summary:
This diff has been automatically generated by the inpage editor.
If you want to update this diff, go through the preview link that would be attached to the test plan.
Please ensure you are editing the same page that was used to create this diff.
Reviewed By: passy
Differential Revision: D37853011
fbshipit-source-id: 1d68d5a80b30bb1b1cdf5703272717dadbe3a977
Summary:
Nothing interesting here, just adding necessary sources from Flipper into the VS Studio solution.
As a consequence, some warnings had to be turned off as otherwise they're treated as errors and the solution doesn't build.
Reviewed By: passy
Differential Revision: D36760242
fbshipit-source-id: 2f5e615f8a465554dd35c245756f94bcace6e34a
Summary:
This change brings in Folly and Boost into our solution.
Boost is resolved with NuGet. Folly is resolved by re-using the RNW integration.
For reference:
Flipper depends on Folly. Folly depends on a few things:
- Boost
- FMT
- Glog
- Double-Conversion
Folly from RNW uses some stubs to resolve fmt, glog, and double-conversion. That's OK.
Only Boost needs resolving.
On Visual Studio, we can use the following package managers: NuGet and vcpkg.
Boost can be resolved using either.
Using NuGet as otherwise vcpkg needs to be run locally by anybody wanting to build the solution. NuGet makes things easier.
Reviewed By: aigoncharov
Differential Revision: D36759384
fbshipit-source-id: 31a9a398ce5c5dc2f3def02689ae4bb8c42fbb99
Summary:
This diff adds a new menu option to the Logs plugin which allows for enabling/disabling the automatic filtering of search terms in the search history as user types.
Additionally, fixed bug regarding the search term that's used is not actually showing correctly. This is caused by the search value being set in the input search bar instead of the autoComplete component level
Differential Revision: D37555209
fbshipit-source-id: 8a76299f7e1a4b0a3adfa6a4dd883d17f1e7a442
Summary:
This change adds the template for a RNW module to the existing react-native flipper project.
Basically, the changes in this diff are the product of executing the react-native-windows init for the existing library.
See:
https://microsoft.github.io/react-native-windows/docs/getting-startedhttps://microsoft.github.io/react-native-windows/docs/native-modules-setup
Notes:
There's some auto-generated module code contained in this change: ReactNativeModule (.h/.cpp)
allow-large-files
Reviewed By: passy
Differential Revision: D36751772
fbshipit-source-id: 41207bedb00ea147883f6d13336ed6c1da4454d7
Summary:
^
If Flipper stops, we cannot freely access the client outside of the scheduler.
There may be an scheduled operation that depends on it.
Instead, schedule the stop and wait until it finishes.
Reviewed By: cekkaewnumchai
Differential Revision: D37814820
fbshipit-source-id: 44217b5f623a8d92211a3d72a4a204d674b4bb76
Summary:
Sets a default key binding of `ctrl+l` to clear the screen within built-in Flipper plugins which display a log view.
Motivation: A small quality of life improvement for developers used to the default "clear screen" binding. This makes our log-rendering plugins consistent with other native apps such as terminals, Chrome DevTools, and many others.
Reviewed By: mweststrate
Differential Revision: D37782638
fbshipit-source-id: 0a85b930faaa0e9468d5391f15092aad7b6057ee
