Summary: Added docs on how to write React-Native JavaScript based plugins
Reviewed By: passy
Differential Revision: D19344803
fbshipit-source-id: ad1ea66f1031760729fdaea8a7e6c1ef5dcd5439
Summary:
Sync the Getting Started section about React Native integration with the latest changes in https://github.com/facebook/react-native/pull/27426.
## Changelog
Refresh Getting Started with the latest React Native integration
Pull Request resolved: https://github.com/facebook/flipper/pull/676
Test Plan: Tested in RN's template.
Reviewed By: mweststrate
Differential Revision: D18853584
Pulled By: passy
fbshipit-source-id: d001046106743b68d2f08b084c7618d8f768dea1
Summary:
Long-standing 'security' issue. Doesn't matter for a static
site generator with controlled input, of course, but
we're failing our OSS validation if we just dismiss it.
Reviewed By: cekkaewnumchai
Differential Revision: D18638722
fbshipit-source-id: d8636dee67826c4e453ac0f74cd3dfa8f77ba0dd
Summary:
Random observations
1. RN already generates the Flipper initialization code out of the box
2. This code assumes a prefixed namespace: `facebook.flipper`. Maybe it would be better if that were `appname`, but that seems an unnecessary burden at this point, preventing direct copy / paste possibilities
3. Out of the box, the generated code by RN doesn't align with the code provided here, because no `ReactInstanceManager` argument is passed in (nor does it seem to be available in a straight-forward way)
4. patch MainApplication.java with `getReactNativeHost().getReactInstanceManager()`
5. turn this into an explicit section: https://fbflipper.com/docs/tutorial/js-table.html#dynamic-plugin-loading. Also explain that when using `node_modules`, config doesn't need to be changed?
6. xcode 10! sudo xcode-select -s /Applications/Xcode_10.XXX/Contents/Developer/
7. Also tried to install Reactotron plugins by Infinite Red, got that compilable in the end, but the andoid / ios implementations still seems to be stub, so I'll try to follow up with them later, to be notified when they actually have something
Reviewed By: passy
Differential Revision: D18349098
fbshipit-source-id: 233bbe20a37c57c7dfe08c8fccdd4508bdefe96f
Summary:
This didn't look quite right to me, "Download Mac", "Linux", "Windows".
Changed it to a separate "Download for", with "Mac", "Linux" and "Windows" buttons.
Reviewed By: passy
Differential Revision: D18225271
fbshipit-source-id: d644570d072029fc792cd9d9c18d8616ada0017b
Summary:
Got a warning during `yarn start` that the caniuse database
was out of date so I updated it along with the rest.
allow-large-files
Reviewed By: jknoxville
Differential Revision: D17715099
fbshipit-source-id: 8ff705afbaa0f2be272f85e2996d8e32c1f6ab05
Summary:
There's probably a more elegant way for doing this
so please let me know if you can think of something.
Reviewed By: danielbuechele
Differential Revision: D17318727
fbshipit-source-id: 9afcc30205171cfb07f0a749c552692cb40a3ced
Summary:
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.
<details>
<summary>Commits</summary>
- [`754f0c2`](754f0c20e1) 1.3.2
- [`90ee1fa`](90ee1fab37) ensure keys are valid when mixing in values
- See full diff in [compare view](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2)
</details>
<details>
<summary>Maintainer changes</summary>
This version was pushed to npm by [doowb](https://www.npmjs.com/~doowb), a new releaser for mixin-deep since your current version.
</details>
<br />
[](https://help.github.com/articles/configuring-automated-security-fixes)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/529
Reviewed By: danielbuechele
Differential Revision: D17095288
Pulled By: passy
fbshipit-source-id: 6433300f18828c7e7c117e25821b69c6b6fb5def
Summary:
Added docs for the Navigation Plugin.
I've added instructions on how to use the plugin with vanilla Android, or how to integrate it with a third party solution.
Reviewed By: danielbuechele
Differential Revision: D16856614
fbshipit-source-id: e99cb94318820bd926f50bd4ba205fb11396a9d8
Summary:
Now that we finally have something we can screenshot ...
Just for the features page right now, will add some
"installation" instructions next.
Reviewed By: oprisnik
Differential Revision: D15898050
fbshipit-source-id: 9dfd3b1121799e7069336aac845ba2abdb3e42df
Summary: Just a minor version change, no changes expected.
Reviewed By: jknoxville
Differential Revision: D15897958
fbshipit-source-id: b103772159177e47884eb88e47f7b4077f77be03
Summary: The "next" link at the bottom right now leads to a 404 (was the old data page).
Reviewed By: jknoxville
Differential Revision: D15237635
fbshipit-source-id: 67ee7ace933d270b9e85b012e9128e1003c73ece
Summary:
I copied the wordings from Pascal's android setup and changed the API's to match the iOS one. 🙈
This doc explains how to build custom plugin in iOS
Reviewed By: passy
Differential Revision: D15200426
fbshipit-source-id: 0a3c966f7c74aae410c6b3ee643e5a38d33880de
Summary:
- Layout was in an odd spot. "Other platforms" is still weird, but it's at least next to the JS part now.
- Tutorial is the first thing after the intro.
Reviewed By: danielbuechele
Differential Revision: D15198470
fbshipit-source-id: 263582ee51f228a295be5952f5dc219e53c5e3e6
Summary:
JS is next. Screenshot on the intro page is really bad.
I hope danielbuechele can replace this. :)
Reviewed By: jknoxville
Differential Revision: D15184371
fbshipit-source-id: 2faaf46450d192ae400675c13b8d71fa1b7dab14
Summary: Inlining the component docs header instead of reading it from the same file we write to.
Reviewed By: passy
Differential Revision: D15199683
fbshipit-source-id: dc34e25b5f8073aa582f90a14bc875c8e8c431db
Summary:
JS pages first, then client pages.
Would be nice if we had some sort of separator, but I think you can only have two levels.
Reviewed By: danielbuechele
Differential Revision: D15198312
fbshipit-source-id: 6c9f8d8775f513a55c256366448faed13b671767
Summary:
* Renamed to "Client Plugin API" to align with the "JavaScript Plugin API" page.
* Added some more info and reworded some parts.
Reviewed By: danielbuechele
Differential Revision: D15198192
fbshipit-source-id: 2c86b6a852e9ed52b0885eb5b7db8436028489d5
Summary: This was missing because it was still being generated in /docs.
Reviewed By: danielbuechele
Differential Revision: D15198144
fbshipit-source-id: aa9e77a1603fb63c1a7576091b70d8fa7124ab16
Summary: Documents init in the API reference and deletes the now redundant communicating page.
Reviewed By: danielbuechele
Differential Revision: D15198128
fbshipit-source-id: a9b88632b74edd7d9656ed888192db1fbe7f3642
Summary:
* Made the code snippets uniform across languages.
* Renamed to "Providing data to plugins" because sending hints at sending across the desktop-client connection which is misleading.
Reviewed By: danielbuechele
Differential Revision: D15198081
fbshipit-source-id: e2c318cdc6055c191f47e846b518c26dd21e4a68
Summary: This documents all pretty much the entire API.
Reviewed By: passy
Differential Revision: D15187834
fbshipit-source-id: 073c6a0dc40e3373967e9e5c5b7d44ab9c0aa07f
Summary:
The purpose of this page wasn't that clear to me, though the content is pretty focused. I've changed it from JS setup to JS Plugin Definition, and reworded it a bit.
I think it makes sense if this specifies everything to do with plugins on the file system, and the next page talks about what you do in javascript.
Reviewed By: passy
Differential Revision: D15184829
fbshipit-source-id: 6335ebc8d4297ffcbf1ab9860b4f055fe5bbcf87
Summary:
This page got lost in the reorganisation. Adding it back.
There's still work to be done on the content and organisation of these docs.
Reviewed By: passy
Differential Revision: D15184349
fbshipit-source-id: 76256ba53189579bec363903dc4068a421cafc98
Summary: priteshrnandgaonkar pointed out that they sometimes overlap with the text.
Reviewed By: jknoxville
Differential Revision: D15182356
fbshipit-source-id: def39676d5dcce85aa0b41760cec0ec5cfb9398c
Summary:
Please give feedback on the sidebar placement.
This is only the Android part. I'll put up a second diff copying the iOS thing over
but hope someone can commandeer that and check for accuracy.
Reviewed By: priteshrnandgaonkar
Differential Revision: D15181454
fbshipit-source-id: d32081feefbfb0ffc38890e835a7d5f6b78667ab
Summary: Describes the interface that clients should conform to to implement the layout plugin.
Reviewed By: danielbuechele
Differential Revision: D15166234
fbshipit-source-id: b86303f18f33762f09cfc503ece856cfcc887493
Summary: I can't take credit for this, I found it in the internal wiki. Have just modernised it and made it public.
Reviewed By: danielbuechele
Differential Revision: D15165547
fbshipit-source-id: d59344aa6ad47be6ab32b88abcdfc14a7d20c775
Summary:
Specifies the API for implementing your own Flipper Client.
I believe this provides everything you need to know to build a flipper-compliant client.
The only snag is that the current certificate exchange procedure would require a change to allow for new OS's, device types etc. It would be much better if we had a TLS-opt out so you don't need to go through all that rigmarole.
Reviewed By: passy
Differential Revision: D15150550
fbshipit-source-id: 2878dcc174807c3f86c0562660e8a3e43e5777b1