Summary:
Originally we planned to move the IDE inline in the row but this is hard to do well, especially with the horizontal scroll as well as the extra buttons for biggrep, codehub, AS and vscode.
Context menu is still very natural so lets try this
Reviewed By: lblasa
Differential Revision: D47210289
fbshipit-source-id: 339508c820915298161bf95fd1c3cea60b800746
Summary: Remove debug logs and add re-format other warn logs to have parity with iOS
Reviewed By: antonk52
Differential Revision: D47330455
fbshipit-source-id: ac8edde2124bbe99d0ea11f46f3b85dd77b96c7b
Summary:
This change has a minimal Connectivity Hub with a log viewer of connectivity related events.
The hub is integrated so that is usable.
Reviewed By: antonk52
Differential Revision: D47296027
fbshipit-source-id: 7611ce0b1480e9bdb7cdff2bcedeb445a322c195
Summary: To dispatch events, we need a valid instance of FlipperServer. This is the place so enable the recorder with it.
Reviewed By: antonk52
Differential Revision: D47295986
fbshipit-source-id: f2231544c58ba8f76e9102265e10a99520260b0a
Summary:
CertificateProvider is intrinsically related to a client query, make it available to it.
This becomes the optional 'context' of shell executions. When these are recorded, the context is provider to the recorder which can then link an ongoing certificate exchange process with the success or failure of said command.
Reviewed By: antonk52
Differential Revision: D47295894
fbshipit-source-id: 9469d18bda02793d71a6a8b29c93f4af1db23569
Summary:
Centralise connectivity logging into a single place. By having all logs go through a single interface, then it becomes trivial to manipulate them as needed.
In this change, this is not done.
In subsequent diffs, logs will be dispatched via an event and will be visualised in the Connectivity Hub.
Reviewed By: passy
Differential Revision: D47185054
fbshipit-source-id: fb5eab98895be0c8f61fb9a77d3e66d6a8dbcb27
Summary: These resolutions aren't used, validated with `yarn why`. See the diff higher in the stack for automation.
Reviewed By: yungsters
Differential Revision: D47282205
fbshipit-source-id: a2e909e3802f780fbe7525e5945faebee7004aef
Summary:
Scaffolding connectivity hub. The final place may be different though.
But at least for now whilst we iterate on the solution, this should be enough.
Reviewed By: passy
Differential Revision: D47230905
fbshipit-source-id: e3b3f7d773e1bf8b0dd9821cf25c6fa8e77669f4
Summary: As per comment, the issue is already fixed and released.
Reviewed By: LukeDefeo
Differential Revision: D47257442
fbshipit-source-id: 2a975690bab0eaed12b6b4233be41f675760a0bc
Summary:
Bit of refactoring, bit of improvements, maybe. Mainly:
- Name consistency
- Promise chaining to async/await
- Refactoring
Reviewed By: lawrencelomax, antonk52
Differential Revision: D47224620
fbshipit-source-id: 5f4515f576decc03d470c11f24577b43f34a5a28
Summary: Already have SecureClientQuery. No need to have this as a type as it's not used or needed anywhere.
Reviewed By: antonk52
Differential Revision: D47210345
fbshipit-source-id: d9f3026a0e2a0b5dd2e87f16dba34a388dacd75f
Summary: It should've been there with ClientQuery.
Reviewed By: antonk52
Differential Revision: D47210314
fbshipit-source-id: 869496918648f20b616c1a612296fff55597af77
Summary: Bit of reorganising as utils is a bit too generic and crowded.
Reviewed By: passy
Differential Revision: D47186536
fbshipit-source-id: 7b1dd26db95aef00778ff4f23d91f7371c4d07ad
Summary:
The field changed from mStates to states breaking our reflection based code. Ideally I would like to just check if type == KStateContainer and access the field normally but the rest of the infrastructure expect to work on a java field.
Added tests to catch this sort of thing in the future. had to shift buck files around a bit to get it to work
Reviewed By: antonk52
Differential Revision: D46974357
fbshipit-source-id: 87a6f5883b33e4d1a7359df5987fc7ead7c19033
Summary: It doesn't get more generic than 'comms'. So, narrow it down: app-connectivity.
Reviewed By: passy
Differential Revision: D47185255
fbshipit-source-id: 87e9c2487c9b07603d14e856de670757078c0da1
Summary: Make it more clear about that this is. `ServerAdapter` was VERY generic.
Reviewed By: passy
Differential Revision: D47185076
fbshipit-source-id: 7d9b30f423398004bedc92ad22bc0217d1c8453f
Summary: When the length of `pkcs12.second.c_str()` is equal to `length`, strncpy won't write a null-terminator at the end of the destination string, making the destination unsafe to read and potentially cause an overflow.
Reviewed By: lblasa
Differential Revision: D46934320
fbshipit-source-id: 5e7acd49523b80105bcc47471facd9ff23b8a2b8
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4905
Use fully qualified names in an attempt to fix the broken build.
Reviewed By: passy
Differential Revision: D47148297
fbshipit-source-id: bb2e81f62a65b9d4516a0bc4cfe2abddfc18a566
Summary: node count and root node prescense will be very useful
Reviewed By: lblasa
Differential Revision: D47153394
fbshipit-source-id: 067f6f3aefa17cdfa88124956781400f53fe08d7
Summary:
See https://github.com/samdenty/console-feed/issues/124.
This is breaking our CI and lots of other things. We should hopefully be able to cleanly revert this on Monday.
Reviewed By: ivanmisuno
Differential Revision: D47150333
fbshipit-source-id: f34d6afdb83607c8ac2cc7fb2989ca68733798e0
Summary: Set delegate and close inside the operation's queue as to make it safer i.e. all socket related operations are done inside the queue.
Reviewed By: ivanmisuno
Differential Revision: D47124235
fbshipit-source-id: 48b53db1cd47d017a26186a156046ba68fe358b7
Summary:
About to release React Native 0.72.1. This version of React Native has to depend on SocketRocket 0.7.0, released yesterday.
Cocoapods is failing to install dependencies with the following error:
```
In snapshot (Podfile.lock):
SocketRocket (= 0.7.0)
In Podfile:
FlipperKit/FlipperKitReactPlugin (= 0.182.0) was resolved to 0.182.0, which depends on
FlipperKit/Core (= 0.182.0) was resolved to 0.182.0, which depends on
SocketRocket (~> 0.6.0)
React-Core/RCTWebSocket (from `../react-native/`) was resolved to 1000.0.0, which depends on
SocketRocket (= 0.7.0)
React-CoreModules (from `../react-native/React/CoreModules`) was resolved to 1000.0.0, which depends on
SocketRocket
```
By bumping the SocketRocket dependencies and publishing a new version of FlipperKit, we would be able to release React Native.
Reviewed By: passy, cipolleschi
Differential Revision: D47125059
fbshipit-source-id: d0797880c502c14db9f0261c3e8abf2652e7bba2
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4890
Reviewed By: ivanmisuno
Differential Revision: D47091378
Pulled By: passy
fbshipit-source-id: 254b1a6ca737c2ccfa40db3bae147d0db1b1594b
Summary:
Never really liked this code. Before this change, calls to connect were blocking.
Because of this, we had to make use of promises and a bit of really not that good-looking code.
So, this change makes connect non-blocking meaning that we make full use of our event handler.
These changes contain:
- CSR is not getting generated after each failed attempt.
- Connect is no longer blocking.
- Do not report events via the handler when explicitly disconnecting.
Reviewed By: jknoxville
Differential Revision: D46853228
fbshipit-source-id: 00e6a9c7c039a756175fe14982959e078d92bacb
Summary:
This diff bumps `hramos/needs-attention` to `v2.0.0` & `actions/checkout` to `v3`
- `hramos/needs-attention@v2.0.0` is a `latest` **BREAKING** release with a number of improvements made by Pranav-yadav i.e. ***me*** 😎
### Major Improvements:
`hramos/needs-attention@v2.0.0`:
- Bump `Node.js` to `v16`
- Bump `actions/checkout` to `v3`
- Add **TypeScript**
- Generate and publish **fully compiled** dist (with deps) instead of `node_modules`
### Ref.:
- Full Changelog for `v2.0.0`: https://github.com/hramos/needs-attention/releases/tag/v2.0.0
- Marketplace `v2.0.0`: https://github.com/marketplace/actions/needs-attention?version=v2.0.0
## Changelog:
[GENERAL] [SECURITY] - [Actions] `issues` - Bump `hramos/needs-attention` to `v2.0.0` & `actions/checkout` to `v3`
Pull Request resolved: https://github.com/facebook/flipper/pull/4862
Test Plan: - Workflow should add and remove respective labels as usual.
Reviewed By: lblasa
Differential Revision: D47017048
Pulled By: passy
fbshipit-source-id: ebc70e2c64e1d782977da96863d9b9969a453551
Summary:
This diff switches to `dtolnay/rust-toolchain@stable` since `actions-rs/toolchain` is **NOT maintained** and bumps `actions/checkout@v3.5.3`
> **Note**:
> `uses: dtolnay/rust-toolchain@stable`
> The selection of Rust toolchain is made based on the particular `rev` of this Action being requested. For example `dtolnay/rust-toolchain@nightly` pulls in the `nightly` Rust toolchain, while `dtolnay/rust-toolchain@1.42.0` pulls in `1.42.0`.
### Ref.:
- `actions-rs/toolchain` is **NOT Maintained**, issue:
https://github.com/actions-rs/toolchain/issues/216
- `dtolnay/rust-toolchain@stable` usage note: https://github.com/dtolnay/rust-toolchain#example-workflow
- `actions/checkout@v3.5.3` changelog: https://github.com/actions/checkout/releases/tag/v3.5.3
## Changelog:
[GENERAL] [SECURITY] - [Actions] `packer` - Switch to `dtolnay/rust-toolchain@stable` & bump `actions/checkout@v3.5.3`
Pull Request resolved: https://github.com/facebook/flipper/pull/4878
Test Plan: - Workflow should run and work as usual.
Reviewed By: lblasa
Differential Revision: D47056977
Pulled By: passy
fbshipit-source-id: 68023fcce355831314af2f31d514ed95efb7788c
Summary:
Usage tracking comes from Electron's `main.tsx`. There's a timer that dispatches an IPC event every 60 seconds.
This is all good for Electron builds.
For non-electron builds, there's no such thing as IPC.
So, react to the IPC event whenever necessary but also handle the interval internally such that usage is tracked independently of explicit callers.
Reviewed By: antonk52
Differential Revision: D47053404
fbshipit-source-id: f17694e65eed18678b45a2e815813bafab69c3f1
Summary: A transition period of 2 years should be enough.
Reviewed By: LukeDefeo
Differential Revision: D47053216
fbshipit-source-id: c9f9bfbff82a05942d408b325088095a6069cced
Summary: Im concerned that we are gettign disconnected without realising, this should help with the logs
Reviewed By: lblasa
Differential Revision: D47053321
fbshipit-source-id: 1014a3e856517e234f0f79f2a4692f18397fc457
Summary: This will hopefully be useful for prod debugging where we have users with no data,
Reviewed By: lblasa
Differential Revision: D47053328
fbshipit-source-id: 37ecce885ebd93bf2ffdd67cf49cf33255dda429
Summary:
This just adds a link next to each request in the Flipper GraphQL plugin to take you to the mobile GraphQL efficiency tool. We want this to be a kind of hub for mobile devs using GraphQL, alongside GraphiQL.
This was a suggestion from a product dev who attended our demo. Later we could also pull down actually efficiency info and show it directly in Flipper.
Reviewed By: ginfung
Differential Revision: D47029548
fbshipit-source-id: 05185e57bfbfaab9169a6b154822ede82d50fd4d
Summary:
PerformanceStatsEvent declares the metrics we track for performance.
DynamicPerformanceStatsEvent is a new type which extends it by allowing arbitraty key/value pairs to be reported and visualised.
Reviewed By: antonk52
Differential Revision: D47023248
fbshipit-source-id: fadfad79561fca9ae48d0668da3cc62f0d0391d8
