Summary:
Split container had a convenient property `scrollable`, that automatically applies a Scroll container to the main content.
But I noticed it leads to bad design choices because it is so convenient. So sometimes scrolling would be unnecessarily in two directions because of this.
Or, since the scroll container wraps around the whole content, toolbars would scroll out of view. By forcing scrolling to be put explicitly in the component tree, we encourage plugin developers to think about where they actually want to have that scroll, and in which direction.
Also added options to use the Container padding properties on ScrollContainer, which is great since we can keep the scrollbars outside the padding, and apply it to the content only, to prevent an accidental mistake where people would put a scroll container in a padded container, that would put the scrollbar inside the padding.
Reviewed By: cekkaewnumchai
Differential Revision: D24502546
fbshipit-source-id: 524004a1c5f33a185f9b959251b72875dd623cb3
Summary:
So far we distinguished `Layout.Container` from `Layout.Vertical`, but they did almost exactly the same, so figured to unify them, so smaller API ftw :) Normal containers put children vertical, and if you want to use horizontal, use Layout.Horzontal
Also simplified code in Layout file a little bit.
Fixed issue I split container where the main container didn't go "underneath" the fixed container
Reviewed By: cekkaewnumchai
Differential Revision: D24502547
fbshipit-source-id: 517db3692749e670cda8f0cd7cb1c807df818b4d
Summary: Added `axis` property to scroll container, to make scroll work in one direction, and fill out the other one.
Reviewed By: cekkaewnumchai
Differential Revision: D24390943
fbshipit-source-id: 5767e753edfb947f43b3998e10d6cebf57f9b53b
Summary: This diff adds the device switcher, filling the switcher with apps and devices.
Reviewed By: cekkaewnumchai
Differential Revision: D24053787
fbshipit-source-id: 4f69835a12eec90a0e5704f71c8ceed5509f61ce
Summary: Added standardized dimensions for padding and gap, to encourage people to build layouts that look consistent, using for example `padv="small"`
Reviewed By: cekkaewnumchai
Differential Revision: D23961386
fbshipit-source-id: 33cd3b8974858e021a8b7d1b32f018fe3f007c63
Summary:
This diff introduces:
- ScrollContainer
- Make sure Ant Link components always open URLs externally, to avoid users needing to use electron api's
- Introduce a design systems page where people can find docs on how to organise sandy layout, and it also provides a convenient way to test layout mechanisms.
- Fixed several layout bugs found as a result of adding the design system page
In next diff:
- more convenience around organizing paddings
- making the design system accessible from the menu
Reviewed By: cekkaewnumchai
Differential Revision: D23930274
fbshipit-source-id: 4aab058d15b3391287e0e32513a5d83831448857
