Summary: It is an escape hatch for testing iOS Sample app if `navigate('/')` cannot be made to work easily (D51394323)
Reviewed By: lblasa
Differential Revision: D51466697
fbshipit-source-id: fd6c2f37504807b4b634b85cb10e837523dadba8
Summary: setTimeout should terminate process if graceful termination takes too long. Before, we scheduled the timer only *after* the graceful termination completes which does not make any sense
Reviewed By: lblasa
Differential Revision: D51346673
fbshipit-source-id: b5adadbcf474a8c66839e1fc70bcc6482c47635e
Summary: This is a duplicate, is not needed, causes confusion.
Reviewed By: aigoncharov
Differential Revision: D51307091
fbshipit-source-id: 4d55d727ea5f20100ecd15ad6e23aa0c01722524
Summary: Instead of having duplicate configs defined on our HTML. Move the config definition to the server.
Reviewed By: aigoncharov
Differential Revision: D51307092
fbshipit-source-id: 68f4afc918cf191b3a15b3981429c5a05d5df8df
Summary:
When flipper starts it writes to both env vars the value from settings. This is needed for subprocesses to have access to them.
The problem with the check for both env vars is
- In prod environment applications does not have access to them
- In dev, when developers launch flipper from terminal (`yarn run flipper-server`) it picks up these env vars if they are set which can cause different behaviour in dev and prod
To make flipper work more deterministic, for users and us. I removed this check and now we always write to these env vars what the user has provided in flipper settings or the default.
Reviewed By: lblasa
Differential Revision: D51266495
fbshipit-source-id: cf3adfd4ba83a733a30b5b0b29c270b32ff3a61a
Summary:
As I was setting up a new mac I had to change this setting in flipper settings.
From a few android people that I've spoken to no one could answer me if the old one is still used.
Ideally we should infer this during the first time flipper starts
- `/opt/android_sdk` current default
- `$HOME/Library/Android/sdk` adb from Android Studio
- `$HOME/fbsource/third-party/toolchains/android-sdk` adb that is always available in fbsource
Reviewed By: lblasa
Differential Revision: D51120929
fbshipit-source-id: edb2a58b9c9f37465ea2fc5493975dd427d5523b
Summary:
Auth token used be injected in the manifest file. Instead, have the server injected into the main HTML page.
The main driver to this change are:
- Simplify
- There are instances in which for some reason reading/writing the token from the manifest fails. This will address that problem.
Reviewed By: lblasa
Differential Revision: D51160521
fbshipit-source-id: 4626fd8f56bc8b61182a53a5d9cf5acad1e723bc
Summary:
If after 5 hours there are no connected clients, shutdown the server.
This is to prevent cases whereas the long-lived instance makes users use stale versions of Flipper if Flipper stays indefinitely running in the background.
Reviewed By: passy
Differential Revision: D51111926
fbshipit-source-id: 4c38e392cf8a6a4fb840bffdea92c0b0314aefb9
Summary: Expose an endpoint to open Flipper UI. This will be used by the Flipper Server Cocoa app to open the UI.
Reviewed By: antonk52
Differential Revision: D51115327
fbshipit-source-id: 1ab1c32d93945cf8d75b145905983738331a6468
Summary: This is currently done by querying the 'console-log' event. Instead, make it type safe and official.
Reviewed By: antonk52
Differential Revision: D50927954
fbshipit-source-id: ff767acdc51b942c6deb92ffbfd93288b3367062
Summary: This is currently done by querying the 'console-log' event. Instead, make it type safe and official.
Reviewed By: antonk52
Differential Revision: D50927803
fbshipit-source-id: e0488782dd584e36b6f742f9892fc09ffaf62469
Summary: This is currently done by querying the 'console-log' event. Instead, make it type safe and official.
Reviewed By: antonk52
Differential Revision: D50927713
fbshipit-source-id: 780c0f158bf8bdaa6d009035a0cee62c7828f479
Summary:
Reference:
https://fb.workplace.com/groups/flippersupport/permalink/1717333982080586/
The steps added below seem to have fixed the issue.
Still need to investigate why these steps are needed.
Reviewed By: aigoncharov
Differential Revision: D50797561
fbshipit-source-id: a31c71dbedc506344438082846b41ff16b6f459a
Summary: This seems to be (no longer) in use.
Reviewed By: lblasa
Differential Revision: D50645270
fbshipit-source-id: 69cf276f97d960a16ffd3e48342420b33fa646da
Summary: Previously I had created a RN build, locally, with a few minor differences. That had to be reverted. Instead of reverting and re-applying changes, I'm introducing a flag that can be used in the interim to produce the RN-only builds.
Reviewed By: LukeDefeo
Differential Revision: D50555055
fbshipit-source-id: edface9a1587fb51e54eebe73724032baf985c83
Summary:
Every time the token is returned, export it to the manifest.
This covers the case in which the token found in the manifest has already expired.
Reviewed By: antonk52
Differential Revision: D50419458
fbshipit-source-id: 8eefa0e97e234985b34f824190b208bf74e2d8ec
Summary: If the token has already expired, generate another one.
Reviewed By: aigoncharov
Differential Revision: D50410431
fbshipit-source-id: 108a3b344a1bcafd93a8d9bc94cba5c133d099d7
Summary: Do not use mutex for device listing.
Reviewed By: antonk52
Differential Revision: D50265112
fbshipit-source-id: 9b3bf4f9351e28dfb6366b6b787ec8b466b9bc47
Summary:
This change will allow us to display correct stack traces in flipper UI as well as send them to scuba.
Currently correct stack traces are only displayed in the console and we do not have access to them.
Reviewed By: ivanmisuno
Differential Revision: D50015827
fbshipit-source-id: 2a60315dd5c06b2635ce0414f612ff1fdca0e489
Summary: Set a timeout period to become ready. It is better to kill the server if not ready, than keeping it alive.
Reviewed By: antonk52
Differential Revision: D50004605
fbshipit-source-id: be1d2c022c634ece059fc03eb6faea695431ba95
Summary: Track whenever the server is unable to bind to the specified port.
Reviewed By: antonk52
Differential Revision: D49951304
fbshipit-source-id: 971d7c324f27c287036707d21bb51d26acbd6615
Summary:
^
Also, if an error happens, do not swallow it, rethrow.
Reviewed By: passy
Differential Revision: D49912780
fbshipit-source-id: 30451110d8c5776e2b0826d6e924ab5fe98cd7e2
Summary: If we are unable to bind to the specified port, exit process.
Reviewed By: passy
Differential Revision: D49908107
fbshipit-source-id: 6d76f3d661ec61867be5307c756e372a7b20a9f6
Summary: Currently, we are not interested in these errors. Let's add some logging as a way of knowing if they take place and why.
Reviewed By: antonk52
Differential Revision: D49828378
fbshipit-source-id: f741a45e1ba9892aa54dca85f97bcc419e0b5e25
