Michel Weststrate
54f9ff260b
Show quick notification if plugin interaction fails
...
Summary:
Per title, if a plugin makes a client call, show a quick notif so that the user knows why his plugin interactions aren't responding in case the plugin doesn't use `isConnected` guards.
This might turn out to be too spammy, but I think it should be ok.
Reviewed By: nikoant
Differential Revision: D26277099
fbshipit-source-id: bd555ea84acae6189ec7f8fff0fc0a088dbc5337
2021-02-09 04:16:27 -08:00
Michel Weststrate
e5232da402
make sure Dropdown.Button uses flex like Button
...
Summary: Button fills out by default in Ant design if used in a flex container. Dropdown.Button doesn't do so. With this change
Reviewed By: jknoxville
Differential Revision: D26045409
fbshipit-source-id: 593b767aa7e38a98c8887b426f36fe41cb41bfd3
2021-01-25 06:42:50 -08:00
Michel Weststrate
6f75e39ca5
Clean up employee warning
...
Summary: Replaced in-your-face warning with a but more subtle one. Means also less usage of component lib.
Reviewed By: nikoant
Differential Revision: D25944965
fbshipit-source-id: 02a66ff96df2ab8b648f8b8cbeb30d025adfd5a8
2021-01-19 07:09:59 -08:00
dependabot[bot]
91b501d0ed
Bump antd from 4.6.6 to 4.9.1 in /desktop ( #1734 )
...
Summary:
allow-large-files
Bumps [antd](https://github.com/ant-design/ant-design ) from 4.6.6 to 4.9.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases ">antd's releases</a>.</em></p>
<blockquote>
<h2>4.9.1</h2>
<ul>
<li>TypeScript
<ul>
<li>� Fix Collapse.Panel <code>collapsible</code> property to optional. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28092 ">#28092</a> <a href="https://github.com/sammarks ">sammarks</a></li>
</ul>
</li>
</ul>
<hr />
<ul>
<li>TypeScript
<ul>
<li>� 修复 Collapse.Panel 可折叠属性 <code>collapsible</code> 为可选。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28092 ">#28092</a> <a href="https://github.com/sammarks ">sammarks</a></li>
</ul>
</li>
</ul>
<h2>4.9.0</h2>
<ul>
<li>Modal
<ul>
<li>{emoji:1f195} Modal support <code>focusTriggerAfterClose</code> to disable auto focus back. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27985 ">#27985</a> <a href="https://github.com/molokovev ">molokovev</a></li>
<li>{emoji:1f41e} Fix Modal hooks not trigger <code>onCancel</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28063 ">#28063</a> <a href="https://github.com/JuniorTour ">JuniorTour</a></li>
<li>{emoji:1f41e} Fix Modal sometime not popup from the click position. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28037 ">#28037</a></li>
<li>{emoji:1f195} Support <code>closable</code> and <code>closeIcon</code> api for Modal.method. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27909 ">#27909</a> <a href="https://github.com/MrHeer ">MrHeer</a></li>
</ul>
</li>
<li>{emoji:1f484} Reduce Table selection column width to <code>32px</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28073 ">#28073</a></li>
<li>Image
<ul>
<li>{emoji:1f525} Image add PreviewGroup component to support multiple images preview. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28069 ">#28069</a></li>
<li>{emoji:1f41e} Fix Image style prop not acting on img element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27446 ">#27446</a></li>
</ul>
</li>
<li>Collapse
<ul>
<li>{emoji:1f525} Collapse support <code>collapsible</code> to customize trigger region and deprecated Panel <code>disabled</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27790 ">#27790</a></li>
<li>{emoji:1f41e} Fix Collapse cannot contains <code><Table sticky /></code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28039 ">#28039</a></li>
</ul>
</li>
<li>{emoji:1f41e} Fix Cascader bug that empty data can be selected. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28062 ">#28062</a> <a href="https://github.com/n0ruSh ">n0ruSh</a></li>
<li>{emoji:1f195} Alert support <code>action</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/25892 ">#25892</a> <a href="https://github.com/jesse3mh9a ">jesse3mh9a</a></li>
<li>{emoji:1f525} Tree refactor drag behavior. Add <code>dropIndicatorRender</code> and <code>allowDrop</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/26462 ">#26462</a> <a href="https://github.com/07akioni ">07akioni</a></li>
<li>{emoji:1f195} Space support <code>wrap</code> for auto break line. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27910 ">#27910</a></li>
<li>{emoji:1f195} Descriptions.Item support <code>labelStyle</code> & <code>contentStyle</code> props. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27897 ">#27897</a></li>
<li>{emoji:1f195} Form.List support <code>initialValue</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27872 ">#27872</a></li>
<li>{emoji:1f195} Menu supports <code>expandIcon</code>, and optimize default expand icon style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27565 ">#27565</a></li>
<li>{emoji:1f195} Input and TextArea add <code>setSelectionRange</code> of <code>ref</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27584 ">#27584</a> <a href="https://github.com/appleshell ">appleshell</a></li>
<li>{emoji:1f195} Select support <code>filterSort</code> to order the filtered options. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27523 ">#27523</a> <a href="https://github.com/n0ruSh ">n0ruSh</a></li>
<li>{emoji:1f1f0_1f1ff} Add Kazakh locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27589 ">#27589</a> <a href="https://github.com/nodkz ">nodkz</a></li>
</ul>
<hr />
<ul>
<li>Modal
<ul>
<li>{emoji:1f195} Modal 支持 <code>focusTriggerAfterClose</code> 以关闭自动恢复焦点的功能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27985 ">#27985</a> <a href="https://github.com/molokovev ">molokovev</a></li>
<li>{emoji:1f41e} 修复 Modal hooks 没有触发 <code>onCancel</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28063 ">#28063</a> <a href="https://github.com/JuniorTour ">JuniorTour</a></li>
<li>{emoji:1f41e} 修复 Modal 有时不在点击位置弹出的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28037 ">#28037</a></li>
<li>{emoji:1f195} Modal.method 支持 <code>closable</code> 和 <code>closeIcon</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27909 ">#27909</a> <a href="https://github.com/MrHeer ">MrHeer</a></li>
</ul>
</li>
<li>{emoji:1f484} 减少 Table 选中列宽度至 <code>32px</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28073 ">#28073</a></li>
<li>Image
<ul>
<li>{emoji:1f525} Image 增加 PreviewGroup 组件支持多张图片预览。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28069 ">#28069</a></li>
<li>{emoji:1f41e} 修复 Image style 属性未作用于 img 元素的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27446 ">#27446</a></li>
</ul>
</li>
<li>Collapse
<ul>
<li>{emoji:1f525} Collapse 添加 <code>collapsible</code> 以支持指定可折叠触发区域并废弃 Panel 的 <code>disabled</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27790 ">#27790</a></li>
<li>{emoji:1f41e} 修复 Collapse 内使用 <code><Table sticky /></code> 时不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28039 ">#28039</a></li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md ">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.9.1</h2>
<p><code>2020-12-01</code></p>
<ul>
<li>TypeScript
<ul>
<li>� Fix Collapse.Panel <code>collapsible</code> property to optional. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28092 ">#28092</a> <a href="https://github.com/sammarks ">sammarks</a></li>
</ul>
</li>
</ul>
<h2>4.9.0</h2>
<p><code>2020-11-30</code></p>
<ul>
<li>Modal
<ul>
<li>{emoji:1f195} Modal support <code>focusTriggerAfterClose</code> to disable auto focus back. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27985 ">#27985</a> <a href="https://github.com/molokovev ">molokovev</a></li>
<li>{emoji:1f41e} Fix Modal hooks not trigger <code>onCancel</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28063 ">#28063</a> <a href="https://github.com/JuniorTour ">JuniorTour</a></li>
<li>{emoji:1f41e} Fix Modal sometime not popup from the click position. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28037 ">#28037</a></li>
<li>{emoji:1f195} Support <code>closable</code> and <code>closeIcon</code> api for Modal.method. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27909 ">#27909</a> <a href="https://github.com/MrHeer ">MrHeer</a></li>
</ul>
</li>
<li>{emoji:1f484} Reduce Table selection column width to <code>32px</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28073 ">#28073</a></li>
<li>Image
<ul>
<li>{emoji:1f525} Image add PreviewGroup component to support multiple images preview. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28069 ">#28069</a></li>
<li>{emoji:1f41e} Fix Image style prop not acting on img element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27446 ">#27446</a></li>
</ul>
</li>
<li>Collapse
<ul>
<li>{emoji:1f525} Collapse support <code>collapsible</code> to customize trigger region and deprecated Panel <code>disabled</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27790 ">#27790</a></li>
<li>{emoji:1f41e} Fix Collapse cannot contains <code><Table sticky /></code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28039 ">#28039</a></li>
</ul>
</li>
<li>{emoji:1f41e} Fix Cascader bug that empty data can be selected. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28062 ">#28062</a> <a href="https://github.com/n0ruSh ">n0ruSh</a></li>
<li>{emoji:1f195} Alert support <code>action</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/25892 ">#25892</a> <a href="https://github.com/jesse3mh9a ">jesse3mh9a</a></li>
<li>{emoji:1f525} Tree refactor drag behavior. Add <code>dropIndicatorRender</code> and <code>allowDrop</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/26462 ">#26462</a> <a href="https://github.com/07akioni ">07akioni</a></li>
<li>{emoji:1f195} Space support <code>wrap</code> for auto break line. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27910 ">#27910</a></li>
<li>{emoji:1f195} Descriptions.Item support <code>labelStyle</code> & <code>contentStyle</code> props. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27897 ">#27897</a></li>
<li>{emoji:1f195} Form.List support <code>initialValue</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27872 ">#27872</a></li>
<li>{emoji:1f195} Menu supports <code>expandIcon</code>, and optimize default expand icon style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27565 ">#27565</a></li>
<li>{emoji:1f195} Input and TextArea add <code>setSelectionRange</code> of <code>ref</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27584 ">#27584</a> <a href="https://github.com/appleshell ">appleshell</a></li>
<li>{emoji:1f195} Select support <code>filterSort</code> to order the filtered options. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27523 ">#27523</a> <a href="https://github.com/n0ruSh ">n0ruSh</a></li>
<li>{emoji:1f1f0_1f1ff} Add Kazakh locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27589 ">#27589</a> <a href="https://github.com/nodkz ">nodkz</a></li>
</ul>
<h2>4.8.6</h2>
<p><code>2020-11-27</code></p>
<ul>
<li>{emoji:1f41e} Fix Badge style blink when mounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28003 ">#28003</a></li>
<li>{emoji:1f484} Reduce Modal style size. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27998 ">#27998</a></li>
<li>{emoji:1f41e} Fix Layout.Sider can not collapse when <code>width='0'</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28000 ">#28000</a></li>
<li>{emoji:1f41e} Fix Menu style when using none Ant Design icons. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27983 ">#27983</a></li>
<li>Input
<ul>
<li>{emoji:1f41e} Fix Input.Search button height when customize less variables. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27986 ">#27986</a></li>
<li>{emoji:1f41e} Fix Input.Search <code>addonBefore</code> abnormal style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27960 ">#27960</a></li>
</ul>
</li>
<li>{emoji:1f41e} Fix Typography.Link clicking copy button will redirect. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27982 ">#27982</a></li>
<li>{emoji:1f41e} Fix Carousel throws error <code>Unable to preventDefault inside passive event listener</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/27957 ">#27957</a></li>
<li>{emoji:1f310} Improve data picker locale for <code>en_GB</code> and <code>zh_TW</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28016 ">#28016</a> <a href="https://github.com/abz53378 ">abz53378</a></li>
<li>RTL
<ul>
<li>{emoji:1f484} Optimize the border style of Descriptions in RTL model. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28010 ">#28010</a></li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="dda1f2b09chttps://github-redirect.dependabot.com/ant-design/ant-design/issues/28094 ">#28094</a>)</li>
<li><a href="511c8510fb2cc6b0ca05https://github-redirect.dependabot.com/ant-design/ant-design/issues/28095 ">#28095</a>)</li>
<li><a href="6e040bbd98https://github-redirect.dependabot.com/ant-design/ant-design/issues/28102 ">#28102</a>)</li>
<li><a href="30cc31af7e16bc4bcdabhttps://github-redirect.dependabot.com/ant-design/ant-design/issues/28092 ">#28092</a>)</li>
<li><a href="682b55d6b6https://github-redirect.dependabot.com/ant-design/ant-design/issues/28088 ">#28088</a>)</li>
<li><a href="98ddb8d8dahttps://github-redirect.dependabot.com/ant-design/ant-design/issues/28080 ">#28080</a>)</li>
<li><a href="6bb9701e23https://github-redirect.dependabot.com/ant-design/ant-design/issues/28081 ">#28081</a> from ant-design/feature</li>
<li><a href="ac3142acf6https://github.com/ant-design/ant-design/compare/4.6.6...4.9.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1734
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
Did some exploratory testing and styling simplifications
{F350178586}
Reviewed By: nikoant
Differential Revision: D25461255
Pulled By: mweststrate
fbshipit-source-id: 2f2948664f302829d8fc4bc954b910ff4d033b4c
2020-12-11 06:48:08 -08:00
Michel Weststrate
8a7323b9f8
Render plugin list
...
Summary:
This diff adds the rough navigation to open pugins, there are some rough egdes still, and tests will be added later, but wanted to keep diffs small, and land the feature early to get some initial dogfooding going on early.
Note that we now also show all disabled plugins to help people with trouble shooting.
Reviewed By: nikoant
Differential Revision: D24418411
fbshipit-source-id: 1402d69efe2e52bc2c81336cfb4f4c9928ea4d80
2020-10-22 09:41:11 -07:00
Michel Weststrate
f14a724fa5
Device plugin list
...
Summary:
Render a plugin list
Will add tests once the entire feature is complete
Reviewed By: cekkaewnumchai
Differential Revision: D24079897
fbshipit-source-id: db7250ff612b67ab18dfcacdcb9c44dab596933d
2020-10-20 03:24:46 -07:00
Chaiwat Ekkaewnumchai
2b6bac4227
Add Flipper Doctor Component
...
Summary:
As designed by Vince [here](https://www.figma.com/file/4e6BMdm2SuZ1L7FSuOPQVC/Flipper?node-id=585%3A127550 ), this diff adds Flipper Doctor into Sandy
Note:
- The dot on Doctor icon will act similarly to `DoctorBar`
- add type to `count` for `LeftRailButton` to act like dot badge
- Get rid of padding in `antd` modal
Reviewed By: nikoant, mweststrate
Differential Revision: D24137349
fbshipit-source-id: 8ce441e0ed96083eba09d98dfd3a45ff9b5be027
2020-10-07 08:47:55 -07:00
Chaiwat Ekkaewnumchai
6d1da5bb42
Add Login Component
...
Summary:
- Add Sandy renderer for `SignInSheet`
- Change background color for default button
Reviewed By: mweststrate
Differential Revision: D24112100
fbshipit-source-id: a602c920c24dd039697834aaba3c79e79f04481e
2020-10-07 03:12:30 -07:00
Michel Weststrate
02570136ce
Fix ANT line-height leaking into legacy design
...
Summary:
Fixes layout issue that was caused by ANT line-heights leaking into the old design.
Introduced a `.flipperlegacy_design ` class at the `root` element of Flipper, so that it is easier in the future to bail out / add overrides for certain features in the old design.
Reviewed By: priteshrnandgaonkar
Differential Revision: D24135482
fbshipit-source-id: 40091ebbde71662f2ebea66577f7b727009ca9c6
2020-10-06 04:58:18 -07:00
Chaiwat Ekkaewnumchai
93c897820b
Change Typography Size
...
Summary:
Typography on Sandy! The designed typography is [here in Figma](https://www.figma.com/file/4e6BMdm2SuZ1L7FSuOPQVC/Flipper?node-id=238%3A172 )
Current deflects
- cannot find component for 'body - small' and 'meta'
- don't know how to set 'link secondary hover' as designed
Reviewed By: mweststrate
Differential Revision: D23869256
fbshipit-source-id: efb1475749cebad529b502458d1b15bd445bb346
2020-09-23 17:59:46 -07:00
Pascal Hartig
bc0bcda300
Fix license headers for less files
...
Summary: Failing OSS requirements due to missing headers right now: P143086435
Reviewed By: mweststrate
Differential Revision: D23843532
fbshipit-source-id: 759daefbec641d59adff6ecee8d06dd90c7a6b5b
2020-09-23 09:46:21 -07:00
Michel Weststrate
95638af321
Build main layout
...
Summary: This diff introduces the. main sections and restyled resizable panes according to the Figma design
Reviewed By: cekkaewnumchai
Differential Revision: D23758349
fbshipit-source-id: 7f09574f6b5fb54551141c13667c664e1769f09a
2020-09-21 11:53:21 -07:00
Michel Weststrate
694d4e0e33
Expose theme from JavaScript
...
Summary:
This diff fixes two problems when further theming Flipper:
1. All shades of gray where defined in terms of black/white + transparency. Converted all colors to non transparent to make sure they stack well.
2. The color theme defined in less aren't available as javascript colors. It is possible to achieve that through setting up a babel parser that parses the less files and exposes them to JS. But since we have modern stack, figured that exposing all theme variables as CSS variables as well is a much simpler setup.
Reviewed By: passy
Differential Revision: D23756558
fbshipit-source-id: e92be1f66b11c2c9c400fc1622cb8a493cc4c2a5
2020-09-17 04:05:09 -07:00
Michel Weststrate
ef4379e847
Implemented basic Flipper theme, [Flipper] Setup initial layout and siderail
...
Summary:
This setups the first bits of the Sandy Layout, and has a styled siderail according to the design, that does absolutely nothing.
{gif:0sa60r8c}
Reviewed By: cekkaewnumchai
Differential Revision: D23655313
fbshipit-source-id: e30278aeae0913e231ad105a9afb55c74c6a3370
2020-09-17 04:05:09 -07:00
Michel Weststrate
2d2a8bd675
Introduce dark theme
...
Summary: Adds support for switching dark mode on the fly. Also added the option to apply certain settings without restarting Flipper, as that isn't needed in all cases.
Reviewed By: cekkaewnumchai
Differential Revision: D23625854
fbshipit-source-id: 82175ba10524daf1b48a65feec8c610460df9418
2020-09-17 04:05:09 -07:00
Michel Weststrate
908a8bab1e
Setup Ant.design
...
Summary:
allow-large-files
This makes the Ant.design component library available to Flipper
The CSS setup is unconventional, in the sense that the normal way to do this is to use a webpack loader to dynamically load the right less files, and a babel transform to automatically import the style sheets.
Since we use Metro, which is not very suitable for transforming non-JS(like) files, I figured that the simplest thing is to pre-compile the entire less theme. Which should be fine since we shouldn't be changing the less files very often, and since we don't ship a website, it is probably not too bad to have the full ANT theme for now in there, even though we don't use all components. It is 600 K of css. In the next diff the CSS is loaded conditionally, only if Sandy is enabled.
If the CSS turns out to be too big we can optimise this later to only import CSS for components we use by doing some Metro magic, but it doesn't seem to be trivial (that is, I couldn't get in to work in < 2 hours).
Reviewed By: cekkaewnumchai
Differential Revision: D23625855
fbshipit-source-id: 3ba810b2221dc0c7b719f66310e590c7748cf239
2020-09-17 04:05:08 -07:00
