Summary: This is more reliable and follows redirect which we need for GitHub downloads.
Reviewed By: antonk52
Differential Revision: D50263976
fbshipit-source-id: d001b6eb460510b0b673ea66651e7c39cac3092f
Summary:
Copying files will randomly fail with something akin to
```
Error: Cannot copy '../acirb/bin/acorn' to a subdirectory of itself, '../acorn/bin/acorn'.
```
See https://github.com/jprichardson/node-fs-extra/issues/708
Reviewed By: antonk52
Differential Revision: D50263977
fbshipit-source-id: 39091ef57b79c692ec89e7a250595509839e2af8
Summary:
**Issue**
From passy:
when one of the app server ports is occupied, Flipper PWA is stuck at the loading screen
Reviewed By: passy
Differential Revision: D50261985
fbshipit-source-id: 8ce90cd6d515c26a824645f642dacbe92e7f4105
Summary:
As discussed with lblasa. This solves a few issues:
- Confusing names in `ps` and Activity Monitor related to Flipper.
- Permission requests for the Keychain from "node" lead users to deny it.
- Seeing "node" as allowed apps for an entry in Keychain is confusing.
Reviewed By: lblasa
Differential Revision: D50232337
fbshipit-source-id: 3bc92aae0ca31d1a80582fb8a794bbc64fc2f2e5
Summary:
Even though node docs state
> Assigning a value to process.title might not result in an accurate label within process manager applications such as macOS Activity Monitor or Windows Services Manager.
Locally this worked for me on M1 machine. Will test on intel as well.
Reviewed By: lblasa
Differential Revision: D50228844
fbshipit-source-id: 69937ded7da259e05335df50332ea114ff566f21
Summary:
Use an URLProvider paired with a token provider for attempts to establish a websocket connection.
This gives extra flexibility whenever a token is not available or changes as the ReconnectingWebSocket will call the URLProvider after each unsuccessful connection.
Reviewed By: antonk52
Differential Revision: D50220329
fbshipit-source-id: f53993a90c9c0f64bf213019b6b8af5fa818048d
Summary:
The logs written to the file shouldn't be JSON.
It just makes it hard to read and there's no tool to process this either.
Instead, write the logs as seeing in the console for easier reading.
Reviewed By: antonk52
Differential Revision: D50219806
fbshipit-source-id: a07fb53a10b36e1a3c2992a133b8c0c818bd816b
Summary:
This will automatically invoke the "Start" button if Flipper detect it is offline, to automate that step. It will do so only once
(safe for the reload logic that also triggers on server errors, not sure if that was intentionally?)
Reviewed By: lblasa
Differential Revision: D50074673
fbshipit-source-id: 2c11e80429a2c4ed0e43e62cb2f6057fad5eb410
Summary: This should help us to make flipper more reliable and avoid failing loading plugins if they are loaded from cache(old ones)
Reviewed By: lblasa
Differential Revision: D50081726
fbshipit-source-id: edef9999ad44660331153a082e15c6f3f5de9b05
Summary:
This change will allow us to display correct stack traces in flipper UI as well as send them to scuba.
Currently correct stack traces are only displayed in the console and we do not have access to them.
Reviewed By: ivanmisuno
Differential Revision: D50015827
fbshipit-source-id: 2a60315dd5c06b2635ce0414f612ff1fdca0e489
Summary:
There used to be a flag to control whether we wanted to replace an existing running instance.
No longer in use so safe to delete.
Reviewed By: antonk52
Differential Revision: D50077975
fbshipit-source-id: 8d7bad1f85e4520fd006cdcabe6e9899468688cc
Summary:
Get the authentication token before an open as either browser or PWA.
There could be cases whereas the PWA gets launched first before the token is exported to the manifest and thus it makes it not possible to connect on a first launch.
Reviewed By: antonk52
Differential Revision: D50004992
fbshipit-source-id: d58b7a75dcb9aaf7fadd3e3c3a773581441f9d92
Summary: Set a timeout period to become ready. It is better to kill the server if not ready, than keeping it alive.
Reviewed By: antonk52
Differential Revision: D50004605
fbshipit-source-id: be1d2c022c634ece059fc03eb6faea695431ba95
Summary: Change the button title when clicked.
Reviewed By: mweststrate
Differential Revision: D49954493
fbshipit-source-id: 3d689effc0cc5587ab8a07901b66139577b21837
Summary: Track whenever the server is unable to bind to the specified port.
Reviewed By: antonk52
Differential Revision: D49951304
fbshipit-source-id: 971d7c324f27c287036707d21bb51d26acbd6615
Summary:
Simplify how messages (state updates) are shown in Flipper UI.
This main change was introduced as a way to show the 'Start' server button whenever we were in a disconnected state. This is not as simple as the server may be restarting or the client may be even have reset the WS connection. Hence you the experience where this UI is shown and immediately dismissed.
This UI is only ever shown if at one point the server was alive, period. So, in this case, either the server becomes available again OR the user quits the PWA/tab/browser and launches again.
IMHO, this is a better experience that totally assuming the server is dead.
In a next iteration, we can be more clever and have a timeout such that if after a set period of time the server doesn't become online, then we show a button to start (or force kill) the server.
Reviewed By: aigoncharov
Differential Revision: D49915698
fbshipit-source-id: 03fcc150ed1f1303d1d727c82a71eb32616208e8
Summary:
^
Also, if an error happens, do not swallow it, rethrow.
Reviewed By: passy
Differential Revision: D49912780
fbshipit-source-id: 30451110d8c5776e2b0826d6e924ab5fe98cd7e2
Summary: Also remove the suppress error usage as is it was never used.
Reviewed By: aigoncharov
Differential Revision: D49910876
fbshipit-source-id: 7267eaddadb73ab2b6e2aab0045157271ceed427
Summary: When a user pastes anything, it is treated as an input for a search through the entire row
Reviewed By: lblasa
Differential Revision: D49948975
fbshipit-source-id: 2dd23d4ee0819623549d88eb077c7b2d2fdf604f
Summary:
When a user enters any arbitrary text, we will treat as an input for the search through the entire row.
Based on feedback from https://fb.workplace.com/groups/flippersupport/permalink/1703929480087703/
Reviewed By: lblasa
Differential Revision: D49911868
fbshipit-source-id: 4c569e4b01e468f0ca112ea4b00fe143b30bed2a
