Summary: Taking on the feedback from the demo yesterday, I've improved the required parameter's dialog by showing where specific errors occur in the form and adding live editing to the URI displayed.
Reviewed By: danielbuechele
Differential Revision: D16802921
fbshipit-source-id: 2e729549306a8efb79ca76d3da6f70632ccd9212
Summary:
Some uris parsed from the device contain required parameters. Here we parse the uri and check if there is a required parameter on navigation. If there is we alert the user to correct the error.
In the next diff, I will strip away non-required parameters if they are present but not filled in.
Reviewed By: danielbuechele
Differential Revision: D16710944
fbshipit-source-id: ea32cfe60e2bb5e4f395caebf585ba1b220dcefe
Summary:
Okay so the main changes here are integrating the providers into the auto complete sheet and getting the search bar to work with it also.
For instance, in the search bar, I want to update the value string to whatever the user has highlighted in the auto complete sheet, without executing a new query. So thus, I had to create a new state variable in the search bar component for this.
I've also moved the custom hook into its own file to keep the component short in size. It had to be mainly rewritten to support providers instead of only bookmarks. Same goes for the entire AutoCompleteSheet component.
The bookmarksProvider is stored in the persisted state as to not regenerate every-time on render. It is only updated if the bookmarks are updated which are also now stored in the persistedState for the same reason.
Lastly, a DefaultProvider object was also made for the initial persisted state object.
Reviewed By: danielbuechele
Differential Revision: D16581644
fbshipit-source-id: 88723a4081d96250f723a4cd7b1ade101bf3e8f3
