Summary: See https://github.com/facebook/flipper/issues/1680, the sections plugin was exposed publicly, even though we don't have a publicly available client plugin
Reviewed By: passy
Differential Revision: D24993552
fbshipit-source-id: 788ecc29ec64048b3077dea89e492ddbf1ea7d84
Summary:
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest) from 26.6.2 to 26.6.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/releases">babel-jest's releases</a>.</em></p>
<blockquote>
<h2>26.6.3</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-resolve-dependencies]</code> Continue dependency resolution if mock dependency can't be found (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/10779">#10779</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/blob/master/CHANGELOG.md">babel-jest's changelog</a>.</em></p>
<blockquote>
<h2>26.6.3</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-resolve-dependencies]</code> Continue dependency resolution if mock dependency can't be found (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/10779">#10779</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="2f6931e91d"><code>2f6931e</code></a> v26.6.3</li>
<li><a href="a7ae4f2c22"><code>a7ae4f2</code></a> chore: bump babel core types (<a href="https://github.com/facebook/jest/tree/HEAD/packages/babel-jest/issues/10772">#10772</a>)</li>
<li>See full diff in <a href="https://github.com/facebook/jest/commits/v26.6.3/packages/babel-jest">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1666
Reviewed By: passy
Differential Revision: D24993947
Pulled By: mweststrate
fbshipit-source-id: a8213bd08187c9bb1dd97429fe009f24b5fc572f
Summary:
Bumps [types/babel__core](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/babel__core) from 7.1.10 to 7.1.12.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/babel__core">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1686
Reviewed By: passy
Differential Revision: D24993992
Pulled By: mweststrate
fbshipit-source-id: f4fde9c6940c9e159ae06ce5d1fd8319e8e57e4e
Summary: This prefixes APIs of `flipper-plugin`, that are used by Flipper, but should not be used by plugins directly, with `_`. Also added tests to make sure we are always intentional when extending the exposed APIs
Reviewed By: passy
Differential Revision: D24991700
fbshipit-source-id: ed3700efa188fca7f5a14d5c68250598cf011e42
Summary: This updates the docs of Flipper to use Sandy, rather than `FlipperPlugin` class. Restructured the docs a bit as a result.
Reviewed By: passy
Differential Revision: D24991285
fbshipit-source-id: 66d5760c25cf9cf3983515433dfd64348d51db3d
Summary:
This diff updates plugin scaffolding by using Sandy and closely following the internal Scarf templates (see D24949452, D24949452)
By using `flipper-plugin`, it is now also possible to write unit tests for a plugin, and the default infra for that is generated (babel / jest)
For now there is still a dependency on `flipper` to support fancy components not yet available in Sandy, this will be updated in the future: T79632585
Changelog: `flipper-pkg init` now uses the new Sandy plugin infrastructure ant Ant.design component system
Reviewed By: nikoant
Differential Revision: D24950080
fbshipit-source-id: afc5e7ac728b20cb84fdbbdcb76cd45968736c01
Summary: Updated the scarf template to fix some urls, at `antd` by default, and avoid depending on `flipper-plugin`.
Reviewed By: cekkaewnumchai
Differential Revision: D24949452
fbshipit-source-id: 56b6628309d3cdf6c30acddf83dab6e493cd7c0e
Summary: This diff adds the `client.onUnhandledMessage` handler, to be able to handle messages for which we don't know the names upfront. Some existing plugins that only send one kind of message can benefit from this, as can generic plugins, like the createTablePlugin
Reviewed By: passy
Differential Revision: D24949453
fbshipit-source-id: 0fed81e28aee350632c09ee3bb834f306dc8b100
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1687
I cleaned up and tagged both of the custom actions.
It's much better to pin them down properly so that
future changes on `main` don't break anything.
Reviewed By: nikoant
Differential Revision: D24996462
fbshipit-source-id: 6d63e76b758439ba8df4ef2f5b77992789744e7b
Summary:
Bumps [flipper-client-sdk](https://github.com/facebook/flipper) from 0.0.2 to 0.0.3.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/facebook/flipper/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1668
Reviewed By: mweststrate
Differential Revision: D24981564
Pulled By: passy
fbshipit-source-id: 55431dd6f5ecf6bbb52324890a7efdb28b10350e
Summary:
GitHub only issues one push event for multiple commits.
This causes things to behave weirdly. My action now
looks for a commit with a certain message and runs
the subsequent steps on it. If there's more than one
matching commit, it uses the last one. Not great, not terrible.
Pull Request resolved: https://github.com/facebook/flipper/pull/1678
Test Plan: Ran it on my fork: https://github.com/passy/flipper-1/actions/runs/360332680
Reviewed By: nikoant
Differential Revision: D24955986
Pulled By: passy
fbshipit-source-id: 6dcbe11e69bf77c803e3907ced3185ca85483ec8
Summary:
Bumps [types/inquirer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/inquirer) from 6.5.0 to 7.3.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/inquirer">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1685
Reviewed By: passy
Differential Revision: D24993998
Pulled By: mweststrate
fbshipit-source-id: bca428a99b361950ae2af4c16e079e4f48461968
Summary:
Bumps [metro-react-native-babel-preset](https://github.com/facebook/metro) from 0.63.0 to 0.64.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro-react-native-babel-preset's releases</a>.</em></p>
<blockquote>
<h2>Release v0.64.0</h2>
<ul>
<li><strong>[Feature]</strong>: Add <code>mkdtemp</code> and <code>mkdtempSync</code> implementations to <code>metro-memory-fs</code> (1ed78495ec5b492d3ce6f1f375bc596b18d9dc52)</li>
<li><strong>[Feature]</strong>: Add <code>chmod</code>, <code>lchmod</code>, and <code>fchmod</code> implementations to <code>metro-memory-fs</code> (d99b55be2cb9567e31f5a09ff96e3fd10c54941b)</li>
<li><strong>[Feature]</strong>: Support function-name inference for flow typecast-expressions to source-maps (d48277f5b78f43365333652a459602b7990fca54)</li>
<li><strong>[Feature]</strong>: Support <code>SegmentID</code> field in Hermes mini-dump stack traces (d0634a858a860b4739ca821cec744b705edf9013)</li>
<li><strong>[Feature]</strong>: Support node modules algorithm for resolving configuration path (dea7e0549c286f8052df86f833de6221463687c7)</li>
<li><strong>[Feature]</strong>: Remove template literal and shorthand prop transformation from hermes-stable preset (1367b711d8807d0b300e23a06d11befe3e66d6f1)</li>
<li><strong>[Feature]</strong>: Add <code>nodeModulesPath</code> option to resolver (b2528d40c46085a32adbae370d0e47b6a24e3c8c)</li>
<li><strong>[Feature]</strong>: Remove computed properties, spread, and spread rest transform plugins from <code>Hermes-canary</code> preset (82818e778b75cdd1398f974513111a9a0ed43907)</li>
<li><strong>[Breaking]</strong>: Renames the Metro <code>transform.inlineRequires.blacklist</code> option to <code>blockList</code>. (b25fe89261732bd0befe965e4cf0bd38ff55b2b6)</li>
<li><strong>[Fix]</strong>: Prevent inlining of <code>__DEV__</code> in object property-keys (42942ca2ba81d03e50167ed028c8efb733bb0a3b)</li>
<li><strong>[Fix]</strong>: Include <code>/node_modules</code> in resolver search path (04a2a466eb353ea2953aac108654276c262fedfb)</li>
<li><strong>[Fix]</strong>: Correctly escape the path separator in blocklist regular expressions on Windows (881d9f6d97da92fbf510236fef697642ac9a3fe2)</li>
<li><strong>[Experimental]</strong>: Support absolute file paths when symbolicating stack traces (7be228453f5ff93191401c54614feb7c336fa86c)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e93fff1bab"><code>e93fff1</code></a> Bump metro version to 0.64.0</li>
<li><a href="881d9f6d97"><code>881d9f6</code></a> Fix regular expression compatibility issue with node v12 (<a href="https://github-redirect.dependabot.com/facebook/metro/issues/604">https://github.com/facebook/flipper/issues/604</a>)</li>
<li><a href="120f866dc1"><code>120f866</code></a> Deploy Flow v0.137.0</li>
<li><a href="31a416527a"><code>31a4165</code></a> Upgrade CI build to node 12</li>
<li><a href="97852c1330"><code>97852c1</code></a> update eslint-plugin-react to 7.21.5 version</li>
<li><a href="82818e778b"><code>82818e7</code></a> Move Computed Prop, Array Spread, Object Spread/Rest to Hermes Canary</li>
<li><a href="653789db1e"><code>653789d</code></a> Back out "Move Object.assign and ** to Hermes canary"</li>
<li><a href="3d564dd9fc"><code>3d564dd</code></a> Move Object.assign and ** to Hermes canary</li>
<li><a href="3c52ac7f05"><code>3c52ac7</code></a> add Hermes profile predicate helpers</li>
<li><a href="0f376bbd93"><code>0f376bb</code></a> Add <code>type</code> to <code>TransformResult</code></li>
<li>Additional commits viewable in <a href="https://github.com/facebook/metro/compare/v0.63.0...v0.64.0">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a href="https://www.npmjs.com/~cpojer">cpojer</a>, a new releaser for metro-react-native-babel-preset since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1665
Reviewed By: passy
Differential Revision: D24993963
Pulled By: mweststrate
fbshipit-source-id: 40b6f4771d171a5ca83f2e1377be5df1d1f31bc1
Summary: The plugin seems to miss the train to version 0.65. This diff gives it a ride to the current version
Reviewed By: nikoant
Differential Revision: D24950948
fbshipit-source-id: 3132a3baf0a41d8ec0de5cf8c55c0561126b038f
Summary:
Michel discovered that the ITSR GK has been dialled down completely since the last bug.
Coming to re-enable it I discovered a bug that has been introduced since then, so have fixed that, but we can't just ramp up the original GK because the current version of flipper will crash if ITSR is used.
So instead, I'm leaving the current GK ramped down, and replacing it with a new one, which is safe to ramp up.
This will mean ITSR is only enabled on versions from the next release onwards.
Reviewed By: nikoant
Differential Revision: D24922822
fbshipit-source-id: 8a6990fd5130bd046c24b0da757492b37e4040f2
Summary:
Before this change, launching a simulator would ony show the simulator if the simulator process itself was already running. This makes sure that opening a simulator also works from a closed state
Changelog: Automatically start an iOS simulator to launch a device when none is running yet
Reviewed By: nikoant
Differential Revision: D24919363
fbshipit-source-id: 45039330710cf81aa73222967d667964bb01f42a
Summary:
Ideally, we want to fetch app Icons from the device, but for now, we can at least for Facebook owned apps we can use a hardcoded set of icons, which probably even looks better.
For ` Lite` apps, the colors of the icon and background are reversed, which makes both variations recognizable.
Reviewed By: jknoxville
Differential Revision: D24920161
fbshipit-source-id: 5220093fb3a443ae535faa4c346a2029de9cbbd5
Summary:
Many UI components (such as Button) rely on the redux store being present in the context.
So to use these components freely in popovers, the popover provider has to be within the store provider, not outside of it.
This moves it, along with the context menu and tooltip providers for the same reason.
Has the effect of fixing the ITSR dialog, which had a button inside a popover.
Reviewed By: mweststrate
Differential Revision: D24922493
fbshipit-source-id: e15540ac49795875b1cf86d6c66ec0591dc374ef
Summary: For groups that have a papercuts entry, the support form will now link to them. This will hopefully increase the amount of feedback we get.
Reviewed By: nikoant
Differential Revision: D24921296
fbshipit-source-id: c6d07a10838a7abb1c70e8d61197a7b339f611bc
Summary:
Navigation plugin is a special cause that will remain connected and process messages directly even when disabled, this is to make sure the bookmarks feature keeps working even when the plugin is not enabled.
Changelog: [Sandy][Navigation] on Android, the currently active deeplink of the application will now be shown in the sidebar
Reviewed By: jknoxville
Differential Revision: D24890375
fbshipit-source-id: eb5e4141740e0436396cea5a7aae24337f2e903e
Summary:
This diff adds support for finding appPatterns (not sure how the feature is called) in the device, and auto completing on it.
Also improved the styling of bookmark sections.
This diff also adds support of showing a dialog in which params an be filled out if needed.
The behavior around optional arguments seems buggy, as in, no dialog will show up, but since I didn't want to change the logic around this unilaterally, left it as-is for now.
Updated the dialog to Ant so that the renderReactRoot utility could be used safely
Reviewed By: cekkaewnumchai
Differential Revision: D24889855
fbshipit-source-id: 6af264abec2e9e5b921ef7da6deb1d0021615e9e
Summary:
This diff adds support for the navigation plugin bookmarks to the appinspect tab.
Support for path discovery, and path params will be added in a next diff.
Features:
* click a bookmark and navigate to it
* sync bookmark state and uri with navigation plugin
* manually enter a path and navigate to it by using <ENTER>
Reviewed By: cekkaewnumchai
Differential Revision: D24620250
fbshipit-source-id: 14b393a5456b4afeef69444d2120c8f01686e602
Summary:
Converted the Navigation plugin to Sandy, and updated Locations bookmark accordingly.
This is a prerequisite step of supporting the bookmarkswidgetin the new AppInspect tab.
Updated LocationsButton accordingly, and overal simplified implementation a bit; locationsbutton now reuses the logic of the NavigationPlugin, rather than reimplemting it. This reduces code duplication and also makes sure the state between plugin and location button stays in sync.
Made sure that search providers are derived and cached rather than stored, again simplifying logic
That being said, the navigation plugin is buggy, but all these things failed before this diff as well:
* No events happening when using iOS, despite the plugin being enabled. But these seems to be a long time know issue, looks like it was never implemented
* Not sure if the parameterized bookmarks is working correctly
* screenshots not always happening at the right time (but fixed a race condition where the wrong bookmark might get updated)
* Locations button doesn't show up if the navigation plugin is supported but not enabled (will try to fix in next diff)
Would be great if bnelo12 could do some exploratory testing to verify what ought to be working, but currently isn't.
Reviewed By: cekkaewnumchai
Differential Revision: D24860757
fbshipit-source-id: e4b56072de8c42af2ada0f5bb022cb9f8c04bb47
Summary: expose `appName`, `appId` and `device` to Sandy plugins. Will be used in next diff to migrate navigation plugin
Reviewed By: cekkaewnumchai
Differential Revision: D24857253
fbshipit-source-id: 03ac3d376d5d1950bcf3d78386a65ce167b517e3
Summary:
devices not always being readily available is causes a lot of complication in the api,
figured to resolve devices first before construction clients,
since clients not attached to a device are shown uncategorized anyway, making them practically un-interactable.
For more background info, see following chat.
{F344388883}
This diff will make it possible to only expose a synchronous api in Sandy
n.b. didn't update Navigation plugin, as that is done in a next diff
Reviewed By: jknoxville
Differential Revision: D24858332
fbshipit-source-id: 8339f831fbbc9c219add56a199364fde67adafc7
Summary: It's easier to scan the same header value of multiple requests when it's in roughly the same place for each one.
Reviewed By: mweststrate
Differential Revision: D24885172
fbshipit-source-id: 7be02903d2f9f79c8ba618e57c74169392f6244b
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1673
XCode 12 starts building for apple hardware, but that fails on x86, so only build x86_64.
Reviewed By: nikoant
Differential Revision: D24857260
fbshipit-source-id: 30c0e021d4f809fd3a8ad72537a2627a43e589eb
Summary: Had the `PERSONAL_TOKEN` put in place by the OSS oncall. Still won't know if it has the right permissions until we run this. :/
Reviewed By: nikoant
Differential Revision: D24833829
fbshipit-source-id: 4fbf6e0b0abbc50d0b9a1e9b7ca8b02f6e1f5171
Summary: The sample iOS project can't be built by `buck` because the internal(?) reference codes aren't available anymore. This diff change the way to instantiate the components and add CK dependency (not sure if the correct one or not).
Reviewed By: passy
Differential Revision: D24782764
fbshipit-source-id: 809245771fc3b542fe63dfccdc8bbc6913aa63af
Summary: Scripts now accept full version instead of only patch part of it.
Reviewed By: jknoxville
Differential Revision: D24782300
fbshipit-source-id: 1c454beb9640a5b38669fe39eab642245b0f0f91
Summary: The script now receives new version via command line.
Reviewed By: jknoxville
Differential Revision: D24771302
fbshipit-source-id: 243ad2cc8cb62af86eadb44fbf4bd7c71e97af6f
Summary: Make sure that changelog is shown when using Sandy
Reviewed By: jknoxville
Differential Revision: D24832099
fbshipit-source-id: 6999dfcb55976104db476834446c13322f4b2402
Summary:
Inverted the condition of checking if Sandy is enabled, so by default it is enabled if user is part of the GK.
This will make it more frictionless for people joining the dogfooding group and increases the chances we receive feedback :)
Reviewed By: jknoxville
Differential Revision: D24830075
fbshipit-source-id: d20dacd9e6c2dd2387a94b8a972252f29d0dab0e
Summary: Moved docs outside of FBInternal docs. Will make Sandy APIs the default in the docs soon, and move the links to the proper location, but this at least makes sure we can already link to the correct place in WP announcements
Reviewed By: jknoxville
Differential Revision: D24829287
fbshipit-source-id: 913f2db65a7cdd04bd1be47aebc48ece7a6cef04
Summary:
* Removed Flow compilation step
* Removed all `flow` annotations
* Removed all FlowFixMe's
* Removed flow typings for Flipper
* Left flow transpilation (stripping) in babel, in case there is any external user using Flow in his plugin
* Left `eslint-plugin-flowtype` dependencies, as `eslint-config-fbjs` requires it
Reviewed By: passy
Differential Revision: D24755545
fbshipit-source-id: 9c0a7910657fd1cba88294e041bf2bfdf7b565bf
Summary: This removes the mocked bookmarks section (which is being reimplemented in D24620250), so that early adopter don't see a non-working piece of UI
Reviewed By: passy
Differential Revision: D24827181
fbshipit-source-id: 9759f069bdbcc1efe3f1ecb56954ee539bbca1f0
Summary: For RN Debugger an ugly hack is used that roars its head now again; to make sure that the embedded debugger state isn't lost when switching to a different plugin, the chrome devtools are rendered _outside_ the domNode where they should normally appeared, and made invisible rather than removed when becoming invisible. Since at this moment this is the only place where we apply the trick, figured for now to condone it, rather than making a neater abstraction out of it (or kiling it all together)
Reviewed By: passy
Differential Revision: D24786771
fbshipit-source-id: 726617899bc620fc8b9db677d9413b31d5ad7653
Summary:
Bumps [data-encoding](https://github.com/ia0/data-encoding) from 2.3.0 to 2.3.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="34d1f0e89a"><code>34d1f0e</code></a> Release 2.3.1</li>
<li><a href="47b548f82a"><code>47b548f</code></a> Fix deps.rs URLs</li>
<li><a href="3236d7fc82"><code>3236d7f</code></a> lib: Update changelog</li>
<li><a href="289dca9030"><code>289dca9</code></a> Update documentation</li>
<li><a href="76e21dd413"><code>76e21dd</code></a> Remove stable feature</li>
<li><a href="21eb6991b8"><code>21eb699</code></a> Add no-std test for macro</li>
<li><a href="a89028bcfc"><code>a89028b</code></a> force proc-macro to be no_std compatable</li>
<li><a href="848efe37c1"><code>848efe3</code></a> Add dependency badge to readme</li>
<li><a href="3699a0d665"><code>3699a0d</code></a> Update LICENSE date</li>
<li><a href="6476fb0bb1"><code>6476fb0</code></a> lib: Maybe fix <a href="https://github-redirect.dependabot.com/ia0/data-encoding/issues/33">https://github.com/facebook/flipper/issues/33</a></li>
<li>See full diff in <a href="https://github.com/ia0/data-encoding/compare/v2.3.0...v2.3.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1656
Test Plan: Ran `cargo check`.
Reviewed By: mweststrate
Differential Revision: D24826840
Pulled By: passy
fbshipit-source-id: 353416e0efb3e6bae16773cd535d6bd4f62825e3
