Commit Graph

7 Commits

Author SHA1 Message Date
Anton Nikolaev
30213e118f Update Metro to 0.60.0 (#1380)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1380

Updated Metro to 0.60.0

Reviewed By: mweststrate

Differential Revision: D22453798

fbshipit-source-id: 14c5bacf88bc31bd3dd06ad42edf271769a4a669
2020-07-14 01:08:01 -07:00
Anton Nikolaev
a2e77f5da0 Patch metro to avoid erasing "process" global var
Summary:
Patch for "metro" to avoid erasing of "process" global var during bundling.

Also removed "process" babel transform for main Electron process which was also made to workaround the same issue with "process" being erased.

Reviewed By: mweststrate

Differential Revision: D22389153

fbshipit-source-id: 569882e20534eedfca45509b8efe0186d335c681
2020-07-06 03:09:41 -07:00
Michel Weststrate
89de3d4ae2 Disable require cycle warnings
Summary: The holier-than-thou warnings of metro about require cycles are annoying. Require cycles are generally speaking well handles by ESM, and cause only harm if modules themselves are stateful, which is a bad smell. But warning for every cycle is just a flooding of false positives and removes the insentive to drop actual warnings.

Reviewed By: jknoxville

Differential Revision: D21859908

fbshipit-source-id: 66ec9a619a3737ccab5b16d11be5623d1d97c9f6
2020-06-03 08:45:16 -07:00
Anton Nikolaev
ec7cbd7f14 Fixed the patch disabling warnings for cyclic dependencies inside node_modules
Summary: Fixed the patch disabling warnings for cyclic dependencies inside node_modules. It broke after I changed the way of bundling plugins.

Reviewed By: passy

Differential Revision: D21065488

fbshipit-source-id: f8891f007d14d2475df517b28452dc0b8346f113
2020-04-16 09:52:27 -07:00
Anton Nikolaev
627cc8fe7f Update Metro
Summary: Updated Metro to the latest version 0.59.0

Reviewed By: passy

Differential Revision: D21027614

fbshipit-source-id: 0b2c1c422dfed7e8426bb9a36c5626f3a96eb8f6
2020-04-15 03:59:38 -07:00
Anton Nikolaev
527d417ab4 Suppress Metro warning about cyclic dependencies in node_modules
Summary: Metro shows cyclic dependencies warnings in dev mode even if they are caused by 3rd party packages installed into node_modules. This produces a lot of noise, but totally unactionable. In this diff I have implemented patch for "metro" package wich disables these unactionable warnings.

Reviewed By: passy

Differential Revision: D20835057

fbshipit-source-id: 2aebc59a0f8c0adfc768ed4c170e5d0b9ced7e0e
2020-04-03 04:09:47 -07:00
Anton Nikolaev
85c13bb1f3 Move desktop-related code to "desktop" subfolder (#872)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/872
Move all the JS code related to desktop app to "desktop" subfolder.

The structure of "desktop" folder:
- `src` - JS code of Flipper desktop app executing in Electron Renderer (Chrome) process. This folder also contains all the Flipper plugins in subfolder "src/plugins".
- `static` - JS code of Flipper desktop app bootstrapping executing in Electron Main (Node.js) process
- `pkg` - Flipper packaging lib and CLI tool
- `doctor` - Flipper diagnostics lib and CLI tool
- `scripts` - Build scripts for Flipper desktop app
- `headless` - Headless version of Flipper app
- `headless-tests` - Integration tests running agains Flipper headless version

Reviewed By: passy

Differential Revision: D20249304

fbshipit-source-id: 9a51c63b51b92b758a02fc8ebf7d3d116770efe9
2020-03-14 14:35:17 -07:00