Summary:
This adds some pretty nice unit test coverage analysis for our codebase. Especially useful for external pull requests as a gentle nudge to make sure they don't regress the topline number.
To learn more, check out https://github.com/coverallsapp/github-action
Pull Request resolved: https://github.com/facebook/flipper/pull/1392
Test Plan:
{F245038134}
{F245038132}
https://coveralls.io/builds/32250084
Reviewed By: jknoxville
Differential Revision: D22664361
Pulled By: passy
fbshipit-source-id: 4dc1fc79677da41a9d3ea198224c5678ae156ad4
Summary:
This diff updates the Github workflow to update pod versions after the release is published on Cocoapods.
## Changelog
- Update Github workflow to update the pod versions till the release is published in Cocoapods.
Pull Request resolved: https://github.com/facebook/flipper/pull/1338
Test Plan:
A PR got created with the updated pod versions after the release was pushed.
https://github.com/facebook/flipper/pull/1365
Reviewed By: passy
Differential Revision: D22456857
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 335996bc1ebb6da309d3f60a8f3401559e0a83c7
Summary:
Following some advice to add debugging steps from here: https://github.com/skx/github-action-publish-binaries/issues/19
Also adding an alternative upload action as the issue clearly stems from
something specific to the cURL version on the Action host. This uses
a completely different tool (ghr) for uploading.
Pull Request resolved: https://github.com/facebook/flipper/pull/1199
Test Plan: testinprod
Reviewed By: jknoxville
Differential Revision: D21723887
Pulled By: passy
fbshipit-source-id: cbbc9555283a89e3152c602b87d64976e8dbf4f9
Summary:
This PR adds GH action to create PR with the updated Podfile.lock when a new tag is released.
## Changelog
- Add GH action to automatically create PR with updated Podfile.lock.
Pull Request resolved: https://github.com/facebook/flipper/pull/1097
Test Plan: I was not able to test it on a release of tag. But I tested it by triggering the workflow on a push to the branch. It created a PR like [this](https://github.com/facebook/flipper/pull/1110).
Reviewed By: jknoxville
Differential Revision: D21381996
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 2dffa0f71f7e211541728acb06aea5763ae53f47
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1096
Disable cancelling all Node CI jobs if one of them failed. This will help to detect whether build is failing on all OSes (linux, mac, windows) or only some of them.
Reviewed By: mweststrate
Differential Revision: D21370606
fbshipit-source-id: 86cb3f1a2eb45e2832c5770414c0ca58e0869b66
Summary:
This PR adds a github action to publish pods on a new tag. It also tries to fix a race condition which happens when we try to publish FlipperKit pod. During the release of FlipperKit pod, we rely on the newly published Flipper Pod, and sometimes the release of Flipper Pod takes a time to get updated in the cocoapods trunk.
This is a known issue by the Cocoapods and they will be shipping a fix to this in Cocoapods 1.10. Till then we can keep retrying for 5 times.
Ref: https://github.com/CocoaPods/CocoaPods/issues/9502#issuecomment-579486258
## Changelog
- Adds Github actions to publish cocoapods.
- Removes the Circle CI config to publish on cocoapods
Pull Request resolved: https://github.com/facebook/flipper/pull/1083
Test Plan: I tested this action by running it on this PR and it worked fine.
Reviewed By: jknoxville
Differential Revision: D21348084
Pulled By: priteshrnandgaonkar
fbshipit-source-id: f33f3cdef43ae032ad42c94db72323212e40ec67
Summary:
Really no clue why this isn't working. Manually running the exact
same curl command works just fine. Adding an `ls` and removing paths
because why not.
Pull Request resolved: https://github.com/facebook/flipper/pull/1044
Test Plan: Next release, sadly.
Reviewed By: nikoant
Differential Revision: D21202248
Pulled By: passy
fbshipit-source-id: e6298e8f8f191f7864e5e48ef1a1ad18b71bf3ab
Summary:
This PR adds Github Action to validate the podspec file. Validation is crucial, if it podspecs don't validate then we won't be able publish pods to the trunk.
## Changelog
Add Github Action to validate FlipperKit and Flipper pod
Pull Request resolved: https://github.com/facebook/flipper/pull/1026
Test Plan: Github Action passes.
Reviewed By: mweststrate
Differential Revision: D21130523
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 0116120b9bbb073516798d4d7f08b347ed9755a3
Summary:
This PR adds Github actions to verify that the Sample Objective-C, Swift and Tutorial app build successfully.
## Changelog
Add Github Actions for building Sample Objective-C, Swift and Tutorial app.
Pull Request resolved: https://github.com/facebook/flipper/pull/1025
Test Plan: Github Action passes successfully.
Reviewed By: jknoxville
Differential Revision: D21098106
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 6edd5a3cba74b5ea843abba366c4ad9dc550cf4e
Summary:
Adds a GitHub action that applies a label to issues where the original
author has responded to.
Pull Request resolved: https://github.com/facebook/flipper/pull/1022
Test Plan: Try it out?
Reviewed By: jknoxville
Differential Revision: D21089462
Pulled By: passy
fbshipit-source-id: 6a728d1acf710d36835bfc5966648936ceb5586e
Summary:
This is in line with the most recent stable Android Studio Release.
Pull Request resolved: https://github.com/facebook/flipper/pull/958
Test Plan:
Used it myself.
Open Source CI required a higher NDK, so let's first check what CI says to that internally now.
Reviewed By: jknoxville
Differential Revision: D20794634
Pulled By: passy
fbshipit-source-id: c32f934634b036ad3c1cad9fc49541e585d64329
Summary:
The current upload process is broken because the publish step only works on Linux.
This first uploads the binary to artifact storage, then downloads it on Linux and runs the publish step.
Pull Request resolved: https://github.com/facebook/flipper/pull/984
Test Plan:
@public
https://github.com/facebook/flipper/pull/984/checks?check_run_id=563996817
Everything here works apart from the publish action which throws a 400, which is expected as there's no tag/release associated with the PR. We can only really test the entire thing on a new release.
Reviewed By: nikoant
Differential Revision: D20868825
Pulled By: passy
fbshipit-source-id: 97304328ec7eb1243280ca7a9f26e8049869d33b
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/983
This diff fixes broken test jobs on GitHub. Tests for all the packages are already being run by the "yarn test" in the root package, so I'm disabling running them separately.
Reviewed By: jknoxville
Differential Revision: D20868138
fbshipit-source-id: 04a86a8127481fecaee63af1f9fd9c7ad0f4269b
Summary:
Still had the old paths referenced.
Pull Request resolved: https://github.com/facebook/flipper/pull/929
Test Plan: Next release, I guess?
Reviewed By: nikoant
Differential Revision: D20669327
Pulled By: passy
fbshipit-source-id: e268259065df5a48336ec09b81776771e1124fd0
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/872
Move all the JS code related to desktop app to "desktop" subfolder.
The structure of "desktop" folder:
- `src` - JS code of Flipper desktop app executing in Electron Renderer (Chrome) process. This folder also contains all the Flipper plugins in subfolder "src/plugins".
- `static` - JS code of Flipper desktop app bootstrapping executing in Electron Main (Node.js) process
- `pkg` - Flipper packaging lib and CLI tool
- `doctor` - Flipper diagnostics lib and CLI tool
- `scripts` - Build scripts for Flipper desktop app
- `headless` - Headless version of Flipper app
- `headless-tests` - Integration tests running agains Flipper headless version
Reviewed By: passy
Differential Revision: D20249304
fbshipit-source-id: 9a51c63b51b92b758a02fc8ebf7d3d116770efe9
Summary:
`build --mac` no longer implies building the DMG so the upload step currently fails.
Pull Request resolved: https://github.com/facebook/flipper/pull/869
Reviewed By: mweststrate
Differential Revision: D20283002
Pulled By: passy
fbshipit-source-id: c255ae3a7e4e006e198b79ad8ce79cfd5e80b6a3
Summary:
We're no longer building this internally because it requires a Mac to build and we only use it in OSS.
Pull Request resolved: https://github.com/facebook/flipper/pull/852
Reviewed By: mweststrate
Differential Revision: D20250521
Pulled By: passy
fbshipit-source-id: c1691c62b2db3bc22cb0231040f593a35ec4f17e
Summary:
This workflow is currently building the android app and then trying to upload the mac app (which isn't built) which is failing.
I think it should be uploading the android app instead.
Pull Request resolved: https://github.com/facebook/flipper/pull/820
Reviewed By: passy
Differential Revision: D20035055
Pulled By: jknoxville
fbshipit-source-id: 08367d464a045b47cf1b8b5395fd2151793a23cf
Summary:
Getting really pissed off with Travis and this has significantly shorter queue times.
Mind that this probably won't work until the Folly PR is merged.
Pull Request resolved: https://github.com/facebook/flipper/pull/810
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D19951126
Pulled By: passy
fbshipit-source-id: ed51ad5ec6d4df3a59784dbd31e7c1667593d04f
Summary:
This reverts commit 5bd0cd3d63 and adds back the github actions which were temporarily disabled.
Pull Request resolved: https://github.com/facebook/flipper/pull/655
Reviewed By: passy
Differential Revision: D18656754
Pulled By: jknoxville
fbshipit-source-id: 9dc9a9aa4224f996677ddfbaf37387ae0b066c56
Summary:
sadface
Hopefully this can be reverted quickly but right now we don't have
Actions support in our org and the failures here are causing all
sorts of downstream errors.
Pull Request resolved: https://github.com/facebook/flipper/pull/639
Test Plan: This PR
Reviewed By: cekkaewnumchai
Differential Revision: D18506405
Pulled By: passy
fbshipit-source-id: 325209d91b5d985772195703a3429e49700d7666
Summary:
Now on every new release, a sample app will be built and added to the Github release artifacts.
Adds a Github action to automatically build and attach the android sample app for every flipper release.
This will allow potential users to try out flipper without having to go to the trouble of building their own app.
Pull Request resolved: https://github.com/facebook/flipper/pull/615
Test Plan:
Tested on my private repo:
https://github.com/jknoxville/flipper/releases/tag/v0.1.john
Reviewed By: passy
Differential Revision: D18224747
Pulled By: jknoxville
fbshipit-source-id: 25d2905bd7539faa91974b23a33678168aef29d8
Summary:
This should just work, but let's see what CI says.
Pull Request resolved: https://github.com/facebook/flipper/pull/583
Reviewed By: jknoxville
Differential Revision: D17906598
Pulled By: passy
fbshipit-source-id: 5de686c8c9b23b101999da938d6e8f9baff7bc86
