Commit Graph

106 Commits

Author SHA1 Message Date
Michel Weststrate
f3fd8646e3 Upgrade example app to 0.62.0-rc.3
Summary:
^

1. Remove entire `react-native/ReactNativeExampleFlipper` folder
2. Run `npx react-native init --version 0.62.0-rc.3 ReactNativeExampleFlipper`
4. restore the `package.json` and `TicTacToe` file and import
5. removed `.eslintrc`, `_BUCK` and `build_defz.bzl`, `.watchmenconfig`

Added comments below to highlight the non-generated changes

Reviewed By: passy

Differential Revision: D20221558

fbshipit-source-id: da1c895a2b0e7ce48092e64cdb5ffdb9e4a1a10b
2020-03-04 19:00:20 -08:00
Pritesh Nandgaonkar
bd388f73e4 CLANGFORMAT the remaining files of xplat/sonar
Summary:
As per title.
Ran `arc lint -a --take CLANGFORMAT --paths-cmd 'hg files ./'` from xplat/sonar

Reviewed By: zertosh

Differential Revision: D19943131

fbshipit-source-id: c1dc10b27389fd6f54f055803519dac6bf0e7997
2020-02-18 05:27:56 -08:00
Janic Duplessis
44f5e35675 Implement react-native-flipper on iOS (#795)
Summary:
Implement the react-native-flipper native module on iOS. Uses very similar abstractions as on Android.

## Changelog

[react-native-flipper] Support iOS
Pull Request resolved: https://github.com/facebook/flipper/pull/795

Test Plan:
Tested using the RN TicTacToe example app

{F228406333}

Reviewed By: mweststrate

Differential Revision: D19853017

Pulled By: priteshrnandgaonkar

fbshipit-source-id: d93d35ff984b9ba75f812c4c8e3c82e4d550f0c0
2020-02-14 21:17:11 -08:00
Pascal Hartig
604511715b Add missing copyright headers
Summary: Failing OSS requirements right now.

Reviewed By: nikoant

Differential Revision: D19557540

fbshipit-source-id: 18d0d68816e70492802f41472e15e1ed0cf35e31
2020-01-24 09:03:45 -08:00
Pascal Hartig
0812568be1 Remove BUCK files
Summary: We won't use them so this is just dead weight that's going to break at some point.

Reviewed By: jknoxville

Differential Revision: D19470548

fbshipit-source-id: 3def22e6f5db2923d5551d7b6a3472cb4364186c
2020-01-24 05:02:06 -08:00
Michel Weststrate
0fa0899299 Create React Native example project
Summary:
This diff creates a sample React Native project (based on the 0.62-rc.0 template).

This example is created like:
(Documenting this here as in the future this might be easier than upgrading the project itself)

1. Run `npx react-native init ReactNativeFlipperExample --version 0.62.0-rc.0`
2. Follow the installation steps to enable Flipper, that is, call `initializeFlipper(this, getReactNativeHost().getReactInstanceManager());` at the end of the `onCreate` method in `MainApplication.java`
3. Put `FlipperTicTacToe` in the root of the project, and call it from `App.js` as a component
4. install `react-native-flipper` as dependency
5. install `relative-deps` as dev dependency, and set it up as shown in `package.json`. This tool make sure that we build and test this project against the version of react-native-flipper in this repository, rather than against the one on NPM.
6. removed some stuff, like tests and linting, which is just in the way in this repo

This PR does not support iOS, as Flipper + RN iOS is still broken in 0.62.0-rc.0, and the current version of react-native-flipper doesn't support iOS yet either.

Documentation on how to set up Flipper in general is not part of this Diff

_N.B. since this is a **public** project, to be visible and runnable by our OSS community, the build setup is kept plain, vanilla, react-native, and **not** wired up to our normal / internal build processes. This is also the reason that lint suggestions beyond the license headers have been ignored. If any others should be applied, it is probably the official react native template that requires updating_

Reviewed By: passy

Differential Revision: D19449295

fbshipit-source-id: 2aeb6044f8dd01f09a95350c84fff2419d685a65
2020-01-23 04:47:52 -08:00