4893c0ffb7c33aa8c5f28fefbd0b0fce537fb6e5
1356 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
dependabot[bot]
|
686060c434 |
Bump inquirer from 7.3.3 to 8.0.0 in /desktop (#2211)
Summary: Bumps [inquirer](https://github.com/SBoudrias/Inquirer.js) from 7.3.3 to 8.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/SBoudrias/Inquirer.js/releases">inquirer's releases</a>.</em></p> <blockquote> <h2>inquirer@8.0.0</h2> <ul> <li>Drop support for Node 10 (through dependencies)</li> <li>Add <code>postfix</code> option to the editor prompt to allow easily turning on proper syntax highlighting</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
49a5842c7b |
Bump @types/node from 14.14.37 to 14.14.41 in /desktop (#2207)
Summary: Bumps [types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.37 to 14.14.41. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2207 Reviewed By: mweststrate Differential Revision: D27945782 Pulled By: passy fbshipit-source-id: a54055baefc11614cc0f546c53a0b7c418468b4e |
||
|
dependabot[bot]
|
32117f264b |
Bump rsocket-tcp-server from 0.0.19 to 0.0.25 in /desktop (#2210)
Summary: Bumps [rsocket-tcp-server](https://github.com/rsocket/rsocket-js) from 0.0.19 to 0.0.25. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
bea6794867 |
Bump @algolia/client-search from 4.8.6 to 4.9.0 in /desktop (#2206)
Summary: Bumps [algolia/client-search](https://github.com/algolia/algoliasearch-client-javascript) from 4.8.6 to 4.9.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/releases"><code>@algolia/client-search</code>'s releases</a>.</em></p> <blockquote> <h2>4.9.0</h2> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.6...4.9.0">v4.9.0</a></h2> <ul> <li>feat(dictionaries): adds methods and tests (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1253">https://github.com/facebook/flipper/issues/1253</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/aed6554">aed6554</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1253">https://github.com/facebook/flipper/issues/1253</a></li> <li>feat(types): support <code>type</code> and <code>facet</code> in search methods (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1263">https://github.com/facebook/flipper/issues/1263</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/54c1cb7">54c1cb7</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1263">https://github.com/facebook/flipper/issues/1263</a></li> <li>fix(findAnswers): omit removeWordsIfNoResults correctly (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/3aec216">3aec216</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/blob/master/CHANGELOG.md"><code>@algolia/client-search</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.8.6...4.9.0">v4.9.0</a></h2> <ul> <li>feat(dictionaries): adds methods and tests (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1253">https://github.com/facebook/flipper/issues/1253</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/aed6554">aed6554</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1253">https://github.com/facebook/flipper/issues/1253</a></li> <li>feat(types): support <code>type</code> and <code>facet</code> in search methods (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1263">https://github.com/facebook/flipper/issues/1263</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/54c1cb7">54c1cb7</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1263">https://github.com/facebook/flipper/issues/1263</a></li> <li>fix(findAnswers): omit removeWordsIfNoResults correctly (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/3aec216">3aec216</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
97ace78cac |
Bump @babel/preset-env from 7.13.12 to 7.13.15 in /desktop (#2184)
Summary: Bumps [babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.13.12 to 7.13.15. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/preset-env</code>'s releases</a>.</em></p> <blockquote> <h2>v7.13.15 (2021-04-08)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13099">#13099</a> fix: raise <code>SyntaxError</code> for unparenthesized assert and assign (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13049">#13049</a> fix: the LHS in for-of loop should not start with let (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13101">#13101</a> fix(ts): allow trailing comma after rest parameter in <code>TSDeclareFunction</code> (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> <li><code>babel-plugin-proposal-do-expressions</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/10101">#10101</a> yield for do expression (<a href="https://github.com/tanhauhau"><code>@tanhauhau</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13030">#13030</a> Refactor switch support in <code>NodePath#getCompletionRecords</code> (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li>Other <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13106">#13106</a> fix: do not filter report from functions within class elements (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13075">#13075</a> Compile classes when spread is unsupported (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13115">#13115</a> [preset-env - debug] Print targets that need each plugin (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>📝 Documentation</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13081">#13081</a> Update CoC contacts (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-plugin-transform-regenerator</code>, <code>babel-standalone</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13086">#13086</a> Align <code>regenerator-transform</code> import with native ESM (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-transform-fixture-test-runner</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13087">#13087</a> Do not load root <code>babel.config.js</code> in tests (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🏃♀️ Performance</h4> <ul> <li><code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13076">#13076</a> perf: lazy load preset-env plugins (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h4>Committers: 5</h4> <ul> <li>Bogdan Savluk (<a href="https://github.com/zxbodya"><code>@zxbodya</code></a>)</li> <li>Federico Ciardi (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li>Tan Li Hau (<a href="https://github.com/tanhauhau"><code>@tanhauhau</code></a>)</li> </ul> <h2>v7.13.14 (2021-03-29)</h2> <p>Thanks <a href="https://github.com/charlessuh"><code>@charlessuh</code></a> for your first PR to Babel!</p> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13068">#13068</a> fix(core): make sure "clone-deep-browser" code path is used on browsers (<a href="https://github.com/charlessuh"><code>@charlessuh</code></a>)</li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/preset-env</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.13.15 (2021-04-08)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13099">#13099</a> fix: raise <code>SyntaxError</code> for unparenthesized assert and assign (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13049">#13049</a> fix: the LHS in for-of loop should not start with let (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13101">#13101</a> fix(ts): allow trailing comma after rest parameter in <code>TSDeclareFunction</code> (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> <li><code>babel-plugin-proposal-do-expressions</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/10101">#10101</a> yield for do expression (<a href="https://github.com/tanhauhau"><code>@tanhauhau</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13030">#13030</a> Refactor switch support in <code>NodePath#getCompletionRecords</code> (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li>Other <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13106">#13106</a> fix: do not filter report from functions within class elements (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13075">#13075</a> Compile classes when spread is unsupported (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13115">#13115</a> [preset-env - debug] Print targets that need each plugin (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>📝 Documentation</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13081">#13081</a> Update CoC contacts (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-plugin-transform-regenerator</code>, <code>babel-standalone</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13086">#13086</a> Align <code>regenerator-transform</code> import with native ESM (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-transform-fixture-test-runner</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13087">#13087</a> Do not load root <code>babel.config.js</code> in tests (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🏃♀️ Performance</h4> <ul> <li><code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13076">#13076</a> perf: lazy load preset-env plugins (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h2>v7.13.14 (2021-03-29)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13068">#13068</a> fix(core): make sure "clone-deep-browser" code path is used on browsers (<a href="https://github.com/charlessuh"><code>@charlessuh</code></a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li>Other <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13066">#13066</a> add SHOW_CONFIG_FOR to template (<a href="https://github.com/hzoo"><code>@hzoo</code></a>)</li> </ul> </li> <li><code>babel-cli</code>, <code>babel-core</code>, <code>babel-helper-transform-fixture-test-runner</code>, <code>babel-register</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13057">#13057</a> Remove lodash deps (<a href="https://github.com/hzoo"><code>@hzoo</code></a>)</li> </ul> </li> </ul> <h4>🏃♀️ Performance</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13063">#13063</a> Only resolve <code>package.json</code> when relative configs are enabled (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.13.13 (2021-03-26)</h2> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Anton Nikolaev
|
e1f6f770cd |
Collect information about connected device and app as a part of plugin usage analytics
Summary: We received questions several times from plugin authors on how to find usage for particular app/platform and I wanted to add that data on plugin usage dashboard, but right now it's impossible. We're only collecting plugin ID as a part of plugin usage analytics. That means it's impossible to filter some plugin usage (e.g. "Network") by particular platform or mobile app. This diff improves plugin usage analytics to collect enhanced data. Reviewed By: passy Differential Revision: D27935801 fbshipit-source-id: c2fc7d8cf84f9a28823ae56a1dda7158e0b12f1f |
||
Pascal Hartig
|
c007d74af9 |
Handle RSocket disconnects gracefully
Summary:
Tiny change, hours of debugging. Big thanks to jknoxville for
answering all my stupid questions.
Our number one "error" right now by users affected is
```
Unhandled Promise Rejection:
Error: RSocketTcpClient:
Socket closed unexpectedly.
```
Of course no stacktrace, because JavaScript and Promises.
The underlying problem is that RSocket keeps track of recently used
"receivers" which is every method that has sent a request. When someone disconnects their device or closes an emulator/simulator, the socket's `end` event is treated the same way any other connection error would be:
|
||
|
Pascal Hartig
|
9e7a455910 |
Mute port forwarding errors
Summary: Mentioned in the comment, these aren't actionable errors. Reviewed By: jknoxville Differential Revision: D27910465 fbshipit-source-id: 6f5e9d9d25edbb02648f3118c074e9f1986e3a86 |
||
|
Pascal Hartig
|
3431206c0e |
Add linter for naked console.errors
Summary: `console.error(err)` are hard to identify in the codebase especially as we often don't have reliable stack trace information. I've already cleaned up a bunch of them manually by going after the most high-firing ones; this should make it easier to identify the remaining ones. Reviewed By: jknoxville Differential Revision: D27913964 fbshipit-source-id: 0ff6624a0c083829846550b40954945d655b7cf6 |
||
Flipper Bot
|
bde0791818 |
Flipper Release: v0.86.0
Summary: Releasing version 0.86.0 Reviewed By: priteshrnandgaonkar Differential Revision: D27905837 fbshipit-source-id: 349b63a1f06d85b075d07b610179fd613da6bf52 |
||
Aaron Coplan
|
5a89776a05 |
Implement Diff selection flow in UIQR Flipper Plugin
Summary: Allow the user to manually select a diff from a list of diffs they have authored to send a screen to. This is particularly useful for NT users. Reviewed By: nscoding Differential Revision: D27804191 fbshipit-source-id: 805923399f2ced8d9c3b3ca0c80d5cdfd63af4f8 |
||
|
Pascal Hartig
|
f1b8aeffd7 |
Disable mangling and compression
Summary: This is not doing much in terms of size. We're talking 780 bytes after PACK compression but we're losing a lot of information in our errors (before have symbolication). We may reenable this at some point but I think it might be safe to leave it to this. Reviewed By: nikoant Differential Revision: D27887636 fbshipit-source-id: 15affeac588db667914320cbd098f7041b8b9c09 |
||
Harold Martin
|
4d262c0da4 |
Add protobuf support to network inspector (#2080)
Summary: Protobuf based APIs are becoming more common (i.e. gRPC) but are difficult to inspect. Unlike plain text data formats (JSON), Protobuf calls transmit binary data requiring the format to be known ahead of time, making ad-hoc inspection impossible. This PR allows for those format definitions (messages in protobuf terminology) to be transmitted from the client to the network inspector plugin. These definitions are then imported into ProtobufJS which enables the binary data transmitted to be inspected as easily as JSON data. See Retrofit PR in https://github.com/facebook/flipper/pull/2084 ## Changelog * Add ProtobufJS library to network plugin * New `ProtobufFormatter` UI in `RequestDetails` * `ProtobufDefinitionsRepository` to cache and load protobuf defintions * `addProtobufDefinitions` call in the Android network plugin Pull Request resolved: https://github.com/facebook/flipper/pull/2080 Test Plan:  Reviewed By: mweststrate Differential Revision: D27507451 Pulled By: passy fbshipit-source-id: 586d891b74f2b17d28fe7a2a99074da755851f38 |
||
Tim Yung
|
451c332260 |
Back out "Update React DevTools deps from 4.6 -> 4.12"
Summary:
Reverts D27764688 (
|
||
|
dependabot[bot]
|
bfc9ba0e68 |
Bump open from 8.0.4 to 8.0.5 in /desktop (#2189)
Summary: Bumps [open](https://github.com/sindresorhus/open) from 8.0.4 to 8.0.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sindresorhus/open/releases">open's releases</a>.</em></p> <blockquote> <h2>v8.0.5</h2> <ul> <li>Fix <code>chrome</code> app on macOS (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/240">https://github.com/facebook/flipper/issues/240</a>) 87f3d7a</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v8.0.4...v8.0.5">https://github.com/sindresorhus/open/compare/v8.0.4...v8.0.5</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
587e288bbf |
Bump cli-ux from 5.4.6 to 5.5.1 in /desktop (#2190)
Summary: Bumps [cli-ux](https://github.com/oclif/cli-ux) from 5.4.6 to 5.5.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/oclif/cli-ux/releases">cli-ux's releases</a>.</em></p> <blockquote> <h2>v5.5.1</h2> <h2><a href="https://github.com/oclif/cli-ux/compare/v5.5.0...v5.5.1">5.5.1</a> (2020-11-12)</h2> <h3>Bug Fixes</h3> <ul> <li>Downgrade fs-extra to support Node.js 8 (<a href="https://github-redirect.dependabot.com/oclif/cli-ux/issues/275">https://github.com/facebook/flipper/issues/275</a>) (<a href=" |
||
Michel Weststrate
|
18491dac11 |
Fixed issue where split container with null elems woudn't use remaining size
Summary: This fixes an issue where `Layout.Top/Right/Left/Bottom` would not render its secondary child in the remaining size, if the primary child is empty (`null`). This is caused by React not rendering anything for null children, and as a result the CSS rules for the primary child would then match the second child. In the example below making the component tree invisible if there are no bundles in the NT/Bloks plugin. Fixed by rendering a zero sized element instead. Reviewed By: jknoxville Differential Revision: D27793382 fbshipit-source-id: 1e76b51986c30a6a0d98e9356fcad4dd8d5d5f91 |
||
|
Michel Weststrate
|
0fe879c838 |
Improve multiple element selector UI
Summary: Layer selection is pretty easy to miss, as reported in for example: https://fb.workplace.com/groups/flippersupport/permalink/1098169193997071/ Moved the layer selection to the top of the view and gave it some highlighting + dynamic height. The section is no longer collapsible. Changelog: [Layout] Make the layer selection more prominent Reviewed By: priteshrnandgaonkar Differential Revision: D27708650 fbshipit-source-id: c86a55c3a20794aee86e64b6766b2ca4dd6b563f |
||
|
Michel Weststrate
|
5db2ef1275 |
Perf fixes
Summary: This diff fixes some more perf bottlenecks in the layout inspector (see the diffs earlier in the stack for the total picture). Mostly: 1. Pass down stable refs from the root for callbacks and configuration 2. Remove the deep-equality check in the sidebar section rendering, which has a pretty significant constant overhead, especially if the selection didn't change 3. If the selection changes, the correct semantics is to reset the sidebar rather than trying to reconcile the elements. (A consequence of this is that Panel collapse state isn't preserved atm after changing selection, will address that in a later diff) This reduces average render time for sidebar from ~20 to ~2 ms. Reviewed By: priteshrnandgaonkar Differential Revision: D27677353 fbshipit-source-id: ba183b7e3d778c0b3c8e7ca0d51535ce99a097ca |
||
|
Michel Weststrate
|
4f75247213 |
Make Sidebar Extensions more idiomatic
Summary: Sidebar extensions were unkeyed, which make them render inefficiently. I cleaned the api a bit here by making the extensions more idiomatic; they are now components rather then functions, so that they have their own render cycle, state, etc. They are memo-ed now as well, so that they don't have to re-render if the selected item doesn't change. Reviewed By: nikoant Differential Revision: D27685980 fbshipit-source-id: b133bc42061b3b8cf971792f5818810ecb80e3ea |
||
|
Michel Weststrate
|
7d9495027b |
Fix layout inspector re-rendering all elements on all changes
Summary: Changelog: [Layout] Addressed several performance issues in the layout plugin This diff and a few of the next stuff fix some performance issues in the Layout plugin. This diff fixes an issue where computing the context menu will cause all rows to render at all times, make the responiveness of the plugin quite slugish. The fix in this case is to build up the context menu lazily, and pass a stable ref to the function through the tree, rather than a new menu every time the root component renders. The changes in this diff and the next ones in total reduces the time (in prod builds) to draw a frame from ~200ms to ~5ms. Reviewed By: cekkaewnumchai Differential Revision: D27685983 fbshipit-source-id: a48b2ce2cdd1db31bb13122924617cbc3b6c198a |
||
|
Michel Weststrate
|
e29222fba7 |
Update and patch loading React DevTools
Summary: When trying to run some React component performance profiles, the updates registered made absolutely no sense (components rerendering without any parent or other cause causing them to render etc). That turned out to be caused by having an outdated version of the React devTools in Flipper. Sadly the newer version of the React DevTools didn't work with our current Electron version anymore. Some horrible hacking is needed to work around that. To help with updating the tools in the future (they are by default cached forever on the local machine), I've introduced the `FLIPPER_UPDATE_DEV_TOOLS` variable. The plugin loading work around is inspired by https://github.com/electron/electron/issues/23662#issuecomment-787420799 Reviewed By: passy Differential Revision: D27685981 fbshipit-source-id: c35e49aff9b2457b63122eeee0d5c042ddd3b08b |
||
|
Michel Weststrate
|
69de9bc92d |
Initial move to flipper-plugin
Summary: This diff moves the core of ElementsInspector to flipper-plugin and decouples it from legacy design system and Electron, without any significant improvements or API changes yet, which will follow later. Colors and docs will be added later in this stack. Reviewed By: passy Differential Revision: D27660300 fbshipit-source-id: 96abfa3b3174fa852cf04ae119c23c3d629fee74 |
||
|
dependabot[bot]
|
ca7b331e3b |
Bump @typescript-eslint/experimental-utils from 4.20.0 to 4.21.0 in /desktop (#2187)
Summary: Bumps [typescript-eslint/experimental-utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils) from 4.20.0 to 4.21.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/experimental-utils</code>'s releases</a>.</em></p> <blockquote> <h2>v4.21.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.20.0...v4.21.0">4.21.0</a> (2021-04-05)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [no-type-alias] consider <code>keyof</code> as an alias (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3242">#3242</a>) (<a href=" |
||
|
dependabot[bot]
|
582a31fb41 |
Bump @testing-library/dom from 7.30.1 to 7.30.3 in /desktop (#2188)
Summary: Bumps [testing-library/dom](https://github.com/testing-library/dom-testing-library) from 7.30.1 to 7.30.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/testing-library/dom-testing-library/releases"><code>@testing-library/dom</code>'s releases</a>.</em></p> <blockquote> <h2>v7.30.3</h2> <h2><a href="https://github.com/testing-library/dom-testing-library/compare/v7.30.2...v7.30.3">7.30.3</a> (2021-03-31)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>types:</strong> missing ignore parameter for SelectorMatcherOptions (<a href=" |
||
|
dependabot[bot]
|
ef986ccb9a |
Bump @types/ws from 7.4.0 to 7.4.1 in /desktop (#2185)
Summary: Bumps [types/ws](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ws) from 7.4.0 to 7.4.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ws">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2185 Reviewed By: passy Differential Revision: D27763543 Pulled By: nikoant fbshipit-source-id: 88afd08d594b3219396c571a7144689e93a99cb5 |
||
Brian Vaughn
|
7bd4f80c25 |
Update React DevTools deps from 4.6 -> 4.12
Summary: Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Sonar, etc. # Changelog: [General][Changed] - Upgraded react-devtools-core dependency to 4.12.0 Reviewed By: gaearon Differential Revision: D27764688 fbshipit-source-id: faa179cf4be3b49b14244d47ee0b91ae63138b8b |
||
|
Flipper Bot
|
a792c146d6 |
Flipper Release: v0.85.0
Summary: Releasing version 0.85.0 Reviewed By: jknoxville Differential Revision: D27766005 fbshipit-source-id: 25bdd6d0ad831e087e51529adc5e6c2b4fa43d57 |
||
|
dependabot[bot]
|
c2ab19360f |
Bump eslint from 7.23.0 to 7.24.0 in /desktop (#2183)
Summary: Bumps [eslint](https://github.com/eslint/eslint) from 7.23.0 to 7.24.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p> <blockquote> <h2>v7.24.0</h2> <ul> <li><a href=" |
||
|
dependabot[bot]
|
3ba9cf4233 |
Bump react-refresh from 0.9.0 to 0.10.0 in /desktop (#2186)
Summary: Bumps [react-refresh](https://github.com/facebook/react/tree/HEAD/packages/react) from 0.9.0 to 0.10.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/react/releases">react-refresh's releases</a>.</em></p> <blockquote> <h2>v0.10.0</h2> <h3>React Core</h3> <h4>New Features</h4> <ul> <li>Added warnings to help migrate towards descriptors</li> <li>Made it possible to server render without React-related markup (<code>data-reactid</code>, <code>data-react-checksum</code>). This DOM will not be mountable by React. <a href="http://facebook.github.io/react/docs/top-level-api.html#react.rendercomponenttostaticmarkup">Read the docs for <code>React.renderComponentToStaticMarkup</code></a></li> <li>Added support for more attributes: <ul> <li><code>srcSet</code> for <code><img></code> to specify images at different pixel ratios</li> <li><code>textAnchor</code> for SVG</li> </ul> </li> </ul> <h4>Bug Fixes</h4> <ul> <li>Ensure all void elements don’t insert a closing tag into the markup.</li> <li>Ensure <code>className={false}</code> behaves consistently</li> <li>Ensure <code>this.refs</code> is defined, even if no refs are specified.</li> </ul> <h3>Addons</h3> <ul> <li><code>update</code> function to deal with immutable data. <a href="http://facebook.github.io/react/docs/update.html">Read the docs</a></li> </ul> <h3>react-tools</h3> <ul> <li>Added an option argument to <code>transform</code> function. The only option supported is <code>harmony</code>, which behaves the same as <code>jsx --harmony</code> on the command line. This uses the ES6 transforms from <a href="https://github.com/facebook/jstransform">jstransform</a>.</li> </ul> <h2>v0.10.0-rc1</h2> <p>No release notes provided.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/facebook/react/blob/master/CHANGELOG.md">react-refresh's changelog</a>.</em></p> <blockquote> <h2>0.10.0 (March 21, 2014)</h2> <h3>React Core</h3> <h4>New Features</h4> <ul> <li>Added warnings to help migrate towards descriptors</li> <li>Made it possible to server render without React-related markup (<code>data-reactid</code>, <code>data-react-checksum</code>). This DOM will not be mountable by React. <a href="https://reactjs.org/docs/top-level-api.html#react.rendercomponenttostaticmarkup">Read the docs for <code>React.renderComponentToStaticMarkup</code></a></li> <li>Added support for more attributes: <ul> <li><code>srcSet</code> for <code><img></code> to specify images at different pixel ratios</li> <li><code>textAnchor</code> for SVG</li> </ul> </li> </ul> <h4>Bug Fixes</h4> <ul> <li>Ensure all void elements don’t insert a closing tag into the markup.</li> <li>Ensure <code>className={false}</code> behaves consistently</li> <li>Ensure <code>this.refs</code> is defined, even if no refs are specified.</li> </ul> <h3>Addons</h3> <ul> <li><code>update</code> function to deal with immutable data. <a href="https://reactjs.org/docs/update.html">Read the docs</a></li> </ul> <h3>react-tools</h3> <ul> <li>Added an option argument to <code>transform</code> function. The only option supported is <code>harmony</code>, which behaves the same as <code>jsx --harmony</code> on the command line. This uses the ES6 transforms from <a href="https://github.com/facebook/jstransform">jstransform</a>.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/facebook/react/commits/v0.10.0/packages/react">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2186 Reviewed By: passy Differential Revision: D27760972 Pulled By: nikoant fbshipit-source-id: a998232901ee6c02686069d119ef7818be4d7404 |
||
|
dependabot[bot]
|
296ee9c69c |
Bump tslib from 2.1.0 to 2.2.0 in /desktop (#2191)
Summary: Bumps [tslib](https://github.com/Microsoft/tslib) from 2.1.0 to 2.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/tslib/releases">tslib's releases</a>.</em></p> <blockquote> <h2>tslib 2.2.0</h2> <p>This release supports TypeScript 4.3's new functionality for ECMAScript private methods and accessors, and private static class members.</p> <p>It does so by expanding the scope of <code>__classPrivateFieldGet</code> and <code>__classPrivateFieldSet</code>. See <a href="https://github-redirect.dependabot.com/microsoft/tslib/pull/146">microsoft/tslib#146</a> for more details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Anton Nikolaev
|
576afd36a1 |
Downgrade electron to 11.2.3
Summary: Downgrade electron to 11.2.3 to work-around performance problems described in https://github.com/facebook/flipper/issues/2173. Changelog: Electron downgraded to v11.2.3 to work-around performance issues on MacOS Big Sur Reviewed By: passy Differential Revision: D27732746 fbshipit-source-id: cec187f47ac5b734c33f3e6eecc5cf0b03d76c1a |
||
|
Anton Nikolaev
|
dc7226b7dc |
Script for plugin type-checking (#2172)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/2172 New script which runs "tsc" for all plugins, receives list of errors and then checks which plugins are affected. It works for shared libs too, e.g. if there is an error in a shared library, then all plugins dependant on it will be counted as affected. For convenience, script saves list of errors affecting each plugin to "tsc-errors.log" in plugin folder. This script will be used for automatic type-checking plugins against current "stable" and "insiders" versions of Flipper. An alternative to this implementation would be to simply run "tsc" for each plugin individually, but such implementation takes a lot of time (5+ sec per plugin) and so cannot be effectively used on diffs. Reviewed By: mweststrate Differential Revision: D27499765 fbshipit-source-id: fcbbfc94a13e6c7c5beff0c889a929f84c41b2dd |
||
|
Anton Nikolaev
|
e7c5a5cc93 |
Check that all dependencies provided by Flipper core are specified as peers in plugins
Summary: This is a guard to ensure all Flipper built-in packages are declared as peer dependencies. It also removes all of them from nested node_modules after installation to be 100% sure they always loaded from the root folder, because e.g. react can be still installed as a transitive dependency even it is not declared as dependency directly. Reviewed By: passy Differential Revision: D27040267 fbshipit-source-id: 1e315a6b280b36ab20778ee261aa386b51d9f964 |
||
|
Anton Nikolaev
|
4d3e631ce6 |
Transform fb-internal code within plugins
Summary: This diff changes flipper-pkg to allow using fb-internal code in plugins when they are packaged as standalone packages. It basically transforms fb-stubs/fb folders in plugins in the same way as for Flipper app. Reviewed By: passy Differential Revision: D27173406 fbshipit-source-id: 8ba97d5f57b5e276c19d13270a0d810873504add |
||
|
Anton Nikolaev
|
b45b5f854a |
Move layout plugin sidebar extensions to the plugin package
Summary: Moved layout plugin sidebar extensions to the plugin package. Reviewed By: passy Differential Revision: D27036489 fbshipit-source-id: 5b3406e5c50ba61709d925a3c0cb07a6fd7552db |
||
|
Anton Nikolaev
|
e5261967cb |
Link shared libs to allow re-using them in both in public and fb-internal plugins
Summary: Link plugin shared libraries to the "plugins/node_modules" dir so they can be used as peer dependencies by both public and fb-internal plugins. ``` plugins - node_modules -- fb_shared_lib (symlink pointing to "plugins/fb/fb_shared_lib") -- public_shared_lib (symlink pointing to "plugins/public/public_shared_lib") - fb -- fb_shared_lib -- fb_plugin (can now use both fb_shared_lib and public_shared_lib as peer dependencies) - public -- public_shared_lib -- public_plugin (can now use both public_shared_lib and fb_shared_lib (optionally if it's an fb-internal repo) as peer dependencies) ``` Reviewed By: passy Differential Revision: D27034936 fbshipit-source-id: 68ee5312060ff57649ae061dd7dd14f8beb6d4a1 |
||
|
Anton Nikolaev
|
4997cb9847 |
Show file path and position when babel transformation failed
Summary: Currently when babel transformation is failed, only stack is shown. It's better to log the whole error object because it also contains path and line number of the code failing to transpile. Reviewed By: passy Differential Revision: D27034942 fbshipit-source-id: 76e03871c924489e2698a26622e6bc6fdd305560 |
||
|
Anton Nikolaev
|
b3274a8450 |
Plugin folders re-structuring
Summary: Here I'm changing plugin repository structure to allow re-using of shared packages between both public and fb-internal plugins, and to ensure that public plugins has their own yarn.lock as this will be required to implement reproducible jobs checking plugin compatibility with released flipper versions. Please note that there are a lot of moved files in this diff, make sure to click "Expand all" to see all that actually changed (there are not much of them actually). New proposed structure for plugin packages: ``` - root - node_modules - modules included into Flipper: flipper, flipper-plugin, react, antd, emotion -- plugins --- node_modules - modules used by both public and fb-internal plugins (shared libs will be linked here, see D27034936) --- public ---- node_modules - modules used by public plugins ---- pluginA ----- node_modules - modules used by plugin A exclusively ---- pluginB ----- node_modules - modules used by plugin B exclusively --- fb ---- node_modules - modules used by fb-internal plugins ---- pluginC ----- node_modules - modules used by plugin C exclusively ---- pluginD ----- node_modules - modules used by plugin D exclusively ``` I've moved all public plugins under dir "plugins/public" and excluded them from root yarn workspaces. Instead, they will have their own yarn workspaces config and yarn.lock and they will use flipper modules as peer dependencies. Reviewed By: mweststrate Differential Revision: D27034108 fbshipit-source-id: c2310e3c5bfe7526033f51b46c0ae40199fd7586 |
||
|
Michel Weststrate
|
32bf4c32c2 |
Remove Console feature
Reviewed By: fabiomassimo Differential Revision: D27622952 fbshipit-source-id: 45ce5188a55f50b8ca28f28f354d9402902a5df8 |
||
|
Flipper Bot
|
ac70d35671 |
Flipper Release: v0.84.0
Summary: Releasing version 0.84.0 Reviewed By: nikoant Differential Revision: D27617439 fbshipit-source-id: 8e4ca47eeddca8a8b46d051a7f70133dab04c3ac |
||
|
Anton Nikolaev
|
04c5fb61f4 |
Rollback removing paths from tsconfig.json
Summary: Returning back paths config in tsconfig.json which I removed recently. Without them typescript compilation is required when exported APIs changed in dependency packages, e.g. in "flipper-plugin", otherwise lint/tests fails. So it's better to keep them for convenience. Reviewed By: mweststrate Differential Revision: D27619748 fbshipit-source-id: bb5929526ee2bf6bd06a5f15dbf898b7ca6deea7 |
||
|
Michel Weststrate
|
49c4e2f56d |
Remove Interaction tracker
Reviewed By: passy Differential Revision: D27619537 fbshipit-source-id: 970a1661e2b4cafe5fb6a79082d04aa1f9644439 |
||
|
Michel Weststrate
|
53c557f923 |
Move DataInspector to flipper-plugin
Summary: This diff moves the rest of the DataInspector jungle to flipper-plugin. No actual improvements are made yet, but the code is decoupled from Electron and the legacy theming. For example by using Antd based context menus. Note that `ManagedDataInspector` is now rebranded `DataInspector`, as that is the only variation that should (and is) used publicly. For the interactionTracker removal, see next diff. SearchableDataInspector will be addressed in a next diff Reviewed By: passy Differential Revision: D27603125 fbshipit-source-id: 188bd000260e4e4704202ce02c7fc98319f0bc22 |
||
|
Michel Weststrate
|
9030a98c6e |
Move DataDescription utility to flipper-plugin
Summary: Another utility component used by DataInspector. Colors have been hardcoded for now, to decouple from the classic Flipper color palette. Will organize this better later in this stack, and when addressing / adding support for dark mode. Buttons, checkboxes, selects have been replaced by Antd's counterpart. Unlike ManagedDataTable, the DataInspector is primarily moved rather than copied & adapted, as the underlying abstraction / API won't change significantly. So the changes here will immediately affect all plugins in Flipper using this component. Reviewed By: passy Differential Revision: D27603126 fbshipit-source-id: bacd48c9af2b591033e7f2352627f11acb4df589 |
||
|
Michel Weststrate
|
b6674bf96b |
Move highlighter to flipper-plugin
Summary: This stack moves the DataInspector component to flipper-plugin. The first diffs will move some utility abstractions to turn this into smaller steps Reviewed By: passy Differential Revision: D27591890 fbshipit-source-id: d0285ca31b6c9b334000dd15c722b9bda7638d73 |
||
|
Michel Weststrate
|
cd27e4c010 |
Folder rename datatable -> data-table
Summary: just a rename, as we will have `data-inspector` folder as well in next diffs. Reviewed By: passy Differential Revision: D27591891 fbshipit-source-id: b1fe92cbf4be1633e623e59b694efc3f687c3413 |
||
|
Michel Weststrate
|
07c4470ab9 |
Stricter types for DataDescription
Summary: Made datatypes used by DataInspector more strictly typed (in the hope to be able to drop some, but all are still in use, although the distinction between different elements isn't always clear). Reviewed By: passy Differential Revision: D27266825 fbshipit-source-id: 6a1c74b0ae3daff6299ca598b18a205d17c42e22 |
||
|
Anton Nikolaev
|
eabf0fc340 |
Fix native window objects leak after refreshes
Summary: It looks like electron creates new native window object after each window refresh, but we hold previous objects because of listeners attached to them. In dev mode, Electron signalises about that in console log each time when window is focused / blured after refresh: ``` Attempting to call a function in a renderer window that has been closed or released. Function provided here: init-fast-refresh.bundle?platform=web&dev=true&minify=false:800356:19 ``` Reviewed By: passy Differential Revision: D27619305 fbshipit-source-id: 51d1590903a37dba721fb7a711fdebb9f0034b98 |
||
Mykyta Sikriier
|
c9b6f6c7d9 |
ANDROID_SDK_ROOT support (#2106)
Summary: According to Google, ANDROID_HOME is deprecated. This means, that having only ANDROID_SDK_ROOT as environment variable leading to Android SDK is enough. Flipper supports only ANDROID_HOME, so I would like to add ANDROID_SDK_ROOT support. However, there is a set of rules of ANDROID_HOME and ANDROID_SDK_ROOT priority. Everything is mentioned on a this page: https://developer.android.com/studio/command-line/variables ## Changelog Added ANDROID_SDK_ROOT environment variable support Pull Request resolved: https://github.com/facebook/flipper/pull/2106 Test Plan: Probably I would need a help with this Reviewed By: mweststrate Differential Revision: D27505024 Pulled By: passy fbshipit-source-id: 8bdc66a9652c673fd44944d87af1efc9e93d0f1b |
