Summary: UDS will be removed. The first step would be to remove the TCP optionality.
Reviewed By: passy
Differential Revision: D48264741
fbshipit-source-id: ca9e1b68be61e99240e95bcd4f26f2db63a64005
Summary: Instead of delaying the shutdown by a set timer, immediately shutdown.
Reviewed By: antonk52
Differential Revision: D48264571
fbshipit-source-id: 5e6556f2ecafb7cf9a19b3075e72f2be1abf9f95
Summary:
If listing devices is successful, then don't record the event
as this is triggered every X amount of seconds.
Reviewed By: antonk52
Differential Revision: D47995681
fbshipit-source-id: 2d0fa68fd7b9c4ce74bad9e8cc0296691d9b8880
Summary: The `DataDescriptionType` accepts the `BigInt` type but it doesn't render. Added the `case` for that and reuse the `NumberValue` tag for it.
Reviewed By: aigoncharov
Differential Revision: D48152012
fbshipit-source-id: 32ebc8a37df34d57b40c7ecdad331c547415b335
Summary: Also removing topLevelSelection as it is no longer used in flipper
Reviewed By: aigoncharov
Differential Revision: D48069386
fbshipit-source-id: 6e4cdd6aab67d2cd30ac1884118703520125bf84
Summary: This is a continuation of flipper redesign. Next diff will mov notification and connectivity into modals as well
Reviewed By: LukeDefeo
Differential Revision: D48066573
fbshipit-source-id: 3b4a22462221d8da13b07ad1738e05de849e00c4
Summary: Feedback from support group said it wasnt clear when recording was on
Reviewed By: antonk52
Differential Revision: D48027414
fbshipit-source-id: db61a9806da285610e8f550ceff5af4d7b7acb47
Summary: Add an option to kill the debugging bridge directly within Flipper.
Reviewed By: antonk52
Differential Revision: D47990786
fbshipit-source-id: 30cd8ca1d55e8b2ade03700d884e5d849a2dadbf
Summary: Commands can be idb or adb. If no ClientQuery is provided, set the OS accordingly.
Reviewed By: antonk52
Differential Revision: D47990745
fbshipit-source-id: 3e38b6ecb0a8ea21e584c1d6eff6feb53dd2cfab
Summary:
The previous recommendation doesn't always holds true. There are reported cases in which a process is listening to the specified port yet is not being listed by the lsof command as advised.
The command below seems to work better.
sudo lsof -i :52342
Reviewed By: antonk52
Differential Revision: D47989269
fbshipit-source-id: ea216de00ef6edc90de58e9d3fe3a0579a171fea
Summary: OS will become useful later on, add it.
Reviewed By: antonk52
Differential Revision: D47989161
fbshipit-source-id: 3615544051b163b77f87e5c52e6ac9cae8c478d4
Summary: This mode is useless for leaves
Reviewed By: aigoncharov
Differential Revision: D47949539
fbshipit-source-id: 7f3ae6652ad696e9f550fe5b8f2298a1a3eff329
Summary: I noticed a slow down when using key board controls as this would change the selection. this adds the optimization back when wireframe mode == All
Reviewed By: antonk52
Differential Revision: D47949836
fbshipit-source-id: a08e5608c159d23b8a0afed419724c02231718d6
Summary:
Made rows smaller so you get to see more content
Monospace font
Reviewed By: antonk52
Differential Revision: D47949839
fbshipit-source-id: f8935e233838ff35acf8c1ab14bcf9b8f2153ab4
Summary: This is quite annoying and causes may un needed reboots of flipper server while developing
Reviewed By: antonk52
Differential Revision: D47949842
fbshipit-source-id: c2f18e16a4933e4209e74f51978cb7d05b80ee11
Summary: On certain apps there are a lot of views that have zero size and this isnt clear from the tree view. This will help
Reviewed By: lblasa
Differential Revision: D47917167
fbshipit-source-id: 180ef1cf34c3735acfd54d3498db9d29f759d959
Summary:
Rather than automatically collapsing siblings when using the visualiser instead we take a different approach:
1. The tree starts out fully collapsed
2. Every time you click on the visualiser we expand it and its ancestory chain to expanded nodes.
This is exactly how the Dom inspector works. The previous approach of constantly collapsing all siblings when uinsg the visualiser felt too intrusive and taking control from the user. The option is still there but only in the context menu
Some ultilities around autocollapsing nodes were removed as they dont make sense anymore that we now send complete frames
Changelog: UIDebugger Tree starts collapsed and expands as you click from the visualiser
Reviewed By: aigoncharov
Differential Revision: D47949843
fbshipit-source-id: 4381d22b12874dde5a89267572bee95f084380e3
Summary:
Added 3 context menu items:
- expand recursive
- collapse recursive
These are self explanatory.
I also collapse non ancestors. This collapses everything except your direct ancestor path to the root. Quite useful to refocus the tree on a node
Changelog: UIDebugger - added context menu items for exanding and collapsing the tree.
Reviewed By: aigoncharov
Differential Revision: D47949840
fbshipit-source-id: 6eebba182fe2092fbf5f0db0ec5ff728c3900424
Summary: The idea of the hit test is to return the deepest children that hit an element and not their parents. Due to this bug we were actually returning every other node all the way up to the root resulting in way to many hit nodes for target mode
Reviewed By: lblasa
Differential Revision: D47949837
fbshipit-source-id: d3391b4a700ab0be4c3b21dde5f13452f90c887b
Summary:
This allows you to control how the wire frames are drawn, useful when there are lots of overalpping wireframes
Changelog: UIDebugger - Added wireframe mode control, useful when lots of overlapping wireframes
Reviewed By: aigoncharov
Differential Revision: D47949841
fbshipit-source-id: 72de7d085ca433557107ab0cc6e4399220836d9f
Summary: STDOUT and STDERR can overflow the panel. This change creates a container for these two panels which should keep content within their boundaries.
Reviewed By: antonk52
Differential Revision: D47952711
fbshipit-source-id: 394390ae6b6a12329fe0eea1fc9948a7261b11bf
Summary: Sidebar should only show if the entry requires one. In this case, only shell commands have details to be displayed in the sidebar.
Reviewed By: antonk52
Differential Revision: D47952535
fbshipit-source-id: ae657032504dbb80900a534d2d357c9316b67cd9
Summary:
The code used the hovered node and selected node somewhere inconsistently for keyboard controls, this led to subitle bugs where if you moused over the next keybaord jump point would be the hovered node sometimes. This straightens it all out
Changelog: [UIDebugger] Fixed bug with keyboard tree controls
Reviewed By: aigoncharov
Differential Revision: D47832249
fbshipit-source-id: 7697c97a817ed5b70250c0c4f12fc1c59bdb96b9
Summary: Previously we would run the effect even if search term hadnt changed causing us to scorll to a search term rather than the selected node when selecting in the visualiser
Reviewed By: antonk52
Differential Revision: D47831188
fbshipit-source-id: 5700d49aea219a1229bcc8df462e55d8508c6c1a
Summary:
^
A dashboard to display the logs from a user session will be built next.
Reviewed By: antonk52
Differential Revision: D47944634
fbshipit-source-id: fb9e53981de5abb401c93c47cdec68f72c944b94
Summary: This is the most basic visualiser for command details.
Reviewed By: antonk52
Differential Revision: D47917006
fbshipit-source-id: 7654a3c6e416346548b45dbc72ca4a1838bea787
Summary: It's troubleshooting in general, not only connectivity. So rename and refactor accordingly.
Reviewed By: antonk52
Differential Revision: D47914411
fbshipit-source-id: 658563bfd33427f11fe9f7660b0985fc3f013866
Summary:
Styles are applied depending on entry type. This was an issue when we had 'cmd' as a type too.
So, let's simplify and keep type to denote info, warning, or errors.
Later on we can add a different tag if we want to differentiate between logs, command, others.
Reviewed By: passy
Differential Revision: D47912857
fbshipit-source-id: 213a0768a95f63cbd692ba96f6745ab740346a58
Summary: Migrate to new server event which allows troubleshoot
Reviewed By: passy
Differential Revision: D47875977
fbshipit-source-id: 2549bef6ebb26660176747d44e3f535ad9f1d213
Summary: Reuse the function that was refactored on previous diff.
Reviewed By: antonk52
Differential Revision: D47873752
fbshipit-source-id: 71e12cd34d1826080487297e308450cb2a2a5c26
Summary:
Extract notification creation from inside the existing function.
This will be reused to display connection notifications from the server event.
Reviewed By: antonk52
Differential Revision: D47873728
fbshipit-source-id: c01dc93dfef28135ecf7e77e92d4d517af082125
Summary:
There's a generic notification server event.
This change introduces a new notification server event dedicated for connection troubleshoot.
The difference is, this notification will have a button to troubleshoot the issue. Additionally, in the future, we may even be able to add a payload so that we can troubleshoot the exact problem.
Reviewed By: antonk52
Differential Revision: D47873697
fbshipit-source-id: 28843a08836d0054909f6b9ab7a88b14b8a1b868
