Summary:
If installation fails, we should exit with an error code and not just a
message. This should help narrow down the CI failures, too.
Pull Request resolved: https://github.com/facebook/flipper/pull/292
Reviewed By: danielbuechele
Differential Revision: D10255759
Pulled By: passy
fbshipit-source-id: a6b033deadf11069e6c5665870a811ae2d0ec5ef
Summary: Also acts as a model for using the computeNotifications api.
Reviewed By: passy
Differential Revision: D10240659
fbshipit-source-id: 610512de7484e10c9c0ed8e661913c2fe10869da
Summary:
Method `computeNotifications` added to the base plugin class.
Plugins should implement this to define a mapping from their state+props to the notifications they are emitting.
I've plugged this into componentDidUpdate, because we don't yet have the background plugin infra. When we do, we'll want some other incoming data hook to use so it's not tied to the react component rendering.
Example usage added to network plugin in the next commit.
Reviewed By: passy
Differential Revision: D10127875
fbshipit-source-id: efd4d8cfc0d3d33852a6cf9a290549a5f90d389d
Summary:
Yesterday I made a change that switches from hardcoded IP address 10.0.2.2, to localhost for emulators on Android 5+.
This didn't work with flipper because it relies on port forwarding, and port forwarding was only done for physical devices, not emulators.
This corrects that, by port forwarding whenever possible. This will enable using localhost, which simplifies remote adb connection support.
Reviewed By: danielbuechele
Differential Revision: D10255554
fbshipit-source-id: 77a05eddf530e0e9495568f2a0901f390464345a
Summary: Now that we have a node test in place, let's run this.
Reviewed By: danielbuechele
Differential Revision: D10217534
fbshipit-source-id: cf3debaf15b80d75234b67e4a78f6343c0fce50a
Summary:
It's not super useful, to be honest, but it's to have one
open source `.node.js` test in place so `yarn test` doesn't
error out.
Reviewed By: danielbuechele
Differential Revision: D10217530
fbshipit-source-id: c0e17e48782174b856ef6d5fe94c5c042564e4f5
Summary:
Original commit changeset: e53aa6ad10ac
This original change relies on adb reverse being run on emulators, which isn't happening. I didn't pick it up during tests because a previous build of flipper had done it.
Reverting the change. Will fix adb reverse and then re apply it later.
Reviewed By: priteshrnandgaonkar
Differential Revision: D10241728
fbshipit-source-id: 521c18c5a0eb45f3af0fe510defd9116b9bb0626
Summary: On emulators and devices that support adb reverse, using localhost will always work, whereas "10.0.2.2" won't work for networked adb connections.
Reviewed By: passy
Differential Revision: D10231163
fbshipit-source-id: e53aa6ad10ac4964431694c48e7148add69487fb
Summary: Pretty sure this was meant to get removed before open sourcing, it isn't referenced anywhere.
Reviewed By: danielbuechele
Differential Revision: D10202081
fbshipit-source-id: 23d213b3a041acad85eb723d32b65f7da276003d
Summary:
The buck install command fails when xcode_dmg is used in sandcastle hosts, meaning xcode is mounted somewhere other than /Applications.
Skip the connection test for now. I'll get oneworld working with it instead.
Reviewed By: passy
Differential Revision: D10231097
fbshipit-source-id: 16e320070f8b3fd4f56ff919bdd3ec47355e342c
Summary:
Use CircleCI 2.1 for common executors and remove the common build step
as this is already done by Travis. Instead, focus on publishing either
snapshots or releases.
Pull Request resolved: https://github.com/facebook/flipper/pull/289
Reviewed By: jknoxville
Differential Revision: D10216413
Pulled By: passy
fbshipit-source-id: cfbc52c43187339ae6cb1c486d81e7c40216e86b
Summary: This should not affect prod as flipper (also called sonar) should only be an internal debug product but i needed to fix it to start the app.
Reviewed By: jknoxville
Differential Revision: D10156590
fbshipit-source-id: 84a76e5cbe2f4bbe89627895efcfb7e6cdadae13
Summary: Inline sourcemaps were broken in Metro until 0.47.1, so now we can debug flipper plugins again!
Reviewed By: passy
Differential Revision: D10200221
fbshipit-source-id: 919c1bc4f7aee720f25f2375ffbd8a786ebd0017
Summary:
Snapshots should only ever be published off of master.
Pull Request resolved: https://github.com/facebook/flipper/pull/288
Reviewed By: danielbuechele
Differential Revision: D10161974
Pulled By: passy
fbshipit-source-id: dca8463ff80de9d407758405c24e6511bef534d1
Summary:
This isn't working on Travis yet and will skip the subsequent steps
which do provide value if run right now.
Pull Request resolved: https://github.com/facebook/flipper/pull/287
Reviewed By: jknoxville
Differential Revision: D10161725
Pulled By: passy
fbshipit-source-id: 3502230e842c9451e8f33309b500a720cdaa5514
Summary: Was passing in a Proxy instance before instead of a string. Now it passes the correct string that callers would expect.
Reviewed By: sjkirby
Differential Revision: D10181911
fbshipit-source-id: 8dfa677479a81de0f7b5be23f827ce7b52169931
Summary:
We're in a pretty good state now. Let's get rid of the big warning.
Pull Request resolved: https://github.com/facebook/flipper/pull/285
Reviewed By: jknoxville
Differential Revision: D10161261
Pulled By: passy
fbshipit-source-id: ef1fc03c289a0472916c67bf34c2f9e394c3fef2
Summary: Something here must have conflicted upon landing. Redoing this again.
Reviewed By: danielbuechele
Differential Revision: D10145804
fbshipit-source-id: 1176167c7e3880055ff5e7b3d7f5723416f6131f
Summary:
There were still some tests with the internal test runner which
would fail in open source and with Gradle.
Reviewed By: priteshrnandgaonkar
Differential Revision: D10145759
fbshipit-source-id: 99915548441e426b88b1fa6ace1e852775e2a770
Summary:
Before running the test suite, build wilde and run it on a local emulator.
This takes about 15 mins on a lego-mac with a warm cache.
It's probably worth splitting out the normal unit tests into a separate job, so we get quicker feedback on them. I'll do that in a separate diff.
Lets run this for a while, and see how it goes, I'm wondering if it might get flaky because it will be building the master version of wilde, so potentially could be broken a lot, though it's passed evry time I've tried it so far.
If it's reliable, we can run the same thing with loads of other apps in parallel.
Reviewed By: passy
Differential Revision: D10110408
fbshipit-source-id: 61c549eb1b9d04729dcb5ed01271a484af4777f5
Summary: Take care of the test class names.
Reviewed By: danielbuechele
Differential Revision: D10113028
fbshipit-source-id: c8f0967fe2ae8c0f416e0f2f1eab30785fad01e8
Summary:
Adding support for JS testing. Currently there are two environments tests can run in: node and electron. To select which environment to run a test in, name your test file accordingly `*.node.js` or `*.electron.js` and put it in a `__tests__` folder.
- `yarn test` to run node based tests
- `yarn test-electron` to run electron tests
A basic snapshot test of the empty app is added to make sure the app is rendering as expected. A test for the server is added to make sure when Flipper is started the two servers (secure and insecure) are started and ready to accept connections.
Reviewed By: passy
Differential Revision: D10050212
fbshipit-source-id: 8ef7f931339b43251d9d423886bcaca99ae691e4
Summary:
The manifest is invalid without a package name and causes CI
to fail in some weird ways.
Reviewed By: jknoxville
Differential Revision: D10123737
fbshipit-source-id: d4adc84e6c1a4297fc1b30720f131fd06c22c4d3
Summary: This confused Android Studio real bad.
Reviewed By: danielbuechele
Differential Revision: D10103210
fbshipit-source-id: 20b28575942998fa0c646090e46a2f55983a26a6
Summary: update docs to match new styling API and rename from Sonar to Flipper.
Reviewed By: passy
Differential Revision: D10107270
fbshipit-source-id: 75d7a06c88795aa1d3dce8f135f3a9c21d5d038d
Summary: Will reenable the Circle CI job for automatic snapshot publishing.
Reviewed By: danielbuechele
Differential Revision: D10107227
fbshipit-source-id: 5c76287e71fa2328b4b2d33be14792d2fdb1d209
Summary: This is from before we adopted the gradle standard layout.
Reviewed By: danielbuechele
Differential Revision: D10101917
fbshipit-source-id: f45ab06cbf4d56a70df1cac6cb1fd234148d2634
Summary:
Adds a test runner for jest test and adds three simple test cases:
- render the app
- start a server
- client connecting to the app
Test can be run using `yarn test`.
To make the test runner work, some changes needed to be made:
- remove the export of `init()` from `'flipper'`, because it was a cyclic dependency
- updating Button.js to the new ref-API
Reviewed By: jknoxville
Differential Revision: D10027078
fbshipit-source-id: 49107b0dd4dec666b92ecd841422fe7e6b3a7756
Summary:
Apparently, `--quiet` is *too* quiet on "dumb" terminals,
staying quiet for longer than 10 minutes on Circle CI, causing
the jobs to fail.
Pull Request resolved: https://github.com/facebook/flipper/pull/282
Reviewed By: jknoxville
Differential Revision: D10083183
Pulled By: passy
fbshipit-source-id: 6d006ab8aa2954d72d545bcef5d9e2d863a9f6a3
Summary: Currently sample app instacrashes due to native lib renamed to flipperfb.
Reviewed By: passy
Differential Revision: D10051573
fbshipit-source-id: a739a6f354c2ef2b5576c1e82728a5db2714ace2
Summary: Previous diffs fixed all compilation issues, this one makes them actually pass again.
Reviewed By: danielbuechele
Differential Revision: D10050632
fbshipit-source-id: 7e9f30c51d192b9f7e43abec8a19b2f1eef997df
Summary: Check that it never hangs or crashes during startup
Reviewed By: priteshrnandgaonkar
Differential Revision: D10034630
fbshipit-source-id: b69ce9e6f91a5499a084c4d7328e6934ec92ece4
Summary: New 0.8.0 release which includes name changes from sonar to flipper.
Reviewed By: passy, danielbuechele
Differential Revision: D10050160
fbshipit-source-id: 5394ea0d032cea39f40cc9ed8e0f054e506d4f04
