Summary:
Sonar isn't yet opening this activity remotely, but it's worth getting users to add it early, so that when it does, it will work.
Pull Request resolved: https://github.com/facebook/flipper/pull/250
Reviewed By: passy
Differential Revision: D9455599
Pulled By: jknoxville
fbshipit-source-id: 252f7e7f89751b188665ece4ab9f815fd90fe500
Summary:
I think the getting-started page should be a no-nonsense quick set of steps to get you up and running so you can try out flipper.
With it referencing the non existent "MySonarPlugin", you can't just follow the steps for it to work. You'd have to either write a plugin which would take a while, or look at the sample apps on your own to see how to add a real plugin. I think it will be far more helpful just to give a working example.
Pull Request resolved: https://github.com/facebook/flipper/pull/240
Reviewed By: passy
Differential Revision: D9378196
Pulled By: jknoxville
fbshipit-source-id: 18ae4a39d09c7baa17adb7f7a71fd766e9bc8e51
Summary:
The title gets taken from the header, so is duplicated.
Pull Request resolved: https://github.com/facebook/flipper/pull/220
Reviewed By: passy
Differential Revision: D9244730
Pulled By: jknoxville
fbshipit-source-id: d4701cb4af6f551a35cfa02c9ff43aef495f1da0
Summary:
This comment was left there from the default cocoapods-generated Podfile, so it can now be removed.
Pull Request resolved: https://github.com/facebook/flipper/pull/207
Differential Revision: D9242957
Pulled By: passy
fbshipit-source-id: f3e6d0ebd61962410367bb0a0aa6209b31c4ef01
Summary:
When referring to the project, we usually capitalize Flipper, but don't
do this super consistently. This fixes a few cases and some other
grammar issues.
Pull Request resolved: https://github.com/facebook/flipper/pull/214
Reviewed By: jknoxville
Differential Revision: D9219587
Pulled By: passy
fbshipit-source-id: 4c2a30730b8719ea4c058ad3c6cc262cbbdf6266
Summary: Releases a new iOS version 0.6.16. After landing this I will release 0.6.16 tag on github
Reviewed By: danielbuechele
Differential Revision: D9194965
fbshipit-source-id: 13d5e346d6d34a7bf7b6dfb568ca622d97660132
Summary: We're now on JCenter with the new package name.
Reviewed By: danielbuechele
Differential Revision: D9195254
fbshipit-source-id: 948f1abe557746de349cd4138fa98658e43184d0
Summary: rename all visible references of Sonar to Flipper. Changes endpoint URLs to the new repo address.
Reviewed By: passy
Differential Revision: D9082100
fbshipit-source-id: 2ab8b680a19c23d80050e8e768379c29d66acfca
Summary:
Solves #203
- [x] Sample Objc and Swift apps now have default configs(i.e non-recursive header search paths)
- [x] Fix for the cocoapods default config by adding FBMacros.h file in `Core` subspec
- [x] Updated the Spec(0.6.15) so that 0.6.15 works for default configs
- [x] Updated the doc
Pull Request resolved: https://github.com/facebook/flipper/pull/205
Reviewed By: passy
Differential Revision: D9148358
Pulled By: priteshrnandgaonkar
fbshipit-source-id: e6d32d9cde7b100573bd9a9996f0ec850b269d28
Summary: Adds a new plugin to support [LeakCanary](https://github.com/square/leakcanary), displaying memory leaks as they are detected. Each leak shows a hierarchical path from the GC root to the leaked object, and allows inspection of these objects' fields.
Reviewed By: jknoxville
Differential Revision: D8865149
fbshipit-source-id: 99bcf216578b9d6660ead7d48b9bafe0d20a6c08
Summary: Replaces sonar with flipper in the docs of a website
Reviewed By: passy
Differential Revision: D9046564
fbshipit-source-id: 55d03d787489406571ea0b4ac0adbc0daaa95cd4
Summary:
This PR adds support for using SonarKit clients in Swift apps. Fixes#13, fixes#87
1. Swift can't import Obj-C modules which have C++ headers. For this reason, we use SonarKit as an Obj-C++ wrapper around Sonar, which is written in C++. Due to search path misconfiguration, trying to import SonarKit into a Swift project would import `xplat/Sonar/SonarPlugin.h` instead of `iOS/SonarKit/SonarPlugin.h`, which caused `file not found` errors for C++ stdlib imports like #28 because new projects don't have their search paths set up correctly.
2. The network and layout plugins have C++ definitions (struct methods, classes) in some of their headers. This causes the compiler to get confused for Swift projects, because it only supports importing Objective-C files in umbrella headers, meaning that the `SonarKit` won't build.
1. I updated the `HEADER_SEARCH_PATHS` of SonarKit.podspec's build configuration to include `${PODS_ROOT}/Headers/Private/SonarKit/**` first, which alleviates the search path issue. The Obj-C `Sample` project seems to have worked around this by including a hardcoded `${PODS_ROOT}/SonarKit/**` search path in the pbxproj, which is why Sample works but new projects (like those referenced in #28) don't. I removed this since it's no longer necessary.
2. I added a `SampleSwift` app to demonstrate using Sonar with a Swift project.
3. Because the Podfiles for `Sample` and `SampleSwift` referenced podspecs using `:podspec` instead of a concrete version, Cocoapods wouldn't copy local header files (instead, it downloads them from the source). To enable local development of these sample apps using `:path`, I added a symlink to SonarKit.podspec in the root of the directory.
4. I changed SonarKit.podspec to use a tag-based `source`, since v0.0.1 pulls from the master branch of this repo.
The layout and network plugins still don't work with Swift - in order to fix this, we'll need to work on extracting the C++ out of their headers and writing Obj-C++ wrappers for them. I decided to push this off to a later PR since this one is quite large already.
This means that we need to be able to `import SonarKit` without importing all the network/layout plugin headers. In order to make this work, I made "SonarKit/Core" the spec's `default_subspecs`.
priteshrnandgaonkar, let me know if you have any thoughts on this implementation. You can verify that the SampleSwift app works by checking out this branch, `pod install`ing in the SampleSwift directory, and building it :)
Pull Request resolved: https://github.com/facebook/Sonar/pull/106
Reviewed By: jknoxville
Differential Revision: D8890010
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 449305bcc5cbeb5787c23f51b1ecb80a5cbdad32
Summary:
This diff adds the support to automate iOS releases. This diff adds two scripts, one for updating all the `podspecs`, and `podfiles` with updated version number. The script also updates the version used in sample and getting started doc file.
The second script publishes a github tag.
Following will be the process for iOS release:-
1. From `fbobjc/Libraries/SonarKit/Scripts` run `sh public-ios-podspec-update.sh`, it will update all the podspecs, podfiles and docs with updated version number. Commit it and land this
2. Once the above changes are landed and synced to github, run `sh push-new-github-tag.sh` from `fbobjc/Libraries/SonarKit/Scripts` to push the tag on github
As a follow up on this diff, ideally, we should trigger second script automatically when the 1st task changes are synced to github.
Reviewed By: jknoxville
Differential Revision: D8879958
fbshipit-source-id: 8f0dc9200e8f64578af33e1446629f09c16c43f2
Summary:
Noticed issues in https://fbsonar.com/docs/stetho.html - not sure if this will push there if accepted, but suggesting the changes in any case.
Created from Diffusion's 'Open in Editor' feature.
Reviewed By: jknoxville
Differential Revision: D8852241
fbshipit-source-id: 4a3e564e22ccb1edc43aa4cc335d3a8aeb916f3b
Summary:
This diff uses `tag` instead of master branch and also updates the version number to the desktop sdk.
Pull Request resolved: https://github.com/facebook/Sonar/pull/152
Reviewed By: danielbuechele
Differential Revision: D8820016
Pulled By: priteshrnandgaonkar
fbshipit-source-id: ff2e554be55254b77c4e130b35b7299abbafa77d
Summary:
Depends on #149.
Version bump for Android to bring it in line with the top-level version.
Pull Request resolved: https://github.com/facebook/Sonar/pull/150
Reviewed By: priteshrnandgaonkar
Differential Revision: D8804324
Pulled By: passy
fbshipit-source-id: 6c796f34cf064f117b6195b3c88d9b5c100f8dbb
Summary:
This PR includes documentation for using the `SonarOkhttpInterceptor` for applications using the `OkHttp` network stack. The docs were modelled on the [Stetho docs](http://facebook.github.io/stetho/#enable-network-inspection)
Fixes#22.
Pull Request resolved: https://github.com/facebook/Sonar/pull/144
Differential Revision: D8780506
Pulled By: danielbuechele
fbshipit-source-id: fb2ddd4356b421c3baf0a80a410dd579ebc1bd8d
Summary: This diff is mainly moving diffs around to open source the Sandbox plugin. I created the MD file writing some docs. The rest is just making our own FB implementation work
Reviewed By: danielbuechele
Differential Revision: D8731839
fbshipit-source-id: 27ac67223c6de9d1be406ab8c06b71b82d5407bc
Summary:
`SoLoader.init(Context, int)` isn't what we want as it can raise an `IOException` (checked) and implies exo-package. I suppose this was meant to be
`(Context, boolean)`.
Reviewed By: jknoxville
Differential Revision: D8512345
fbshipit-source-id: 7fad2a3788e64149fc02e3446db2c71412ccb43d
Summary:
As per GH-14 comment, the docs were pointing to an internal `private` method to check if `Sonar` should be enabled
Closes https://github.com/facebook/Sonar/pull/23
Reviewed By: danielbuechele
Differential Revision: D8379336
Pulled By: jknoxville
fbshipit-source-id: bc580dc40a1994a2f4a30544d77f86b60e9353f6
Summary:
Just a small typo in the filename
Closes https://github.com/facebook/Sonar/pull/44
Differential Revision: D8379387
Pulled By: danielbuechele
fbshipit-source-id: ae855068098360805c8ec56a1544a3cbea22f2c0
Summary: WithDefaultsTestRunner is FB-specific. Let's replace that with its base class.
Reviewed By: danielbuechele
Differential Revision: D8355145
fbshipit-source-id: 4d87ad00a82d1e2d5b536289f247910c6139df07
