Commit Graph

12 Commits

Author SHA1 Message Date
Chaiwat Ekkaewnumchai
b81724b7b0 Update Podfile for ReactNativeFlipperExample
Summary:
Encountered while trying to install the sample React Native app. Try the suggestion and the files changed.

This files are modified from `pod deintegrate` and `pod install` commands

Reviewed By: passy

Differential Revision: D21905958

fbshipit-source-id: 8b391acf5001c764bcfc0dd08b7ac5294ec9f5df
2020-06-08 09:00:03 -07:00
Michel Weststrate
dd111076c9 Only use Flipper in DEBUG builds
Summary:
as discussed in https://github.com/facebook/flipper/issues/976#issuecomment-634917766,

this solves the issue that FlipperKit is accidentally included in production builds ones react-native-flipper is installed, due to it's dependency on Flipper kit

This change is safe because the bindings did already have a check to verify that the Flipper bindings are available at all, and silenty skips their absence in production builds: https://www.internalfb.com/intern/diffusion/FBS/browse/master/xplat/sonar/react-native/react-native-flipper/index.js?commit=b7dd7e05b177&lines=128

Reviewed By: passy

Differential Revision: D21749213

fbshipit-source-id: 2c4435c7a375fbc24f89159855d3e0297f3aa9a4
2020-05-28 09:59:53 -07:00
Michel Weststrate
febb3deed9 Some dep bumps
Summary: Some dependency updates, mostly to prepare for next diff and update the podfile with the newest RN template

Reviewed By: passy

Differential Revision: D21749214

fbshipit-source-id: 0af10e404901a7522253136dc8c03020e7c813f8
2020-05-28 09:59:53 -07:00
Pascal Hartig
b56e89f7ca Update podfile
Summary: I think that's a good thing to keep up-to-date?

Reviewed By: mweststrate

Differential Revision: D20890360

fbshipit-source-id: a9c95d4afb2f6b6f0b32f595c53f3799b9ffaa73
2020-04-07 05:54:41 -07:00
Michel Weststrate
60ec958f6b Add (manual) tests to be able to verify working of network and logs
Summary: Added some UI so that we can manually verify that logging and network inspection is working in RN + Flipper.

Reviewed By: jknoxville

Differential Revision: D20668428

fbshipit-source-id: 4271595583e055b2b0324b3da7ac216c39717093
2020-03-26 04:54:24 -07:00
Michel Weststrate
8a7e0578ff Update to rc.5
Summary:
* Followed plan of D20221558
* Manually bumped Flipper version on iOS to 0.33.1, which contains https://github.com/facebook/flipper/pull/874/files (make Flipper compatible with iOS 9).
* Will submit a PR on RN to bump the iOS template

Reviewed By: passy

Differential Revision: D20361824

fbshipit-source-id: 4f013b731b40e2d4f941742f9201bf2bb4382ec3
2020-03-10 09:02:30 -07:00
Michel Weststrate
f3fd8646e3 Upgrade example app to 0.62.0-rc.3
Summary:
^

1. Remove entire `react-native/ReactNativeExampleFlipper` folder
2. Run `npx react-native init --version 0.62.0-rc.3 ReactNativeExampleFlipper`
4. restore the `package.json` and `TicTacToe` file and import
5. removed `.eslintrc`, `_BUCK` and `build_defz.bzl`, `.watchmenconfig`

Added comments below to highlight the non-generated changes

Reviewed By: passy

Differential Revision: D20221558

fbshipit-source-id: da1c895a2b0e7ce48092e64cdb5ffdb9e4a1a10b
2020-03-04 19:00:20 -08:00
Pritesh Nandgaonkar
bd388f73e4 CLANGFORMAT the remaining files of xplat/sonar
Summary:
As per title.
Ran `arc lint -a --take CLANGFORMAT --paths-cmd 'hg files ./'` from xplat/sonar

Reviewed By: zertosh

Differential Revision: D19943131

fbshipit-source-id: c1dc10b27389fd6f54f055803519dac6bf0e7997
2020-02-18 05:27:56 -08:00
Janic Duplessis
44f5e35675 Implement react-native-flipper on iOS (#795)
Summary:
Implement the react-native-flipper native module on iOS. Uses very similar abstractions as on Android.

## Changelog

[react-native-flipper] Support iOS
Pull Request resolved: https://github.com/facebook/flipper/pull/795

Test Plan:
Tested using the RN TicTacToe example app

{F228406333}

Reviewed By: mweststrate

Differential Revision: D19853017

Pulled By: priteshrnandgaonkar

fbshipit-source-id: d93d35ff984b9ba75f812c4c8e3c82e4d550f0c0
2020-02-14 21:17:11 -08:00
Pascal Hartig
604511715b Add missing copyright headers
Summary: Failing OSS requirements right now.

Reviewed By: nikoant

Differential Revision: D19557540

fbshipit-source-id: 18d0d68816e70492802f41472e15e1ed0cf35e31
2020-01-24 09:03:45 -08:00
Pascal Hartig
0812568be1 Remove BUCK files
Summary: We won't use them so this is just dead weight that's going to break at some point.

Reviewed By: jknoxville

Differential Revision: D19470548

fbshipit-source-id: 3def22e6f5db2923d5551d7b6a3472cb4364186c
2020-01-24 05:02:06 -08:00
Michel Weststrate
0fa0899299 Create React Native example project
Summary:
This diff creates a sample React Native project (based on the 0.62-rc.0 template).

This example is created like:
(Documenting this here as in the future this might be easier than upgrading the project itself)

1. Run `npx react-native init ReactNativeFlipperExample --version 0.62.0-rc.0`
2. Follow the installation steps to enable Flipper, that is, call `initializeFlipper(this, getReactNativeHost().getReactInstanceManager());` at the end of the `onCreate` method in `MainApplication.java`
3. Put `FlipperTicTacToe` in the root of the project, and call it from `App.js` as a component
4. install `react-native-flipper` as dependency
5. install `relative-deps` as dev dependency, and set it up as shown in `package.json`. This tool make sure that we build and test this project against the version of react-native-flipper in this repository, rather than against the one on NPM.
6. removed some stuff, like tests and linting, which is just in the way in this repo

This PR does not support iOS, as Flipper + RN iOS is still broken in 0.62.0-rc.0, and the current version of react-native-flipper doesn't support iOS yet either.

Documentation on how to set up Flipper in general is not part of this Diff

_N.B. since this is a **public** project, to be visible and runnable by our OSS community, the build setup is kept plain, vanilla, react-native, and **not** wired up to our normal / internal build processes. This is also the reason that lint suggestions beyond the license headers have been ignored. If any others should be applied, it is probably the official react native template that requires updating_

Reviewed By: passy

Differential Revision: D19449295

fbshipit-source-id: 2aeb6044f8dd01f09a95350c84fff2419d685a65
2020-01-23 04:47:52 -08:00