Commit Graph

13 Commits

Author SHA1 Message Date
Anton Kastritskiy
3b1763bd7d explicit instructions for idb
Summary: Add explicit instructions how to install idb internally

Reviewed By: LukeDefeo

Differential Revision: D51600754

fbshipit-source-id: c40d5d07c4cb570a7c51699ce0e4b8a67c506147
2023-11-28 03:40:23 -08:00
Anton Kastritskiy
f6445fea43 Check if Android Studio is installed
Summary:
Since Android Studio is technically not required, I made this check optional.
Though, these steps will gurantee that android env will work for an engineer who opened flipper for the first time

Reviewed By: lblasa

Differential Revision: D51267272

fbshipit-source-id: f30e58f322ea080b00a27ae86b871df2b39e1bb9
2023-11-14 04:29:59 -08:00
Anton Kastritskiy
1199e1f667 Update settings location to reflect new nav bar
Reviewed By: elboman

Differential Revision: D51257953

fbshipit-source-id: f19d2a1343276ee066b422e85b71e4d0a8e7bdb9
2023-11-13 08:26:13 -08:00
Anton Kastritskiy
cb485613e4 Internal Xcode install instruction
Reviewed By: elboman

Differential Revision: D51257660

fbshipit-source-id: 6cf213135f1070def3e62e936d6147b15749b7de
2023-11-13 08:26:13 -08:00
Anton Kastritskiy
0cbd640e5c expand on ios doctor suggestions
Summary:
this should help to address support posts like this one

https://fb.workplace.com/groups/flippersupport/posts/1724631861350798

Reviewed By: potomak

Differential Revision: D51203549

fbshipit-source-id: 097faeb6c9d506bc1fa2ac4602cba95e99a4e2cb
2023-11-10 09:54:08 -08:00
Anton Kastritskiy
45157c3675 Change order of ios checks
Summary:
Current order is confusion, the new order better reflects order at which users gets started with iOS

1. Install Xcode
2. Point Xcode-select at most recent xcode version
3. Install SDK
4. Accept Xcode SDK license
5. check idb health

Reviewed By: lblasa

Differential Revision: D51202202

fbshipit-source-id: da39acf7ef325889c2288b3941cef0ca803356cd
2023-11-10 09:54:08 -08:00
Anton Kastritskiy
b9952410b3 xcode-select copiable command
Reviewed By: ivanmisuno

Differential Revision: D50383695

fbshipit-source-id: 094c0477e44180591b479468fd365959e485da8a
2023-10-18 05:55:23 -07:00
Anton Kastritskiy
b6560e1c74 check xcode-select is using the latest major version available
Reviewed By: mweststrate

Differential Revision: D50369254

fbshipit-source-id: 140a044ca55ec1f445b38e02c7df13cb667d89c6
2023-10-17 16:01:08 -07:00
Anton Kastritskiy
73862c9408 refine typescript type of tryExecuteComand
Summary: You can now descriminate based on `hasProblem`. Thus removing asserting operator

Reviewed By: LukeDefeo

Differential Revision: D50366398

fbshipit-source-id: a16a5419ce946831bd2d1624b1baa75c89a47aa3
2023-10-17 16:01:08 -07:00
Andrey Goncharov
55b7ef934c Augument IDB installation instructions for intern users
Reviewed By: passy

Differential Revision: D37994214

fbshipit-source-id: bd36abf1ed024ca1f18fcc5297108e4ca333c578
2022-07-20 06:03:38 -07:00
Lawrence Lomax
fbd3212994 Add valid path check for xcode-select'd Xcode
Summary: We should also check that Xcode exists at the path that the user has `xcode-select`'d

Reviewed By: passy

Differential Revision: D34168672

fbshipit-source-id: dc7c36bcb2ad1cec99e6ebb4d531417e55402f01
2022-02-11 04:21:05 -08:00
Lawrence Lomax
ef2b03ea95 Specialize error message when no xcode selected
Summary:
We can detect an xcode-select failure earlier on, right now this will be misleading as later healtchecks around `xctrace`/`xcodebuild` will fail and it's not clear why.

If you don't have any Xcode selected, then we can detect this and mark it as an error. This can be done by looking out the output of the command.

To do this we have to propogate the stdout of the shell-out back, so there's a subtype of the regular healtcheck. This is then inspected for it's path since `xcode-select` returns the same exit code if xcode isn't selected or at it's default state.

Reviewed By: passy

Differential Revision: D34168673

fbshipit-source-id: c0aa846bb251aaf026beb976a042b727c7cf1c24
2022-02-11 04:21:05 -08:00
Anton Kastritskiy
b4fc108c2e Rename first batch for '.ts' files to '.tsx' in doctor, static and test-utils
Summary: Rename first batch for '.ts' files to '.tsx'

Reviewed By: nikoant

Differential Revision: D33843051

fbshipit-source-id: 68dd2dc6538afce2daaf24c6412dc5db8b38acbc
2022-01-28 08:32:19 -08:00