Summary:
Since Android Studio is technically not required, I made this check optional.
Though, these steps will gurantee that android env will work for an engineer who opened flipper for the first time
Reviewed By: lblasa
Differential Revision: D51267272
fbshipit-source-id: f30e58f322ea080b00a27ae86b871df2b39e1bb9
Summary:
Current order is confusion, the new order better reflects order at which users gets started with iOS
1. Install Xcode
2. Point Xcode-select at most recent xcode version
3. Install SDK
4. Accept Xcode SDK license
5. check idb health
Reviewed By: lblasa
Differential Revision: D51202202
fbshipit-source-id: da39acf7ef325889c2288b3941cef0ca803356cd
Summary: You can now descriminate based on `hasProblem`. Thus removing asserting operator
Reviewed By: LukeDefeo
Differential Revision: D50366398
fbshipit-source-id: a16a5419ce946831bd2d1624b1baa75c89a47aa3
Summary: We should also check that Xcode exists at the path that the user has `xcode-select`'d
Reviewed By: passy
Differential Revision: D34168672
fbshipit-source-id: dc7c36bcb2ad1cec99e6ebb4d531417e55402f01
Summary:
We can detect an xcode-select failure earlier on, right now this will be misleading as later healtchecks around `xctrace`/`xcodebuild` will fail and it's not clear why.
If you don't have any Xcode selected, then we can detect this and mark it as an error. This can be done by looking out the output of the command.
To do this we have to propogate the stdout of the shell-out back, so there's a subtype of the regular healtcheck. This is then inspected for it's path since `xcode-select` returns the same exit code if xcode isn't selected or at it's default state.
Reviewed By: passy
Differential Revision: D34168673
fbshipit-source-id: c0aa846bb251aaf026beb976a042b727c7cf1c24