Commit Graph

7 Commits

Author SHA1 Message Date
Joao Alves
51e37311d0 Fix: Release builds on android (#1325)
Summary:
After `react-native-flipper` 0.48.0 I cannot build releases on android (I think that passed on CI tests because the example was running an older version of this package, 0.47.0).
So I moved all the `android/src/main` content to `android/src/debug` because we will not use Flipper in another Build Variant

## Changelog

I moved all content from `react-native-flipper/android/src/main` to `react-native-flipper/android/src/debug`.

Probably solves https://github.com/facebook/flipper/issues/1303
Pull Request resolved: https://github.com/facebook/flipper/pull/1325

Test Plan: Maybe create a custom CI script to verify if Flipper deps are present on Release Builds, [something like this](https://github.com/facebook/flipper/issues/1274#issue-641197153)

Reviewed By: cekkaewnumchai

Differential Revision: D22333432

Pulled By: passy

fbshipit-source-id: 4abbab5ecbe08d44752b2138569ff60d25724087
2020-07-02 04:07:59 -07:00
Pascal Hartig
03b231703b Update react-native dependency @allow-large-files
Summary:
This should fix https://github.com/facebook/flipper/issues/1274

I had some cleaning up to do to get to this point.

Changelog:
Fix `react-native-flipper` dependency pulling in debug-only artifacts into release builds.

Reviewed By: mweststrate

Differential Revision: D22160304

fbshipit-source-id: 0ebc0ed942427f2966bccd721bf01aafa38ba400
2020-06-23 07:49:01 -07:00
Michel Weststrate
60ec958f6b Add (manual) tests to be able to verify working of network and logs
Summary: Added some UI so that we can manually verify that logging and network inspection is working in RN + Flipper.

Reviewed By: jknoxville

Differential Revision: D20668428

fbshipit-source-id: 4271595583e055b2b0324b3da7ac216c39717093
2020-03-26 04:54:24 -07:00
Michel Weststrate
f3fd8646e3 Upgrade example app to 0.62.0-rc.3
Summary:
^

1. Remove entire `react-native/ReactNativeExampleFlipper` folder
2. Run `npx react-native init --version 0.62.0-rc.3 ReactNativeExampleFlipper`
4. restore the `package.json` and `TicTacToe` file and import
5. removed `.eslintrc`, `_BUCK` and `build_defz.bzl`, `.watchmenconfig`

Added comments below to highlight the non-generated changes

Reviewed By: passy

Differential Revision: D20221558

fbshipit-source-id: da1c895a2b0e7ce48092e64cdb5ffdb9e4a1a10b
2020-03-04 19:00:20 -08:00
Pascal Hartig
604511715b Add missing copyright headers
Summary: Failing OSS requirements right now.

Reviewed By: nikoant

Differential Revision: D19557540

fbshipit-source-id: 18d0d68816e70492802f41472e15e1ed0cf35e31
2020-01-24 09:03:45 -08:00
Pascal Hartig
0812568be1 Remove BUCK files
Summary: We won't use them so this is just dead weight that's going to break at some point.

Reviewed By: jknoxville

Differential Revision: D19470548

fbshipit-source-id: 3def22e6f5db2923d5551d7b6a3472cb4364186c
2020-01-24 05:02:06 -08:00
Michel Weststrate
0fa0899299 Create React Native example project
Summary:
This diff creates a sample React Native project (based on the 0.62-rc.0 template).

This example is created like:
(Documenting this here as in the future this might be easier than upgrading the project itself)

1. Run `npx react-native init ReactNativeFlipperExample --version 0.62.0-rc.0`
2. Follow the installation steps to enable Flipper, that is, call `initializeFlipper(this, getReactNativeHost().getReactInstanceManager());` at the end of the `onCreate` method in `MainApplication.java`
3. Put `FlipperTicTacToe` in the root of the project, and call it from `App.js` as a component
4. install `react-native-flipper` as dependency
5. install `relative-deps` as dev dependency, and set it up as shown in `package.json`. This tool make sure that we build and test this project against the version of react-native-flipper in this repository, rather than against the one on NPM.
6. removed some stuff, like tests and linting, which is just in the way in this repo

This PR does not support iOS, as Flipper + RN iOS is still broken in 0.62.0-rc.0, and the current version of react-native-flipper doesn't support iOS yet either.

Documentation on how to set up Flipper in general is not part of this Diff

_N.B. since this is a **public** project, to be visible and runnable by our OSS community, the build setup is kept plain, vanilla, react-native, and **not** wired up to our normal / internal build processes. This is also the reason that lint suggestions beyond the license headers have been ignored. If any others should be applied, it is probably the official react native template that requires updating_

Reviewed By: passy

Differential Revision: D19449295

fbshipit-source-id: 2aeb6044f8dd01f09a95350c84fff2419d685a65
2020-01-23 04:47:52 -08:00