Summary:
// allow-large-files
Pull Request resolved: https://github.com/facebook/flipper/pull/4265
Related to https://github.com/facebook/flipper/issues/4240
Resolving https://github.com/facebook/flipper/issues/3859 led to breaking changes in react-native-flipper which made it incompatible with react-natvie < 0.69.
In this diff we migrate our example app to react-native 0.69 and add a notice to our readme about the react-native 0.69+ requirement
Reviewed By: lblasa
Differential Revision: D40673740
fbshipit-source-id: 18f4742449d115be7a5100f2bc4d834dcebea80f
Summary:
Bumps [react-native](https://github.com/facebook/react-native) from 0.66.4 to 0.67.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react-native/releases">react-native's releases</a>.</em></p>
<blockquote>
<h2>0.67.1</h2>
<p>A patch release including fixes to unblock Detox and Android JSC builds</p>
<ul>
<li>Remove alert's window when call to <code>hide</code>. (<a href="a46a99e120">a46a99e120</a> by <a href="https://github.com/asafkorem"><code>@asafkorem</code></a>)</li>
<li>Do not remove libjscexecutor.so from release builds (<a href="574a773f8f">574a773f8f</a> by <a href="https://github.com/cortinico"><code>@cortinico</code></a>)</li>
</ul>
<hr />
<p>You can participate in the conversation on the status of this release at this <a href="https://github.com/reactwg/react-native-releases/discussions/12">discussion</a></p>
<hr />
<p>To help you upgrade to this version, you can use the <a href="https://react-native-community.github.io/upgrade-helper/">upgrade helper</a> ⚛️</p>
<hr />
<p>You can find the whole changelog history in the <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md">changelog.md file</a>.</p>
<h2>0.67.0</h2>
<p>0.67 stable is out!</p>
<p>This release includes <strong>385 commits</strong> with <strong>75 contributors</strong>! Thank you to all our contributors new and old! You can find the <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md#v0670">full changelog here</a>.</p>
<ul>
<li>See the highlights of the release in our <a href="https://reactnative.dev/blog/2022/01/19/version-067">release blog post</a>.</li>
<li>You can participate in the conversation on the status of this release at <a href="https://github.com/reactwg/react-native-releases/discussions/10">this issue</a>.</li>
<li>You can upgrade to this version using the <a href="https://react-native-community.github.io/upgrade-helper/">upgrade helper webtool</a> ⚛️</li>
</ul>
<h2>0.67.0-rc.6</h2>
<p>We are aiming for this to be our candidate for stable. We aim to promote 0.67.0-rc.6 to stable in the first half of January 2022.</p>
<ul>
<li>(iOS) Fix M1 build error when pod has no IPHONEOS_DEPLOYMENT_TARGET <a href="9cd4092336</a></li>
</ul>
<hr />
<p>To test it, run</p>
<pre lang="sh"><code>npx react-native init RN067RC6 --version 0.67.0-rc.6
</code></pre>
<hr />
<p>You can participate in the conversation on the status of this release at this <a href="https://github.com/reactwg/react-native-releases/discussions/1">discussion</a>.</p>
<hr />
<p>To help you upgrade to this version, you can use the <a href="https://react-native-community.github.io/upgrade-helper/">upgrade helper</a> ⚛️</p>
<hr />
<p>You can find the whole changelog history in the <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md">changelog.md file</a>.</p>
<h2>0.67.0-rc.5</h2>
<p>We are aiming for this to be our candidate for stable (�)</p>
<ul>
<li>Revert Hermes 0.10 due to <a href="https://github-redirect.dependabot.com/facebook/hermes/issues/649">facebook/hermes#649</a>
<ul>
<li>Revert Hermes on iOS: <a href="a510c2733f</a></li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react-native/blob/main/CHANGELOG.md">react-native's changelog</a>.</em></p>
<blockquote>
<h2>v0.67.1</h2>
<h3>Fixed</h3>
<h4>Android specific</h4>
<ul>
<li>Do not remove libjscexecutor.so from release builds (<a href="574a773f8f">574a773f8f</a> by <a href="https://github.com/cortinico"><code>@cortinico</code></a>)</li>
</ul>
<h4>iOS specific</h4>
<ul>
<li>Remove alert's window when call to <code>hide</code>. (<a href="a46a99e120">a46a99e120</a> by <a href="https://github.com/asafkorem"><code>@asafkorem</code></a>)</li>
</ul>
<h2>v0.67.0</h2>
<h3>Added</h3>
<h4>Android specific</h4>
<ul>
<li>Add <code>ACCESS_MEDIA_LOCATION</code> permission to PermisionsAndroid library. (<a href="79db483568">79db483568</a> by <a href="https://github.com/Skrilltrax"><code>@Skrilltrax</code></a>)</li>
<li>Implement <code>SnapToAlignment</code> in <code>ReactScrollView</code> (<a href="e774c037bc">e774c037bc</a>), <code>ReactScrollViewManager</code> (<a href="c6e5640e87">c6e5640e87</a>), <code>ReactHorizontalScrollView</code> (<a href="b12256394e">b12256394e</a>), <code>ReactHorizontalScrollViewManager</code> (<a href="deec1db9fd">deec1db9fd</a>) and update <code>ScrollView.js</code> (<a href="a54cfb9e57">a54cfb9e57</a>) and reach parity with iOS (<a href="04184ef851">04184ef851</a>) by <a href="https://github.com/mdvacca"><code>@mdvacca</code></a></li>
<li>Show Redbox for C++ errors. (<a href="d6c879edba">d6c879edba</a> by <a href="https://github.com/sota000"><code>@sota000</code></a>)</li>
<li>Added an experimental touch dispatch path (<a href="a2feaeb5f1">a2feaeb5f1</a> by <a href="https://github.com/ShikaSD"><code>@ShikaSD</code></a>)</li>
</ul>
<h4>iOS specific</h4>
<ul>
<li>Added <code>cancelButtonTintColor</code> prop for <code>ActionSheetIOS</code> to change only the text color of the cancel button (<a href="01856633a1">01856633a1</a> by <a href="https://github.com/nomi9995"><code>@nomi9995</code></a>)</li>
<li>Added <a href="https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/LaunchServicesKeys.html#//apple_ref/doc/uid/TP40009250-SW14"><code>LSApplicationQueriesSchemes</code></a> in info.plist with entries tel, telprompt, http, fb, geo (<a href="b26f277262">b26f277262</a> by <a href="https://github.com/utkarsh-dixit"><code>@utkarsh-dixit</code></a>)</li>
<li>Add <code>UIAccessibilityTraitUpdatesFrequently</code> to progressBar role (<a href="1a42bd6e97">1a42bd6e97</a> by <a href="https://github.com/jimmy623"><code>@jimmy623</code></a>)</li>
<li>Add <code>asdf-vm</code> support in <code>find-node.sh</code> (<a href="3e7c310b1d">3e7c310b1d</a> by <a href="https://github.com/pastleo"><code>@pastleo</code></a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li><code>ImageBackground</code> now respects <code>imageStyle</code> width and height (<a href="dbd5c3d8e5">dbd5c3d8e5</a> by <a href="https://github.com/Naturalclar"><code>@Naturalclar</code></a>)</li>
<li>Rename deprecated <code>Keyboard.removeEventListener</code> to <code>Keyboard.removeListener</code>. (<a href="8880c09076">8880c09076</a> by <a href="https://github.com/yungsters"><code>@yungsters</code></a>)</li>
<li>Update <code>Modal</code>'s mock to not render its children when it is not visible (<a href="ec614c16b3">ec614c16b3</a> by <a href="https://github.com/AntoineDoubovetzky"><code>@AntoineDoubovetzky</code></a>)</li>
<li>Upgraded <code>react-devtools-core</code> dependency to 4.19.1 (<a href="356236471a">356236471a</a> by <a href="https://github.com/jstejada"><code>@jstejada</code></a>)</li>
<li>React-native/normalize-color now supports Node.js (<a href="65e58f26e1">65e58f26e1</a> by <a href="https://github.com/yungsters"><code>@yungsters</code></a>)</li>
<li>Updated to Contributor Covenant v2.1 (<a href="19f8d2f7da">19f8d2f7da</a>)</li>
</ul>
<h4>Android specific</h4>
<ul>
<li>Hermes initialization will no longer need an explicit configuration. (<a href="a40f973f58">a40f973f58</a> by <a href="https://github.com/Ashoat"><code>@Ashoat</code></a>)</li>
<li>Setting <code>overflow: scroll</code> in View component style will clip the children in the View container (<a href="93beb83abe">93beb83abe</a> by <a href="https://github.com/ryancat"><code>@ryancat</code></a>)</li>
<li>Native views backing <code>Animated.View</code> (w/ JavaScript-driven animations) will no longer be flattened; this should be a transparent change. (<a href="4fdbc44ab5">4fdbc44ab5</a> by <a href="https://github.com/yungsters"><code>@yungsters</code></a>)</li>
<li>Use new Locale API on Android 11 (API 30)+ (<a href="b7c023a8c1">b7c023a8c1</a>)</li>
<li>Changed <code>react.gradle</code> <code>detectCliPath</code> function logic for <code>cliPath</code> case (<a href="ce51b62494">ce51b62494</a> by <a href="https://github.com/vitalyiegorov"><code>@vitalyiegorov</code></a>)</li>
<li>Remove <code>"high"</code> and <code>"balanced"</code> as values for <code>android_hyphenationFrequency</code> on <code>Text</code> (<a href="a0d30b848a">a0d30b848a</a>)</li>
<li>Bump Gradle version to 7.2, Bump Kotlin version to 1.5.31 (<a href="9ae3367431">9ae3367431</a> by <a href="https://github.com/svbutko"><code>@svbutko</code></a>)</li>
<li>Move mavenCentral repo below local paths (<a href="046b02628d">046b02628d</a> by <a href="https://github.com/friederbluemle"><code>@friederbluemle</code></a>)</li>
</ul>
<h4>iOS specific</h4>
<ul>
<li>Optimized font handling for iOS (<a href="4ac42d88ef">4ac42d88ef</a> by <a href="https://github.com/Adlai-Holler"><code>@Adlai-Holler</code></a>)</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="25f3d310d9"><code>25f3d31</code></a> [0.67.1] Bump version numbers</li>
<li><a href="96ad60e3a1"><code>96ad60e</code></a> Do not remove libjscexecutor.so from release builds (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/32932">#32932</a>)</li>
<li><a href="218b4c19bb"><code>218b4c1</code></a> fix(iOS): remove alert's window when call to <code>hide</code>. (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/32833">#32833</a>)</li>
<li><a href="857dbd9b20"><code>857dbd9</code></a> [0.67.0] Bump version numbers</li>
<li><a href="900af2b3b6"><code>900af2b</code></a> TODO dummy commit</li>
<li><a href="842aac5a3c"><code>842aac5</code></a> Update bump-oss-version.js to guide releaser through release actions (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/32769">#32769</a>)</li>
<li><a href="a59141fb28"><code>a59141f</code></a> Update comments in publish-npm and leverage isTaggedLatest</li>
<li><a href="e7296d6b34"><code>e7296d6</code></a> Remove usages of bump-oss-version from generated scripts</li>
<li><a href="6fc004e95f"><code>6fc004e</code></a> Use tag to set publish version (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/32757">#32757</a>)</li>
<li><a href="c3aa86bea2"><code>c3aa86b</code></a> [0.67.0-rc.6] Bump version numbers</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/react-native/compare/v0.66.4...v0.67.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3341
Test Plan:
React Native Android
1. Start Android emulator (Pixel 4, API 27 Oreo 8.1)
2. Go to ReactNativeFlipperExample
3. Run yarn
4. Run yarn use-local-deps
5. Run yarn android
6. Wait for the app to start
7. Check "Logs" plugin works
8. Check "Network" plugin works (click on "IS NPM UP?")
9. Check "Layout" plugin works
10. Check "React Native Tic-Tac-Toe" plugin works
React Native iOS
1. Go to ReactNativeFlipperExample
2. Run yarn
3. Run yarn use-local-deps
4. Go to ReactNativeFlipperExample/ios
5. Run rm -f Podfile.lock
6. Run pod install --repo-update
7. Go to ReactNativeFlipperExample
8. Run yarn ios
9. Wait for the app to start
10. Check "Logs" plugin works
11. Check "Network" plugin works (click on "IS NPM UP?")
12. Check "Layout" plugin works
13. Check "React Native Tic-Tac-Toe" plugin works
Reviewed By: mweststrate
Differential Revision: D33741751
Pulled By: lblasa
fbshipit-source-id: 0bf7778615c327f3d2ef497932e77e94fb0d766d
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/2838
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D30838706/V2/flipper/)
Reviewed By: timur-valiev
Differential Revision: D30838706
Pulled By: passy
fbshipit-source-id: 6f7acf441211d9c5f61a4663af6eaf94f86c4dad
Summary: Upgrade React Native to 0.65.1 in the reference project. Verified that the app installs on Android, iPhone 12, with and without Hermes
Reviewed By: timur-valiev
Differential Revision: D30807062
fbshipit-source-id: 79f4aba2ca9767769842f77221d4cf3eeefbf478
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/2834
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D30808471/V2/flipper/)
Reviewed By: timur-valiev
Differential Revision: D30808471
Pulled By: passy
fbshipit-source-id: 3cb5d487f1222a08ae9b67cb50fbf459ded40058
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2275
Forced all current pods to use the latest available. If this builds successfully, will create a PR against React Native so that they become the default, and remove them here again.
This job currently does limit the architectures we build for. Pritesh is investigating if we can wide that again, as this might not be acceptable to RN in general.
This doesn't bump the android version to 0.88, as the artifact publishing failed for that version, but since there are currently less problems with the Android version I wanted to go ahead with just iOS.
Reviewed By: cekkaewnumchai, priteshrnandgaonkar
Differential Revision: D28257283
fbshipit-source-id: a631b1c354617ed356cd1e74b9e8e8aa050eed60
Summary:
allow-large-files
Per title. hermes enabled so that we can verify the hermes debugger works.
Reviewed By: passy
Differential Revision: D27229331
fbshipit-source-id: c2e45151b9d2097edc7e79f54eb89f9d110899d6
Summary: The React Native example project was broken for iOS. Fixed this by upgrading cocoapods locally, and bumping the Flipper version.
Reviewed By: passy, priteshrnandgaonkar
Differential Revision: D26777641
fbshipit-source-id: 889ff4f9de7c44240fe0a1b5d7d3c7c0b688d8ad
Summary:
In D25244631 (92bd68a371) we bumped the react-native dep of Flipper but we didn't apply the migration guide (sorry for missing that in the review), so the ReactNativeExample fell apart when trying to build for iOS. This diff applies the migration guide which nicely fixes that:
https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4
Recreating the Podfile.lock and running `./gradlew clean` fixed all build problems after that.
Verified that `yarn ios` and `yarn android`, and building from XCode all work.
Found (probably unrelated / existing) issues:
* custom plugins only show up after initial app start after refreshing the plugin list by navigating to another diffs first, so this seems to be a UI staleness bug
* Network plugin doesn't seem to work ion iOS (either not showing traffic or not showing data at all)
Reviewed By: passy
Differential Revision: D25755490
fbshipit-source-id: baea8b152fb252deda04291ec197ab87c2fbe3eb
Summary:
Encountered while trying to install the sample React Native app. Try the suggestion and the files changed.
This files are modified from `pod deintegrate` and `pod install` commands
Reviewed By: passy
Differential Revision: D21905958
fbshipit-source-id: 8b391acf5001c764bcfc0dd08b7ac5294ec9f5df
Summary: Some dependency updates, mostly to prepare for next diff and update the podfile with the newest RN template
Reviewed By: passy
Differential Revision: D21749214
fbshipit-source-id: 0af10e404901a7522253136dc8c03020e7c813f8
Summary:
* Followed plan of D20221558
* Manually bumped Flipper version on iOS to 0.33.1, which contains https://github.com/facebook/flipper/pull/874/files (make Flipper compatible with iOS 9).
* Will submit a PR on RN to bump the iOS template
Reviewed By: passy
Differential Revision: D20361824
fbshipit-source-id: 4f013b731b40e2d4f941742f9201bf2bb4382ec3
Summary:
Implement the react-native-flipper native module on iOS. Uses very similar abstractions as on Android.
## Changelog
[react-native-flipper] Support iOS
Pull Request resolved: https://github.com/facebook/flipper/pull/795
Test Plan:
Tested using the RN TicTacToe example app
{F228406333}
Reviewed By: mweststrate
Differential Revision: D19853017
Pulled By: priteshrnandgaonkar
fbshipit-source-id: d93d35ff984b9ba75f812c4c8e3c82e4d550f0c0
