Summary:
Changelog: Flipper will no automatically select any newly connected client
This reverts D26250896 (2df117923c) to V5, which is to aggressively select new clients. The current behavior was too conservative and caused Flipper to jump to a different client, without returning, after reconnecting a disconnected device.
As reported in https://fb.workplace.com/groups/flippersupport/permalink/1084676302013027/
Reviewed By: fabiomassimo
Differential Revision: D26691046
fbshipit-source-id: b16af2052f58dc1d4254eb1e6ebbb5848c53ed7e
Summary: Gave every device an icon, and use it as fallback in case we don't have a client icon. Added an icon for the Flipper client. This gets (largely) rid of the 'blank' icons
Reviewed By: fabiomassimo
Differential Revision: D26691054
fbshipit-source-id: d83012e755ae5edb230747e88f9b2eac45450b19
Summary:
There is currently a separate device for the Flipper inspection plugin. Figured it would be simpler and more logical to directly put it under the host device.
Might clean this up further in the future by having a `host` device and turning this into a device plugin
Reviewed By: fabiomassimo
Differential Revision: D26691053
fbshipit-source-id: 4f2fe890a1fff559b19b1599cc02017c45a635b9
Summary:
Fixes https://github.com/facebook/flipper/issues/1945
Changelog: Fixed an issue where device plugins targeting the host device didn't show up without connected clients.
Reviewed By: fabiomassimo
Differential Revision: D26690516
fbshipit-source-id: b46fd9bf06189354ed772581dc8db6b17104bea9
Summary:
Fix problems with row highlighting on mocks route list. When selecting a row, the highlight would sometimes be on the wrong row. Also, when adding routes, the routes would sometimes get added in the middle of the list instead of at the end.
These problems were caused by incorrectly referencing route rows in code. Sometimes index was used and other times the key was used. Fixed by consistently using key.
This fixes the problem described in issue https://github.com/facebook/flipper/issues/1733
## Changelog
Network Plugin - fix problems with row highlighting on mocks route list
Pull Request resolved: https://github.com/facebook/flipper/pull/1917
Test Plan:
Start with no mocks | No rows should be shown | TRUE
Add a single mock | First (and only row should be highlighted) | TRUE
Delete mock | No rows should be shown | TRUE
Add single mockAdd another mock | 2nd row should be highlighted | TRUE
Add another mock | 3rd row should be highlighted | TRUE
Add 2 more mocks and assign number to each row (5 total) | Last row should be highlighted | TRUE
Select 1st row | 1st row should be highlighted | TRUE
Delete 1st row | 1st row should be highlighed | TRUE
Select last row | last row should be highlighted | TRUE
Delete last row | last row should be deleted and new last row should be highlighted | TRUE
Highlight a middle row (row 3) | middle row should be highlighted | TRUE
Delete middle row | middle row should be deleted and last row should be in its place and should be highlighted | TRUE
Reviewed By: passy
Differential Revision: D26604455
Pulled By: mweststrate
fbshipit-source-id: f29690244e32b364983089541718f4bc75154dd1
Summary:
Fix for https://github.com/facebook/flipper/issues/1964
Changelog: fixed possible crash on startup after updating from a previous Flipper version to 0.77.0
Reviewed By: mweststrate
Differential Revision: D26664846
fbshipit-source-id: 6f9fabeaee8cfe1fa0df11bb57e27d659378a835
Summary:
Bumps [dateformat](https://github.com/felixge/node-dateformat) from 3.0.3 to 4.5.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/felixge/node-dateformat/releases">dateformat's releases</a>.</em></p>
<blockquote>
<h2>4.5.1</h2>
<ul>
<li>Fixed an issue with the <code>WW</code> mask not working</li>
</ul>
<h2>4.5.0</h2>
<ul>
<li>Added <code>WW</code> mask for week with padding (<a href="https://github-redirect.dependabot.com/felixge/node-dateformat/pull/156">details</a>)</li>
</ul>
<h2>4.4.2</h2>
<ul>
<li>Fixed an issue with <code>DDD</code> and <code>DDDD</code> masks sometimes not working (<a href="https://github-redirect.dependabot.com/felixge/node-dateformat/pull/158">details</a>)</li>
</ul>
<h2>4.4.1</h2>
<ul>
<li>Update <code>DDD</code> mask to use <code>Ysd</code>, <code>Tdy</code> and <code>Tmw</code> (<a href="https://github-redirect.dependabot.com/felixge/node-dateformat/pull/155">details</a>)</li>
</ul>
<h2>4.4.0</h2>
<ul>
<li>Added <code>DDD</code> and <code>DDDD</code> Mask for <code>Today</code>, <code>Tomorrow</code> and <code>Yesterday</code> (<a href="https://github-redirect.dependabot.com/felixge/node-dateformat/pull/71">details</a>)</li>
</ul>
<h2>4.3.1</h2>
<ul>
<li>Added <code>p</code> Mask for Timezone Offset e.g. <code>+02:00</code> (<a href="https://github-redirect.dependabot.com/felixge/node-dateformat/pull/149">details</a>)</li>
</ul>
<h2>4.2.2</h2>
<ul>
<li>Fix Rounding Issue with L Mask (<a href="https://github-redirect.dependabot.com/felixge/node-dateformat/pull/147">details</a>)</li>
</ul>
<h2>4.2.1</h2>
<ul>
<li>Reduce size of package (<a href="https://github-redirect.dependabot.com/felixge/node-dateformat/pull/142">details</a>)</li>
</ul>
<h2>4.2.0</h2>
<ul>
<li>Fixed Invalid '1970-01-01' Formatting (<a href="https://github-redirect.dependabot.com/felixge/node-dateformat/pull/143">details</a>)</li>
</ul>
<h2>4.1.0</h2>
<ul>
<li>Added Padding Short Date Mask</li>
</ul>
<h2>4.0.2</h2>
<ul>
<li>Fixed an issue with old years not having padding. e.g. 0009 was formatting as 9.</li>
</ul>
<h2>Performance Improvements</h2>
<p>This release brings significant performance improvements to dateformat.<br />
Some common operations are now 6 times faster than before!!!</p>
<p>There are no breaking changes in this release.</p>
<p><img src="https://user-images.githubusercontent.com/53957795/100558584-e0921f80-3313-11eb-984a-ac2995bc01ee.png" alt="image" /></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/felixge/node-dateformat/commits/v4.5.1">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a href="https://www.npmjs.com/~chase-manning">chase-manning</a>, a new releaser for dateformat since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1957
Reviewed By: mweststrate
Differential Revision: D26605958
Pulled By: passy
fbshipit-source-id: a794b90b7b183177264ed8d42c47ebff8b98e330
Summary:
Bumps [rsocket-flowable](https://github.com/rsocket/rsocket-js) from 0.0.22 to 0.0.23.
<details>
<summary>Commits</summary>
<ul>
<li><a href="8e357291ed"><code>8e35729</code></a> v0.0.23</li>
<li><a href="5eece29159"><code>5eece29</code></a> ensures existing Buffer polyfills are overridden (<a href="https://github-redirect.dependabot.com/rsocket/rsocket-js/issues/114">https://github.com/facebook/flipper/issues/114</a>)</li>
<li><a href="e002a64d69"><code>e002a64</code></a> ensures connection closed if connect() subscription is cancelled (<a href="https://github-redirect.dependabot.com/rsocket/rsocket-js/issues/113">https://github.com/facebook/flipper/issues/113</a>)</li>
<li><a href="a94ebeab5b"><code>a94ebea</code></a> improves example</li>
<li><a href="6fb2aa519b"><code>6fb2aa5</code></a> removes proper handler</li>
<li><a href="d392b39843"><code>d392b39</code></a> adds missing rsocket-types package</li>
<li><a href="f85762d078"><code>f85762d</code></a> adds example of server-side with composite metadata</li>
<li><a href="195e9affd5"><code>195e9af</code></a> fixes formats and improves composite-metadata example</li>
<li>See full diff in <a href="https://github.com/rsocket/rsocket-js/compare/v0.0.22...v0.0.23">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1954
Reviewed By: mweststrate
Differential Revision: D26605957
Pulled By: passy
fbshipit-source-id: 511bf81579216edc60ab4ab1f4a1adab1cd305c2
Summary:
A temporarily hack that was a left-over from the past where we could switch between Sandy and non-Sandy UI, caused Flipper to crash.
This is the first runtime crash we find with the new Crash reporting dialog last week :)
Changelog: Fixed an issue where Flipper could occasionally crash when disconnecting a device
Reviewed By: passy
Differential Revision: D26634620
fbshipit-source-id: 5ca0b14dee332859a4d8af27501f0916c55a1370
Summary: `install` is now ambiguous because of some new plugins we've added.
Reviewed By: mweststrate
Differential Revision: D26633940
fbshipit-source-id: 62369ba76cced905350e62b7782619811b7284a0
Summary:
I'm in the progress of releasing a prefab-enabled FBJNI release. This dramatically reduces the hackery around integrating with separately released native libraries.
This will fail until the release is actually out.
Pull Request resolved: https://github.com/facebook/flipper/pull/1941
Test Plan:
`./gradlew :sample:installDebug` works as before.
Once the release is out, we need to check if this creates any problems with RN but because we advice to exclude the dependency, I expect it not to cause any trouble.
Reviewed By: mweststrate
Differential Revision: D26545104
Pulled By: passy
fbshipit-source-id: 1e21fa1816f28e2fcb52da68863fabc8bc625136
Summary:
Renamed actions "star" and "unstar" everywhere to "enable", "disable" and "switch". The logic behind original "star" action changed significantly, so this rename just makes everything much clearer.
Please note that as a part of rename persisted state fields "userStarredPlugins" and "userStarredDevicePlugins" were renamed. I've added a "redux-persist" migration for seamless transition.
Reviewed By: passy
Differential Revision: D26606459
fbshipit-source-id: 83ad475f9b0231194701c40a2cdbda36f02c3d10
Summary:
This is a very simple implementation of "profiles". It allows defining sets of plugins and associate them with GKs. Plugins from sets are automatically installed and enabled when a mobile app connected to Flipper for the first time (e.g. user has not already debugged same app before). Set is only enabled if user is passing the associated GK.
Sets are simply hardcoded for now.
Reviewed By: timur-valiev
Differential Revision: D26605371
fbshipit-source-id: 9bf0600d44381e047361d960558aa004960550c1
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.75.1 to 0.76.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/flipper/releases">react-native-flipper's releases</a>.</em></p>
<blockquote>
<h2>v0.76.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a>
for full notes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="208e899b4f"><code>208e899</code></a> Flipper Release: v0.76.0</li>
<li><a href="b25de27b8a"><code>b25de27</code></a> Move bolts dependencies to Fresco plugin (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1937">https://github.com/facebook/flipper/issues/1937</a>)</li>
<li><a href="e3d1e41cc1"><code>e3d1e41</code></a> Dedupe errors when sending</li>
<li><a href="6667a15f2c"><code>6667a15</code></a> Lispy grammar parser</li>
<li><a href="f6026de2f0"><code>f6026de</code></a> Record video always in 1280x720</li>
<li><a href="c0010bea4c"><code>c0010be</code></a> Fix to avoid loading of disabled device plugins</li>
<li><a href="805261b429"><code>805261b</code></a> Basic skeleton for no diff found</li>
<li><a href="2fc3c2a4c1"><code>2fc3c2a</code></a> Update the plugin name and icon</li>
<li><a href="6d2206769c"><code>6d22067</code></a> Fix the regex to allow xcode from non standard location (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1939">https://github.com/facebook/flipper/issues/1939</a>)</li>
<li><a href="e491ed55af"><code>e491ed5</code></a> Upgrade to Electron v11.2.3</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.75.1...v0.76.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1952
Reviewed By: nikoant
Differential Revision: D26605954
Pulled By: passy
fbshipit-source-id: f49a6073afddd13f1923441b067ae6e0290be863
Summary: Fixed passing parameter for running dev build as "insiders" via env var. It was broken before and it was only possible to pass it via command line.
Reviewed By: passy
Differential Revision: D26578901
fbshipit-source-id: a579ac5bb6e5527abbe978318bf0c0398f76f1fe
Summary:
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 7.2.0 to 8.0.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md">eslint-config-prettier's changelog</a>.</em></p>
<blockquote>
<h3>Version 8.0.0 (2021-02-21)</h3>
<ul>
<li>
<p>Changed: All configs have been merged into one!</p>
<p>To upgrade, change:</p>
<pre lang="json"><code>{
"extends": [
"some-other-config-you-use",
"prettier",
"prettier/typescript-eslint",
"prettier/babel",
"prettier/flowtype",
"prettier/react",
"prettier/standard",
"prettier/unicorn",
"prettier/vue"
]
}
</code></pre>
<p>Into:</p>
<pre lang="json"><code>{
"extends": [
"some-other-config-you-use",
"prettier"
]
}
</code></pre>
<p>The <code>"prettier"</code> config now includes not just ESLint core rules, but also rules from all plugins. Much simpler!</p>
<p>So … what’s the catch? Why haven’t we done this earlier? Turns out it’s just a sad mistake. I (<a href="https://github.com/lydell"><code>lydell</code></a>) was confused when testing, and thought that turning off unknown rules in a config was an error. Thanks to Georgii Dolzhykov (<a href="https://github.com/thorn0"><code>thorn0</code></a>) for pointing this out!</p>
<p>If you use [eslint-plugin-prettier], all you need is [plugin:prettier/recommended]:</p>
<pre lang="json"><code>{
"extends": [
"some-other-config-you-use",
"plugin:prettier/recommended"
]
}
</code></pre>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0dd2a7ed26"><code>0dd2a7e</code></a> eslint-config-prettier v8.0.0</li>
<li><a href="03c79b9306"><code>03c79b9</code></a> One config to rule them all (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/175">https://github.com/facebook/flipper/issues/175</a>)</li>
<li><a href="72ce4d7ede"><code>72ce4d7</code></a> Update npm packages</li>
<li>See full diff in <a href="https://github.com/prettier/eslint-config-prettier/compare/v7.2.0...v8.0.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1950
Reviewed By: nikoant
Differential Revision: D26578214
Pulled By: passy
fbshipit-source-id: f1a94a1fc7bdbefed7f71eba25bdc994bc4533a0
Summary:
Upgrade the static docs plugin.
You no longer need to import OssOnly and FbInternalOnly in markdown files, so removed those imports too.
Reviewed By: passy
Differential Revision: D26580059
fbshipit-source-id: 2763de2f5fbef41ec2ac7f7bdd147418badb78b6
Summary:
Bumps [tar](https://github.com/alexcrichton/tar-rs) from 0.4.32 to 0.4.33.
<details>
<summary>Commits</summary>
<ul>
<li><a href="f07b3c15e3"><code>f07b3c1</code></a> Bump to 0.4.33</li>
<li><a href="25cadd8e9b"><code>25cadd8</code></a> fix: allow unaligned final blocks in sparse archives (<a href="https://github-redirect.dependabot.com/alexcrichton/tar-rs/issues/244">https://github.com/facebook/flipper/issues/244</a>)</li>
<li>See full diff in <a href="https://github.com/alexcrichton/tar-rs/compare/0.4.32...0.4.33">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1946
Reviewed By: priteshrnandgaonkar
Differential Revision: D26578205
Pulled By: passy
fbshipit-source-id: d4dd222a63c1c157b814450f84dbca26865888a5
Summary:
Errors and warnings are both shown to users. I'm applying the rule of
thumb of using errors for non-recoverable problems that require *our*
intervention. All of these errors can happen under normal
circumstances.
Reviewed By: mweststrate
Differential Revision: D26577917
fbshipit-source-id: 12ba6725b6575bdf62141b01a16a5638c2c95701
Summary: Changelog: Layout plugin: fixed automatic expanding of layout tree when a deep element selected in the target mode.
Reviewed By: passy
Differential Revision: D26577751
fbshipit-source-id: 9f4a074d114892d6903a58e1ed44cf580cf1d432
Summary:
None of these are fatal. In fact, they're quite common for people
who've got Android enabled but no tools installed. So they're warnings
at best.
I'd like to find a way to guide people to the settings in this case
or use Doctor to disable Android support instead of retrying this
endlessly.
Reviewed By: mweststrate
Differential Revision: D26547577
fbshipit-source-id: 81e658fe3d95b2d12e76e4b635575f3e5a6fc53b
Summary:
We do have a fall-back for this so there's no need to give this error or even
warning treatment. If the fallback fails, we already have a warning.
Reviewed By: mweststrate
Differential Revision: D26547277
fbshipit-source-id: 96ac91def7e6e111d32d3536d8796f347d6c519d
Summary: This gets exposed by using glog from tp2 for fbcode platform builds.
Reviewed By: aniketmathur
Differential Revision: D26515732
fbshipit-source-id: 7bb4b20a43702f9096bd6014278faffb5029712f
Summary:
Upgraded to the latest Android Studio and this popped up.
Pull Request resolved: https://github.com/facebook/flipper/pull/1936
Test Plan:
Built the sample app.
Repro'd the previous build failure. Weirdly enough, this only occurred on Linux, not on my Mac. Now it's passing.
Reviewed By: mweststrate
Differential Revision: D26483694
Pulled By: passy
fbshipit-source-id: 9c27eb6d28a0f390154899d67469a504d68c2ad4
Summary: Keeps a small ring buffer of errors we're sending and checks if they're tracked. I'm sure there's a better data structure for this out there were we could have O(1) membership checks, but since we're not keeping that many errors to begin with and we're saving a lot of CPU that would go into sending the errors to Scribe, this should be a net positive.
Reviewed By: mweststrate
Differential Revision: D26488825
fbshipit-source-id: fdcf58e88d43864852c13e4741a7ab620d596094
Summary:
Grammar parsers for Lispy language (it's a lisp) - to be used later to
1) extract meaningful data from binding scripts
2) better presentation of the scripts
There a are two parsers - one is transforming lispy to 'honest', raw tree
Another one does some simplifications - unwrap consts,arrays and maps
It uses https://nearley.js.org/docs/grammar parser and moo lexer
Reviewed By: yousuf-haque
Differential Revision: D26422882
fbshipit-source-id: 09c8aa91b635e4605104f9a52fa4699b53990006
Summary:
Video recording for Android devices is quite unreliable now, because not all resolutions are supported:
https://android.stackexchange.com/questions/168944/unable-to-get-output-buffers-err-38-when-attempting-to-screen-record-emulator
In this diff I changed resolution for the captured videos to always be 1280x720 or 720x1280. These resolutions are always supported because they are used by default if device native resolution cannot be detected.
Changelog: Android video is now always captured in 1280x720 / 720x1280 to avoid the issue when video cannot be captured because of unsupported resolution (err=-38)
Reviewed By: mweststrate
Differential Revision: D26225203
fbshipit-source-id: 0f9491309bf049fd975f20e096c5c7362d830adc
Summary: There is a bug right now that even for disabled plugins we're loading them. In particular, this led to the Flipper freezes caused by Logs plugin even if it is disabled.
Reviewed By: passy
Differential Revision: D26503012
fbshipit-source-id: 2068626f4637ced44c457ee1b7ba7fffdcf5aa47
Summary:
- populate the state
- will render some UI that you can reload
- next up showing the diff number and title
Differential Revision: D26477472
fbshipit-source-id: d5c5175771c324c9f893a6b6c6a14a40a2f0f0fe
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1939
This diff fixes T84865014. We used to assume in our xcode cli check that xcode will be run from standard /Applications folder. But as mentioned in the above tasks, its not always true.
Reviewed By: passy
Differential Revision: D26484287
fbshipit-source-id: 32d343dece53576f99cbbb6d193138e803505935
Summary:
I'm on-call and this seems like an on-call-y thing to do. Who knows, maybe one of these crash backports addresses the Big Crasher.
The JSON got reformatted by the script but the contents are unchanged apart from the version numbers.
Created by `cd electron-updater && cargo run 11.2.3`.
Reviewed By: fabiomassimo
Differential Revision: D26483726
fbshipit-source-id: a8b76102283fde94f42961d1b715a55ac89d66c7
Summary:
Noticed that subsequent `adb logcat` invocations are stateful, and we didn't clear it's state when clearing the logs in memory.
This is a bandaid to get back to the previous behavior. I am wondering whether it wouldn't be just much more intuitive to always clear the logs (`adb logcat -c`) before we start the streaming log listener, so that users are never shown old logs from before flipper was connected?
Also fixed a leak in cleaning up the log listeners that was revealed by the possibility to disable the log plugin
Reviewed By: nikoant
Differential Revision: D26450262
fbshipit-source-id: 5b426e2d0e1fafdbc512d48d22b7bd4f30b61309
Summary:
Bumps [js-base64](https://github.com/dankogai/js-base64) from 3.5.2 to 3.6.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="ad8897c84b"><code>ad8897c</code></a> version 3.6.0</li>
<li><a href="78016271df"><code>7801627</code></a> add isValid()</li>
<li>See full diff in <a href="https://github.com/dankogai/js-base64/compare/3.5.2...3.6.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1935
Reviewed By: mweststrate
Differential Revision: D26463175
Pulled By: passy
fbshipit-source-id: 06b223e8d89c75f5bda1e67b4e41403f7663ec7e
Summary: Show warnings for the device plugins defined in the legacy format and suggest to migrate them
Reviewed By: mweststrate
Differential Revision: D26459321
fbshipit-source-id: 4e45cd58a63a4ff9903ecaf12e6f9ba4a43e71e1
Summary: Enable device plugins by default to minimise breaking changes for users. Users will be able disable them if they want.
Reviewed By: mweststrate
Differential Revision: D26439227
fbshipit-source-id: 95c19e9335d583646c8aafd70a03e73bcf86c3bc
