Summary: In this diff we load and call a private API enabling voiceover hierarchy and pass it over via existing channel when client is in the accessibility mode
Reviewed By: lblasa
Differential Revision: D49393813
fbshipit-source-id: 437af1131547218cd52f4a56797707411787d7cf
Summary:
Make sure mobile client and sonar desktop app keep debugger mode in sync
Desktop client listens to available modes and currently selected mode which is what we use here.
Later we can tweak the logic to try to restore last mode if desktop or mobile clients crash / disconnect etc
Reviewed By: lblasa
Differential Revision: D49384358
fbshipit-source-id: 5bc1f4240253b68a746dfa5feba4b352f4e261a2
Summary:
In accessibility mode it is important to be visually aware of the order of the elements on the screen aside from the list on the left
To enable this let's show the indices on the elements
Voice over assumes single continuous list of objects so it is okay to pass index of children we should never have nested lists in accessibility mode
Reviewed By: lblasa
Differential Revision: D49440400
fbshipit-source-id: e6878b4b33952053823451ad76993259f0794067
Summary:
## This diff: Add debugger mode infrastructure
We want to enable infrastructure allowing adding modes in the future without branching client and plugin code
This infra allows for the client to send a message informing flipper about the supported modes (following diffs)
Currently broadcasting mode change event over to the client
Reviewed By: lblasa
Differential Revision: D49385860
fbshipit-source-id: 2db6f65064d1ff7e1f57b2da93c3ed195400fb7f
Summary: Give the user something actionable when tree is not ready due to flipper connected check failing
Reviewed By: lblasa
Differential Revision: D49455254
fbshipit-source-id: 8869cacde5b65260f4615f5ba2ba34f967d7d27f
Summary:
THis is useful for bloks where fliper needs to be open before hand,
We might also be able to replace some of the annoying notification bubles with these sleeker inline warnings
Reviewed By: lblasa
Differential Revision: D49454977
fbshipit-source-id: fca4fbd3258a68d93c75655cfff247adfa3e6bb2
Summary: Make non-interactive elements non-focusable and disable hover styles for them
Reviewed By: LukeDefeo
Differential Revision: D49455532
fbshipit-source-id: a047e1a149ab4131feef70b80a4995b455441701
Summary: Each search term renderer handles its "editing" state internally now. As a result, we can simplify switch-case
Reviewed By: antonk52
Differential Revision: D49454252
fbshipit-source-id: 297ce73f53772b0112ed338c6aac0583f3807ec8
Summary: For the purposes of the demo I added power search config for a float field to the summary field
Reviewed By: lblasa
Differential Revision: D49452844
fbshipit-source-id: 26aaadd07a1a8a67dfcf3cb9d8e487f8f4ee2214
Summary: For the purposes of the demo I added power search config for an integer field to the summary field
Reviewed By: lblasa
Differential Revision: D49452729
fbshipit-source-id: 78b8fdccfd799a0f71f652d90d10e11db237cbae
Summary:
At the end of the stack we are going to unify two branches of the switch-case in PowerSearchTerm.tsx.
Each search term is going to handle the finalized and "editing" mode internally
Reviewed By: lblasa
Differential Revision: D49451975
fbshipit-source-id: 587ba332d1fbfbaefb368e37965543575e64062f
Summary: Used last year to GK server usage. This is obsolete so is safe to remove.
Reviewed By: ivanmisuno
Differential Revision: D49414625
fbshipit-source-id: 9eeff932c59c90dff829e4c6c83bad43a0fd74e3
Summary:
Whenever there is an issue, I always find myself adding these logs.
Instead of keep doing that, reuse the existing FLIPPER_DEBUG_LOG definition as a way of enabling/disabling the verbose logs very easily.
Reviewed By: ivanmisuno
Differential Revision: D49227973
fbshipit-source-id: d053df6668b1dda6f6782e8ef7d844c82945f126
Summary: Use the same standard used in other places.
Reviewed By: ivanmisuno
Differential Revision: D49228128
fbshipit-source-id: 771b6923f758400200298f3339b83b2c4d51648b
Summary: The string were out of sync so using the constants instead
Reviewed By: fabiocarballo
Differential Revision: D49414046
fbshipit-source-id: 5d61831505e5d7ecec3d5c9717d4549ba4b291a8
Summary: Let's keep it simple, do not reload. Just show/hide the right content.
Reviewed By: antonk52
Differential Revision: D49377316
fbshipit-source-id: 9b2a47374da3e72f17e2d55c9290960b703fd43e
Summary:
Whenever there was a connectivity error, we would show an error message and setup a retry mechanism as to refresh the page as to make it transparent for engineers to have a working workspace again.
The problem is that there are two different channels:
- HTTP server
- WS server
If the HTTP server is healthy but there is a WS error, it is not entirely correct to try to reload the page. If the error conditions for the WS remain, then we end up in a loop.
Reviewed By: passy, antonk52
Differential Revision: D49373335
fbshipit-source-id: 4e0a08fe2384860db0bf92a22edc87402d41651c
Summary:
Our development defaults should match the user defaults.
For anyone still wanting to test electron, use `yarn start-electron`.
Changelog: `yarn start` now launches the in-browser version of Flipper. Use `yarn start-electron` for the old behaviour.
Reviewed By: lblasa
Differential Revision: D49371369
fbshipit-source-id: a97ad1650ad851a4573fdfe52f606ac2f5a296ba