Summary: Refactored Navigation plugin to make it fast-refreshable: moved the main component into a separate file and exported all components as named functions. Without these changes every change of UI triggered full reload.
Reviewed By: timur-valiev
Differential Revision: D29814077
fbshipit-source-id: 5285bdc5f14a5163f9501c0d45a3affefb08fc8e
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2609
Make it possible to mark some tests to run on non-CI, or unix only
Reviewed By: nikoant
Differential Revision: D29813506
fbshipit-source-id: 140f8a4eaed5af3282ab9d139b46a52818be0934
Summary:
Fix changelog display in dark mode, as reported in https://github.com/facebook/flipper/issues/2379#issuecomment-851059786
Changelog: Fix dark mode support in changelog dialog.
Reviewed By: timur-valiev
Differential Revision: D29801181
fbshipit-source-id: ffbbd012c99dee897c4fd67653b4f6375294d668
Summary:
Bumps [types/fb-watchman](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/fb-watchman) from 2.0.0 to 2.0.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/fb-watchman">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2593
Reviewed By: mweststrate
Differential Revision: D29752886
Pulled By: passy
fbshipit-source-id: a97533bd6f110abf691facda350cf3892b6c0ac3
Summary:
Bumps [types/rsocket-core](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/rsocket-core) from 0.0.6 to 0.0.7.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/rsocket-core">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2592
Reviewed By: mweststrate
Differential Revision: D29752888
Pulled By: passy
fbshipit-source-id: 9cf7f0b7c696567b2c31cd771aa40dfea5abec4d
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.96.1 to 0.98.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/flipper/releases">react-native-flipper's releases</a>.</em></p>
<blockquote>
<h2>v0.98.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a>
for full notes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="5da8fca2e4"><code>5da8fca</code></a> Flipper Release: v0.98.0</li>
<li><a href="a3bd6a9b98"><code>a3bd6a9</code></a> Update flipper to use latest version of docusaurus-plugin-internaldocs-fb pac...</li>
<li><a href="abfa50c232"><code>abfa50c</code></a> Enable Inpage Editor On flipper sites.</li>
<li><a href="25fa0b7c61"><code>25fa0b7</code></a> Make plugin status screen more useful</li>
<li><a href="1fdc261111"><code>1fdc261</code></a> Update setup.mdx (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/2595">https://github.com/facebook/flipper/issues/2595</a>)</li>
<li><a href="9498a529d5"><code>9498a52</code></a> Filter out empty strings after splitting top-level JSON</li>
<li><a href="e346c79ffd"><code>e346c79</code></a> Flipper Snapshot Bump: v0.97.1-SNAPSHOT</li>
<li><a href="1b36e33a25"><code>1b36e33</code></a> Flipper Release: v0.97.0 (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/2579">https://github.com/facebook/flipper/issues/2579</a>)</li>
<li><a href="8c7b2fe4d5"><code>8c7b2fe</code></a> ws security bump</li>
<li><a href="88d6d000c8"><code>88d6d00</code></a> Fixed error in error handling</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.96.1...v0.98.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2604
Reviewed By: nikoant
Differential Revision: D29764086
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 49c0b86160c83ffe0014eedb2248d7e58fadf6a4
Summary:
This diff bumps core-ktx from 1.3.0 to 1.5.0 and appcompat from 1.1.0 to 1.3.0 inside `android/tutorial`
core-ktx 1.5.0 is the last version built with Kotlin 1.4.x and is the latest we can safely upgrade to.
To update to core-ktx 1.6.0 we would need to bump KGP on the overall project to 1.4.x or 1.5.x to fix the build
failures.
Reviewed By: passy
Differential Revision: D29762647
fbshipit-source-id: 7ad23b3cbebe14b36dedaa7f8aedf11eece8429d
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/2599
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D29752884/V2/flipper/)
Reviewed By: mweststrate
Differential Revision: D29752884
Pulled By: passy
fbshipit-source-id: ca8456fe519e093ca3a7c428d3c0b20aa39c19c7
Summary:
Just a few tweaks to bring AndroidX up-to-date. Required
some fixes to the Kotlin Tutorial as it was throwing
errors about JRE incompatibilities.
Reviewed By: fabiomassimo
Differential Revision: D29761484
fbshipit-source-id: 10cb76115fe7542a60b6e5d14be9c0434e85171c
Summary:
This seems to be time-sensititve and breaks
occassionally on GitHub Actions.
Reviewed By: fabiomassimo
Differential Revision: D29760768
fbshipit-source-id: 12b496257d01d169c52f3a430175846f9a7eb227
Summary:
Restored sidebar in Flipper messages plugin, by using a Container, as DetailsSidebar is only valid in a PluginContainer context.
Also made tab rendering a bit more condensed while at it.
Reviewed By: timur-valiev
Differential Revision: D29734639
fbshipit-source-id: d3ec6f354e14194035e93daa014985721844416d
Summary:
Some folks were missing the copy as text ManagedTable used to have, so introduced both the options to either copy as text (visible columns or custom copy handler) or as JSON
Changelog: It is now possible to both copy as text or as JSON from data tables
Reviewed By: jknoxville
Differential Revision: D29712096
fbshipit-source-id: 27bd2e869a247bd0896ce2774c08651123fd531d
Summary:
This stack adds a SNAPL Video Logs Flipper Plugin.
In this commit I created the skeleton for the desktop and the client sides of the plugin.
Differential Revision: D29065783
fbshipit-source-id: e204a465e64ede9479665fcbbb6be34643de5218
Summary:
Just wanted to give this a try. Fixed Flipper capitalization inconsistencies.
*This diff has been automatically generated by the inpage editor*
Differential Revision: D29711275
fbshipit-source-id: 8302220b87c504b4f1ccc422aa05c1c559809cbb
Summary: While working on D29694696, noticed it is tricky to test against an OnDemand, as the URL format is pretty specific and authentication flow uses an unrelated URL base constant. Introduced `FB_ONDEMAND` env var to make testing easier. If this is a common scenario we could consider making it a setting in the long run.
Reviewed By: timur-valiev
Differential Revision: D29694707
fbshipit-source-id: 747ceb80c95c3bdf0276497c41c9ff5ed9a198f2
Summary: As reported in https://fb.workplace.com/groups/flippersupport/permalink/1171595499987773/, the SupportForm doesn't support dark mode. Fixed this by fixing theming in some of the underlying deprecated components.
Reviewed By: timur-valiev
Differential Revision: D29694034
fbshipit-source-id: f8b90ecc87f7f16f6e1f9751d22309d37a052d5a
Summary: A bunch of dropdowns in Flipper are using native context menu to show their items. Rewrote to use Antd instead and reduce coupling with Electron
Reviewed By: timur-valiev
Differential Revision: D29694035
fbshipit-source-id: 5fd80c255c308567daf3e46e03bc27494c8ba142
Summary: Similarly to previous stack, remove the need to import Electron to write things to clipboard. Introduced linter to prevent future use.
Reviewed By: timur-valiev
Differential Revision: D29661777
fbshipit-source-id: 7bc67ede40b65c5f232b69128f3a423e232ddc1b
Summary:
This stack reduces our direct dependency on Electron, for example by exposing our own API to open links.
Also exposing `getFlipperLib` as API from `flipper-plugin`, so that these utility methods are available outside plugin contexts as well.
Reviewed By: timur-valiev
Differential Revision: D29661689
fbshipit-source-id: 0c0523326eeb0d9d8fbe3e03c4609327bb53596b
Summary: The inpage editor is now enabled on flipper sites {emoji:1f973}{emoji:1f973}.
Reviewed By: jknoxville
Differential Revision: D29694782
fbshipit-source-id: 7683892adfd54c2ec6644b1a0ead45124692cf8e
Summary: If no device/client was selected, no plugins would show up in the plugin status list either, which is very confusing. Changed this to always show all loaded plugins, regardless of selected device / app.
Reviewed By: nikoant
Differential Revision: D29661006
fbshipit-source-id: 720a1697df7ed17b00d5db5a72a8e2b6bb344b1e
Summary:
Change iOS to Objective C, reference which file is being updated
- Clarifies how to update iOS if using objective C for flipper network plugin
## Changelog
- renamed iOS to ObjC for flipper network plugin setup
- specified which iOS file to modify for flipper network plugin setup
Pull Request resolved: https://github.com/facebook/flipper/pull/2595
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D29662605/V2/flipper/)
Reviewed By: passy
Differential Revision: D29662605
Pulled By: nikoant
fbshipit-source-id: acdc8bba73900c19500fc91f8a275930c51d73ad
Summary:
During component cleanup broke the error handling :'). Causing plugin errors to bubble up and be handled as chrome errors instead. This caused our soft crash metric to spike in the last week.
Changelog: Fixed error handling of UI errors caused by plugins
Reviewed By: passy
Differential Revision: D29585448
fbshipit-source-id: 4c5d40b300a7b71eeb532f7be4765f742d239890
Summary:
It was requested a few times to inline simple values in the preview, to be able to quickly inspect vectors etc while inspecting elements
Implements https://github.com/facebook/flipper/issues/2551
Reviewed By: passy
Differential Revision: D29555541
fbshipit-source-id: c2c171cd7d2bf213f0cd05b5b5723918c9536025
Summary:
Fix selection problem on ManageMockResponsePanel. Currently, when the user adds new routes, the detail section continues to show the detail for the first route. Select different routes in the list does not change the detail panel. The screen is currently not doing anything on selection.
Also fixed a problem with updating on mock header names and values. Updates were not persisting if user did not exist input fields before leaving header input panel.
## Changelog
Network Plugin - Fix selection problem on ManageMockResponsePanel
Pull Request resolved: https://github.com/facebook/flipper/pull/2574
Test Plan:
Add multiple mock routes
Select various routes
Verify that detail panel shows the selected route
Reviewed By: passy
Differential Revision: D29582286
Pulled By: mweststrate
fbshipit-source-id: 6690e2262a033cdfa5afa6e6fdfacc9694244590
Summary: Found some errors in a CI failure originating from a JavaScript file. The horror!
Reviewed By: jknoxville
Differential Revision: D29549998
fbshipit-source-id: 633100ec9a446050bb0c703dcc37e9b132b17198
Summary: Apply local storage setting at a few relevant places, see parent diff
Reviewed By: cekkaewnumchai
Differential Revision: D29516498
fbshipit-source-id: 4797986e3540217e42dfb867f7d627921b97618e
Summary:
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest) from 27.0.2 to 27.0.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/releases">babel-jest's releases</a>.</em></p>
<blockquote>
<h2>27.0.5</h2>
<h3>Features</h3>
<ul>
<li><code>[jest/fake-timers]</code> Flush callbacks scheduled with <code>requestAnimationFrame</code> every 16ms when using legacy timers. (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11567">#11523</a>)</li>
<li><code>[pretty-format]</code> Use <code>globalThis</code> (with polyfill if required) to bring support for esbuild's browser bundling mode (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11569">#11569</a></li>
</ul>
<h3>Fixes</h3>
<ul>
<li><code>[jest-core]</code> Support special characters like <code>@</code>, <code>+</code> and <code>()</code> on Windows with <code>--findRelatedTests</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11548">#11548</a>)</li>
<li><code>[jest/fake-timers]</code> Do not add <code>setImmediate</code> and <code>clearImmediate</code> if they do not exist in the global environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11599">#11599</a>)</li>
<li><code>[jest/reporters]</code> Allow <code>node-notifier@10</code> as peer dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
<li><code>[jest/reporters]</code> Update <code>v8-to-istanbul</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
</ul>
<h2>27.0.4</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config, jest-resolve]</code> Pass in <code>require.resolve</code> to resolvers to resolve from correct base (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11493">#11493</a>)</li>
</ul>
<h2>27.0.3</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config]</code> <code>require.resolve</code> on default test sequencer and test environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11482">#11482</a>)</li>
<li><code>[jest-mock]</code> Fixed <code>fn</code> and <code>spyOn</code> exports (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11480">#11480</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/blob/master/CHANGELOG.md">babel-jest's changelog</a>.</em></p>
<blockquote>
<h2>27.0.5</h2>
<h3>Features</h3>
<ul>
<li><code>[jest/fake-timers]</code> Flush callbacks scheduled with <code>requestAnimationFrame</code> every 16ms when using legacy timers. (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11567">#11523</a>)</li>
<li><code>[pretty-format]</code> Use <code>globalThis</code> (with polyfill if required) to bring support for esbuild's browser bundling mode (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11569">#11569</a></li>
</ul>
<h3>Fixes</h3>
<ul>
<li><code>[jest-core]</code> Support special characters like <code>@</code>, <code>+</code> and <code>()</code> on Windows with <code>--findRelatedTests</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11548">#11548</a>)</li>
<li><code>[jest/fake-timers]</code> Do not add <code>setImmediate</code> and <code>clearImmediate</code> if they do not exist in the global environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11599">#11599</a>)</li>
<li><code>[jest/reporters]</code> Allow <code>node-notifier@10</code> as peer dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
<li><code>[jest/reporters]</code> Update <code>v8-to-istanbul</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
</ul>
<h2>27.0.4</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config, jest-resolve]</code> Pass in <code>require.resolve</code> to resolvers to resolve from correct base (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11493">#11493</a>)</li>
</ul>
<h2>27.0.3</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config]</code> <code>require.resolve</code> on default test sequencer and test environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11482">#11482</a>)</li>
<li><code>[jest-mock]</code> Fixed <code>fn</code> and <code>spyOn</code> exports (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11480">#11480</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="dafa4737dc"><code>dafa473</code></a> v27.0.5</li>
<li>See full diff in <a href="https://github.com/facebook/jest/commits/v27.0.5/packages/babel-jest">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2522
Reviewed By: priteshrnandgaonkar
Differential Revision: D29490752
Pulled By: passy
fbshipit-source-id: a71cafb4d9a4400205fe8ba84223e076943eea4c
Summary:
Going through all the patch updates and other small updates to pre-empt dependabot.
allow-large-files
Reviewed By: jknoxville
Differential Revision: D29547777
fbshipit-source-id: 86ef2408da0564049916cd96d66665074cdc23f2
Summary: Remove the duplicate function and centralise it as nikoant suggested.
Reviewed By: fabiomassimo
Differential Revision: D29548480
fbshipit-source-id: 3e931cc88198415017c557c6b7c81cb35c3f22c9
Summary: This makes it possible to save source maps to a separate folder so we can upload them from CI.
Reviewed By: nikoant
Differential Revision: D29521599
fbshipit-source-id: a137659092b7648858b97ecf5b5c60c88889517a
Summary: Dependabot complaining that the package is vulnerable so I pinned it to the latest minor/parch versions for all three packages depending on it.
Reviewed By: passy
Differential Revision: D29519029
fbshipit-source-id: 3f3476e8fc61c74f533da4038633dd23bea6d682
