Summary: Disables the picker if the selection isn't editable
Differential Revision: D24419005
fbshipit-source-id: 433229a23db7fac947f574110326f5bf0dc51bc3
Summary:
Removes the "Set current" button if the timeline isn't editable
Note that the styling does weird stuff to colors when a field is set as not editable
Differential Revision: D24419006
fbshipit-source-id: 84dcee2e04d5ed7ebb3dc0255e99d1756f195284
Summary:
Bumps [metro](https://github.com/facebook/metro) from 0.60.0 to 0.63.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro's releases</a>.</em></p>
<blockquote>
<h2>Release v0.63.0</h2>
<ul>
<li>[fix] Change initialisation logo and text from RN to Metro</li>
</ul>
<h2>Release v0.62.0</h2>
<ul>
<li>[feature] Add onBundleBuilt to ServerOptions</li>
</ul>
<h2>Release v0.61.0</h2>
<p>Contains all changes since 0.60.0:</p>
<ul>
<li>[Feature]: Add support for blockList and array of regexs</li>
<li>[Fix]: Change order of imports to be the same as in source files</li>
<li>[Feature]: Add new secureServerOptions option to runServer</li>
<li>[Feature]: Add inline-requires option</li>
<li>[PetPeeve]: Metro server => Metro</li>
</ul>
<p>See <a href="https://github.com/facebook/metro/compare/0.60.0...0.61.0">0.59.0...0.60.0</a> for a full list of changes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b9bacd51d0"><code>b9bacd5</code></a> Metro release v0.63.0</li>
<li><a href="c106b6540e"><code>c106b65</code></a> Change initialisation logo and text</li>
<li><a href="be719b29c0"><code>be719b2</code></a> remove redundant deprecated-utility setting from flow configs</li>
<li><a href="9236feba99"><code>9236feb</code></a> Turn off template literal and shorthand properties transform for hermes-canary</li>
<li><a href="6b82e8443c"><code>6b82e84</code></a> Create a <code>metro-runtime</code> module</li>
<li><a href="18883f6caa"><code>18883f6</code></a> Fix up package.json files.</li>
<li><a href="921b73e4d0"><code>921b73e</code></a> Remove autogenerated table of contents (deprecated in docusaurus v2)</li>
<li><a href="eb9b02572b"><code>eb9b025</code></a> Update configuration page with examples</li>
<li><a href="00a5a6d8d6"><code>00a5a6d</code></a> Fix troubleshooting and help pages</li>
<li><a href="c73eaf88f8"><code>c73eaf8</code></a> Update docusaurus version</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/metro/compare/v0.60.0...v0.63.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1606
Reviewed By: passy
Differential Revision: D24392103
Pulled By: nikoant
fbshipit-source-id: 6d816629f55e04852d6737f9960fa61d7e83cee8
Summary: Added `axis` property to scroll container, to make scroll work in one direction, and fill out the other one.
Reviewed By: cekkaewnumchai
Differential Revision: D24390943
fbshipit-source-id: 5767e753edfb947f43b3998e10d6cebf57f9b53b
Summary:
Restore sidebar functionality for Sandy plugins
Also needed to fix some circular dependency issues as fallout.
Reviewed By: cekkaewnumchai
Differential Revision: D24362215
fbshipit-source-id: 0a09ac35ba981322ae0793edc3aa79ffddf2ce73
Summary: When trying to refactor some components, did once again run into circular imports that cause the flipper startup sequence to fail. Added linting rules to make sure this is much less likely to happen in the future, and fixed all resulting errors
Reviewed By: nikoant
Differential Revision: D24390583
fbshipit-source-id: 9b20cf6a4d3555dc68f0069c2950dd7162b17e67
Summary:
Render a plugin list
Will add tests once the entire feature is complete
Reviewed By: cekkaewnumchai
Differential Revision: D24079897
fbshipit-source-id: db7250ff612b67ab18dfcacdcb9c44dab596933d
Summary: This diff adds the device switcher, filling the switcher with apps and devices.
Reviewed By: cekkaewnumchai
Differential Revision: D24053787
fbshipit-source-id: 4f69835a12eec90a0e5704f71c8ceed5509f61ce
Summary:
Add a GUI for the timeline of a Component based off MarkerTimeline.
It enables selecting points on the timeline, which will display their properties (arbitrary KVS). A button allows the user to select the current point of the timeline for the tree. This triggers unselection of the tree as per D24254002.
Solving re-selection isn't trivial, which is why the tree collapses on redraw too, and I believe we can live with this UX for this v1.
Reviewed By: astreet
Differential Revision: D23865369
fbshipit-source-id: 026562e71aa04b4e5e1e7cf1392d8ef140cdf43c
Summary: Recreation of D22118786, which was so old rebasing died on some lacking meta data. Lands https://github.com/facebook/flipper/pull/1256
Reviewed By: passy
Differential Revision: D24331424
fbshipit-source-id: 65fc5d8bf0242d4266e269716a319d71ce2e2826
Summary: These tests are testing the logic of building the main components in Actions tab and Sagas tab.
Reviewed By: zaxy78
Differential Revision: D24078307
fbshipit-source-id: 2929832e18f4ccbf2cf46e94c8ef08f4f947cc85
Summary:
Bumps [console-feed](https://github.com/samdenty99/console-feed) from 3.1.0 to 3.1.7.
<details>
<summary>Commits</summary>
<ul>
<li><a href="07a720b795"><code>07a720b</code></a> v3.1.7</li>
<li><a href="3ba0e2facd"><code>3ba0e2f</code></a> feat: display caught errors on properties</li>
<li><a href="e447954462"><code>e447954</code></a> Fixing the regeneratorRuntime error and React.memo error (<a href="https://github-redirect.dependabot.com/samdenty99/console-feed/issues/54">https://github.com/facebook/flipper/issues/54</a>)</li>
<li><a href="2fca873a16"><code>2fca873</code></a> update README.md</li>
<li>See full diff in <a href="https://github.com/samdenty99/console-feed/compare/v3.1.0...v3.1.7">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1587
Reviewed By: mweststrate
Differential Revision: D24250090
Pulled By: nikoant
fbshipit-source-id: 007908667af7f440787af371ae83a84f7a5488ff
Summary: In D24138822 I basically bumped all desktop deps. That was a bit too much as it affected our build infra and broke it. The problem wasn't easy to bisect so choose a smaller set of deps instead to update; everything transpile & lint related + a few well tested runtime deps.
Reviewed By: cekkaewnumchai
Differential Revision: D24161841
fbshipit-source-id: 67162efeccd05a344b229ce976102cfafe6d1099
Summary:
As designed by Vince [here](https://www.figma.com/file/4e6BMdm2SuZ1L7FSuOPQVC/Flipper?node-id=585%3A127550), this diff adds Flipper Doctor into Sandy
Note:
- The dot on Doctor icon will act similarly to `DoctorBar`
- add type to `count` for `LeftRailButton` to act like dot badge
- Get rid of padding in `antd` modal
Reviewed By: nikoant, mweststrate
Differential Revision: D24137349
fbshipit-source-id: 8ce441e0ed96083eba09d98dfd3a45ff9b5be027
Summary:
Fixes layout issue that was caused by ANT line-heights leaking into the old design.
Introduced a `.flipperlegacy_design ` class at the `root` element of Flipper, so that it is easier in the future to bail out / add overrides for certain features in the old design.
Reviewed By: priteshrnandgaonkar
Differential Revision: D24135482
fbshipit-source-id: 40091ebbde71662f2ebea66577f7b727009ca9c6
Summary:
Bumps [query-string](https://github.com/sindresorhus/query-string) from 6.13.1 to 6.13.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sindresorhus/query-string/releases">query-string's releases</a>.</em></p>
<blockquote>
<h2>v6.13.3</h2>
<ul>
<li>Fix the TypeScript type for the <code>.stringifyUrl()</code> method b15f945</li>
</ul>
<p><a href="https://github.com/sindresorhus/query-string/compare/v6.13.2...v6.13.3">https://github.com/sindresorhus/query-string/compare/v6.13.2...v6.13.3</a></p>
<h2>v6.13.2</h2>
<ul>
<li>Fix the <code>ParsedQuery</code> TypeScript typ 56d2923</li>
</ul>
<p><a href="https://github.com/sindresorhus/query-string/compare/v6.13.1...v6.13.2">https://github.com/sindresorhus/query-string/compare/v6.13.1...v6.13.2</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="eb769d201d"><code>eb769d2</code></a> 6.13.3</li>
<li><a href="b15f945fc1"><code>b15f945</code></a> Fix the TypeScript type for the <code>.stringifyUrl()</code> method</li>
<li><a href="60802a7697"><code>60802a7</code></a> 6.13.2</li>
<li><a href="56d29234a2"><code>56d2923</code></a> Fix the <code>ParsedQuery</code> TypeScript typ</li>
<li>See full diff in <a href="https://github.com/sindresorhus/query-string/compare/v6.13.1...v6.13.3">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1554
Reviewed By: cekkaewnumchai
Differential Revision: D24112939
Pulled By: mweststrate
fbshipit-source-id: 466b391e021369cd5b1e9180e1fd967baef16bca
Summary:
Changelog: Flipper can now launch iOS simulators by using `File > Launch Emulator...`
In the Sandy designs the device selector dropdown no longer shows the option to launch an emulator. So added a button to app inspect and the main menu instead.
I found it always a bit funny that we can launch android emulators, but not iOS emulators. Turns out that launching them is actually not very complex, so added capabilities to launch ios emulators
Reviewed By: jknoxville
Differential Revision: D24021737
fbshipit-source-id: c106cc2246921e008f9c808ebb811d8e333aa93b
Summary: If a new code path uses some Ant design based components in classic flipper, they are unstyled before this diff. By making sure that the ant stylesheet is loaded we can safely 'leak' new UI elements into the old UI. For example when we use toasters, dialogs etc.
Reviewed By: cekkaewnumchai
Differential Revision: D24021751
fbshipit-source-id: 3b42d28f1c75e4df441170660027562264e879dd
Summary: This is a small utility to be able to render a react element without giving it a position somewhere in the react render tree, so that dialogs can be triggered and rendered imperatively for example.
Reviewed By: cekkaewnumchai
Differential Revision: D24021752
fbshipit-source-id: 84633624c63c72a38a1b277207efba75af358a03
Summary: Added standardized dimensions for padding and gap, to encourage people to build layouts that look consistent, using for example `padv="small"`
Reviewed By: cekkaewnumchai
Differential Revision: D23961386
fbshipit-source-id: 33cd3b8974858e021a8b7d1b32f018fe3f007c63
Summary:
This diff introduces:
- ScrollContainer
- Make sure Ant Link components always open URLs externally, to avoid users needing to use electron api's
- Introduce a design systems page where people can find docs on how to organise sandy layout, and it also provides a convenient way to test layout mechanisms.
- Fixed several layout bugs found as a result of adding the design system page
In next diff:
- more convenience around organizing paddings
- making the design system accessible from the menu
Reviewed By: cekkaewnumchai
Differential Revision: D23930274
fbshipit-source-id: 4aab058d15b3391287e0e32513a5d83831448857
Summary: The same as D23729972 (0982dc06a0), but now it is also possible to reload device plugins independently.
Reviewed By: jknoxville
Differential Revision: D23960058
fbshipit-source-id: 01e0edb29a62ed173dfe6f5946466269adee453a
Summary: Show plugin version on hover to easily check the current version without opening Plugin Manager
Reviewed By: mweststrate
Differential Revision: D23730582
fbshipit-source-id: 580da6ccd38c10b13dd9c438d4cf8d6ba8719644
Summary: Implemented a way for re-loading single plugin on auto-update. This make it possible to apply update without full Flipper restart.
Reviewed By: mweststrate
Differential Revision: D23729972
fbshipit-source-id: ed30f7cde5a0537945db0b5bb6969ae8fde42cb6
Summary:
I noticed that after the typescript upgrade, I got several weird positives from ESLint (like unused parameters in a type definition, which are obviously always unused, e.g. `type onClick = (e: Event) => void`). After some investigation, it turned out these warnings are generated by eslint, but that those rules should be performaned by typescript/eslint instead. For future reference to which rules this applies:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/README.md#extension-rules
Updated the config, and while at it, fixed all warnings in our codebase, except for `react-hooks/exhaustive-deps` warnings, since those require semantic changes.
This reduces the amount of eslint warnings from 86 to 39.
Reviewed By: passy
Differential Revision: D23905630
fbshipit-source-id: 0557708fd9ec6b17840a3c191e7d3baf225bdf23
Summary:
This diff introduces the AppInspect pane.
I didn't get very fare, and it is markup only, but while at it made a bunch of other improvement in the component lib, so figured to prematurely submit to don't make the diffs too big.
Improvements
- Separated sidebar and Layout.X, as it was to much responsibility for one component, and made customization hard. Also caused state loss when switching between resizable and not.
- Setup a basic top level selection. Maybe will move it into redux in the future, but for now it suffices.
- Introduced Layout.Horizontal and `Layout.Vertical` as alternative to Ant design's space. The reason is that the latter can't stretching children, which we use quite frequently. (that is because they use wrappers to create spacing, but since we run on Electron, we can use CSS `gap` instead, which handles that much more elegantly).
- Fixed issue where gutter handle could disappear when dragging to far.
Reviewed By: cekkaewnumchai
Differential Revision: D23867265
fbshipit-source-id: e872b7f48b868e255f2c34d45e811b8ed93d0b00
Summary: May be useful for stability signals, or general bug correlation down the line.
Reviewed By: nikoant
Differential Revision: D23904843
fbshipit-source-id: ca31722b58d4657a9600fe5ce16ea3b5efd2c870
Summary:
This adds support for flipper logs in Sandy, including some theme adjustments.
Did remove storage and showing of debug messages, as I noticed it tends to crash Flipper after a while since there are so many. Also added a fixed limit of only remembering last 1000
Also converted Toolbar and button with dropdown items to Sandy.
Reviewed By: cekkaewnumchai
Differential Revision: D23824528
fbshipit-source-id: b89d1182d4f14682251dbb482d93c2c009ddc7a4
Summary:
allow-large-files
Updated to typescript 4. Note that this is no new major, the way TS numbers is that 4.0 is simply the number after 3.9 (so they refuse to use 3.10).
Primarily reason is that it allows us to use `/** deprecated */`. although there are definitely more interesting improvements
Reviewed By: passy, nikoant
Differential Revision: D23869445
fbshipit-source-id: 54e251b398b8698d9b18898ce66c3203b32aa356
Summary:
Per title
~~Note: `useStore.tsx` is copied from D23783500 (e7fdd8332d). This should be merged correctly in case the diff is landed before.~~
Reviewed By: mweststrate
Differential Revision: D23784302
fbshipit-source-id: adb5678c1b2614e3af4278889529c3fa79335bef
Summary:
Typography on Sandy! The designed typography is [here in Figma](https://www.figma.com/file/4e6BMdm2SuZ1L7FSuOPQVC/Flipper?node-id=238%3A172)
Current deflects
- cannot find component for 'body - small' and 'meta'
- don't know how to set 'link secondary hover' as designed
Reviewed By: mweststrate
Differential Revision: D23869256
fbshipit-source-id: efb1475749cebad529b502458d1b15bd445bb346
Summary:
We're seeing some CSR mismatches when they aren't expected. Adding logging to print out what is being found, to see if it's any OS-specific encoding issues or something like that, or completely different CSRs, etc.
URL encoded in case there are differences in non printable characters.
Reviewed By: nikoant
Differential Revision: D23867267
fbshipit-source-id: f406a396c808687b6b84561eb1def61b565aee34
Summary: The Flipper `Button` component now uses Ant.design under the hood if available. This is detected using context
Reviewed By: cekkaewnumchai
Differential Revision: D23813166
fbshipit-source-id: 489a34d55c0b69d7b5bcd30f4275b89d0bb22c0d
Summary: Converted Buttons to hooks, to make it easier to use context in the future. No further changes.
Reviewed By: cekkaewnumchai
Differential Revision: D23812921
fbshipit-source-id: 3739ad49e734dbe4d903a23d58da7cc267f6e109
