Summary:
Since Android Studio is technically not required, I made this check optional.
Though, these steps will gurantee that android env will work for an engineer who opened flipper for the first time
Reviewed By: lblasa
Differential Revision: D51267272
fbshipit-source-id: f30e58f322ea080b00a27ae86b871df2b39e1bb9
Summary:
When flipper starts it writes to both env vars the value from settings. This is needed for subprocesses to have access to them.
The problem with the check for both env vars is
- In prod environment applications does not have access to them
- In dev, when developers launch flipper from terminal (`yarn run flipper-server`) it picks up these env vars if they are set which can cause different behaviour in dev and prod
To make flipper work more deterministic, for users and us. I removed this check and now we always write to these env vars what the user has provided in flipper settings or the default.
Reviewed By: lblasa
Differential Revision: D51266495
fbshipit-source-id: cf3adfd4ba83a733a30b5b0b29c270b32ff3a61a
Summary:
The previous logic aimed to reuse an existing server during bootstrap if the launched version was higher than the running one. This is no longer required or wanted.
## Risk assessment: LOW
### Rationale
It is extremely rare to launch Flipper whilst already having another instance running. This can happen during development, but it is extremely rare in production.
Launcher (singleton) launches Server (singleton).
Launcher can be executed multiple times and this will not create newer server instances.
If anything, if we are unable to kill any other instance, whatever that may be, continue. This is to cover the cases where a shutdown may have been acknowledged but the process is still shutting down.
Reviewed By: antonk52
Differential Revision: D51232901
fbshipit-source-id: 8b8b85f4bac68f5670b1878e827871f78dc68999
Summary:
The single value == / contains are covered by the setlike oper /ators.
Less operators is better as less overwhelming. Plus with the group operators you can add futher options or'ed togther which is a complain from the user.
Reviewed By: aigoncharov
Differential Revision: D51255253
fbshipit-source-id: 72f909319fd3d8034ebe4725a5a5254ecfeb074b
Make as manything as inferred enum as possible
changelog: [Logs] Improve power search config to populate dropdown for level, PID & Tag
Reviewed By: aigoncharov
Differential Revision: D51199644
fbshipit-source-id: 383b61abca5d91a8e318bbfb1aac7d3852074167
Summary:
Current order is confusion, the new order better reflects order at which users gets started with iOS
1. Install Xcode
2. Point Xcode-select at most recent xcode version
3. Install SDK
4. Accept Xcode SDK license
5. check idb health
Reviewed By: lblasa
Differential Revision: D51202202
fbshipit-source-id: da39acf7ef325889c2288b3941cef0ca803356cd
Summary: All functionality was about selecting plugins
Reviewed By: lblasa
Differential Revision: D51200129
fbshipit-source-id: edc33c2b989eabec2ca4a7e285f92c50950977ed
Summary: Error thrown from server is serialiased that is a string, not instance of Error
Reviewed By: LukeDefeo
Differential Revision: D51201870
fbshipit-source-id: 833818789a50a21d3d27e0388635e0e2b7470c9d
Summary:
As I was setting up a new mac I had to change this setting in flipper settings.
From a few android people that I've spoken to no one could answer me if the old one is still used.
Ideally we should infer this during the first time flipper starts
- `/opt/android_sdk` current default
- `$HOME/Library/Android/sdk` adb from Android Studio
- `$HOME/fbsource/third-party/toolchains/android-sdk` adb that is always available in fbsource
Reviewed By: lblasa
Differential Revision: D51120929
fbshipit-source-id: edb2a58b9c9f37465ea2fc5493975dd427d5523b
Summary:
Auth token used be injected in the manifest file. Instead, have the server injected into the main HTML page.
The main driver to this change are:
- Simplify
- There are instances in which for some reason reading/writing the token from the manifest fails. This will address that problem.
Reviewed By: lblasa
Differential Revision: D51160521
fbshipit-source-id: 4626fd8f56bc8b61182a53a5d9cf5acad1e723bc
Summary: It is quite cumbersome to list all of the operators. Much simpler to use a predefined set of power search operators we set up for each specific filed type
Reviewed By: lblasa
Differential Revision: D51116029
fbshipit-source-id: 5dd0b7f4176097109666107dfc3cab996379b818
Summary:
It does not make too much sense to keep the unknown value conversion behind a flag. It is relatively cheap. Let's do it for all strings.
Also, let's extend the list of default string operators
Reviewed By: lblasa
Differential Revision: D51115573
fbshipit-source-id: a62c08a90d8ddf6f23f59412c3fd981e19225e47
Summary: Document the new release flow that does no longer involve local builds.
Reviewed By: antonk52
Differential Revision: D51115563
fbshipit-source-id: 0c518e51dba64b2325047d6b1e485216e48d9777
Summary:
If after 5 hours there are no connected clients, shutdown the server.
This is to prevent cases whereas the long-lived instance makes users use stale versions of Flipper if Flipper stays indefinitely running in the background.
Reviewed By: passy
Differential Revision: D51111926
fbshipit-source-id: 4c38e392cf8a6a4fb840bffdea92c0b0314aefb9
Summary:
Previously the render function was selecting the data from the paylaod object, this mean what was on screen and waht powersearch saw was diffferent.
Now we supply a dotted key path and remove this from render, power search operator also uses this dotted key path so the search works
changelog: UIdebugger added powersearch operators to Framework event table
Reviewed By: aigoncharov
Differential Revision: D51113095
fbshipit-source-id: 3c951c2a8a7a0a35e0aa79a194b979b699f83008
Summary:
It was hard-coded to always open the first time.
This allows to run the server on debug mode without opening UI.
Reviewed By: antonk52
Differential Revision: D51115746
fbshipit-source-id: 9467f0fbff45987247a2bb3bf5eb1aa578de1913
Summary: Expose an endpoint to open Flipper UI. This will be used by the Flipper Server Cocoa app to open the UI.
Reviewed By: antonk52
Differential Revision: D51115327
fbshipit-source-id: 1ab1c32d93945cf8d75b145905983738331a6468
Summary:
As to not conflict with non-electron installations, this will ensure the product name and app id matches the installation.
By doing this, both Flipper installations can co-exist, which I think is desirable.
Reviewed By: antonk52
Differential Revision: D51078955
fbshipit-source-id: fabaa6eb2a45ac542297b0456a09e938a2ec2e0b
Summary:
## Context
https://fb.workplace.com/groups/flippersupport/posts/1722856878194963
## Changes
* Add a worker plugin that takes modules suffixed with `?worker`, bundles them, treats them as web workers, and returns a function as a default export that instanitates a new worker
Reviewed By: antonk52
Differential Revision: D51059224
fbshipit-source-id: cef89486f7a2d5b8ce38354df4a5749271a6c41d
Summary:
Some features of bloks do not work off vpn.
Until we figure out how to make them off vpn
Reviewed By: LukeDefeo
Differential Revision: D51076469
fbshipit-source-id: c83d96e89d33d245845312b39928a7460a235217
