Summary: This change only adds the PWA as capable of handling files with the ".flipper" extension.
Reviewed By: aigoncharov
Differential Revision: D48353437
fbshipit-source-id: fd78942ac4dffb7d26d5ca5be826290018465b93
Summary: These two functions were not enabled for the browser experience.
Reviewed By: antonk52
Differential Revision: D48315991
fbshipit-source-id: 2944a386d9de8a06b043305e7ceb8a6c41e11209
Summary: Implementation was missing for the browser. This provides a default implementation.
Reviewed By: aigoncharov
Differential Revision: D48311198
fbshipit-source-id: fd067600f571234e0fbccfb90853b62f175ff8fb
Summary: Not really a connectivity related log, so removed [conn] from it.
Reviewed By: passy
Differential Revision: D48266546
fbshipit-source-id: e384301d6301940366b594b4bc612349cc2264ce
Summary: Combine the two used commands as will make things easier for our users.
Reviewed By: passy
Differential Revision: D48266474
fbshipit-source-id: 1ee5c568ff001dc5ba3f11e21b09a2a6ab430ac7
Summary: Also removing topLevelSelection as it is no longer used in flipper
Reviewed By: aigoncharov
Differential Revision: D48069386
fbshipit-source-id: 6e4cdd6aab67d2cd30ac1884118703520125bf84
Summary: This is a continuation of flipper redesign. Next diff will mov notification and connectivity into modals as well
Reviewed By: LukeDefeo
Differential Revision: D48066573
fbshipit-source-id: 3b4a22462221d8da13b07ad1738e05de849e00c4
Summary: Feedback from support group said it wasnt clear when recording was on
Reviewed By: antonk52
Differential Revision: D48027414
fbshipit-source-id: db61a9806da285610e8f550ceff5af4d7b7acb47
Summary: Add an option to kill the debugging bridge directly within Flipper.
Reviewed By: antonk52
Differential Revision: D47990786
fbshipit-source-id: 30cd8ca1d55e8b2ade03700d884e5d849a2dadbf
Summary:
The previous recommendation doesn't always holds true. There are reported cases in which a process is listening to the specified port yet is not being listed by the lsof command as advised.
The command below seems to work better.
sudo lsof -i :52342
Reviewed By: antonk52
Differential Revision: D47989269
fbshipit-source-id: ea216de00ef6edc90de58e9d3fe3a0579a171fea
Summary: STDOUT and STDERR can overflow the panel. This change creates a container for these two panels which should keep content within their boundaries.
Reviewed By: antonk52
Differential Revision: D47952711
fbshipit-source-id: 394390ae6b6a12329fe0eea1fc9948a7261b11bf
Summary: Sidebar should only show if the entry requires one. In this case, only shell commands have details to be displayed in the sidebar.
Reviewed By: antonk52
Differential Revision: D47952535
fbshipit-source-id: ae657032504dbb80900a534d2d357c9316b67cd9
Summary: This is the most basic visualiser for command details.
Reviewed By: antonk52
Differential Revision: D47917006
fbshipit-source-id: 7654a3c6e416346548b45dbc72ca4a1838bea787
Summary: It's troubleshooting in general, not only connectivity. So rename and refactor accordingly.
Reviewed By: antonk52
Differential Revision: D47914411
fbshipit-source-id: 658563bfd33427f11fe9f7660b0985fc3f013866
Summary: Reuse the function that was refactored on previous diff.
Reviewed By: antonk52
Differential Revision: D47873752
fbshipit-source-id: 71e12cd34d1826080487297e308450cb2a2a5c26
Summary:
Extract notification creation from inside the existing function.
This will be reused to display connection notifications from the server event.
Reviewed By: antonk52
Differential Revision: D47873728
fbshipit-source-id: c01dc93dfef28135ecf7e77e92d4d517af082125
Summary:
There's a generic notification server event.
This change introduces a new notification server event dedicated for connection troubleshoot.
The difference is, this notification will have a button to troubleshoot the issue. Additionally, in the future, we may even be able to add a payload so that we can troubleshoot the exact problem.
Reviewed By: antonk52
Differential Revision: D47873697
fbshipit-source-id: 28843a08836d0054909f6b9ab7a88b14b8a1b868
Summary: Add key for server error notifications as to prevent duplicates.
Reviewed By: antonk52
Differential Revision: D47869240
fbshipit-source-id: 7c826ab07a8f92bd053200786ed990ad78bbfa67
Summary: If the notification is shown, allow engineers to switch to the connectivity troubleshooting view as it may highlight where the problem is.
Reviewed By: antonk52
Differential Revision: D47869154
fbshipit-source-id: f4154bb230d891dc4ac108b5acbe7e6541ffed1a
Summary:
The intention was to fine tune everything, internally, before making it available.
Because we can immediately benefit from having it, for troubleshooting, then remove the GK
Reviewed By: LukeDefeo, antonk52
Differential Revision: D47868827
fbshipit-source-id: 4d6356081a4abeea8912f20aad065523e7183da8
Summary:
Intention of this change is to simplify and standardise the way top level selection is done.
Top level selection is now part of the state, and thus setting it is done in the reducer instead.
Reviewed By: antonk52
Differential Revision: D47844742
fbshipit-source-id: 8e5aad8975f0046b85098b988cca40228316c249
Summary: Add a key such that the same notification does not appear again for the same device/app.
Reviewed By: antonk52
Differential Revision: D47835045
fbshipit-source-id: 78237b4102aa199ebea23b7c5726b567fc4de91e
Summary: Refactor was going to happen, but it was required at this stage as to fix a selection problem.
Reviewed By: LukeDefeo
Differential Revision: D47831239
fbshipit-source-id: 87ce6250721f6d3df3e826e779409625ddc85660
Summary: Once an item is selected, more details can be shown to our users.
Reviewed By: antonk52
Differential Revision: D47797390
fbshipit-source-id: 1bf98f81df32d103f7c0fc332f819507dcf84cc2
Summary:
With a lot of virtual devices it can be confusing to remember which one contains your builds. This allows user to favourite certain ones to avoid this
Changelog: Added ability to favourite emulators / simulators in the launch virtual devices dialog
Reviewed By: mweststrate
Differential Revision: D47724521
fbshipit-source-id: aaec56608ad6ba23634797315f6f9fd77fc8b258
Summary:
1. fixed state when no connectivity by using a disabled button, now its styled correctly, (before it was tiny)
2. No need to show the user profile button as its own icon since log in is forced by flipper, so move log out into the more menu
Reviewed By: mweststrate
Differential Revision: D47720740
fbshipit-source-id: c7531a2a2897627c2627080179fd77adfed5c30c
Summary:
1. improved the disabled state, no longer shows persistant border
2. made the right sidebar button always visible again since the disabled state is less distracting
3. Made the toggle state be on when the side bar is open
4. Fixed issue where where it would say toggled when sidebar not visible
5. Shortened the names to be less verbose
Reviewed By: mweststrate
Differential Revision: D47720739
fbshipit-source-id: df27e688c7a66e8dee07c4db675851c4355b41db
Summary: Similar treatment to troubleshoot problem
Reviewed By: lblasa
Differential Revision: D47720741
fbshipit-source-id: 6875988a9a0763cb4ed473d6e8522581fc27bef3
Summary: Timeout exceptions while connection to new clients where rethrown but catched nowhere. Probably this warning should be handled more gracefully, but this at least moves it to warn rather than spawning our monitoring on transient issues
Reviewed By: passy, antonk52
Differential Revision: D47665050
fbshipit-source-id: ad51808d12e9f4de318d4426933ecb3787839b7c
Summary:
The Setup Doctor screen was hard-set into a modal window. Instead, make this an optional that defaults to yes.
This will allow the usage of the screen in non-modal container.
Reviewed By: antonk52
Differential Revision: D47629528
fbshipit-source-id: c5248df1358f1b14775b90c9bf12fd63b8885caf
Summary:
^
Not all selections have a left sidebar. If the current selection doesn't have one, it doesn't make sense to have the toggle sidebar button, so hide it.
Reviewed By: LukeDefeo
Differential Revision: D47593545
fbshipit-source-id: 940d59536e26bd1ab341d2038df431c67e0a5442
