Summary:
There's a generic notification server event.
This change introduces a new notification server event dedicated for connection troubleshoot.
The difference is, this notification will have a button to troubleshoot the issue. Additionally, in the future, we may even be able to add a payload so that we can troubleshoot the exact problem.
Reviewed By: antonk52
Differential Revision: D47873697
fbshipit-source-id: 28843a08836d0054909f6b9ab7a88b14b8a1b868
Summary: Add key for server error notifications as to prevent duplicates.
Reviewed By: antonk52
Differential Revision: D47869240
fbshipit-source-id: 7c826ab07a8f92bd053200786ed990ad78bbfa67
Summary: If the notification is shown, allow engineers to switch to the connectivity troubleshooting view as it may highlight where the problem is.
Reviewed By: antonk52
Differential Revision: D47869154
fbshipit-source-id: f4154bb230d891dc4ac108b5acbe7e6541ffed1a
Summary:
The intention was to fine tune everything, internally, before making it available.
Because we can immediately benefit from having it, for troubleshooting, then remove the GK
Reviewed By: LukeDefeo, antonk52
Differential Revision: D47868827
fbshipit-source-id: 4d6356081a4abeea8912f20aad065523e7183da8
Summary:
Intention of this change is to simplify and standardise the way top level selection is done.
Top level selection is now part of the state, and thus setting it is done in the reducer instead.
Reviewed By: antonk52
Differential Revision: D47844742
fbshipit-source-id: 8e5aad8975f0046b85098b988cca40228316c249
Summary: Add a key such that the same notification does not appear again for the same device/app.
Reviewed By: antonk52
Differential Revision: D47835045
fbshipit-source-id: 78237b4102aa199ebea23b7c5726b567fc4de91e
Summary: This is needed on Windows, otherwise it just throws an error when using spawn.
Reviewed By: passy
Differential Revision: D47832379
fbshipit-source-id: c1a5094c2e72683a695949cd99b2a1054f01aced
Summary: Just adds a function stub that will add the necessary run script for windows.
Reviewed By: passy
Differential Revision: D47627532
fbshipit-source-id: 09b6a203c2a5def20e586b5753d95ca58797852a
Summary: Refactor was going to happen, but it was required at this stage as to fix a selection problem.
Reviewed By: LukeDefeo
Differential Revision: D47831239
fbshipit-source-id: 87ce6250721f6d3df3e826e779409625ddc85660
Summary:
This diff switches to `softprops/action-gh-release@v0.1.15` for creating a release since `actions/create-release` is *archived* and is **NOT maintained**.
### Ref.:
- `actions/create-release` archived and not maintained notice: https://github.com/actions/create-release
- `softprops/action-gh-release@v0.1.15` changelog: https://github.com/softprops/action-gh-release/releases/tag/v0.1.15
## Changelog:
[GENERAL] [SECURITY] - [Actions] `release` - Switch to `softprops/action-gh-release@v0.1.15` to create a release
Pull Request resolved: https://github.com/facebook/flipper/pull/4870
Test Plan: - Workflow should run and work as usual.
Reviewed By: lblasa
Differential Revision: D47829486
Pulled By: passy
fbshipit-source-id: fea3b9ed7b76736bcc85d6bd1fa43a14d10a8763
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4971
Reviewed By: lblasa
Differential Revision: D47829475
Pulled By: passy
fbshipit-source-id: 6e897ecb76776be3b36de590fe76afa233e2e435
Summary: Once an item is selected, more details can be shown to our users.
Reviewed By: antonk52
Differential Revision: D47797390
fbshipit-source-id: 1bf98f81df32d103f7c0fc332f819507dcf84cc2
Summary:
Some commands are run without a ClientQuery i.e. fetching devices.
Nevertheless, this can be provide insights when problems take place.
Reviewed By: antonk52
Differential Revision: D47795358
fbshipit-source-id: 0b7dc34475ae061f1b72843a087a798d305ed1c8
Summary:
UI Debugger initialisation is defined in two places. Internally, done inside:
fb/FlipperKitUIDebuggerPluginInit.mm
OSS:
FlipperKitUIDebuggerPluginInit.mm
Contents of `fb/` directory are not synced in OSS. OSS file is excluded internally as it doesn't use the XPlugins.
Reviewed By: aigoncharov
Differential Revision: D47759035
fbshipit-source-id: 3578be076525f05b530a0d129b5c37e48572d58e
Summary: This is never identity hash code for declarative framework so this default impl is just a source of bugs, including this one.
Reviewed By: lblasa
Differential Revision: D47754625
fbshipit-source-id: 470aab084c82fa847f25116342021a79d52b7c67
Summary:
Use the application key window bounds if possible.
In the case where the application is not using the entire screen,
like in Split View on an iPad, the running application is
not using the entire screen thus the snapshot stretches to
fill the screen size which is incorrect.
Reviewed By: LukeDefeo
Differential Revision: D47793033
fbshipit-source-id: d6c7932d35bad13752713772d078f94bad530b09
Summary:
Now that we have panels for tree visualiser separately we can have visualiser specific controls. There is a dedicated button for focus mode which should make that more discoverable and a better implementation of target mode which uses a slider. This has several benefits:
1. more discoverable
2. more obvious what is going on with the text prompts and a real slider control instead of mouse enter
3. there is no context menu getting in the way of the content
Changelog: UIDebugger Add visualizer target mode feature for selecting views in the z stack easily
Changelog: UIDebugger Add FocusMode button to visualiser toolbar
Reviewed By: mweststrate
Differential Revision: D47671658
fbshipit-source-id: 6f657f9d417280627457624660b934c9898cda58
Summary: This isnt very discoverable and we can put functionality in the toolbar
Reviewed By: mweststrate
Differential Revision: D47670683
fbshipit-source-id: 8426ba05135f9a56f0a0952e94ac80480cd30a48
Summary: This looks a lot neater and allows us to have separate dedicated visualiser header
Reviewed By: mweststrate
Differential Revision: D47626867
fbshipit-source-id: 843721853e0ff88837afbb9bf3f510a908160d12
Summary:
1. Add indent guidess to all tree depths
2. Monospaced font
3. cleaned up alignment of icons
4. Gave everything a bit more space to breathe
Changelog: UI Debugger Tree UI refresh, added indent guides and fixed alignment
Reviewed By: mweststrate
Differential Revision: D47626869
fbshipit-source-id: e4509621cda6c254f7dd5a7ec9b99c13efb577f4
Summary:
The old layout plugins target mode would ask you which view you wanted to select when you clicked, the visualiser currently chooses for you based on size of the element.
Sometimes this isnt what you want so I have added a context menu with all the intersecting nodes from which you can select or focus
Reviewed By: lblasa
Differential Revision: D47589789
fbshipit-source-id: 9c9d0d7587b830aa72089267d9bcf2b687142574
Summary:
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.171 to 1.0.175.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p>
<blockquote>
<h2>v1.0.175</h2>
<ul>
<li>Restore missing LICENSE files in serde_derive crate (<a href="https://redirect.github.com/serde-rs/serde/issues/2527">https://github.com/facebook/flipper/issues/2527</a>, thanks <a href="https://github.com/ankane"><code>@ankane</code></a>)</li>
</ul>
<h2>v1.0.174</h2>
<ul>
<li>Documentation improvements</li>
</ul>
<h2>v1.0.173</h2>
<ul>
<li>Fix missing trait implementations when using serde derive macro on a macro-generated data structure, such as via the <code>bitflags</code> crate (<a href="https://redirect.github.com/serde-rs/serde/issues/2516">https://github.com/facebook/flipper/issues/2516</a>)</li>
</ul>
<h2>v1.0.172</h2>
<ul>
<li>Experiment with precompiling the serde_derive macros to reduce build time (<a href="https://redirect.github.com/serde-rs/serde/issues/2514">https://github.com/facebook/flipper/issues/2514</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="6140b6f527"><code>6140b6f</code></a> Release 1.0.175</li>
<li><a href="4cabc9f293"><code>4cabc9f</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2527">https://github.com/facebook/flipper/issues/2527</a> from ankane/license-files</li>
<li><a href="aa7c6345a4"><code>aa7c634</code></a> Include license files in serde_derive crate</li>
<li><a href="27414c90a8"><code>27414c9</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2522">https://github.com/facebook/flipper/issues/2522</a> from serde-rs/leak</li>
<li><a href="50e2f4b213"><code>50e2f4b</code></a> Leak all memory allocated during macro expansion</li>
<li><a href="22be673beb"><code>22be673</code></a> Release 1.0.174</li>
<li><a href="166c89fabf"><code>166c89f</code></a> Opt in to generate-link-to-definition when building on docs.rs</li>
<li><a href="6e0b13eedb"><code>6e0b13e</code></a> Release 1.0.173</li>
<li><a href="7e8f978ca9"><code>7e8f978</code></a> Handle $crate special case</li>
<li><a href="6c0e838a7c"><code>6c0e838</code></a> Always consider empty output to be unsuccessful</li>
<li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.171...v1.0.175">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4964
Reviewed By: aigoncharov
Differential Revision: D47755906
Pulled By: passy
fbshipit-source-id: 9724e43e14ce3f1b3d413dea27cbe6a524b5a203
Summary:
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.9.23 to 0.9.25.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p>
<blockquote>
<h2>0.9.25</h2>
<ul>
<li>Serialize using quoted style around scalar that has digits with leading zero (<a href="https://redirect.github.com/dtolnay/serde-yaml/issues/347">https://github.com/facebook/flipper/issues/347</a>)</li>
</ul>
<h2>0.9.24</h2>
<ul>
<li>Implement FromStr for serde_yaml::Number (<a href="https://redirect.github.com/dtolnay/serde-yaml/issues/381">https://github.com/facebook/flipper/issues/381</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="f26dac4b3a"><code>f26dac4</code></a> Release 0.9.25</li>
<li><a href="fda96c77eb"><code>fda96c7</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/serde-yaml/issues/383">https://github.com/facebook/flipper/issues/383</a> from dtolnay/leadingzero</li>
<li><a href="a38768fc52"><code>a38768f</code></a> Quoted style for string consisting of digits with leading zero</li>
<li><a href="cd1fd90f23"><code>cd1fd90</code></a> Add test of quoting of number with leading zeros</li>
<li><a href="c1b1eac970"><code>c1b1eac</code></a> Resolve incorrect_partial_ord_impl_on_ord_type clippy lint</li>
<li><a href="da99545d4b"><code>da99545</code></a> Release 0.9.24</li>
<li><a href="053af6fefc"><code>053af6f</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/serde-yaml/issues/382">https://github.com/facebook/flipper/issues/382</a> from dtolnay/parsenumber</li>
<li><a href="3c681651e1"><code>3c68165</code></a> Add test of Number parsing</li>
<li><a href="610d7b290d"><code>610d7b2</code></a> Implement FromStr for serde_yaml::Number</li>
<li>See full diff in <a href="https://github.com/dtolnay/serde-yaml/compare/0.9.23...0.9.25">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4963
Reviewed By: aigoncharov
Differential Revision: D47755910
Pulled By: passy
fbshipit-source-id: 6a74aabf563a33935bdfe8952ae5e77be767ce42
