Commit Graph

5534 Commits

Author SHA1 Message Date
Pascal Hartig
623a505284 Downgrade app-builder to fix build
Summary: Uggh, a patch release that introduces a breaking change: The minimum Node version. https://github.com/facebook/flipper/runs/2667073574

Reviewed By: nikoant

Differential Revision: D28681220

fbshipit-source-id: d41e8b701ceca0703d4ec19da9d4e472fb54ae0d
2021-05-25 10:39:48 -07:00
Pascal Hartig
bca8030df8 Dep bump
Summary:
Daily bump keeps the yada yada. Only patch updates or safe ones.

allow-large-files

Reviewed By: nikoant

Differential Revision: D28636754

fbshipit-source-id: d2a8c7fc0779bea30ff6532ae076694ce0e1fffa
2021-05-25 08:53:36 -07:00
Pascal Hartig
526e0ddd01 Demote console.error on check fail
Summary:
We use exception for control flow here which isn't great
but we shouldn't log naked errors when a check fails.

Reviewed By: nikoant

Differential Revision: D28645636

fbshipit-source-id: db8c7b1457883acc767ac850f015f6b35a41730b
2021-05-25 04:09:43 -07:00
Michel Weststrate
d9c986fcf8 Fix test flakiness by using jest timers
Summary: Some tests were occasionally flaky, by emulating delays, time variation should no longer influence tests.

Reviewed By: passy

Differential Revision: D28572946

fbshipit-source-id: f4134a6509a0ec0be2e8f36e5623c4882b5531b8
2021-05-25 02:22:21 -07:00
Anton Nikolaev
8d508c8634 Build script updated to allow specifying directory with default plugins
Summary: This change allows passing a directory containing plugin packages to include them into Flipper distributive. This is used by release command on Sandcastle (see D28626715).

Reviewed By: passy

Differential Revision: D28628425

fbshipit-source-id: 9c5d7527721f99b43991bace0b5e2f3a4ede0d13
2021-05-25 01:41:57 -07:00
Flipper Bot
313baafded Flipper Snapshot Bump: v0.91.3-SNAPSHOT
Summary: Releasing snapshot version 0.91.3-SNAPSHOT

Reviewed By: nikoant

Differential Revision: D28638215

fbshipit-source-id: a6c05fd37bcce58ad139684247e3bd65713a81e2
2021-05-24 06:52:10 -07:00
Flipper Bot
0305947ca2 Flipper Release: v0.91.2
Summary: Releasing version 0.91.2

Reviewed By: nikoant

Differential Revision: D28638216

fbshipit-source-id: 282edcbfb954e65f4a8559445856b01929578619
2021-05-24 06:52:10 -07:00
Anton Nikolaev
d57c4d687c Fix build-plugin script
Summary: This diff fixes "build-plugin" script which is failing for fb-internal plugins, because "fb/package.json" not exist. Because of that release of "fb/mobilebuilds" plugin failed recently: https://www.internalfb.com/intern/sandcastle/job/13510799309874638.

Reviewed By: passy

Differential Revision: D28624924

fbshipit-source-id: e00da98cfef992f5d49045afc9d404764a0d13ac
2021-05-24 02:46:42 -07:00
Pascal Hartig
4dd3b3e8ba Dep bump
Summary: A daily bump keeps the dependabot away.

Reviewed By: fabiomassimo

Differential Revision: D28602154

fbshipit-source-id: 058789faaa3d00a60273c1944bef0dbebd591946
2021-05-23 11:40:52 -07:00
Anton Nikolaev
76701565ac Cleanup public plugins metadata
Summary: Now we support splitting metadata to public and fb-internal (see the previous diff in the stack), and this diff actually cleans up all public plugin metadata from fb-specific things.

Reviewed By: passy

Differential Revision: D28568413

fbshipit-source-id: eae699eabaae489c4bcfbfcc407c3bef42bfd338
2021-05-21 07:15:28 -07:00
Anton Nikolaev
5ae104cc59 Merge plugin package.json from public and fb-internal parts
Summary: Allow splitting package.json to public one and fb-internal one located in "fb/package.json". When plugin is packaged, fields in package.json are overwritten by fields from "fb/package.json" if they exist. This give us a way to specify additional metadata which only make sense internally (e.g. oncall and internal links to docs and support).

Reviewed By: mweststrate

Differential Revision: D28542101

fbshipit-source-id: c0167461897a994e5731aaf0fe625de052eda864
2021-05-21 07:15:28 -07:00
Michel Weststrate
d680a2807f Bumped deps / pods to latest (0.91.1), re-enabled i386
Summary:
Per title

After landing this and verifying in CI, will apply those version bumps to RN itself: https://github.com/facebook/react-native/pull/31562, and remove the custom overrides in the future

Reviewed By: passy

Differential Revision: D28573552

fbshipit-source-id: e52c40f4751f933f17312aac2aacfd695f554a3f
2021-05-21 03:54:39 -07:00
Andres Suarez
39172f6413 Apply clang-format
Reviewed By: igorsugak

Differential Revision: D28477074

fbshipit-source-id: f15dfc45b9fb30c661ebe2899cd882676d0fdf2a
2021-05-20 21:23:41 -07:00
Pascal Hartig
bf32eca8fc Remove console.error for login
Summary:
This is in fact correctly handled, shown in the UI and we don't
need a task if someone pastes the wrong token.

Reviewed By: priteshrnandgaonkar

Differential Revision: D28569896

fbshipit-source-id: 689bff06b4a488be7ad4c58eb4f2e91018da31cf
2021-05-20 08:55:55 -07:00
dependabot[bot]
550305ee99 Bump ansi-to-html from 0.6.14 to 0.6.15 in /flipper-js-client-sdk (#2318)
Summary:
Bumps [ansi-to-html](https://github.com/rburns/ansi-to-html) from 0.6.14 to 0.6.15.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/rburns/ansi-to-html/commits">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ansi-to-html&package-manager=npm_and_yarn&previous-version=0.6.14&new-version=0.6.15)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2318

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474718

Pulled By: mweststrate

fbshipit-source-id: e153a70fc3c1e85c62dec9bb752fa8171fba3c18
2021-05-20 07:42:26 -07:00
dependabot[bot]
7020c894eb Bump @typescript-eslint/parser from 4.22.1 to 4.23.0 in /flipper-js-client-sdk (#2321)
Summary:
Bumps [typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.22.1 to 4.23.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@​typescript-eslint/parser</code>'s releases</a>.</em></p>
<blockquote>
<h2>v4.23.0</h2>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.22.1...v4.23.0">4.23.0</a> (2021-05-10)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>scope-manager:</strong> fix visiting TSAsExpression in assignment (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3355">#3355</a>) (<a href="87521a0241">87521a0</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>experimental-utils:</strong> Include <code>getCwd()</code> in <code>RuleContext</code> type (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3308">#3308</a>) (<a href="2b75c11d69">2b75c11</a>)</li>
<li>refactor to split AST specification out as its own module (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/2911">#2911</a>) (<a href="25ea953cc6">25ea953</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md"><code>@​typescript-eslint/parser</code>'s changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.22.1...v4.23.0">4.23.0</a> (2021-05-10)</h1>
<h3>Features</h3>
<ul>
<li>refactor to split AST specification out as its own module (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/2911">#2911</a>) (<a href="25ea953cc6">25ea953</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="18d8151e54"><code>18d8151</code></a> chore: publish v4.23.0</li>
<li><a href="25ea953cc6"><code>25ea953</code></a> feat: refactor to split AST specification out as its own module (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/2911">#2911</a>)</li>
<li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v4.23.0/packages/parser">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@typescript-eslint/parser&package-manager=npm_and_yarn&previous-version=4.22.1&new-version=4.23.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2321

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474731

Pulled By: mweststrate

fbshipit-source-id: 024f6b7be85dad7c4645e966ca7a308fd98c8b85
2021-05-20 07:42:26 -07:00
dependabot[bot]
4174387488 Bump @typescript-eslint/eslint-plugin from 4.22.1 to 4.23.0 in /desktop (#2330)
Summary:
Bumps [typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.22.1 to 4.23.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@​typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p>
<blockquote>
<h2>v4.23.0</h2>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.22.1...v4.23.0">4.23.0</a> (2021-05-10)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>scope-manager:</strong> fix visiting TSAsExpression in assignment (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3355">#3355</a>) (<a href="87521a0241">87521a0</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>experimental-utils:</strong> Include <code>getCwd()</code> in <code>RuleContext</code> type (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3308">#3308</a>) (<a href="2b75c11d69">2b75c11</a>)</li>
<li>refactor to split AST specification out as its own module (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/2911">#2911</a>) (<a href="25ea953cc6">25ea953</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md"><code>@​typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.22.1...v4.23.0">4.23.0</a> (2021-05-10)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>scope-manager:</strong> fix visiting TSAsExpression in assignment (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3355">#3355</a>) (<a href="87521a0241">87521a0</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>refactor to split AST specification out as its own module (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/2911">#2911</a>) (<a href="25ea953cc6">25ea953</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="18d8151e54"><code>18d8151</code></a> chore: publish v4.23.0</li>
<li><a href="87521a0241"><code>87521a0</code></a> fix(scope-manager): fix visiting TSAsExpression in assignment (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/3355">#3355</a>)</li>
<li><a href="25ea953cc6"><code>25ea953</code></a> feat: refactor to split AST specification out as its own module (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/2911">#2911</a>)</li>
<li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v4.23.0/packages/eslint-plugin">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@typescript-eslint/eslint-plugin&package-manager=npm_and_yarn&previous-version=4.22.1&new-version=4.23.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2330

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474753

Pulled By: mweststrate

fbshipit-source-id: d3aa251618b1d95daebde4619711e764647ab252
2021-05-20 07:42:26 -07:00
Anton Nikolaev
fe7bb7cedd Fix null reference on isError check
Summary: Fixed new error which appeared in logview after last release. See task T91245438 for details.

Reviewed By: passy

Differential Revision: D28569848

fbshipit-source-id: a4b622d4387aa41ecc4db269e05c5315669df250
2021-05-20 07:13:35 -07:00
Stephen Schwink
0c854eaeb5 Add Flipper icon "raincloud"
Reviewed By: joelmats

Differential Revision: D28541930

fbshipit-source-id: 109264f705f0060a3b1b085abc1d0717decb6143
2021-05-19 13:35:05 -07:00
Flipper Bot
066ddbcb41 Flipper Snapshot Bump: v0.91.2-SNAPSHOT
Summary: Releasing snapshot version 0.91.2-SNAPSHOT

Reviewed By: passy

Differential Revision: D28546236

fbshipit-source-id: 537518100535affac63e93b149f4116e3141dc5d
2021-05-19 13:16:05 -07:00
Flipper Bot
e277ca9b05 Flipper Release: v0.91.1
Summary: Releasing version 0.91.1

Reviewed By: passy

Differential Revision: D28546238

fbshipit-source-id: 9dee4ccbbe647e99a2f590a48a7671af6bad5b73
2021-05-19 13:16:05 -07:00
Pritesh Nandgaonkar
15454ceec7 Update Boost iOSX dep and make it work for arm and i386 for sims (#2341)
Summary:
This diff updates and adds the boost ios podspec in flipper repo. This new boost dep works for Arm and i386 archs for simulator too.

This diff also updates our GH Action to remove i386 from excluded archs. Still arm64 is kept as non M1 mac machines do not have arm swift symbols for arm simulator. And since all our CI is on non M1, it is required.

It also takes care of https://github.com/facebook/flipper/issues/2268
## Changelog

- Update the boost dep
- Update the GH action

Pull Request resolved: https://github.com/facebook/flipper/pull/2341

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D28537004

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 474ccec674d0edf5fa7b792b15a326e0f139d977
2021-05-19 11:15:13 -07:00
Pascal Hartig
e0e95b59c7 Update docs workflow (#2342)
Summary:
Updated to the latest version which apparently doesn't need a privileged token anymore, which would be good news.
Also updated the message to include a `[ci skip]` which instructs CircleCI not to run because we're having a chicken-and-egg-problem here with CircleCI otherwise needing a config to tell it not to run, otherwise it will run and fail because there's no config.

Pull Request resolved: https://github.com/facebook/flipper/pull/2342

Test Plan:
hopeitwork

Task: T91157540

Reviewed By: mweststrate

Differential Revision: D28539468

Pulled By: passy

fbshipit-source-id: 609c3fa1578e0506aadeb225c4e38ff53db67934
2021-05-19 09:37:41 -07:00
Anton Nikolaev
3f55ceac8f Added few eslint rules checking promises
Summary:
Added rules to ensure we properly propagate errors from promises.

Also found and fixed a place where promise function parameter was mismatched.

Reviewed By: mweststrate

Differential Revision: D28537820

fbshipit-source-id: b93f44274fc76544049813f645508cb78e432880
2021-05-19 09:30:42 -07:00
Michel Weststrate
c897d92df8 Minor doc improvements
Summary: per title

Reviewed By: muraziz

Differential Revision: D28538087

fbshipit-source-id: 322558d909fb89cd297b56d6aaf3de98e20b4ec1
2021-05-19 08:16:47 -07:00
Flipper Bot
f0dc199d38 Flipper Snapshot Bump: v0.91.1-SNAPSHOT
Summary: Releasing snapshot version 0.91.1-SNAPSHOT

Reviewed By: nikoant

Differential Revision: D28536897

fbshipit-source-id: a3a2906439b9080188c5991610dbbb9db7a7e314
2021-05-19 06:55:43 -07:00
Flipper Bot
610d250129 Flipper Release: v0.91.0
Summary: Releasing version 0.91.0

Reviewed By: nikoant

Differential Revision: D28536898

fbshipit-source-id: 343d3eab79449713ad7ce75887ab28564e7167b8
2021-05-19 06:55:43 -07:00
Michel Weststrate
767c6855c8 Clean up response handling
Reviewed By: priteshrnandgaonkar, fabiomassimo

Differential Revision: D28441183

fbshipit-source-id: 6e47d05145e986279860b49cfff078a905f62689
2021-05-19 06:22:43 -07:00
Anton Nikolaev
25ae4a0535 Include information about selected device, app and plugin into analytics events and error reports
Summary:
This diff generalises computation of the currently selected plugin, app, device etc. and adds this information to all the analytics events and error reports.

Slicing of events by os, device, app or selected plugin can be very useful. This is especially true for errors which often affects only certain types of devices, e.g. android only or physical devices only. Having such information can help to narrow down such issues.

Reviewed By: passy

Differential Revision: D28511441

fbshipit-source-id: ed9dc57927c70ed8cc6fe093e21604eae54c2f60
2021-05-19 05:17:41 -07:00
bizzguy
b378d8b946 fix problem with mock request data (#2340)
Summary:
Network Plugin - When creating a mock request from a selected request, the request data is not in the proper format.  It is decoded instead of just being copied from the call (which has already been decoded properly).  This PR fixes that problem.

Below is a screenshot showing the problem (which occurs for all text response data):

![image](https://user-images.githubusercontent.com/337874/118744068-423e3b80-b819-11eb-9076-216459517fdb.png)

## Changelog

Network Plugin - Fix problem with decoding request data for mocks copied from selection

Pull Request resolved: https://github.com/facebook/flipper/pull/2340

Test Plan:
Using the sample Android app, issue a network request

In Flipper, create a mock for the network request by selecting it and using the "Copy Selected Calls" function in the mock

Verify that the request data is readable:

![image](https://user-images.githubusercontent.com/337874/118744220-8af5f480-b819-11eb-9206-0fa40e7d7e46.png)

Note:

Testing was done using the sample app which uses responses with JSON data.  I was not able to provide testing for other types of calls, specifically calls that would return binary data.

Reviewed By: passy

Differential Revision: D28533224

Pulled By: mweststrate

fbshipit-source-id: ce11d23ade60843c110286f7a5bbeba91febbcf0
2021-05-19 03:15:30 -07:00
Hugo Cuvillier
7572178f25 Remove redeclared header CKMutex from CK
Summary: It can now only be accessed through `RenderCore`.

Reviewed By: ivanmisuno

Differential Revision: D28532729

fbshipit-source-id: b5b97ec93c96303b2a6e4c270dfc667712086b79
2021-05-19 02:38:15 -07:00
Denis Colliot
525e8b19fb Detect JSON API content type ('application/vnd.api+json') as textual content (#2337)
Summary:
Network requests and responses using JSON API content type of pattern `application/vnd.api+json` (see https://jsonapi.org/#mime-types) are currently treated as binary data. They should be treated as textual content.

## Changelog

Add regular expression to detect JSON content types.

Pull Request resolved: https://github.com/facebook/flipper/pull/2337

Test Plan: Using an API that return `Content-Type` of pattern `application/vnd.api+json`, verify that the response data in sidebar appears as text rather than `(binary data)`.

Reviewed By: passy

Differential Revision: D28513547

Pulled By: mweststrate

fbshipit-source-id: 3335b7eeb63c2429c2245113c8c83bd7e08a9420
2021-05-18 13:48:17 -07:00
Pascal Hartig
4cdc72aba4 Add error logging doc
Summary: Lightweight docs about error logging.

Reviewed By: nikoant, priteshrnandgaonkar

Differential Revision: D28474066

fbshipit-source-id: 0527ab82d4fd084fc2ed88328e88db14f6ee4184
2021-05-18 11:23:05 -07:00
bizzguy
b0313316cc Network Plugin: Add xhtml and xml to 'Textual' check (#2336)
Summary:
Network requests that return a "Content-Type" of 'application/xhtml+xml' are currently being treated as binary data when they should be treated as text.

## Changelog

Network Plugin - treat "Content-Type" of 'application/xhtml+xml' as text

Pull Request resolved: https://github.com/facebook/flipper/pull/2336

Test Plan: Using an API that return "Content-Type" of 'application/xhtml+xml' , verified that the response data in sidebar appears as text rather than '(binary data)'

Reviewed By: nikoant

Differential Revision: D28478695

Pulled By: mweststrate

fbshipit-source-id: ed60c8301dbd0cf65924a80d9e6a5800a59c6bb8
2021-05-18 10:23:38 -07:00
Michel Weststrate
f0f54b19b9 Added basic chart to demo
Summary:
Added demo to show how DataSource can power charts using event sampling and smart windowing.

A more experimental application: use dataSource to power some charts, that leverages the events emitted from an datasource that is continuously being appended:

- incoming events are downsampled 1 in 100 to build up the bottom window
- incoming events are not downsampled to render the topwindow, but since datasource views will ignore events outside the window, things will stay pretty responsive when a window is selected (without a window, the downsampled dataset is used as source for top chart as well).

Compared to a naive (well still slightly optimised with useFastArray) implementation that throws all incoming event in a big array, it performs > 20 times faster (see difference in amount of events processed)

Reviewed By: passy

Differential Revision: D28474409

fbshipit-source-id: 6a7973d1ade3053b1d6c8f72069697d96b1ef4fd
2021-05-18 08:46:18 -07:00
Pascal Hartig
3b6b684f10 Demote user errors
Summary:
One is keytar, which just needed a context.

The second one is happening every time someone uses Flipper
and not being on Lighthouse, spamming our log category besides
actually being properly handled.

Reviewed By: nikoant

Differential Revision: D28479791

fbshipit-source-id: 029721df46d12b2942b590a232618ef039a2323d
2021-05-18 08:34:19 -07:00
Anton Nikolaev
cfedabcdef Attribute error reports with plugin id and version
Summary: This diff adds attributing of all error reports with the information about the plugins caused them. To do that we try to map error stack trace to plugins by searching for plugin directories in it. We can do this only for plugins loaded from disk as we are looking for their physical locations in stack. To make it possible to search for multiple plugins in one go we build and maintain a trie containing all the loaded plugins locations.

Reviewed By: passy

Differential Revision: D28475938

fbshipit-source-id: 59c8ac39ffe54262b1d57f21fad44eb89748dff2
2021-05-18 08:08:30 -07:00
Anton Nikolaev
853ee24c9b Add info about interactions to error reports
Summary: When reporting errors we could add info about interactions which caused errors. Ability to connect errors and interactions could be quite helpful for analysing and debugging errors and where they are coming from.

Reviewed By: passy, mweststrate

Differential Revision: D28467575

fbshipit-source-id: bef69917a4d6c786d762a2f6eb75a47fd4e46b0f
2021-05-18 08:08:30 -07:00
Anton Nikolaev
03a1add092 Fix extracting errors from console.error data
Summary: Flipper logs all errors reported by "console.error", but I found that stack traces are broken for them. It is because a bug in `extractError` function which extracts errors from the data logged to console. It fails to extract original error stack trace and instead always logs stack trace where "console.error" was called.  This diff fixes the issue, so errors are properly reported with their original stack traces. However, sometimes stack trace of console.error call can also be useful to find where the error was actually catched and logged, so we're now writing this stack trace into addition field "log_stack_trace".

Reviewed By: passy

Differential Revision: D28466569

fbshipit-source-id: 55fb8ab52c05e8196efc1e47aec95cc1fbc0e594
2021-05-18 08:08:30 -07:00
Anton Nikolaev
8bbf9c46a3 Keep promise rejections unhandled after catching them for logging
Summary: Tracked component catches rejected promises under it to log them. After catching promises become "handled". This might hide potential promise error handling mistakes, so it's better to ensure we keep promises unhandled after catching them for tracking, so they are properly catched by the unhandled promise handler after that. The easiest solution seems to just make new rejected promise and return it instead of the catched one.

Reviewed By: passy

Differential Revision: D28466570

fbshipit-source-id: 26c1e7af3d6e4f7067b95f20e646462d808bb497
2021-05-18 08:08:30 -07:00
Anton Nikolaev
a4eb2a56d6 Option for "yarn start" and "yarn build" scripts to pre-install default plugin packages instead of bundling them
Summary:
Sorry for long diff! I can try to split it if necessary, but many changes here are 1-1 replacements / renames.

**Preambule**
Currently we bundle default plugins into the Flipper main bundle. This helps us to reduce bundle size, because of plugin dependencies re-use. E.g. if multiple plugins use "lodash" when they are bundled together, only one copy of "lodash" added. When they are bundled separately, the same dependency might be added to each of them. However as we're not going to include most of plugins into Flipper distributive anymore and going to rely on Marketplace instead, this bundling doesn't provide significant size benefits anymore. In addition to that, bundling makes it impossible to differentiate whether thrown errors are originated from Flipper core or one of its plugins.

Why don't we remove plugin bundling at all? Because for "dev mode" it actually quite useful. It makes dev build start much faster and also enables using of Fast Refresh for plugin development (fast refresh won't work for plugins loaded from disk).

**Changes**
This diff introduces new option "no-bundled-plugins" for "yarn start" and "yarn build" commands. For now, by default, we will continue bundling default plugins into the Flipper main bundle, but if this option provided then we will build each default plugin separately and include their packages into the Flipper distributive as "pre-installed" to be able to load them from disk even without access to Marketplace.

For "yarn start", we're adding symlinks to plugin folders in "static/defaultPlugins" and then they are loaded by Flipper. For "yarn build" we are dereferencing these symlinks to include physical files of plugins into folder "defaultPlugins" of the produced distributive. Folder "defaultPlugins" is excluded from asar, because loading of plugins from asar archive might introduce some unexpected issues depending on their implementation.

Reviewed By: mweststrate

Differential Revision: D28431838

fbshipit-source-id: f7757e9f5ba9183ed918d70252de3ce0e823177d
2021-05-18 08:08:30 -07:00
dependabot[bot]
706b3cfca8 Bump socket.io from 4.0.1 to 4.1.1 in /desktop (#2334)
Summary:
Bumps [socket.io](https://github.com/socketio/socket.io) from 4.0.1 to 4.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p>
<blockquote>
<h2>4.1.1</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> properly type server-side events (<a href="b84ed1e41c">b84ed1e</a>)</li>
<li><strong>typings:</strong> properly type the adapter attribute (<a href="891b1870e9">891b187</a>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/4.1.0...4.1.1">https://github.com/socketio/socket.io/compare/4.1.0...4.1.1</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.1.1">4.1.1</a></li>
<li>engine.io version:  <code>~5.1.0</code></li>
<li>ws version: <code>~7.4.2</code></li>
</ul>
<h2>4.1.0</h2>
<p>Blog post: <a href="https://socket.io/blog/socket-io-4-1-0/">https://socket.io/blog/socket-io-4-1-0/</a></p>
<h3>Features</h3>
<ul>
<li>add support for inter-server communication (<a href="93cce05fb3">93cce05</a>)</li>
<li>notify upon namespace creation (<a href="499c89250d">499c892</a>)</li>
<li>add a &quot;connection_error&quot; event (<a href="7096e98a02">7096e98</a>, from <code>engine.io</code>)</li>
<li>add the &quot;initial_headers&quot; and &quot;headers&quot; events (<a href="252754353a">2527543</a>, from <code>engine.io</code>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/4.0.2...4.1.0">https://github.com/socketio/socket.io/compare/4.0.2...4.1.0</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.1.0">4.1.0</a></li>
<li>engine.io version:  <code>~5.1.0</code></li>
<li>ws version: <code>~7.4.2</code></li>
</ul>
<h2>4.0.2</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> make &quot;engine&quot; attribute public (<a href="b81ce4c9d0">b81ce4c</a>)</li>
<li>properly export the Socket class (<a href="d65b6ee84c">d65b6ee</a>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/4.0.1...4.0.2">https://github.com/socketio/socket.io/compare/4.0.1...4.0.2</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.0.2">4.0.2</a></li>
<li>engine.io version:  <code>~5.0.0</code></li>
<li>ws version: <code>~7.4.2</code></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/blob/master/CHANGELOG.md">socket.io's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/socketio/socket.io/compare/4.1.0...4.1.1">4.1.1</a> (2021-05-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> properly type server-side events (<a href="b84ed1e41c">b84ed1e</a>)</li>
<li><strong>typings:</strong> properly type the adapter attribute (<a href="891b1870e9">891b187</a>)</li>
</ul>
<h1><a href="https://github.com/socketio/socket.io/compare/4.0.2...4.1.0">4.1.0</a> (2021-05-11)</h1>
<h3>Features</h3>
<ul>
<li>add support for inter-server communication (<a href="93cce05fb3">93cce05</a>)</li>
<li>notify upon namespace creation (<a href="499c89250d">499c892</a>)</li>
<li>add a &quot;connection_error&quot; event (<a href="7096e98a02">7096e98</a>, from <code>engine.io</code>)</li>
<li>add the &quot;initial_headers&quot; and &quot;headers&quot; events (<a href="252754353a">2527543</a>, from <code>engine.io</code>)</li>
</ul>
<h3>Performance Improvements</h3>
<ul>
<li>add support for the &quot;wsPreEncoded&quot; writing option (<a href="dc381b72c6">dc381b7</a>)</li>
</ul>
<h2><a href="https://github.com/socketio/socket.io/compare/4.0.1...4.0.2">4.0.2</a> (2021-05-06)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> make &quot;engine&quot; attribute public (<a href="b81ce4c9d0">b81ce4c</a>)</li>
<li>properly export the Socket class (<a href="d65b6ee84c">d65b6ee</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="995f38f4cc"><code>995f38f</code></a> chore(release): 4.1.1</li>
<li><a href="891b1870e9"><code>891b187</code></a> fix(typings): properly type the adapter attribute</li>
<li><a href="b84ed1e41c"><code>b84ed1e</code></a> fix(typings): properly type server-side events</li>
<li><a href="fb6b0efec9"><code>fb6b0ef</code></a> chore(release): 4.1.0</li>
<li><a href="95d9e4a42f"><code>95d9e4a</code></a> test: fix randomly failing test</li>
<li><a href="499c89250d"><code>499c892</code></a> feat: notify upon namespace creation</li>
<li><a href="93cce05fb3"><code>93cce05</code></a> feat: add support for inter-server communication</li>
<li><a href="dc381b72c6"><code>dc381b7</code></a> perf: add support for the &quot;wsPreEncoded&quot; writing option</li>
<li><a href="9fff03487c"><code>9fff034</code></a> chore(release): 4.0.2</li>
<li><a href="b81ce4c9d0"><code>b81ce4c</code></a> fix(typings): make &quot;engine&quot; attribute public</li>
<li>Additional commits viewable in <a href="https://github.com/socketio/socket.io/compare/4.0.1...4.1.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=socket.io&package-manager=npm_and_yarn&previous-version=4.0.1&new-version=4.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2334

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474762

Pulled By: mweststrate

fbshipit-source-id: 390da943efd6e6e96135d612adb855f132580ff6
2021-05-18 06:42:10 -07:00
dependabot[bot]
26209a0134 Bump @testing-library/dom from 7.30.4 to 7.31.0 in /desktop (#2333)
Summary:
Bumps [testing-library/dom](https://github.com/testing-library/dom-testing-library) from 7.30.4 to 7.31.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/testing-library/dom-testing-library/releases"><code>@​testing-library/dom</code>'s releases</a>.</em></p>
<blockquote>
<h2>v7.31.0</h2>
<h1><a href="https://github.com/testing-library/dom-testing-library/compare/v7.30.4...v7.31.0">7.31.0</a> (2021-05-10)</h1>
<h3>Features</h3>
<ul>
<li>Add extra error messages when <code>screen</code> was passed instead of a DOM element (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/949">https://github.com/facebook/flipper/issues/949</a>) (<a href="c273ed518c">c273ed5</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c273ed518c"><code>c273ed5</code></a> feat: Add extra error messages when <code>screen</code> was passed instead of a DOM elem...</li>
<li><a href="4b2976d516"><code>4b2976d</code></a> chore: Format codebase with prettier (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/955">https://github.com/facebook/flipper/issues/955</a>)</li>
<li><a href="13efbb3b1d"><code>13efbb3</code></a> chore: Remove unused Nullish type (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/953">https://github.com/facebook/flipper/issues/953</a>)</li>
<li><a href="e061cd1fdd"><code>e061cd1</code></a> docs: add amitmiran137 as a contributor (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/952">https://github.com/facebook/flipper/issues/952</a>)</li>
<li><a href="37d1cc48d9"><code>37d1cc4</code></a> chore: rename master to main (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/942">https://github.com/facebook/flipper/issues/942</a>)</li>
<li><a href="d8a8d581b0"><code>d8a8d58</code></a> docs: add simcha90 as a contributor (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/951">https://github.com/facebook/flipper/issues/951</a>)</li>
<li><a href="b00dff949f"><code>b00dff9</code></a> chore(refactor): move queries to TS / prettify some code according ABC (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/948">https://github.com/facebook/flipper/issues/948</a>)</li>
<li><a href="ffc8f26d48"><code>ffc8f26</code></a> docs: add nickmccurdy as a contributor (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/936">https://github.com/facebook/flipper/issues/936</a>)</li>
<li><a href="9c03efa5f3"><code>9c03efa</code></a> chore: continue testing on Node 15 (<a href="https://github-redirect.dependabot.com/testing-library/dom-testing-library/issues/935">https://github.com/facebook/flipper/issues/935</a>)</li>
<li>See full diff in <a href="https://github.com/testing-library/dom-testing-library/compare/v7.30.4...v7.31.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@testing-library/dom&package-manager=npm_and_yarn&previous-version=7.30.4&new-version=7.31.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2333

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474761

Pulled By: mweststrate

fbshipit-source-id: e6d59ad2aef69c7df066c2a01d769083a1f042a4
2021-05-18 06:42:10 -07:00
dependabot[bot]
ea541436c8 Bump jest-environment-jsdom-sixteen from 1.0.3 to 2.0.0 in /desktop (#2335)
Summary:
Bumps [jest-environment-jsdom-sixteen](https://github.com/SimenB/jest-environment-jsdom-sixteen) from 1.0.3 to 2.0.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="313be06cc4"><code>313be06</code></a> 2.0.0</li>
<li><a href="03837baa9a"><code>03837ba</code></a> Update README.md</li>
<li>See full diff in <a href="https://github.com/SimenB/jest-environment-jsdom-sixteen/compare/v1.0.3...v2.0.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=jest-environment-jsdom-sixteen&package-manager=npm_and_yarn&previous-version=1.0.3&new-version=2.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2335

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474765

Pulled By: mweststrate

fbshipit-source-id: 69db6e427afd33abb95c5aa204821954b21cfc14
2021-05-18 06:42:10 -07:00
dependabot[bot]
4e4a2bdc00 Bump @typescript-eslint/experimental-utils from 4.22.1 to 4.23.0 in /desktop (#2328)
Summary:
Bumps [typescript-eslint/experimental-utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils) from 4.22.1 to 4.23.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@​typescript-eslint/experimental-utils</code>'s releases</a>.</em></p>
<blockquote>
<h2>v4.23.0</h2>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.22.1...v4.23.0">4.23.0</a> (2021-05-10)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>scope-manager:</strong> fix visiting TSAsExpression in assignment (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3355">#3355</a>) (<a href="87521a0241">87521a0</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>experimental-utils:</strong> Include <code>getCwd()</code> in <code>RuleContext</code> type (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3308">#3308</a>) (<a href="2b75c11d69">2b75c11</a>)</li>
<li>refactor to split AST specification out as its own module (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/2911">#2911</a>) (<a href="25ea953cc6">25ea953</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/experimental-utils/CHANGELOG.md"><code>@​typescript-eslint/experimental-utils</code>'s changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.22.1...v4.23.0">4.23.0</a> (2021-05-10)</h1>
<h3>Features</h3>
<ul>
<li><strong>experimental-utils:</strong> Include <code>getCwd()</code> in <code>RuleContext</code> type (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3308">#3308</a>) (<a href="2b75c11d69">2b75c11</a>)</li>
<li>refactor to split AST specification out as its own module (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/2911">#2911</a>) (<a href="25ea953cc6">25ea953</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="18d8151e54"><code>18d8151</code></a> chore: publish v4.23.0</li>
<li><a href="2b75c11d69"><code>2b75c11</code></a> feat(experimental-utils): Include <code>getCwd()</code> in <code>RuleContext</code> type (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils/issues/3308">#3308</a>)</li>
<li><a href="25ea953cc6"><code>25ea953</code></a> feat: refactor to split AST specification out as its own module (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils/issues/2911">#2911</a>)</li>
<li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v4.23.0/packages/experimental-utils">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@typescript-eslint/experimental-utils&package-manager=npm_and_yarn&previous-version=4.22.1&new-version=4.23.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2328

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474748

Pulled By: mweststrate

fbshipit-source-id: c300d94244c0210d7082ac33b952f4925caf8b5e
2021-05-18 06:42:10 -07:00
dependabot[bot]
ac25787c0c Bump @types/split2 from 2.1.6 to 3.2.0 in /desktop (#2332)
Summary:
Bumps [types/split2](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/split2) from 2.1.6 to 3.2.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/split2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@types/split2&package-manager=npm_and_yarn&previous-version=2.1.6&new-version=3.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2332

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474759

Pulled By: mweststrate

fbshipit-source-id: adf85edf7a04928d3b335e698c547c6bb592e219
2021-05-18 06:42:10 -07:00
dependabot[bot]
9d92c7ba0d Bump react-native-flipper from 0.88.0 to 0.90.2 in /react-native/ReactNativeFlipperExample (#2322)
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.88.0 to 0.90.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/flipper/releases">react-native-flipper's releases</a>.</em></p>
<blockquote>
<h2>v0.90.2</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a>
for full notes.</p>
<h2>v0.90.1</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a>
for full notes.</p>
<h2>v0.90.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a>
for full notes.</p>
<h2>v0.89.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a>
for full notes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="877de95ca9"><code>877de95</code></a> Flipper Release: v0.90.2</li>
<li><a href="140d93341e"><code>140d933</code></a> &quot;Fix&quot; &quot;typo&quot; that's blocking Android releases (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/2312">https://github.com/facebook/flipper/issues/2312</a>)</li>
<li><a href="0212da0ba5"><code>0212da0</code></a> Re-applied patch for new version of <code>@​emotion/cache</code></li>
<li><a href="366752f424"><code>366752f</code></a> Enforce version &quot;0.0.0&quot; in plugin sources</li>
<li><a href="580f4c7048"><code>580f4c7</code></a> Flipper Snapshot Bump: v0.90.2-SNAPSHOT</li>
<li><a href="ba3e4500e8"><code>ba3e450</code></a> Flipper Release: v0.90.1</li>
<li><a href="ab93c24dd6"><code>ab93c24</code></a> Fix publishing pipeline (hopefully) (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/2311">https://github.com/facebook/flipper/issues/2311</a>)</li>
<li><a href="b797fec6cc"><code>b797fec</code></a> Daily dep bump</li>
<li><a href="24342dd6f4"><code>24342dd</code></a> Flipper Snapshot Bump: v0.90.1-SNAPSHOT</li>
<li><a href="0a3b817429"><code>0a3b817</code></a> Flipper Release: v0.90.0</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.88.0...v0.90.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-native-flipper&package-manager=npm_and_yarn&previous-version=0.88.0&new-version=0.90.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2322

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474736

Pulled By: mweststrate

fbshipit-source-id: 9c511dec2e3a370f0d1e1dc37865c383cefe9ed6
2021-05-18 06:42:10 -07:00
dependabot[bot]
a005fea38e Bump glob from 7.1.6 to 7.1.7 in /desktop (#2327)
Summary:
Bumps [glob](https://github.com/isaacs/node-glob) from 7.1.6 to 7.1.7.
<details>
<summary>Commits</summary>
<ul>
<li><a href="ce43ea071e"><code>ce43ea0</code></a> 7.1.7</li>
<li><a href="66c102edf4"><code>66c102e</code></a> force 'en' locale in string sorting</li>
<li><a href="37b44c1ec3"><code>37b44c1</code></a> use tap 15</li>
<li>See full diff in <a href="https://github.com/isaacs/node-glob/compare/v7.1.6...v7.1.7">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=glob&package-manager=npm_and_yarn&previous-version=7.1.6&new-version=7.1.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2327

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474747

Pulled By: mweststrate

fbshipit-source-id: 39503c06ab8bb509f4e46d3d58806356473b5ac9
2021-05-18 06:42:10 -07:00
dependabot[bot]
2048d9e7a2 Bump less from 3.12.2 to 4.1.1 in /desktop (#2329)
Summary:
Bumps [less](https://github.com/less/less.js) from 3.12.2 to 4.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/less/less.js/releases">less's releases</a>.</em></p>
<blockquote>
<h2>v4.1.1</h2>
<ul>
<li>Bug fixes</li>
</ul>
<h2>v4.1.0</h2>
<h1>Mixin parentheses requirement removed</h1>
<p>This was maybe too big a change without some kind of deprecation or conversion.
So for this version, this works again:</p>
<pre><code>.mixin;
</code></pre>
<h2>v4.0.0</h2>
<p>This release has 2 breaking changes:</p>
<h3>Parentheses required for mixin calls</h3>
<p>This aligns it with syntax for calling detached rulesets.</p>
<p>Example</p>
<pre lang="less"><code>.mixin() {}
.mixin;  // error in 4.0
</code></pre>
<h3>Parens-division now the default math setting</h3>
<p>Parentheses are required (by default) around division-like expressions, to force math evaluation.</p>
<p>Example:</p>
<pre lang="less"><code>ratio_large: 16;
ratio_small: 9;
<p>/** The following will produce <code>device-aspect-ratio: 1.77777778</code> by default in 3.x */
<a href="https://github.com/media"><code>@​media</code></a> all and (device-aspect-ratio: <a href="https://github.com/ratio"><code>@​ratio</code></a>_large / <a href="https://github.com/ratio"><code>@​ratio</code></a>_small) {
.body { max-width: 800px; }
}
</code></pre></p>
<p>Produces:</p>
<pre lang="css"><code>media all and (device-aspect-ratio: 16 / 9) {
  .body {
    max-width: 800px;
  }
}
</code></pre>
<p>You can, of course, get old math behavior. See: <a href="http://lesscss.org/usage/#less-options-math">http://lesscss.org/usage/#less-options-math</a></p>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/less/less.js/blob/master/CHANGELOG.md">less's changelog</a>.</em></p>
<blockquote>
<h2>Change Log</h2>
<h3>v4.0.0 (2020-12-18)</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/less/less.js/pull/3573">#3573</a> v4.0.0 (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3573">#3573</a>) (<a href="https://github.com/matthew-dean"><code>@​matthew-dean</code></a>)</li>
</ul>
<h3>v3.13.1 (2020-12-18)</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/less/less.js/pull/3575">#3575</a> Fixes <a href="https://github-redirect.dependabot.com/less/less.js/issues/3574">#3574</a> (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3575">#3575</a>) (<a href="https://github.com/matthew-dean"><code>@​matthew-dean</code></a>)</li>
</ul>
<h3>v3.13.0 (2020-12-12)</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/less/less.js/pull/3572">#3572</a> Fixes <a href="https://github-redirect.dependabot.com/less/less.js/issues/3434">#3434</a> - memory / runtime improvements (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3572">#3572</a>) (<a href="https://github.com/matthew-dean"><code>@​matthew-dean</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/less/less.js/pull/3550">#3550</a> Examples contain more valid CSS, to test with a new parser (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3550">#3550</a>) (<a href="https://github.com/matthew-dean"><code>@​matthew-dean</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/less/less.js/pull/3546">#3546</a> Bug fixes - fixes <a href="https://github-redirect.dependabot.com/less/less.js/issues/3446">#3446</a> <a href="https://github-redirect.dependabot.com/less/less.js/issues/3368">#3368</a> (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3546">#3546</a>) (<a href="https://github.com/matthew-dean"><code>@​matthew-dean</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="f4e752904f"><code>f4e7529</code></a> Merge branch 'master' of <a href="https://github.com/less/less.js">https://github.com/less/less.js</a></li>
<li><a href="9538abae09"><code>9538aba</code></a> Release/v4.1.1 (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3599">#3599</a>)</li>
<li><a href="4cc9b8346f"><code>4cc9b83</code></a> Merge branch 'master' of <a href="https://github.com/less/less.js">https://github.com/less/less.js</a></li>
<li><a href="9d9e650890"><code>9d9e650</code></a> v4.1.1</li>
<li><a href="f727b26de5"><code>f727b26</code></a> Fixes <a href="https://github-redirect.dependabot.com/less/less.js/issues/3586">#3586</a> (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3589">#3589</a>)</li>
<li><a href="63c1827c63"><code>63c1827</code></a> Fix expected response when there's a socket error (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3597">#3597</a>)</li>
<li><a href="3c23217358"><code>3c23217</code></a> Release v4.1.0</li>
<li><a href="d495fb26a8"><code>d495fb2</code></a> v4.1.0</li>
<li><a href="a4b6c8544c"><code>a4b6c85</code></a> Roll back paren requirement on mixin calls (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3588">#3588</a>)</li>
<li><a href="7f1938ec10"><code>7f1938e</code></a> Update rollup and other build dependencies (<a href="https://github-redirect.dependabot.com/less/less.js/issues/3583">#3583</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/less/less.js/compare/v3.12.2...v4.1.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=less&package-manager=npm_and_yarn&previous-version=3.12.2&new-version=4.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2329

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474751

Pulled By: mweststrate

fbshipit-source-id: 7e568e71b36fd54cbb95eb9eae64ae7e5c260f63
2021-05-18 06:42:10 -07:00
dependabot[bot]
e18dd53f4a Bump gradle from 4.2.0 to 4.2.1 (#2325)
Summary:
Bumps gradle from 4.2.0 to 4.2.1.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.android.tools.build:gradle&package-manager=gradle&previous-version=4.2.0&new-version=4.2.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2325

Reviewed By: priteshrnandgaonkar

Differential Revision: D28474742

Pulled By: mweststrate

fbshipit-source-id: fa58186520441ea86ae7204e63843a028c3b53e8
2021-05-18 06:42:10 -07:00