Summary: On a fresh VS Code install, only the internal Prettier plugin is available, but not the open source version, which we need as the internal one doesn't work on Flipper (probably due to TypeScript?)
Reviewed By: lblasa
Differential Revision: D36275616
fbshipit-source-id: bccbbcd372f7a7ecca46eb83f5515543e611235c
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: lblasa
Differential Revision: D36246509
fbshipit-source-id: 008b137defae3e15144670e0415ad91383012b21
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: lblasa
Differential Revision: D36249814
fbshipit-source-id: 94d809fe2d2cba8c18891128e13cb05196998d59
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: lblasa
Differential Revision: D36248900
fbshipit-source-id: dfa0d3413741be8223719630675f36adc0acd7b5
Summary:
Original commit changeset: 471470c5ca91
Original Phabricator Diff: D35356211 (501abc6b55)
Recently, bloks users reported that android emulators lost connection upon launching Flipper. (S270689)
Manual bisecting indicates that remote emulators won't crash on v0.142.362128844 (4/6) but crash on 0.143.365099607 (4/21).
Looking at https://www.internalfb.com/code/fbsource/[history]/xplat/scripts/.flipperversion.v2, and backing out D35356211 (501abc6b55) fixes the issue.
It's still unclear why setting `setIntoPermissiveMode` would crash/disconnect the android emulators, I'd defer Flipper team to investigate this further but this diff should unblock all the android bloks emulator + Flipper use case.
Reviewed By: lblasa
Differential Revision: D36263724
fbshipit-source-id: e8674730c0185457f6eda347ce7d9a41f9e1a2a4
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: lblasa
Differential Revision: D36244835
fbshipit-source-id: 8f19cf6bb5064da98f567e8fede2af80b8004ced
Summary:
Remove reference to limitation of an API to a particular platform or app.
We show in Flipper whether the plugin is compatible or not. For example, if an iOS device is connected, for plugins that don't support iOS, Flipper marks them as disabled and show a message.
Reviewed By: lblasa
Differential Revision: D36241811
fbshipit-source-id: 4f936279c8dd616fc95a4e6c3e149a0b74b98bd6
Summary:
^
Change necessary when OpenSSL is compiled without STDIO for file operations. Basically, don't use the BIO file API's. Instead use in-memory BIO and do file operations manually.
UPDATE:
The changes were good, but have been simplified and fixed. A fixed was needed as to read and write the file in binary mode. This has no effect in POSIX systems but it does on Windows and this change was made for Windows. It meant that the BIO was incorrectly written to disk thus corrupting its content.
Changelog: Remove OpenSSL file BIO operations
Reviewed By: jknoxville
Differential Revision: D36060992
fbshipit-source-id: 21b30582dd0b32c24b8ba001d6993034d92de1da
Summary: Take changes from D36140809 into account.
Reviewed By: aigoncharov
Differential Revision: D36206155
fbshipit-source-id: 794f8dd60e47f14acc4fb5fd9fd3d98fa5afdadf
Summary:
This bundles up the Flipper Server in a Mac App Bundle which is identically in shape to a regular Desktop bundle. That means we can swap them out transparently without having to keep the layout in sync with Flipper Launcher.
It bundles nodeJS binary which we can later also provide for aarch64.
Reviewed By: aigoncharov
Differential Revision: D36140809
fbshipit-source-id: fb3410626ab172ce0da48f1a4a1489da68450369
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: mweststrate
Differential Revision: D36197861
fbshipit-source-id: b73787f04892d3f76938929ef84943f2031657e1
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: passy
Differential Revision: D36198283
fbshipit-source-id: 499133cc7265488203a248da2d1e519fc23a0d19
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: mweststrate
Differential Revision: D36197599
fbshipit-source-id: 6fad2066d64f1f191b32639e1f36c24e103a91fb
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: mweststrate
Differential Revision: D36198043
fbshipit-source-id: 961d9b535f0869ae3db3bbdfcbc33be43773edd6
Summary: Taking care of the remaining dependabot tasks In my queue.
Reviewed By: mweststrate
Differential Revision: D36131782
fbshipit-source-id: f8a5ce18bfab7c5d50a88d64f9516d67bba4bd6d
Summary: This takes care of a couple of dependabot bumps.
Reviewed By: lblasa
Differential Revision: D36097174
fbshipit-source-id: 81be4b09d40d090945704eb3477bd30638ad24c1
Summary: More bumps for patch and minor releases. allow-large-files
Reviewed By: aigoncharov
Differential Revision: D36104098
fbshipit-source-id: 6db995e660afbe4febd72aa70ed8150cc16a8c93
Summary: Bunch of dependabot PRs showed that the signal is green, but still wanted to have all in one diff.
Reviewed By: aigoncharov
Differential Revision: D36102480
fbshipit-source-id: 88d472fdc2a910a7441a9e8164fe8af0f2d90f7b
Summary: Caused some inconsistencies when running `tsc`. This brings them back in line.
Reviewed By: aigoncharov
Differential Revision: D36101548
fbshipit-source-id: b8f757c59f879911c9b0920fe11396246ffa37e2
Summary:
^
There's a similar issue/request for Android. So, this change moves the code out from the FlipperKit into Flipper as to be able to reuse it.
Reviewed By: aigoncharov
Differential Revision: D35961745
fbshipit-source-id: aa255db582a7852dc06c2feaba389d1dac3b0f67
Summary: On top of the stack, this should be green again.
Reviewed By: nikoant
Differential Revision: D36100200
fbshipit-source-id: 581e3d825ef8e088f6d5ed4b0fcdfea574121667
Summary:
Before:
```
flipper-server/src/startBaseServer.tsx(222,30): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
flipper-ui-browser/src/flipperServerConnection.tsx(25,9): error TS2322: Type 'Timeout' is not assignable to type 'number'.
```
Reviewed By: nikoant
Differential Revision: D36100188
fbshipit-source-id: 1913a43109a0e068394a188d362f6a9e473e7904
Summary:
^
In dark mode, the logs were not visible as font color is white, same as the background color of the label explicitly set to white.
Don't set it to white (unless the text color is changed as well).
Reviewed By: antonk52
Differential Revision: D36015027
fbshipit-source-id: bf37546a13e4a2153f7307ddeebddb23f27f4403
Summary:
Bumps [de.undercouch.download](https://github.com/michel-kraemer/gradle-download-task) from 4.1.2 to 5.0.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/michel-kraemer/gradle-download-task/releases">de.undercouch.download's releases</a>.</em></p>
<blockquote>
<h2>5.0.5</h2>
<p>Maintenance:</p>
<ul>
<li>Publish signed artifacts to Gradle plugin portal</li>
<li>Update dependencies</li>
</ul>
<h2>5.0.4</h2>
<p>Bug fixes:</p>
<ul>
<li>Fix deadlock in <code>DownloadExtension</code> if <code>max-workers</code> equals 1 (thanks to <a href="https://github.com/beatbrot"><code>@beatbrot</code></a> for spotting this, see <a href="https://github-redirect.dependabot.com/michel-kraemer/gradle-download-task/issues/205">https://github.com/facebook/flipper/issues/205</a>)</li>
</ul>
<p>Maintenance:</p>
<ul>
<li>Update dependencies</li>
</ul>
<h2>5.0.2</h2>
<p>Bug fixes:</p>
<ul>
<li>Fix configuration cache under Java 17</li>
</ul>
<p>Maintenance:</p>
<ul>
<li>Add integration tests for Gradle 7.4</li>
<li>Update dependencies</li>
</ul>
<h2>5.0.1</h2>
<p>Bug fixes:</p>
<ul>
<li>Fix artifact on Gradle plugin portal</li>
</ul>
<h2>5.0.0</h2>
<p>New features:</p>
<ul>
<li>Download multiple files in parallel</li>
<li>Enable concurrent execution with other tasks in the build</li>
<li>Write to disk asynchronously (and therefore in parallel to the download)</li>
<li>Display destination file name in progress message</li>
<li>Log retry attempts</li>
<li>Retry on any exception but <code>UnknownHostException</code></li>
<li>Make <code>download</code> and <code>verify</code> extensions compatible with Kotlin and Gradle 8</li>
<li>Add support for lazy evaluation of Kotlin lambdas</li>
<li>Add Kotlin examples</li>
</ul>
<p>Breaking changes:</p>
<ul>
<li>The plugin now requires Java 8 (or higher) and Gradle 5 (or higher)</li>
<li>The <code>authScheme</code> property has been removed. The plugin is now able to detect the required scheme itself.</li>
<li>Due to incompatibility with Gradle 8, the <code>download</code> and <code>verify</code> extensions now need to be called through their <code>run</code> method.</li>
<li>Further information can be found in the <a href="https://github.com/michel-kraemer/gradle-download-task#migrating-from-version-4x-to-5x">migration guide</a></li>
</ul>
<p>Maintenance:</p>
<ul>
<li>Add integration tests for all Gradle versions up to 7.3.3</li>
<li>Upgrade Gradle to 6.9.1</li>
<li>Upgrade Apache HttpClient to 5.1.2</li>
<li>Migrate to JUnit 5 and AssertJ</li>
<li>Enable jacoco for testkit tests</li>
<li>Upload junit test reports on failure</li>
<li>Use build script to apply functional tests to all Gradle versions</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="4a682b23e7"><code>4a682b2</code></a> Fix build</li>
<li><a href="b93b25ccce"><code>b93b25c</code></a> Bump up version number 5.0.5</li>
<li><a href="7626745167"><code>7626745</code></a> Publish signed artifacts to Gradle plugin portal</li>
<li><a href="5971728301"><code>5971728</code></a> Update dependencies</li>
<li><a href="09f12cc0d3"><code>09f12cc</code></a> Update dependencies</li>
<li><a href="3ec1f8d521"><code>3ec1f8d</code></a> Bump up version number 5.0.4</li>
<li><a href="86f24a3b44"><code>86f24a3</code></a> Correctly forward exceptions</li>
<li><a href="70e68ad25c"><code>70e68ad</code></a> Bump up version number 5.0.3</li>
<li><a href="16fd4912b4"><code>16fd491</code></a> Fix deadlock in DownloadExtension if max-workers equals 1</li>
<li><a href="2fa1e89a80"><code>2fa1e89</code></a> Revert "Add gradle-build-action"</li>
<li>Additional commits viewable in <a href="https://github.com/michel-kraemer/gradle-download-task/compare/4.1.2...5.0.5">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/3640
Reviewed By: passy
Differential Revision: D35893250
Pulled By: lblasa
fbshipit-source-id: 9ca6081264ad79217f01d0d5d8848074a22c8a60
Summary:
^
:android:third-party task, on ocassions, gets parallelised with the :configureCMake task resulting in build errors.
:configureCMake depends on dependencies being in-place and patched.
Our current setup was achieving this via setting these tasks as dependencies of the preBuild task.
Unfortunately, this seems not be a bullet-proof solution.
This patch aims to improve this situation by ensuring the tasks are executed before :configureCMake. Whatever happens first.
Changelog: Execute :third-party:prepare before :configureCMake task on Android
Reviewed By: passy
Differential Revision: D36001637
fbshipit-source-id: 6c53b6852e40e354337c0ac940b5bbad4ef83078
Summary:
^
This change makes it clearer the order of tasks for the native libraries.
If unspecified, tasks will run in parallel.
There was an additional issue in which the revision could be written to disk before all dependencies are properly downloaded and packaged.
For reference, we depend on Folly.
Folly depends on:
- Double-Conversion
- Glog
- Boost
- LibEvent
This is now reflected in the tasks graph.
Reviewed By: passy
Differential Revision: D35931187
fbshipit-source-id: ec19a28521ebf318bd1e92feafab1671733679ca
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: passy
Differential Revision: D35898254
fbshipit-source-id: 67e3f3e344faf105f5a8f393c60441d6af3d62aa
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: passy
Differential Revision: D35897472
fbshipit-source-id: 4b3853cd805c8714c83a8d227395dec8e3ff888f
Summary: Restyle of the page, including changes to spelling, grammar, links, and structure (where relevant).
Reviewed By: passy
Differential Revision: D35899228
fbshipit-source-id: 4ade5b28f1634e792fcf4582fe163d02e2f4fab4
