flipper

jens/flipper

Fork 0

Commit Graph

Author	SHA1	Message	Date
Michel Weststrate	724fb79fe7	Don't submit release automatically when running on SC Summary: Our SC release job failed when submitting directly from the prepare-release script, as the jf context wasn't properly setup. So instead we reuse the code we already have for that in SandcastleFlipperAutoReleaseCommand. However, for manual releases we still do submit automatically and in name of the current user. Reviewed By: passy Differential Revision: D20384247 fbshipit-source-id: ed5eca180f009611f2890f8cb665bf203789d189	2020-03-11 04:50:45 -07:00
Michel Weststrate	9dc187cc25	Make sure prepare-release scripts works when running from another dir Summary: Yesterday's script failed if prepare-release was invoked from another dir Reviewed By: jknoxville Differential Revision: D20362093 fbshipit-source-id: a0ce877a2f145f320cf346dc86e3d2568279b8b9	2020-03-10 07:10:29 -07:00
Michel Weststrate	8f2dd977b7	unify internal and external release into one flow Summary: This diff makes updating the internal and external release part of the same flow. The will be changed to: 1. The chronos job is kicked to start a new release 2. That job kicks of `./prepare-release.sh` (see D20304039) which 1. bumps the version of all packages 2. generates the changelog 3. generates a release diff + test instructions for that 4. generates a diff with snapshot version updates 5. submit those commits 3. when this is job is completed, the relevant release commits can be checked out and tested. 4. If these job is landed, this will kick off the OSS builds through `release.sh` (as-is). But, this will also generate a diff that updates the flipper pin to the verify same commit (new). Next steps: * [ ] update wiki Code pointers (irrelevant for review): - Chronos Job entry https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/flib/intern/sandcastle/commands/SandcastleFlipperAutoReleaseCommand.php?lines=85 - Sonar build step: https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/flib/intern/sandcastle/sonar/SandcastleSonarBuildStep.php?lines=84 - Release commit observer: https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/flib/intern/entity/opensource/github/observers/EntOpensourceGitHubCommitBuilderObserver.php?lines=17-48 Reviewed By: passy Differential Revision: D20283664 fbshipit-source-id: 129ea862bda4721d707f1b6fdd862a937c0ed6d5	2020-03-10 02:48:14 -07:00

Author

SHA1

Message

Date

Michel Weststrate

724fb79fe7

Don't submit release automatically when running on SC

Summary:
Our SC release job failed when submitting directly from the prepare-release script, as the jf context wasn't properly setup. So instead we reuse the code we already have for that in SandcastleFlipperAutoReleaseCommand.

However, for manual releases we still do submit automatically and in name of the current user.

Reviewed By: passy

Differential Revision: D20384247

fbshipit-source-id: ed5eca180f009611f2890f8cb665bf203789d189

2020-03-11 04:50:45 -07:00

Michel Weststrate

9dc187cc25

Make sure prepare-release scripts works when running from another dir

Summary: Yesterday's script failed if prepare-release was invoked from another dir

Reviewed By: jknoxville

Differential Revision: D20362093

fbshipit-source-id: a0ce877a2f145f320cf346dc86e3d2568279b8b9

2020-03-10 07:10:29 -07:00

Michel Weststrate

8f2dd977b7

unify internal and external release into one flow

Summary:
This diff makes updating the internal and external release part of the same flow. The will be changed to:

1. The chronos job is kicked to start a new release
2. That job kicks of `./prepare-release.sh` (see D20304039) which
   1. bumps the version of all packages
   2. generates the changelog
   3. generates a release diff + test instructions for that
   4. generates a diff with snapshot version updates
   5. submit those commits
3. when this is job is completed, the relevant release commits can be checked out and tested.
4. If these job is landed, this will kick off the OSS builds through `release.sh` (as-is). But, this will also generate a diff that updates the flipper pin to the verify same commit (new).

Next steps:
* [ ] update wiki

Code pointers (irrelevant for review):
- Chronos Job entry https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/flib/intern/sandcastle/commands/SandcastleFlipperAutoReleaseCommand.php?lines=85
- Sonar build step: https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/flib/intern/sandcastle/sonar/SandcastleSonarBuildStep.php?lines=84
- Release commit observer: https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/flib/intern/entity/opensource/github/observers/EntOpensourceGitHubCommitBuilderObserver.php?lines=17-48

Reviewed By: passy

Differential Revision: D20283664

fbshipit-source-id: 129ea862bda4721d707f1b6fdd862a937c0ed6d5

2020-03-10 02:48:14 -07:00

3 Commits