Commit Graph

11 Commits

Author SHA1 Message Date
Luke De Feo
2d217575bb improve marker timeline
Summary:
1. removed background hover
2. made can select actually work
3. disable user selection
4. remove decimal points from ms

Reviewed By: lblasa

Differential Revision: D48270181

fbshipit-source-id: 724efedb5cad7f93c80ed5dd7f49efe4c434c324
2023-08-21 04:24:16 -07:00
Lorenzo Blasa
b0a8dbca01 MarkerTimeline to show a more obvious selected state
Summary:
When a marker is selected, it was difficult to notice any style differences.

This changes makes it more obvious when a marker is selected.

Reviewed By: antonk52, aigoncharov

Differential Revision: D44628828

fbshipit-source-id: c4634338e04969f3d973137ad861cb999b28c139
2023-04-04 04:05:15 -07:00
Lorenzo Blasa
c839949fa4 MarkerTimeline add top margin as to center the 'point'
Summary: Without the margin, the point is displayed at the top-left which is not centrally aligned with both time and label.

Reviewed By: antonk52

Differential Revision: D43872394

fbshipit-source-id: 087c09e44c65ddaef79cfb25a860d7b4893ba072
2023-03-07 11:23:20 -08:00
Lorenzo Blasa
807544db4c MarkerTimeline remove top margin of Time
Summary: The margin was miss-aligning with the label.

Reviewed By: antonk52

Differential Revision: D43872373

fbshipit-source-id: 8a6ff8104c6e532d8139053aad221244c2cd5feb
2023-03-07 11:23:20 -08:00
Lorenzo Blasa
a7e523a77c MarkerTimeline set fixed decimals
Summary:
Set a fixed number of decimals for the 'ms'.
More doesn't give more insights and it messes with the overall layout.

Reviewed By: antonk52

Differential Revision: D43872203

fbshipit-source-id: 343278923ee27dbf884af41c997457bfba337ba8
2023-03-07 11:23:20 -08:00
Lorenzo Blasa
305de28f4e MarkerTimeline remove hover padding
Summary: Remove the bottom padding as this was not really making it any better.

Reviewed By: antonk52

Differential Revision: D43872178

fbshipit-source-id: 8302385d190c65000afda02b5c8aa9d272ccc271
2023-03-07 11:23:20 -08:00
Lorenzo Blasa
94587831d5 MarkerTimeline hover background color
Summary:
The hover background colour had complete disregard on the selected theme, both light and dark.

This change removes the gradient and instead sets a right hover background.

Reviewed By: antonk52

Differential Revision: D43872161

fbshipit-source-id: 4f0bfd97a2cb6bb9ceb7869dd38b37dc68ad6bb7
2023-03-07 11:23:20 -08:00
Andres Suarez
79023ee190 Update copyright headers from Facebook to Meta
Reviewed By: bhamodi

Differential Revision: D33331422

fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01
2021-12-27 14:31:45 -08:00
Michel Weststrate
5c8dde0925 Theming colors
Summary:
This diff adds Sandy colors and dark mode support to the `DataInspector` and `LayoutInspector` components, and coverts hardcoded colors to semantic colors. Currently only one set of colors is used since they contrast fine with both dark and light mode, but this could be deviated from now onwards.

Also styled the legacy ManagedTable and Panel, since they are so commonly used (will convert more legacy components in next diffs).

Reviewed By: passy

Differential Revision: D28056698

fbshipit-source-id: 5a85103983f89e82b7f000d309bb9e1e1f07491d
2021-06-29 08:39:34 -07:00
Anton Nikolaev
4a583ad086 Make color of time markers more contrast
Summary: Changelog: Increased contrast of timestamps text on marker timelines used in several plugins (QPL, Sections)

Reviewed By: mweststrate

Differential Revision: D28707431

fbshipit-source-id: 8749a95fccf895bddf707c1d830baf5c65578fb9
2021-05-26 08:18:01 -07:00
Michel Weststrate
53c557f923 Move DataInspector to flipper-plugin
Summary:
This diff moves the rest of the DataInspector jungle to flipper-plugin. No actual improvements are made yet, but the code is decoupled from Electron and the legacy theming. For example by using Antd based context menus.

Note that `ManagedDataInspector` is now rebranded `DataInspector`, as that is the only variation that should (and is) used publicly.

For the interactionTracker removal, see next diff.

SearchableDataInspector will be addressed in a next diff

Reviewed By: passy

Differential Revision: D27603125

fbshipit-source-id: 188bd000260e4e4704202ce02c7fc98319f0bc22
2021-04-07 07:55:13 -07:00