1bb1cae1675aee173f8048cf68bc39b0f8cc5f6d
4575 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Michel Weststrate
|
1bb1cae167 |
Don't send messages to disconnected clients. Make exportPersistedState compatible with disconnected devices.
Summary:
This diff addresses two problems:
1. Since clients plugins can be active beyond having a connection, we have to make it possible for plugin authors to check if they are connected before they make a call.
2. if there is a custom `exportPersistedState`, plugins should be able to skip making calls if the device has disconnected.
Introducing this change makes it possible to interact with a reasonable level with disconnected clients, and makes it possible to create Flipper traces for disconnected clients.
Note that both items were already problems before supporting offline clients; as there can be a noticeable delay between disconnecting and Flipper detecting that (i've seen up to 30 secs). What happend previously in those cases is that the export would simply hang, as would other user interactions, as loosing the connection in the middle of a process would cause the promise chains to be neither rejected or resolved, which is pretty iffy.
Before this diff, trying to export a disconnected device would hang forever like:
{F369600601}
Reviewed By: nikoant
Differential Revision: D26250895
fbshipit-source-id: 177624a116883c3cba14390cd0fe164e243bb97c
|
||
|
Michel Weststrate
|
7650ab620d |
Fixed bug causing pending events of non-sandy plugins not to be part of the export
Summary: During testing I noticed that even though plugin queues were flushed, the processed messages didn't end up in the export snapshots. This was caused by holding a ref of an older snapshot of the state Changelog: Fixed an issue where data that arrived in the background was not part of the generated Flipper export. Reviewed By: nikoant Differential Revision: D26250897 fbshipit-source-id: ddd3f5bb19e38a1b13498d03f235bf63858eb8f8 |
||
|
Michel Weststrate
|
2df117923c |
Select new client after connecting, if possible
Summary: Small UX improvement, try to select a newly arriving client if possible, this is nice as it means that disconnecting and connecting will typically end you up in the same app. Changelog: If a new client connects, Flipper will try to focus on it Reviewed By: nikoant Differential Revision: D26250896 fbshipit-source-id: 83d9777a8608cd887d663a6bbe1444d2aa614e95 |
||
|
Michel Weststrate
|
ff7997b3fa |
Make sure disconnected devices / apps can be imported and exported
Summary: It should be possible to exported disconnected devices, so that flipper traces / support form reports can be created from them. This diff introduces this functionality. Support for plugins with custom export logic is introduced in a later diff. Issues fixed in this diff: - don't try to take a screenshot for a disconnected device (this would hang forever) - device plugins were always exported, regardless whether the user did select them or not - sandy plugins were never part of exported disconnected clients - increased the amount of data exported for device logs to ~10 MB. This makes more sense now as the logs will no longer be included in all cases - fixed issue where are plugins would appear to be enabled after the client disconnected (this bug is the result of some unfortunate naming of `isArchived` vs `isConnected` semantics. Will clean up those names in a later diff. Changelog: It is now possible to create a Flipper trace for disconnected devices and apps Reviewed By: nikoant Differential Revision: D26250894 fbshipit-source-id: 4dd0ec0cb152b1a8f649c31913e80efc25bcc5dd |
||
|
Michel Weststrate
|
8bc1b953c2 |
Show current device/app connection status in AppInspect selector
Summary: UX love for imported and disconnected devices, so that stuff looks better :) Reviewed By: nikoant Differential Revision: D26249348 fbshipit-source-id: 70db682ccf0cb73161e136994f5135717f3c6be6 |
||
|
Michel Weststrate
|
bb529411b5 |
Expose current connection status to Sandy plugins
Summary: Introduced `isConnected` flag on device and plugin client to reflect whether a connection is still available for the plugins, or that they have been disconnected. Potentially we could expose the (readonly) `connected` state atom for this as well, or an `onDisconnect` event for device pugins, to create a responsive UI, but there might be no need for that, in which case this suffices. Reviewed By: nikoant Differential Revision: D26249346 fbshipit-source-id: b8486713fdf2fcd520488ce54f771bd038fd13f8 |
||
|
Michel Weststrate
|
7e1bf0f58b |
Preserve client state after disconnect
Summary: This diff introduces support for keeping clients around after they have disconnected. This is a pretty important debugging improvement, that will allow inspecting a device / app after it crashed for example. With this diff, the current client is just kept around until it connects again, instead of throwing clients immediately away if they disconnect. After this change, ArchivedClients will only be created by imports / exports, and no longer by disconnects. Initially I played with improving the creation of archived devices, by migrating all plugin state over from the original client to the archive, but I discovered that is very prone, as it would be a lot of pointer redistribution (plugins would point to a different client / device etc). While in contrast, disconnected clients is already an existing concept in Flipper, so reusing that keeps all the changes relatively simple. Note that we could potentially still reuse old clients around after reconnected, but it would become much harder to reason about how plugins would behave if they missed updates for a while, so throwing away the device / clients and starting with a fresh slate sounds safer. So I figured that chance to be too risky for now, but would probably be good follow up work. Issues with import / export, UX, and making calls to to a disconnected client will be addressed in follow up diffs Changelog: Clients will retain their state after being disconnected, until they reconnect again Reviewed By: nikoant Differential Revision: D26224677 fbshipit-source-id: feb9d241df2304341c2847fe7fd751ac54c045f6 |
||
|
Michel Weststrate
|
c43049d881 |
Preserve device state after disconnect
Summary: This diff stack introduces support for keeping devices and clients around after they have disconnected. This is a pretty important debugging improvement, that will allow inspecting a device / app after it crashed for example. This feature existed partially before, but only supported Android, and only support plugins with persisted state; as it replace the current device with an archived version of the same device. In practice this didn't work really well, as most plugins would not be available, and all non-persisted state would be lost. This diff makes sure we can keep devices around after disconnecting, the next one will keep the clients around as well. And explain some code choices in more detail. Note that `Device.isArchived` was an overloaded term before, and even more now (both representing imported and disconnected devices), will address that in a later diff. https://github.com/facebook/flipper/issues/1460 https://github.com/facebook/flipper/issues/812 https://github.com/facebook/flipper/issues/1487 Changelog: iOS and Android devices will preserve their state after being disconnected Reviewed By: nikoant Differential Revision: D26224310 fbshipit-source-id: 7dfc93c2a109a51c2880ec212a00463bc8d32041 |
||
|
Michel Weststrate
|
7361ecc080 |
Disable CPU plugin on archived devices
Summary: Changelog: CPU plugin will no longer show up for archived devices CPU plugin did show up on imported devices, but would always result in exceptions as no `adb` connection is available for them. Reviewed By: jknoxville Differential Revision: D26249575 fbshipit-source-id: c4fa7b3fec895f9c4ab9e31dce2f61fb23e9195b |
||
dependabot[bot]
|
eb302235cd |
Bump metro-react-native-babel-preset from 0.64.0 to 0.65.0 in /react-native/ReactNativeFlipperExample (#1881)
Summary: Bumps [metro-react-native-babel-preset](https://github.com/facebook/metro) from 0.64.0 to 0.65.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro-react-native-babel-preset's releases</a>.</em></p> <blockquote> <h2>Release v0.65.0</h2> <ul> <li><strong>[Breaking]</strong>: Remove JSON from default asset types (<a href="https://github-redirect.dependabot.com/facebook/metro/issues/593">https://github.com/facebook/flipper/issues/593</a>)</li> <li><strong>[Breaking]</strong>: Removes support for Node 10 (bc8a3f057c7fe277742de6ca9ce98808a76b1d03)</li> <li><strong>[Feature]</strong>: <code>metro-symbolicate</code>: Support for symbolicating Chrome heap timelines (TODO get hashes of cb542c0f00987996caeef9672288e2b386d36d8b, 6b0a0cb6afaa28d3a72fb2df7cbd2a99dc7362c4)</li> <li><strong>[Feature]</strong>: Update the default list of lazy imports to match RN 0.63 (<a href="https://github-redirect.dependabot.com/facebook/metro/issues/602">https://github.com/facebook/flipper/issues/602</a>)</li> <li><strong>[Performance]</strong>: Several changes that improve Metro's startup and bundling performance (807bea7, bc8a3f0, aceafc5, 279b295, 745e2d8, a942002, d6eefe4)</li> <li><strong>[Fix]</strong>: Optimize <code>Platform.select()</code> calls correctly when the argument includes methods (4d9908b)</li> <li><strong>[Fix]</strong>: Handle EISDIR errors in <code>buildCodeFrameMessage</code> (<a href="https://github-redirect.dependabot.com/facebook/metro/issues/567">https://github.com/facebook/flipper/issues/567</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Michel Weststrate
|
9987c8ee89 |
Make sure antd is used from Flipper
Summary: Fix build job that didn't include require rewrites for antd Reviewed By: timur-valiev Differential Revision: D26311554 fbshipit-source-id: 473a9c7d343e4534a33e5938ea27667f7795d8ac |
||
Pascal Hartig
|
949b57b473 |
Improve types
Summary: The any type was masking how the log object is actually initialised. Sorry for the deluge of drive-by diffs. Something more substantial is coming. Reviewed By: mweststrate Differential Revision: D26250580 fbshipit-source-id: 5ba3f450ac1a646616868a8fd8b3cb42fb14dcc8 |
||
Pascal Hartig
|
93d23e8c0a |
Upgrade to Gradle 6.8.1 (#1895)
Summary: Playing around with alternative upload options and having an up-to-date Gradle installation makes that easier. Pull Request resolved: https://github.com/facebook/flipper/pull/1895 Test Plan: ./gradlew :sample:assembleDebug + CI Reviewed By: nikoant Differential Revision: D26275350 Pulled By: passy fbshipit-source-id: ce5d11c289e6cf52e2d629a4719cc38665adf8e5 |
||
Pritesh Nandgaonkar
|
87e7afe4ab |
Update tutorial podfiles and GH actions (#1896)
Summary: This PR updates the flipperkit version of the Tutorial and updates the GH action to test it without the arch flag. This PR also fixes the script which updates the `flipperkit_version` tag in all the files. It was broken for Tutorial, as it used to replace the last released version of the pod with the current one in each file, but for some reason the flipper version in the Tutorial/Podfile was way older and it never got updated. I have fixed the logic now to replace the current version in the file with the new one, rather than relying on only last version to be replaced. ## Changelog - Updated the GH action of tutorial to remove the -arch flag - Updated Tutorial/Podfile and Podfile.lock - Updated scripts/update-pod-versions.sh Pull Request resolved: https://github.com/facebook/flipper/pull/1896 Test Plan: CI should be green Tested that the version gets updated for each and every file, file tested were Flipper.podspec, FlipperKit.podspec, Sample/Podfile SampleSwift/Podfile Tutorial/Podfile {F369967362} {F369967395} Reviewed By: nikoant Differential Revision: D26275657 Pulled By: priteshrnandgaonkar fbshipit-source-id: 0f21a2a33c740938d2b29624e95974e80a2e38ba |
||
|
Pascal Hartig
|
e788bb09be |
Add logs support for physical devices
Summary: There's a bit of an oddity with `idb` that the `stream` parameter is implied even though the docs say otherwise and if you try to use it, it'll give you a strange Python error. That's likely why we never implemented it. Now, it works just as it does using local tooling. Reviewed By: mweststrate Differential Revision: D26228036 fbshipit-source-id: e20cb31167170ba0501e2929ed129305cb9aaf2c |
||
GitHub
|
05acdc99b0 |
Automated: Update Podfile.lock (#1894)
Summary: This is an automated PR to update the Podfile.lock. - Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions. - Also make sure that all the dependencies are updated to the latest one. - This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request) Pull Request resolved: https://github.com/facebook/flipper/pull/1894 Reviewed By: mweststrate Differential Revision: D26275066 Pulled By: priteshrnandgaonkar fbshipit-source-id: c215bc6fe79d4b194c6c3e96eaa2e17298d25858 |
||
|
Pritesh Nandgaonkar
|
8ade24abbc |
Solves the sampleswift failing job (#1893)
Summary:
Solves the sampleswift failing job, by removing the linker flags which were used when we relied on CocoaLibEvent, but now we do not rely on this.
## Changelog
- Removed cocoalib flag
- Removed arch requirement from the workflow for sample swift
If the flag is removed from the objc sample then I get the following error. It looks like for the objc project, xcode is not able to find the arm64 artifacts for swift deps.
I tried all the alternatives for solving this issue, but it didn't work for objc. I will wait for new xcode and will try with that, hopefully, the newer xcode has the fix.
```
ld: warning: Could not find or use auto-linked library 'swiftFoundation'
ld: warning: Could not find or use auto-linked library 'swiftMetal'
ld: warning: Could not find or use auto-linked library 'swiftUIKit'
ld: warning: Could not find or use auto-linked library 'swiftDarwin'
ld: warning: Could not find or use auto-linked library 'swiftObjectiveC'
ld: warning: Could not find or use auto-linked library 'swiftCoreFoundation'
ld: warning: Could not find or use auto-linked library 'swiftDispatch'
ld: warning: Could not find or use auto-linked library 'swiftCoreImage'
ld: warning: Could not find or use auto-linked library 'swiftCore'
ld: warning: Could not find or use auto-linked library 'swiftQuartzCore'
ld: warning: Could not find or use auto-linked library 'swiftCoreGraphics'
ld: warning: Could not find or use auto-linked library 'swiftSwiftOnoneSupport'
Undefined symbols for architecture arm64:
"protocol descriptor for Swift.ExpressibleByFloatLiteral", referenced from:
l_got.$ss25ExpressibleByFloatLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
"associated type descriptor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType", referenced from:
l_got.$s18IntegerLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
"associated conformance descriptor for Swift.ExpressibleByIntegerLiteral.Swift.ExpressibleByIntegerLiteral.IntegerLiteralType: Swift._ExpressibleByBuiltinIntegerLiteral", referenced from:
l_got.$ss27ExpressibleByIntegerLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
"method descriptor for Swift.ExpressibleByFloatLiteral.init(floatLiteral: A.FloatLiteralType) -> A", referenced from:
l_got.$ss25ExpressibleByFloatLiteralP05floatD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
"protocol descriptor for Swift.ExpressibleByIntegerLiteral", referenced from:
l_got.$ss27ExpressibleByIntegerLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
"value witness table for Builtin.Int32", referenced from:
full type metadata for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftCoreImage", referenced from:
__swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit)
"associated type descriptor for Swift.ExpressibleByFloatLiteral.FloatLiteralType", referenced from:
l_got.$s16FloatLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftQuartzCore", referenced from:
__swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit)
"__swift_FORCE_LOAD_$_swiftDispatch", referenced from:
__swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit)
"method descriptor for Swift.ExpressibleByIntegerLiteral.init(integerLiteral: A.IntegerLiteralType) -> A", referenced from:
l_got.$ss27ExpressibleByIntegerLiteralP07integerD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftCoreFoundation", referenced from:
__swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit)
"protocol witness table for Swift.Int : Swift._ExpressibleByBuiltinIntegerLiteral in Swift", referenced from:
associated type witness table accessor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType : Swift._ExpressibleByBuiltinIntegerLiteral in __C.YGValue : Swift.ExpressibleByIntegerLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftObjectiveC", referenced from:
__swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit)
"__swift_FORCE_LOAD_$_swiftCoreGraphics", referenced from:
__swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit)
"_swift_getForeignTypeMetadata", referenced from:
type metadata accessor for __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
type metadata accessor for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftFoundation", referenced from:
__swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit)
"associated conformance descriptor for Swift.ExpressibleByFloatLiteral.Swift.ExpressibleByFloatLiteral.FloatLiteralType: Swift._ExpressibleByBuiltinFloatLiteral", referenced from:
l_got.$ss25ExpressibleByFloatLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftUIKit", referenced from:
__swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit)
"__swift_FORCE_LOAD_$_swiftMetal", referenced from:
__swift_FORCE_LOAD_$_swiftMetal_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftMetal_$_YogaKit)
"Swift.Float.init(Swift.Double) -> Swift.Float", referenced from:
static (extension in YogaKit):CoreGraphics.CGFloat.% postfix(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
(extension in YogaKit):__C.YGValue.init(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftDarwin", referenced from:
__swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit)
"protocol witness table for Swift.Float : Swift._ExpressibleByBuiltinFloatLiteral in Swift", referenced from:
associated type witness table accessor for Swift.ExpressibleByFloatLiteral.FloatLiteralType : Swift._ExpressibleByBuiltinFloatLiteral in __C.YGValue : Swift.ExpressibleByFloatLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
Pull Request resolved: https://github.com/facebook/flipper/pull/1893
Test Plan:
CI in github should be green
flipper-oss-ios-build works
https://www.internalfb.com/intern/sandcastle/job/22517998513117018/
Reviewed By: mweststrate
Differential Revision: D26254390
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 291cfb949e781ccb9e0317679daa673dcf8e9479
|
||
John Knox
|
e250bda60d |
Fix cert dialog popup on open-source sites
Summary: Upgrades the FB-internal documentation plugin, to no longer call the internal api that requires auth, for external viewers. Context: https://fb.workplace.com/groups/654274975334601/permalink/1288672008171584/ Reviewed By: justintrudell Differential Revision: D26252469 fbshipit-source-id: 31068534ce79a7959c38c6e66e6a9cf12371e228 |
||
|
dependabot[bot]
|
f4cc6bc1c5 |
Bump @typescript-eslint/eslint-plugin from 4.14.0 to 4.14.2 in /flipper-js-client-sdk (#1891)
Summary: Bumps [typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.14.0 to 4.14.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>typescript-eslint/eslint-plugin's releases</code></a>.</em></p> <blockquote> <h2>v4.14.2</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.14.1...v4.14.2">4.14.2</a> (2021-02-01)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [consistent-type-imports] incorrect handling of computed property type signatures (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/2990">#2990</a>) (<a href=" |
||
generatedunixname89002005306973
|
e8e205a91f |
Flipper Snapshot Bump: v0.74.1-SNAPSHOT
Summary: Releasing snapshot version 0.74.1-SNAPSHOT Reviewed By: jknoxville Differential Revision: D26253174 fbshipit-source-id: b5fe3e0738c25f3580d721223e79ddfe386229f4 |
||
|
generatedunixname89002005306973
|
0429c1892f |
Flipper Release: v0.74.0
Summary: Releasing version 0.74.0 Reviewed By: jknoxville Differential Revision: D26253173 fbshipit-source-id: 80f4e3917cf130bbf546af6d48e43a62265660d0 |
||
|
Pritesh Nandgaonkar
|
0ebe3956a4 |
Update OpenSSL pod and remove exclude arch setting (#1892)
Summary: This PR updates the OpenSSL pod and thus updates the corresponding Folly and RSocket pods. The new OpenSSL pod has a support of arm64 artifact for iPhomeSimulators.This PR also updates the replaces the libevent pod which didn't work with arm64 arch for iPhoneSimulator. ## Changelog - Update OpenSSL pod - Update Folly dep - Update RSocket dep - Replace Libevent pod. Pull Request resolved: https://github.com/facebook/flipper/pull/1892 Test Plan: CI Reviewed By: mweststrate Differential Revision: D26229304 Pulled By: priteshrnandgaonkar fbshipit-source-id: 46256d9cd3e0cf5aab6e477e612c3bcb77e31627 |
||
|
Pascal Hartig
|
87caca9e77 |
Demote iOS connection errors
Summary: The "attaching failed" error provides no context and is a handled error, so we don't need to elevate this to a warning. We also see a socket warning on stderr every time we start up logging through simctl, so we don't need to treat that as an error. Reviewed By: nikoant Differential Revision: D26228037 fbshipit-source-id: 1938dadd54499462e1fd614c9477f738661c387b |
||
|
Pascal Hartig
|
661af25ff9 |
getAppVersion for UpdateIndicator
Summary:
VSCode got a new thing where it doesn't save my file because it waits for a formatter or some stuff indefinitely, which is really cool, because it means my diffs end up being incomplete.
So this should have been in D26223274 (
|
||
Anton Nikolaev
|
2f03aca5eb |
Revert D26222885: Upgrade metro to 0.65.0
Differential Revision:
D26222885 (
|
||
|
Pascal Hartig
|
642d89213d |
Extract getAppVersion() util
Summary: Just some simple memoisation so we limit this particular `remote` call to one per session. Reviewed By: mweststrate Differential Revision: D26223274 fbshipit-source-id: 7a12764758823c52f68fb7075f46caf58affb22f |
||
|
Michel Weststrate
|
40abef860f |
Fix key warning
Summary: Crash reporter generated React errors because the different lines in a stack trace are not per definition unique Reviewed By: jknoxville Differential Revision: D26201941 fbshipit-source-id: 084e0157b1fa3b8216d35f62f0dc17b0d6414b8e |
||
|
Anton Nikolaev
|
9fe82dd6c7 |
Upgrade metro to 0.65.0
Summary: Upgrade metro to 0.65.0 Reviewed By: passy Differential Revision: D26222885 fbshipit-source-id: bb386ae4bc913d47d9f3431368e45c6319f0d65d |
||
|
dependabot[bot]
|
e09e3c82ee |
Bump antd from 4.9.1 to 4.11.2 in /desktop (#1886)
Summary: allow-large-files Bumps [antd](https://github.com/ant-design/ant-design) from 4.9.1 to 4.11.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.11.2</h2> <ul> <li>{emoji:1f41e} Fix rc-trigger BuildInPlacements TypeScript compile error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li> </ul> <hr /> <ul> <li>{emoji:1f41e} 修复 rc-trigger BuildInPlacements TypeScript 编译错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li> </ul> <h2>4.11.1</h2> <ul> <li>{emoji:1f484} Layout inline sub menu now has grey background. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f195} PageHeader supports <code>breadcrumbRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li> <li>{emoji:1f195} Typography <code>ellipsis</code> support <code>tooltip</code> to customize tooltip when ellipsis. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li> <li>Image <ul> <li>{emoji:1f195} Image supports <code>preview.maskClassName</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li> <li>{emoji:1f41e} Fix preview image will move after click it. <a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li> <li>{emoji:1f41e} Fix Image <code>placeholder</code> disappear issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li> <li>{emoji:1f41e} Fix multiple Image.PreviewGroup contain same image. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li> </ul> </li> <li>ConfigProvider <ul> <li>{emoji:1f195} ConfigProvider supports <code>iconPrefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li> <li>{emoji:26a1} Optimize ConfigProvider props updating perfermance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li> </ul> </li> <li>{emoji:1f484} Tweak TreeSelect filter highlight color. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li> <li>{emoji:1f484} Fix Select item align style with custom <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li> <li>Form <ul> <li>{emoji:1f41e} Fix Form.Item can not clear nested <code>noStyle</code> error message. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li> <li>{emoji:1f41e} Form.Item with <code>preserve=false</code> will reset value to <code>initialValues</code> when removed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li> </ul> </li> <li>{emoji:1f41e} Fix Button click effect style not working in shadow root. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28995">#28995</a> <a href="https://github.com/rinick"><code>rinick</code></a></li> <li>{emoji:1f41e} Fix Table custom filter menu cannot close bug. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28688">#28688</a> <a href="https://github.com/alekye"><code>alekye</code></a></li> <li>Less <ul> <li>{emoji:1f484} Add <code>menu-inline-submenu-bg</code> less variable and rename <code>menu-dark-submenu-bg</code> to <code>menu-dark-inline-submenu-bg</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f484} Add less variable <code>drawer-footer-padding-horizontal</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28975">#28975</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li> </ul> </li> <li>RTL <ul> <li>{emoji:1f484} Fix Card actions divider style in RTL. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28915">#28915</a> <a href="https://github.com/Aghosey"><code>Aghosey</code></a></li> </ul> </li> <li>TypeScript <ul> <li>� Expose interfaces and types from default entry of antd. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28963">#28963</a></li> <li>� Improve Input/Skeleton <code>style</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28966">#28966</a> <a href="https://github.com/yingpengsha"><code>yingpengsha</code></a></li> </ul> </li> </ul> <hr /> <ul> <li>{emoji:1f484} Layout 内联子表单添加背景颜色以更好的区分层级。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f195} PageHeader 支持 <code>breadcrumbRender</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li> <li>{emoji:1f195} Typography <code>ellipsis</code> 属性添加 <code>tooltip</code> 支持以自定义收缩时的提示信息。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li> <li>Image <ul> <li>{emoji:1f195} Image 支持配置 <code>preview.maskClassName</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li> <li>{emoji:1f41e} 修复预览图片会跟随鼠标移动的问题。<a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li> <li>{emoji:1f41e} 修复 Image <code>placeholder</code> 不显示的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li> <li>{emoji:1f41e} 修复多个 Image.PreviewGroup 之间图片互串的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li> </ul> </li> <li>ConfigProvider</li> <li>ConfigProvider <ul> <li>{emoji:1f195} ConfigProvider 支持 <code>iconPrefixCls</code> 修改图标样式前缀。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li> <li>{emoji:26a1} 优化 ConfigProvider 切换属性的性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li> </ul> </li> <li>{emoji:1f484} 调整 TreeSelect 搜索高亮条目的颜色。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li> <li>{emoji:1f484} 修复 Select 自定义 <code>tagRender</code> 时不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li> <li>Form <ul> <li>{emoji:1f41e} 修复 Form.Item 无法正确清理嵌套的 <code>noStyle</code> 错误信息问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li> <li>{emoji:1f41e} Form.Item 配置 <code>preserve=false</code> 时，移除该字段将自动重置对应值为 <code>initialValues</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.11.2</h2> <p><code>2021-01-26</code></p> <ul> <li>{emoji:1f41e} Fix rc-trigger BuildInPlacements TypeScript compile error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li> </ul> <h2>4.11.1</h2> <p><code>2021-01-24</code></p> <ul> <li>{emoji:1f484} Layout inline sub menu now has grey background. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f195} PageHeader supports <code>breadcrumbRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li> <li>{emoji:1f195} Typography <code>ellipsis</code> support <code>tooltip</code> to customize tooltip when ellipsis. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li> <li>Image <ul> <li>{emoji:1f195} Image supports <code>preview.maskClassName</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li> <li>{emoji:1f41e} Fix preview image will move after click it. <a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li> <li>{emoji:1f41e} Fix Image <code>placeholder</code> disappear issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li> <li>{emoji:1f41e} Fix multiple Image.PreviewGroup contain same image. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li> </ul> </li> <li>ConfigProvider <ul> <li>{emoji:1f195} ConfigProvider supports <code>iconPrefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li> <li>{emoji:26a1} Optimize ConfigProvider props updating perfermance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li> </ul> </li> <li>{emoji:1f484} Tweak TreeSelect filter highlight color. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li> <li>{emoji:1f484} Fix Select item align style with custom <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li> <li>Form <ul> <li>{emoji:1f41e} Fix Form.Item can not clear nested <code>noStyle</code> error message. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li> <li>{emoji:1f41e} Form.Item with <code>preserve=false</code> will reset value to <code>initialValues</code> when removed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li> </ul> </li> <li>{emoji:1f41e} Fix Button click effect style not working in shadow root. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28995">#28995</a> <a href="https://github.com/rinick"><code>rinick</code></a></li> <li>{emoji:1f41e} Fix Table custom filter menu cannot close bug. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28688">#28688</a> <a href="https://github.com/alekye"><code>alekye</code></a></li> <li>Less <ul> <li>{emoji:1f484} Add <code>menu-inline-submenu-bg</code> less variable and rename <code>menu-dark-submenu-bg</code> to <code>menu-dark-inline-submenu-bg</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f484} Add less variable <code>drawer-footer-padding-horizontal</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28975">#28975</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li> </ul> </li> <li>RTL <ul> <li>{emoji:1f484} Fix Card actions divider style in RTL. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28915">#28915</a> <a href="https://github.com/Aghosey"><code>Aghosey</code></a></li> </ul> </li> <li>TypeScript <ul> <li>� Expose interfaces and types from default entry of antd. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28963">#28963</a></li> <li>� Improve Input/Skeleton <code>style</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28966">#28966</a> <a href="https://github.com/yingpengsha"><code>yingpengsha</code></a></li> </ul> </li> </ul> <h2>4.11.0</h2> <p><code>2021-01-24</code></p> <p>It is a wrong release which same as <code>4.10.3</code>, don't use it.</p> <h2>4.10.3</h2> <p><code>2021-01-18</code></p> <ul> <li>{emoji:1f41e} Fix Button not adapting to the <code>btn-border-width</code> when loading. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28886">#28886</a> <a href="https://github.com/jjanssen"><code>jjanssen</code></a></li> <li>Table <ul> <li>{emoji:1f484} Add <code>table-border-color</code> less variable. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28903">#28903</a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
05d1bd1ccb |
Bump react-native-flipper from 0.72.0 to 0.73.0 in /react-native/ReactNativeFlipperExample (#1882)
Summary: Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.72.0 to 0.73.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/flipper/releases">react-native-flipper's releases</a>.</em></p> <blockquote> <h2>v0.73.0</h2> <p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a> for full notes.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
0cae7066b6 |
Bump @typescript-eslint/parser from 4.14.0 to 4.14.2 in /flipper-js-client-sdk (#1890)
Summary: Bumps [typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.14.0 to 4.14.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>typescript-eslint/parser's releases</code></a>.</em></p> <blockquote> <h2>v4.14.2</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.14.1...v4.14.2">4.14.2</a> (2021-02-01)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [consistent-type-imports] incorrect handling of computed property type signatures (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/2990">#2990</a>) (<a href=" |
||
|
Pritesh Nandgaonkar
|
6a0854557e |
Add gk checks in plugin
Summary: This diff adds gk checks, VPN check and User login check to our plugin. I added gk checks for Insta and FB apps. There are three kind of GK's. One with FB universe, one with Distillery universe and one with Insta WWW universe. We have API's to check gk with FB and Distillery universe. API to check with Insta WWW universe doesn't exists. There are some technical challenges to build this API. So right now for gks with Insta WWW universe, we just show an notification with info icon. For gks in other universe we aggressively check it when user closes the notif to verify if user assigned himself/herself to it. In long term we are moving away from gks altogether, we need this UX improvement as it will help users to onboard easily. See the following flow. Reviewed By: mweststrate Differential Revision: D26176996 fbshipit-source-id: 92a931610f9b244c14c6888bb12df936b62edd75 |
||
|
Pascal Hartig
|
9469ad33af |
Make addErrorNotification raise a warning
Summary: These are recoverable, handled errors. We shouldn't treat these as events that require actions from us. They also have a tendency of firing a lot. Reviewed By: nikoant Differential Revision: D26202358 fbshipit-source-id: 445f3c2bcd0041d5cd773ec04172fdeed9b32222 |
||
|
Pascal Hartig
|
6dffc5695e |
Bump ts linters
Summary: It had this scary warning at the top that the TS version was too new for the linters. Reviewed By: nikoant Differential Revision: D26202273 fbshipit-source-id: df03d6bf176da00ee37b027679b9f258ab123395 |
||
|
dependabot[bot]
|
5850bb6b52 |
Bump open from 7.0.3 to 7.3.1 in /desktop (#1867)
Summary: Bumps [open](https://github.com/sindresorhus/open) from 7.0.3 to 7.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sindresorhus/open/releases">open's releases</a>.</em></p> <blockquote> <h2>v7.3.1</h2> <ul> <li>Fix support for WSL when Windows isn&<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/39">https://github.com/facebook/flipper/issues/39</a>;t mounted in <code>/mnt/</code> (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/210">https://github.com/facebook/flipper/issues/210</a>) a3bbadc</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.3.0...v7.3.1">https://github.com/sindresorhus/open/compare/v7.3.0...v7.3.1</a></p> <h2>v7.3.0</h2> <ul> <li>Support WSL configuration where Windows paths are not in PATH (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/195">https://github.com/facebook/flipper/issues/195</a>) be0f794</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.2.1...v7.3.0">https://github.com/sindresorhus/open/compare/v7.2.1...v7.3.0</a></p> <h2>v7.2.1</h2> <ul> <li>Fix <code>app</code> option on Windows (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/191">https://github.com/facebook/flipper/issues/191</a>) 9bcd285</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.2.0...v7.2.1">https://github.com/sindresorhus/open/compare/v7.2.0...v7.2.1</a></p> <h2>v7.2.0</h2> <ul> <li>Use PowerShell on Windows for improved reliability (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/188">https://github.com/facebook/flipper/issues/188</a>) f7ca0d3</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.1.0...v7.2.0">https://github.com/sindresorhus/open/compare/v7.1.0...v7.2.0</a></p> <h2>v7.1.0</h2> <ul> <li>Add <a href="https://github.com/sindresorhus/open#allownonzeroexitcode"><code>allowNonzeroExitCode</code></a> option (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/176">https://github.com/facebook/flipper/issues/176</a>) e009765</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.0.4...v7.1.0">https://github.com/sindresorhus/open/compare/v7.0.4...v7.1.0</a></p> <h2>v7.0.4</h2> <ul> <li>Fix double-encoding of URLs (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/182">https://github.com/facebook/flipper/issues/182</a>) 48b6d0e</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.0.3...v7.0.4">https://github.com/sindresorhus/open/compare/v7.0.3...v7.0.4</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Pascal Hartig
|
12ca12094d |
Linux artifact
Summary: Update the binary for Linux. Took me *a freaking hour* to build. I need an M1 Mac. Reviewed By: mweststrate Differential Revision: D26197862 fbshipit-source-id: e5a593743d239598bab1c8f29a778a49e17afcf8 |
||
|
Pascal Hartig
|
fec1f803b8 |
Add lock file
Summary: Recent versions of stack added this. Probably a good idea to commit this. Reviewed By: nikoant Differential Revision: D26174669 fbshipit-source-id: eaad59f81aa5cdb6cdd456029f1f176b458cac28 |
||
|
Pascal Hartig
|
20b57e2ad9 |
Mac artifact
Summary: This is the new Mac artifact based on what's in the code. Still building the Linux one., Reviewed By: nikoant Differential Revision: D26174670 fbshipit-source-id: a5364b45bcc8d6325a698633d0e1a076ef1080ad |
||
|
Pascal Hartig
|
c73fdb090d |
Include react native path
Summary: Note: Binary update will follow as separate diff. Noticed that these weren't updated automatically. Reviewed By: mweststrate Differential Revision: D26150738 fbshipit-source-id: 05583a3d8c6425d41e985255e0281a90e5062dad |
||
|
Michel Weststrate
|
9bd3d6fd7c |
Fix serialization performance
Summary:
Using our serialization utilities in the previous diff absolute destroyed the performance of serializing the device logs. Investigated a bit, and the root cause is that *every* object serialization would notify the UI.
This is not only pointless, since the UI won't be updated until the next tick anyway, it also is terribly expensive since React has to process and queue all these updates.
Exporting the device logs went down from **2 minutes to a few seconds** with this change. (Still a lot slower than JSON.stringify, but I think the flexibility for plugin devs is worth it).
This change does not only benefit devicelogs plugin, but all existing plugins as well, plugins like GraphQL should now export their data much quicker.
Before (practically all time of serialization is spend in React's setState):
{F366147730}
After (only a spike at the end of the idler tick):
{F366147779}
Reviewed By: priteshrnandgaonkar
Differential Revision: D26146420
fbshipit-source-id: 9bbeccf04701fd044e041956b7bb00f1e0622b63
|
||
|
Michel Weststrate
|
594fa4d2bc |
serialize Sandy plugins with serialization utils to support Date/Set/Map
Summary: Unlike non-sandy plugins, non-sandy plugins weren't serialized using our serialization utility yet. This diff addresses that, meaning that users don't have to bother about how to serialize maps, sets and dates. Unlike the old fashioned plugins, the `makeObjectSerialize` utility is used, rather than `serialize`. This normalizes the objects, but doesn't serialize them, which is done at the end of the export data process anyway for the whole tree. This avoids creating a double JSON serialization which is fully of ugly escape characters. This makes the onImport / onExport definition of the logs plugin nicer. Also improved the docs. Reviewed By: nikoant Differential Revision: D26146421 fbshipit-source-id: 6abfb6ee2e3312e2a13a11832ff103dc62fd844c |
||
|
Michel Weststrate
|
e614993558 |
Fix incorrect date serialization
Summary:
While creating some other tests, discovered that our current date serialization uses `toString()` serialization, causing the amount of milliseconds to be lost. The serialization (see below) uses less bytes as well since the human readable timezone isn't included. This change only affects serialization and is backward compatible.
```
✓ test serialize and deserializeObject function for non Object input (1 ms)
✕ test makeObjectSerializable and deserializeObject function for Date input (2 ms)
✓ test makeObjectSerializable and deserializeObject function for Map of Sets
✓ test makeObjectSerializable and deserializeObject function for Map, Dates and Set with complex nesting (1 ms)
● test makeObjectSerializable and deserializeObject function for Date input
expect(received).toEqual(expected) // deep equality
Expected: 2021-03-01T10:31:07.205Z
Received: 2021-03-01T10:31:07.000Z
```
Reviewed By: priteshrnandgaonkar
Differential Revision: D26145941
fbshipit-source-id: dfd6607a4199ca46e2075027856138efb88a07f9
|
||
|
Michel Weststrate
|
7cc55daf34 |
Stop storing device logs on the device object and in the plugin
Summary: Logs were stored hardcoded on the Device object first, this diff makes it normal plugin state. This makes sure that we can use the same abstractions as in all plugins that store large data sets, and that we can leverage the upcoming DataSource abstraction. Reviewed By: nikoant Differential Revision: D26127243 fbshipit-source-id: 7c386a615fa7989f35ba0df5b7c1d218d37b57a2 |
||
|
Michel Weststrate
|
f2ade40239 |
Support custom data processing during import
Summary: Per title, this allows for pre-processing data after it is deserialized and before it is stored in the plugin Reviewed By: nikoant Differential Revision: D26126423 fbshipit-source-id: bc08a6ab205d2a0d551515563cd85a197595ddb2 |
||
|
Michel Weststrate
|
34c915a739 |
Add support for async / custom plugin export
Summary: Sandy plugins can now set up an `onExport` handler to enable customizing the export format of a plugin: `client.onExport(callback: (idler, onStatusMessage) => Promise<state>)` Import will be done in next diff Reviewed By: nikoant Differential Revision: D26124440 fbshipit-source-id: c787c79d929aa8fb484f15a9340d7c87545793cb |
||
|
Michel Weststrate
|
32bde8cace |
add support for device plugin import / export
Summary: Sandy device plugins weren't exported till now (the only stateful plugin so far was Logs, but logs were stored hardcoded on the device rather than using the plugin export mechanisms). This diff makes sure that SandyDevicePlugins will be exported as well if they are persistable. Reviewed By: nikoant Differential Revision: D22724822 fbshipit-source-id: a10354a9c7e02f3e696d0cdda0f2c6be6f5ac61e |
||
|
Michel Weststrate
|
e1daa449ba |
Unify computation of available plugins
Summary: While trying to change something, discovered we have 3 different mechanisms in our code base to compute active plugins; the plugin list component, support form, and export flipper trace form had all their own, subtly different implementations of computing which plugins are available to the user. Also removed some hardcoded exceptions for e.g. Logs plugin, which in the next diff and onward will be just a vanilla plugin without special casing Unified that, which some how went a bit deeper than hoped, trough some hoops in in circular deps. Also unified to use the same testing utils, to avoid some gobbling objects manually together, with resulted in a bunch of unexpected NPEs. Found out that we actually still have unit tests using Flow in the process :-P. Converted one to TS. Reviewed By: nikoant Differential Revision: D26103172 fbshipit-source-id: 2fce2577d97d98543cb9312b3d013f24faee43aa |
||
bizzguy
|
5320015776 |
Fix mock export file format (#1872)
Summary:
Provide a more robust technique for exporting the mocks to a file.
The current technique for exporting mocks to a file seems to fail under some scenarios. The correct format is an array of objects:
```
[
{
"requestUrl": "https://api.github.com/repos/facebook/yoga",
"requestMethod": "GET",
```
However, the following format is sometimes exported instead:
```
{
"10": {
"requestUrl": "https://demo9512366.mockable.io/SonarPost",
```
Using `Object.values` provides a more robust technique that has been successful during subsequent testing.
## Changelog
Network Plugin - new technique for exporting mocks
Pull Request resolved: https://github.com/facebook/flipper/pull/1872
Test Plan:
Create mocks in the network plugin
Export mocks
Manually examine file for correct format
Import mocks and verify that the file has been imported correctly
Reviewed By: nikoant
Differential Revision: D26172954
Pulled By: mweststrate
fbshipit-source-id: bdfa3ba7dfe656f30ef17df001fc83dd8ea18ece
|
||
Joshua Selbo
|
340a29c1d5 |
Add inspector descriptor for ImageView
Summary: - Made `EnumMapping` support generic value type - `ImageView.ScaleType` is a Java enum; the scaleType api uses this instead of int types. - Introduce descriptor for `ImageView` and allow getting/setting scaleType. Reviewed By: mweststrate Differential Revision: D26092725 fbshipit-source-id: ea3a4ee036b2b808f14277387d360318b7d25824 |
||
|
dependabot[bot]
|
a9ad3d2f1b |
Bump @testing-library/react from 11.1.0 to 11.2.3 in /desktop (#1868)
Summary: Bumps [testing-library/react](https://github.com/testing-library/react-testing-library) from 11.1.0 to 11.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/testing-library/react-testing-library/releases"><code>testing-library/react's releases</code></a>.</em></p> <blockquote> <h2>v11.2.3</h2> <h2><a href="https://github.com/testing-library/react-testing-library/compare/v11.2.2...v11.2.3">11.2.3</a> (2021-01-07)</h2> <h3>Bug Fixes</h3> <ul> <li>Return type of unmount is <code>void</code> (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/857">https://github.com/facebook/flipper/issues/857</a>) (<a href=" |