Commit Graph

434 Commits

Author SHA1 Message Date
facebook-flipper-bot
1a7e3b9b00 Automated: Update Podfile.lock (#2664)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2664

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D30156476/V2/flipper/)

Reviewed By: passy

Differential Revision: D30156476

Pulled By: nikoant

fbshipit-source-id: 04d3ea60a59fc2fe0507319bd6261376388ec31a
2021-08-06 04:02:35 -07:00
facebook-flipper-bot
798239507a Automated: Update Podfile.lock (#2662)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2662

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D30131497/V2/flipper/)

Reviewed By: nikoant

Differential Revision: D30131497

Pulled By: passy

fbshipit-source-id: f321dc0187da2660f585d5f3d47531d7aa19d818
2021-08-05 07:11:13 -07:00
facebook-flipper-bot
c2812a92ee Automated: Update Podfile.lock (#2637)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2637

Reviewed By: passy

Differential Revision: D29962132

Pulled By: cekkaewnumchai

fbshipit-source-id: 98cb91e790a80eac9ca530856f909e0a744e40d0
2021-07-28 09:02:41 -07:00
facebook-flipper-bot
64c5fd2448 Automated: Update Podfile.lock (#2613)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2613

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D29857462/V2/flipper/)

Reviewed By: muraziz

Differential Revision: D29857462

Pulled By: nikoant

fbshipit-source-id: f498f00b6a8fb0c631c27088509be1b3ffdbe3f3
2021-07-23 04:06:24 -07:00
facebook-flipper-bot
4953444ceb Automated: Update Podfile.lock (#2599)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2599

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D29752884/V2/flipper/)

Reviewed By: mweststrate

Differential Revision: D29752884

Pulled By: passy

fbshipit-source-id: ca8456fe519e093ca3a7c428d3c0b20aa39c19c7
2021-07-19 07:30:47 -07:00
Kamil Pyć
2bbd781cae Update Flipper-Folly.podspec (#2515)
Summary:
OpenSSL-Univeral cause app to crash with `rpath/OpenSSL.framework/OpenSSL' not found` when [debugger is not attached] (https://github.com/krzyzanowskim/OpenSSL/issues/115). Looks like this was caused by arm64e slice and it's now resolved in version 1.1.1000

It also updates the folly version to the latest checkout and solves this task T94605859. According to this task it has been asked by folly team to update its dependency to the latest version.

## Changelog

Bump OpenSSL-Universal to version 1.1.1000
Use latest folly checkout v2021.06.14.00

Pull Request resolved: https://github.com/facebook/flipper/pull/2515

Test Plan: There are no code changes, this only removes problematic arm64 slice from OpenSSL-Universal xcframework.

Reviewed By: nikoant

Differential Revision: D29489739

Pulled By: priteshrnandgaonkar

fbshipit-source-id: cd54eccddb9fb87c9e0e25c3b2cedbdb74408f92
2021-07-01 07:05:16 -07:00
facebook-flipper-bot
78df309d16 Automated: Update Podfile.lock (#2544)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2544

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D29499361/V2/flipper/)

Reviewed By: priteshrnandgaonkar

Differential Revision: D29499361

Pulled By: nikoant

fbshipit-source-id: 8052bdfd86c55cfe890849ba31a6f7020b45f298
2021-07-01 05:34:33 -07:00
priteshrnandgaonkar
2f47928524 Automated: Update Podfile.lock (#2535)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2535

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D29455139/V2/flipper/)

Reviewed By: jknoxville

Differential Revision: D29455139

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 10eb515430f4ce16e7ab600e12ef68bdbb7614fb
2021-06-29 07:11:40 -07:00
priteshrnandgaonkar
00e33ac1d8 Automated: Update Podfile.lock (#2512)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2512

Reviewed By: mweststrate

Differential Revision: D29427146

Pulled By: cekkaewnumchai

fbshipit-source-id: e64e59fd9b62f96446e3950dc871011c4d55b804
2021-06-28 04:06:18 -07:00
Pritesh Nandgaonkar
4464fe6bd3 Bump flipper pod versions
Summary: Bump flipper version and podfile locks

Reviewed By: passy

Differential Revision: D29393051

fbshipit-source-id: f40fd6e8d8bfe835479bb0e72c53ce82988bd26b
2021-06-26 06:39:36 -07:00
facebook-flipper-bot
fba61e5681 Automated: Update Podfile.lock (#2475)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2475

Reviewed By: passy

Differential Revision: D29193502

Pulled By: mweststrate

fbshipit-source-id: 2da351bf1408208e3cdf8c65b4dfbafb5d0b1179
2021-06-17 04:16:35 -07:00
Lorenzo Blasa
1cf7456133 Flipper Network Plugin change timestamps source
Summary:
Flipper Network plugin uses timestamps for various usages e.g. start time of network requests, request duration, etc.

This diff changes the origin of such timestamps.

[NSDate timeIntervalSinceReferenceDate] in favour of FBMonotonicDeviceTimeGetCurrentMilliseconds().

The former uses a timestamp based on date. The latter uses the system boot time.

This translates in errors when the Flipper Desktop app tries to make sense of such timestamps.

This change also adds parity with the Android network plugin that uses System.currentTimeMillis().

The result is multiplied by 1000 as JavaScript expects a timestamp in millseconds.

Reviewed By: fabiomassimo

Differential Revision: D29029192

fbshipit-source-id: b38a4798ecf1564f5801ff3549ffeb9671fa32d6
2021-06-11 10:31:59 -07:00
facebook-flipper-bot
02d80526e3 Automated: Update Podfile.lock (#2435)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2435

Reviewed By: fabiomassimo

Differential Revision: D29000395

Pulled By: jknoxville

fbshipit-source-id: 6bec3497db6cb162852bf7f6f8467d22f3f5b7b6
2021-06-09 12:10:18 -07:00
Pritesh Nandgaonkar
9210567685 Update CK to 0.31 everywhere
Summary: Thisi diff updates the CK version to > 0.31 everywhere. It also removes direct CK dependency on SampleSwift, as it doesn't use CK directly.

Reviewed By: fabiomassimo

Differential Revision: D28898898

fbshipit-source-id: 77d4cece79a0a4a51e7ac27b3ec68283740cd0b2
2021-06-04 07:35:07 -07:00
priteshrnandgaonkar
87a5c5dc1b Automated: Update Podfile.lock (#2409)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2409

Reviewed By: passy

Differential Revision: D28896423

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 2758592dad6c0597a6bc3a05e8173f7f00f5593b
2021-06-04 04:12:45 -07:00
Andres Suarez
39172f6413 Apply clang-format
Reviewed By: igorsugak

Differential Revision: D28477074

fbshipit-source-id: f15dfc45b9fb30c661ebe2899cd882676d0fdf2a
2021-05-20 21:23:41 -07:00
Pritesh Nandgaonkar
15454ceec7 Update Boost iOSX dep and make it work for arm and i386 for sims (#2341)
Summary:
This diff updates and adds the boost ios podspec in flipper repo. This new boost dep works for Arm and i386 archs for simulator too.

This diff also updates our GH Action to remove i386 from excluded archs. Still arm64 is kept as non M1 mac machines do not have arm swift symbols for arm simulator. And since all our CI is on non M1, it is required.

It also takes care of https://github.com/facebook/flipper/issues/2268
## Changelog

- Update the boost dep
- Update the GH action

Pull Request resolved: https://github.com/facebook/flipper/pull/2341

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D28537004

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 474ccec674d0edf5fa7b792b15a326e0f139d977
2021-05-19 11:15:13 -07:00
Hugo Cuvillier
7572178f25 Remove redeclared header CKMutex from CK
Summary: It can now only be accessed through `RenderCore`.

Reviewed By: ivanmisuno

Differential Revision: D28532729

fbshipit-source-id: b5b97ec93c96303b2a6e4c270dfc667712086b79
2021-05-19 02:38:15 -07:00
Fabio Milano
5a7d4e2f17 Remove empty files from ComponentKit plugin
Summary: just empty files

Reviewed By: kevin0571

Differential Revision: D28315389

fbshipit-source-id: 9022c98bd3d97b1f7b38e5d14877e710c1ac707d
2021-05-10 03:44:48 -07:00
Pritesh Nandgaonkar
81e1b3b1bd Make tutorial job to pass (#2282)
Summary:
This makes the tutorial app job to pass

## Changelog

Update the podfile with the static dependencies

Pull Request resolved: https://github.com/facebook/flipper/pull/2282

Test Plan: CI is green

Reviewed By: fabiomassimo

Differential Revision: D28295922

Pulled By: priteshrnandgaonkar

fbshipit-source-id: a6507a380f00fbb1df6ba12f481a0104db4626c3
2021-05-07 17:51:56 -07:00
priteshrnandgaonkar
ee9995c0f1 Automated: Update Podfile.lock (#2274)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2274

Reviewed By: mweststrate

Differential Revision: D28257051

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 24968618eb036e55cd704790d37c21fa9496a59b
2021-05-06 14:21:09 -07:00
Pritesh Nandgaonkar
e9ae8f45f9 Update all flipper transitive deps to latest versions (#2245)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2245

This diff does the following:
- Updates Folly to the latest version.
- Updates boost to latest version and the boost is added as pre built artefact
- Updates RSocket to the latest version
- Updates ComponentKit to the latest version which has a fix for XCode 12.5
- Adds Flipper-Glog dependency updated with a fix for the issue mentioned [here](https://github.com/facebook/flipper/issues/2174)
- This diff also ensures that Flipper, FlipperKit builds with Sample and SampleSwift app.
- This diff also ensures that the bug mentioned [here](https://github.com/facebook/flipper/issues/2248) is addressed.

Note: For Tutorial App to work we will have to make a release of Flipper and FlipperKit to CococaPods. Because the tutorial app refers the released version of Flipper and FlipperKit. It doesn't refer it locally.

Reviewed By: passy

Differential Revision: D28058972

fbshipit-source-id: d45dfc7315ace5d5c7d3a4ba94911fd4b58bdc31
2021-05-04 05:03:09 -07:00
GitHub
66320ef85e Automated: Update Podfile.lock (#2246)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2246

Reviewed By: mweststrate

Differential Revision: D28090937

Pulled By: passy

fbshipit-source-id: 21913f74072788d18bc4343d9b23cf09d824ff90
2021-04-29 08:05:06 -07:00
GitHub
e0c464b2fd Automated: Update Podfile.lock (#2195)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2195

Reviewed By: mweststrate

Differential Revision: D27945986

Pulled By: passy

fbshipit-source-id: 9f73adbd09c14b68f42a917f5c8722422b50b3f5
2021-04-23 04:33:15 -07:00
Michel Weststrate
32bf4c32c2 Remove Console feature
Reviewed By: fabiomassimo

Differential Revision: D27622952

fbshipit-source-id: 45ce5188a55f50b8ca28f28f354d9402902a5df8
2021-04-09 05:03:28 -07:00
GitHub
b0815835d4 Automated: Update Podfile.lock (#2170)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2170

Reviewed By: passy

Differential Revision: D27654278

Pulled By: nikoant

fbshipit-source-id: b5405196018d42d8e9d4d16fe3817955f46f8df1
2021-04-08 11:57:40 -07:00
Pritesh Nandgaonkar
6ba5a410a0 Update glog and doubleconversion which uses xcframework (#2153)
Summary:
This PR updates the Glog and DoubleConversion deps. Now the deps are shipped with precompiled xcframework. It will speed up our build time a bit.
The definition can be found [here for glog](https://github.com/priteshrnandgaonkar/glog/tree/update-0.3.5) and [here for double-conversion](https://github.com/priteshrnandgaonkar/double-conversion/)

There has been improvements in time. I will try to precompile folly to improve the timings significantly.

## Changelog

- Updated the Glog and DoubleConversion deps to the precompiled xcframework one
- Updated the sample app's Podfile.lock

Pull Request resolved: https://github.com/facebook/flipper/pull/2153

Test Plan:
- CI should be green
- Verified that sample app builds.

Reviewed By: mweststrate

Differential Revision: D27560567

Pulled By: priteshrnandgaonkar

fbshipit-source-id: ba295cbe84bb9d5ed6bd6ab17bd1cf5ea22f3cee
2021-04-06 06:02:47 -07:00
Hugo Cuvillier
3423d78f59 Rename CKComponentViewConfiguration -> CKViewConfiguration
Summary:
Ditto. #cleanup

allow-large-files

Reviewed By: kevin0571

Differential Revision: D27498785

fbshipit-source-id: 06aa1cd186a4784a93be3fe2fc240a10c3f9fabe
2021-04-01 04:58:24 -07:00
GitHub
ba6b381c01 Automated: Update Podfile.lock (#2147)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2147

Reviewed By: passy

Differential Revision: D27499773

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 20012c59f51f2c02f202e9b1cc1ba18051ec90a3
2021-04-01 03:26:33 -07:00
Hugo Cuvillier
a501838650 Migrate #import <ComponentKit/ headers to #import <RenderCore
Summary:
Ditto.

drop-conflicts

Reviewed By: fabiomassimo

Differential Revision: D27437645

fbshipit-source-id: ddc096154df1845c614c829f7234b41cd49d9503
2021-03-31 06:10:06 -07:00
Pritesh Nandgaonkar
966a027c5b Add dependencies to layouthelper and ios descriptor pods (#2140)
Summary:
This diff makes sure that pod lib lint succeeds and the CI is green for iOS.

It got broken when I landed my changes for the refactoring of FlipperKitLayoutPlugin. It wasn't picked up by flipper-oss-ios-job as it builds sample app and sample app had all the paths to the header search path which individually FlipperKitLayoutHelpers and FlipperKitIOSDescriptors were missing.

I will add the validation of pods as a job in sandcastle when one touches FlipperKit pods, this will avoid such cases in future.

## Changelog

Pull Request resolved: https://github.com/facebook/flipper/pull/2140

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

iOS jobs are green on CI in GH.

Reviewed By: passy

Differential Revision: D27417743

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 17aa4b04bf9954c4bd138261103751a245409568
2021-03-31 04:30:03 -07:00
Xiangxin Sun
a783c0d691 Revert D27328277: add macOS deps to shared libraries
Differential Revision:
D27328277 (7c44d4d4f0)

Original commit changeset: f22d1e9f6a54

fbshipit-source-id: bc893df5ba5a0bd9d47eeab4ff345e7c5047da9b
2021-03-29 20:11:37 -07:00
Xiangxin Sun
2bae11e132 Revert D27332601: add macOS descriptors for layout plugin
Differential Revision:
D27332601 (ed69c4f16a)

Original commit changeset: 35c93cf715f0

fbshipit-source-id: 5dd601f1ec88d890886272d829f3ce6da3e72259
2021-03-29 20:11:37 -07:00
Kyle Cui
ed69c4f16a add macOS descriptors for layout plugin
Summary: Add macOS only descriptors. Currently does not support Yoga/YogaKit or accessibility features; will add those in a later diff.

Reviewed By: priteshrnandgaonkar

Differential Revision: D27332601

fbshipit-source-id: 35c93cf715f004dbf8dbf8753534f1d4f9801b4c
2021-03-29 16:13:24 -07:00
Kyle Cui
7c44d4d4f0 add macOS deps to shared libraries
Summary: Add macOS dependencies and alternative classes to the libraries that FlipperKitLayoutPlugin needs to function.

Reviewed By: priteshrnandgaonkar

Differential Revision: D27328277

fbshipit-source-id: f22d1e9f6a5415cee0bae8eaada653be5f5467b3
2021-03-29 16:13:24 -07:00
Pritesh Nandgaonkar
790f23301e Refactor Layout Plugin
Summary:
This diff moves the iOS descriptors and other layout helpers into its own buck target. Earlier everything was part of the FlipperKitLayoutPlugin target. When kcui, tried to add macos descriptors, we realised that FlipperKitLayoutPlugin doesn't have macos platform in it and thus he had to put #if TARGET_OS_SIMULATOR check in iOS descriptors and at some other places.

In order to make the integration easier I decided to split the Layout Plugin in following way.

```
FlipperKitLayoutPlugin
  -> FlipperKitLayoutIOSDescriptors (platform set as IOS)
  -> FlipperKitLayoutHelpers (used in iOS Descriptors and usefule for Macos too)
  -> FlipperKitLayoutMacOSDescriptors(coming soon by kcui)(platform set as MacOS)

```

Reviewed By: kcui

Differential Revision: D27127587

fbshipit-source-id: f108ef81914297e93c886fe53dabf0a4bf11ebc1
2021-03-25 16:00:28 -07:00
Robert A Barclay
025b51a284 Fixes the Flipper-RSocket podspec to exclude .txt and .md files (#2079)
Summary:
Fixes the Flipper-RSocket podspec similar to the [RSocket podpec](https://github.com/facebook/flipper/pull/1438) to exclude the .md and .txt files from the compilation, which is throwing a warning.

Removal of these warnings:

```
warning: no rule to process file '<redacted>/ios/Pods/Flipper-RSocket/rsocket/benchmarks/CMakeLists.txt' of type 'text' for architecture 'arm64' (in target 'Flipper-RSocket' from project 'Pods')
warning: no rule to process file '<redacted>/ios/Pods/Flipper-RSocket/rsocket/benchmarks/README.md' of type 'net.daringfireball.markdown' for architecture 'arm64' (in target 'Flipper-RSocket' from project 'Pods')
warning: no rule to process file '<redacted>/ios/Pods/Flipper-RSocket/rsocket/README.md' of type 'net.daringfireball.markdown' for architecture 'arm64' (in target 'Flipper-RSocket' from project 'Pods')
```

## Changelog

Fix Flipper-RSocket podspec to exclude .txt and .md files from being included in the compilation

Pull Request resolved: https://github.com/facebook/flipper/pull/2079

Reviewed By: passy

Differential Revision: D27230095

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 0876901aaad1a3b4e8093ed4ccf1cc845e18032a
2021-03-22 18:28:57 -07:00
Pritesh Nandgaonkar
c87a581747 Fixes the swizzling crash (#1943)
Summary:
This fixes the issue mentioned in https://github.com/facebook/flipper/issues/1940

## Changelog

Pull Request resolved: https://github.com/facebook/flipper/pull/1943

Test Plan: User confirmed

Reviewed By: mweststrate

Differential Revision: D26577560

Pulled By: priteshrnandgaonkar

fbshipit-source-id: dec4e34dcec4a3b3c20c11f0f2dc748fe2698693
2021-02-22 05:53:05 -08:00
Pritesh Nandgaonkar
87e7afe4ab Update tutorial podfiles and GH actions (#1896)
Summary:
This PR updates the flipperkit version of the Tutorial and updates the GH action to test it without the arch flag.
This PR also fixes the script which updates the `flipperkit_version` tag in all the files. It was broken for Tutorial, as it used to replace the last released version of the pod with the current one in each file, but for some reason the flipper version in the Tutorial/Podfile was way older and it never got updated.

I have fixed the logic now to replace the current version in the file with the new one, rather than relying on only last version to be replaced.

## Changelog

- Updated the GH action of tutorial to remove the -arch flag
- Updated Tutorial/Podfile and Podfile.lock
- Updated scripts/update-pod-versions.sh

Pull Request resolved: https://github.com/facebook/flipper/pull/1896

Test Plan:
CI should be green
Tested that the version gets updated for each and every file, file tested were Flipper.podspec, FlipperKit.podspec, Sample/Podfile SampleSwift/Podfile Tutorial/Podfile

{F369967362}

{F369967395}

Reviewed By: nikoant

Differential Revision: D26275657

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 0f21a2a33c740938d2b29624e95974e80a2e38ba
2021-02-05 04:51:11 -08:00
GitHub
05acdc99b0 Automated: Update Podfile.lock (#1894)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/1894

Reviewed By: mweststrate

Differential Revision: D26275066

Pulled By: priteshrnandgaonkar

fbshipit-source-id: c215bc6fe79d4b194c6c3e96eaa2e17298d25858
2021-02-05 03:17:18 -08:00
Pritesh Nandgaonkar
8ade24abbc Solves the sampleswift failing job (#1893)
Summary:
Solves the sampleswift failing job, by removing the linker flags which were used when we relied on CocoaLibEvent, but now we do not rely on this.

## Changelog

- Removed cocoalib flag
- Removed arch requirement from the workflow for sample swift

If the flag is removed from the objc sample then I get the following error. It looks like for the objc project, xcode is not able to find the arm64 artifacts for swift deps.

I tried all the alternatives for solving this issue, but it didn't work for objc. I will wait for new xcode and will try with that, hopefully, the newer xcode has the fix.

```
ld: warning: Could not find or use auto-linked library 'swiftFoundation'
ld: warning: Could not find or use auto-linked library 'swiftMetal'
ld: warning: Could not find or use auto-linked library 'swiftUIKit'
ld: warning: Could not find or use auto-linked library 'swiftDarwin'
ld: warning: Could not find or use auto-linked library 'swiftObjectiveC'
ld: warning: Could not find or use auto-linked library 'swiftCoreFoundation'
ld: warning: Could not find or use auto-linked library 'swiftDispatch'
ld: warning: Could not find or use auto-linked library 'swiftCoreImage'
ld: warning: Could not find or use auto-linked library 'swiftCore'
ld: warning: Could not find or use auto-linked library 'swiftQuartzCore'
ld: warning: Could not find or use auto-linked library 'swiftCoreGraphics'
ld: warning: Could not find or use auto-linked library 'swiftSwiftOnoneSupport'
Undefined symbols for architecture arm64:
  "protocol descriptor for Swift.ExpressibleByFloatLiteral", referenced from:
      l_got.$ss25ExpressibleByFloatLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
  "associated type descriptor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType", referenced from:
      l_got.$s18IntegerLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
  "associated conformance descriptor for Swift.ExpressibleByIntegerLiteral.Swift.ExpressibleByIntegerLiteral.IntegerLiteralType: Swift._ExpressibleByBuiltinIntegerLiteral", referenced from:
      l_got.$ss27ExpressibleByIntegerLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
  "method descriptor for Swift.ExpressibleByFloatLiteral.init(floatLiteral: A.FloatLiteralType) -> A", referenced from:
      l_got.$ss25ExpressibleByFloatLiteralP05floatD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
  "protocol descriptor for Swift.ExpressibleByIntegerLiteral", referenced from:
      l_got.$ss27ExpressibleByIntegerLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
  "value witness table for Builtin.Int32", referenced from:
      full type metadata for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftCoreImage", referenced from:
      __swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit)
  "associated type descriptor for Swift.ExpressibleByFloatLiteral.FloatLiteralType", referenced from:
      l_got.$s16FloatLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftQuartzCore", referenced from:
      __swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit)
  "__swift_FORCE_LOAD_$_swiftDispatch", referenced from:
      __swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit)
  "method descriptor for Swift.ExpressibleByIntegerLiteral.init(integerLiteral: A.IntegerLiteralType) -> A", referenced from:
      l_got.$ss27ExpressibleByIntegerLiteralP07integerD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftCoreFoundation", referenced from:
      __swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit)
  "protocol witness table for Swift.Int : Swift._ExpressibleByBuiltinIntegerLiteral in Swift", referenced from:
      associated type witness table accessor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType : Swift._ExpressibleByBuiltinIntegerLiteral in __C.YGValue : Swift.ExpressibleByIntegerLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftObjectiveC", referenced from:
      __swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit)
  "__swift_FORCE_LOAD_$_swiftCoreGraphics", referenced from:
      __swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit)
  "_swift_getForeignTypeMetadata", referenced from:
      type metadata accessor for __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
      type metadata accessor for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftFoundation", referenced from:
      __swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit)
  "associated conformance descriptor for Swift.ExpressibleByFloatLiteral.Swift.ExpressibleByFloatLiteral.FloatLiteralType: Swift._ExpressibleByBuiltinFloatLiteral", referenced from:
      l_got.$ss25ExpressibleByFloatLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftUIKit", referenced from:
      __swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit)
  "__swift_FORCE_LOAD_$_swiftMetal", referenced from:
      __swift_FORCE_LOAD_$_swiftMetal_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftMetal_$_YogaKit)
  "Swift.Float.init(Swift.Double) -> Swift.Float", referenced from:
      static (extension in YogaKit):CoreGraphics.CGFloat.% postfix(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
      (extension in YogaKit):__C.YGValue.init(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftDarwin", referenced from:
      __swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit)
  "protocol witness table for Swift.Float : Swift._ExpressibleByBuiltinFloatLiteral in Swift", referenced from:
      associated type witness table accessor for Swift.ExpressibleByFloatLiteral.FloatLiteralType : Swift._ExpressibleByBuiltinFloatLiteral in __C.YGValue : Swift.ExpressibleByFloatLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

Pull Request resolved: https://github.com/facebook/flipper/pull/1893

Test Plan:
CI in github should be green

flipper-oss-ios-build works
https://www.internalfb.com/intern/sandcastle/job/22517998513117018/

Reviewed By: mweststrate

Differential Revision: D26254390

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 291cfb949e781ccb9e0317679daa673dcf8e9479
2021-02-05 02:10:26 -08:00
Pritesh Nandgaonkar
0ebe3956a4 Update OpenSSL pod and remove exclude arch setting (#1892)
Summary:
This PR updates the OpenSSL pod and thus updates the corresponding Folly and RSocket pods. The new OpenSSL pod has a support of arm64 artifact for iPhomeSimulators.This PR also updates the replaces the libevent pod which didn't work with arm64 arch for iPhoneSimulator.

## Changelog

- Update OpenSSL pod
- Update Folly dep
- Update RSocket dep
- Replace Libevent pod.

Pull Request resolved: https://github.com/facebook/flipper/pull/1892

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D26229304

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 46256d9cd3e0cf5aab6e477e612c3bcb77e31627
2021-02-04 08:50:14 -08:00
GitHub
6ece50fc0e Automated: Update Podfile.lock (#1870)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/1870

Reviewed By: mweststrate

Differential Revision: D26146167

Pulled By: nikoant

fbshipit-source-id: 3a5c1e8fd7cb5f39d5f96d9a299e54b535736839
2021-01-29 05:29:26 -08:00
Pritesh Nandgaonkar
e104a1fa6b Split up the CK code so that internal refers to the latest and Open source refers to the sunset version and it won't be actively developed
Summary:
This diff keeps the opensource integration of CK for Flipper at the same place. It moves the code which is referred internally to a different folder under Facebook directory.

The reason we are doing this is because, CK won't be publishing any more opensource releases to Cocoapods. Thus we would like to keep the code for opensource compatible to the latest one. Internally we would refer to the CK code from Facebook directory.

Reviewed By: fabiomassimo

Differential Revision: D26047510

fbshipit-source-id: 302890bcd36d3e4c4888577d821433f58fcab5c7
2021-01-27 02:43:07 -08:00
GitHub
25030e63c6 Automated: Update Podfile.lock (#1851)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/1851

Reviewed By: mweststrate

Differential Revision: D25982175

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 7e1bfc9badfd9e164f5b0812e820938884488268
2021-01-21 04:13:53 -08:00
Ruslan Serebriakov
0fd6262044 Fixing the issue with broken CKInsetComponent set up
Summary:
After updating the internal properties of CKInsetComponent we didn't update some KVO magic being used in Flipper which caused some crashes:
https://fb.workplace.com/groups/componentkit/permalink/4986354281413147/

Reviewed By: fabiomassimo

Differential Revision: D25946704

fbshipit-source-id: 5995cda20d12b18f7520507cb6ede897fddf2670
2021-01-20 04:52:29 -08:00
Pritesh Nandgaonkar
140ff8861e Add github actions for dependency pod validations (#1834)
Summary:
This PR adds github actions to validate the pods, so that the changes which breaks the validation is not made. This PR also downgrades the version update of OpenSSL, as it doesn't validate the Folly podspec. I have [raised](https://github.com/krzyzanowskim/OpenSSL/issues/113) an issue on the repository which manages the openssl dependency.
## Changelog

- Added githubaction for dependent pod validation
- Downgraded the openssl version, as with upgraded version the folly pod didn't validate.

Pull Request resolved: https://github.com/facebook/flipper/pull/1834

Test Plan: CI

Reviewed By: passy

Differential Revision: D25939525

Pulled By: priteshrnandgaonkar

fbshipit-source-id: f70d043f1f6b2c79028212d8f56c6b8632092e33
2021-01-19 14:20:50 -08:00
GitHub
be31bbdb9c Automated: Update Podfile.lock (#1835)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/1835

Reviewed By: priteshrnandgaonkar

Differential Revision: D25944782

Pulled By: passy

fbshipit-source-id: c0375df1ac8030f3bdfeaa9ac846031499bc9d5e
2021-01-18 04:21:50 -08:00
Andres Suarez
731e39445f Apply clang-format update fixes
Reviewed By: igorsugak

Differential Revision: D25861849

fbshipit-source-id: 840dc1061e557717c7f9ffcccbc09c24b96b78e0
2021-01-10 10:07:30 -08:00
Pritesh Nandgaonkar
98b74c4f49 Fixes a crash caused by network swizzling in FlipperKit (#1810)
Summary:
This PR fixes the crash mentioned [here](https://github.com/facebook/flipper/issues/1674#issuecomment-754402609) in the https://github.com/facebook/flipper/issues/1674 .  The issue was that logging `NSLog(@"%@", [self valueForKey:@"_methodDescription"]);` in the swizzled network delegate class used to cause a crash. The cause of this was the nil `methodDescription.types` sent to `class_addMethod`.

In the following change we do not add a method to the class which doesn't implement the selector, we will anyway listen for those events from the base NSURLSession class. Removing the `class_addMethod`, fixes both the issue mentioned
 [here](https://github.com/facebook/flipper/issues/1674#issuecomment-754402609) in https://github.com/facebook/flipper/issues/1674.

This PR also fixes an issue where no network calls where logged in Flipper when the iOS version was 14, the reason was that the URLSessionResume task was not properly swizzled for 14.

## Changelog

- Do not add a runtime method to the delegate which doesn't implement a responder
- Fix swizzling logic of the URLSession task resume method for ios 14

Pull Request resolved: https://github.com/facebook/flipper/pull/1810

Test Plan:
- I ran the sample app and checked that the network calls are logged.
- I copy pasted the changes in RN project and verified that the  issues mentioned in https://github.com/facebook/flipper/issues/1674 doesn't happen and also verified that the network calls being hit from JS and Native code gets logged in Flipper. Verified with IsolatedSwizzles.zip mentioned over [here](https://github.com/facebook/flipper/issues/1674#issuecomment-754726174). Also verified by copy pasting the code in the fresh  RN project.

Reviewed By: fabiomassimo

Differential Revision: D25801510

Pulled By: mweststrate

fbshipit-source-id: 53ef574696d2abbdbfc2b6d94769327cdfa8aa2b
2021-01-07 05:27:41 -08:00