Summary: Only load the image when clicking on the "button"
Reviewed By: oprisnik
Differential Revision: D14165707
fbshipit-source-id: d07fb76562f8b91fc945713d779319b976e17016
Summary:
Not quite sure about the default as static, but then if it's for
debugging only, does it matter?
Reviewed By: oprisnik
Differential Revision: D14165668
fbshipit-source-id: edd53420a4fc8570de87f02b3e5e65cfe649f810
Summary:
This looks bad. There are two things I want to follow up on in future
diffs before landing this:
- Make loading the image conditional by adding another button.
- Add a default constructor to the plugin that avoids this crazy bit of boilerplate.
Reviewed By: oprisnik
Differential Revision: D14165569
fbshipit-source-id: 25c5fbaee32e72c6469979cda694cc9f13a92166
Summary:
Split off objecthelper into a (future) public and an fb-only version. This also open-sources the very first bit which is pretty useless on its own, but will already compile as its neatly stand-alone.
Note that this blocks releases until we have a stable version of Fresco to depend on.
Reviewed By: oprisnik
Differential Revision: D14149645
fbshipit-source-id: 0020d7ceccf89999695414ce389106ca6325ab7e
Summary: Instead of installing some global mutable thing, pass it down. This also eliminates the rather gnarly side-effect of instantiating some visitor and suddenly logging information in an entirely different place.
Reviewed By: oprisnik
Differential Revision: D14131253
fbshipit-source-id: 760c6a3f85056e334ac1149c76ca4126fbfa7da4
Summary:
Buck doesn't really care so the previous diff works out fine on
its own, but Android Studio is less forgiving.
Reviewed By: oprisnik
Differential Revision: D14131182
fbshipit-source-id: 0ad26e7c5f1e0776bdf07dda2f04bdf16183a5e8
Summary:
This is generic enough, even though I strongly dislike the
installing mechanism, but that can be changed later.
Reviewed By: oprisnik
Differential Revision: D14131183
fbshipit-source-id: b75c1e1563ac9371cbc7d28b239c316a0aa1a9dd
Summary:
Not sure why, but if we stick this in the build folder,
the artifacts get downloaded every single time despite `onlyIfNewer`.
Reviewed By: jknoxville
Differential Revision: D14132383
fbshipit-source-id: 464e4a6e474877c16a06a6e83ccd1a2e355cbea2
Summary:
Bit ugly, but allows us to use this interface in open-source
and internally. There's no buck target as we only need this
for Gradle.
Reviewed By: oprisnik
Differential Revision: D14132467
fbshipit-source-id: 998df6ce31f1fb7d00ea99d6d28759f7e2c800c3
Summary: Enables `FlipperArray`s to be constructed from `JSONObject`s or JSON `String`s, as `FlipperObject`s can be.
Reviewed By: jknoxville
Differential Revision: D13996135
fbshipit-source-id: d8a445d907799cd51dcdb3ba832dfe6fddb7171e
Summary:
as title; this shouldn't change how focus worked before on views, but accounts for the new Section nodes
Depends on D13900789
Reviewed By: astreet
Differential Revision: D13900846
fbshipit-source-id: 093016c17b5c1351108dbd9c884bf99a1b4d49cb
Summary:
as title, highlight a section when hovering over it
Depends on D13900729
Reviewed By: astreet
Differential Revision: D13900789
fbshipit-source-id: 552554f5ecf9a9dd3edf4724581b7dee6a8a855d
Summary:
This doesn't add new behaviour. It adds NodeDescriptor implementations for rendering Section nodes inside Litho flipper inspector.
We'll consider LithoRecyclerView as the point where we can detect a section hierarchy, and it will (for now) have as a child a DebugSection which is the root of the SectionHierarchy.
Depends on D13802978
Reviewed By: astreet
Differential Revision: D13803272
fbshipit-source-id: a5367d97315349770201a29f5d5bd05baec0405e
Summary:
Flipper exposes a call() api to plugins which lets them call their sdk component, and it returns a promise with the response.
Currently this is done by sending a fireAndForget request, noting the id of the request, and then receiving fireAndForget requests and matching up the ids to give the result back to the right plugin promise.
Instead, it will be simpler to use rsocket requestResponse, instead of fireAndForget, which is for this exact use case. This diff adds a requestResponse handler to the SDK, so that it can deal with such requests and respond accordingly, while preserving the current functionality if it receives a fireAndForget.
So this part is backwards compatible and should be safe to land in isolation.
A later diff will change the desktop app to use requestResponse, which may not be backwards compatible, so that will have to be deployed more carefully.
Reviewed By: passy
Differential Revision: D13974049
fbshipit-source-id: b371d94a86b1f186375161ed8f2242a462ce418f
Summary:
For the Sections plugin I need to be able to highlight multiple views at the same time (without highlighting their parent view). This enables us to do that. Let me know if you have any concerns
Depends on D13803412
Reviewed By: astreet
Differential Revision: D13900729
fbshipit-source-id: cdea9c21ceb11563793410b2bb8f7f2c3a44cefb
Summary:
This adds the concept of a custom role description to Flipper's accessibility inspector. This functionality was added in support library version 24.1, and supported in Litho as of D8066609.
This will show both the AccessibilityNodeInfo's raw roleDescription under the AccessibilityNodeInfo section, as well as the derived role description under the main Accessibility section (see highlighted elements in screenshot below).
The difference between the raw role description and the derived role description is that the derived description will show any default description a role is given, such as "Button" for button roles. This makes it clear that the role-description property will override those default strings.
Unfortunately making these mutable requires the AccessibilityRoleUtil class be restructured a bit to support EnumMapping for its roles, which isn't very straightforward due to these default descriptions being stored in the AccessibilityRole enum, so that will have to wait for a future diff.
Screenshot:
{F149099209}
Reviewed By: danielbuechele
Differential Revision: D13759563
fbshipit-source-id: 6eeb22a35f529663725630936af9967ea1f19c0c
Summary:
A new test uses a non-public dependency causing the travis CI to fail.
Use the standard roboelectric one instead.
Reviewed By: passy
Differential Revision: D13801098
fbshipit-source-id: 9fcda26fceaed22d18bd743f10bf39eaae0da7a6
Summary:
Part 1 of enabling flipper to run on custom ports: android SDK.
Still to go: iOS SDK and desktop
This should allow you to run mobile apps that use flipper on different ports than the default (8089,8088).
`adb shell`
`su`
`setprop flipper.ports 1111,2222`
From what I can tell, this only works on rooted devices.
Reviewed By: passy
Differential Revision: D13753238
fbshipit-source-id: c5f370c9d8c7382e8c17fb81d4010c642ef7c114
Summary:
This helps Kotlin nullity inference and *should* already be enforced
by Infer/Eradicate. More details here: https://medium.com/square-corner-blog/non-null-is-the-default-58ffc0bb9111
Reviewed By: jknoxville
Differential Revision: D13732788
fbshipit-source-id: c0c60f0f8e9dc8bffe3780c7a1a700d682a6d2b8
Summary: This diff removes the custom global exception handler which was being used to send crash notifications. Removing it in the favour of next diff, where we detect crash by looking at Logcat
Reviewed By: passy
Differential Revision: D13590049
fbshipit-source-id: 2914d51b2c5f33c1cade4926dbbf72c041047c71
Summary: `PropWithNamedFlipperObject` is an interface that can be implemented by a Litho component prop to display a new section in the Flipper layout inspector.
Reviewed By: danielbuechele
Differential Revision: D13419918
fbshipit-source-id: be2ade160d6381944b1b68a7645b5b23f1d142a1
Summary:
This diff does the following
- Comments out the code in iOS which sends the message to the desktop side
- Also comments out the part where signal handler is initialised, as we no longer need it. I will remove the iOS implementation completely in next few diffs
- Updated the JS side to expect call stack as a string instead of an array
- Updated the android side to send callstack as a string
I have commented out the code for crash reporter plugin of iOS as for iOS I will be adding a watchman to a directory where crash logs are dumped. The diff related to this is in the stack
Reviewed By: passy
Differential Revision: D13424824
fbshipit-source-id: b1105da912292bf73cff948206c031de9b059abd
Summary:
We can only do this when adb reverse is available, i.e. on Android 5+.
This also relies on a recent change to flipper desktop, to always run adb reverse on emulators.
Reviewed By: danielbuechele
Differential Revision: D10302579
fbshipit-source-id: cff07f0311d413fdd49424a42c641dfb3d225f7c
Summary: This was recommended by my Android Studio 3.3 when starting up, so let's do this.
Reviewed By: jknoxville
Differential Revision: D13302768
fbshipit-source-id: c38601659bde4515d62b31efbd907b44304aafba
Summary:
This deprecates the `getPlugin(String)` method and introduces
a `getPluginByClass(Class<T>)` instead which avoids having
to `instanceof`-check and then cast the result, which provides
a nicer experience for Java users.
Reviewed By: jknoxville
Differential Revision: D13277568
fbshipit-source-id: fb7b5b8c0180470ef0ad322559b5b7424520848b
Summary:
Adding a a react-devtools plugin for Android.
This doesn't do much, but announces the plugin to be available.
To make this work on remote device, the hostname and port sent to the device needs to be set in the dev tools. This is isn't done yet, so this will only work for simulators.
Reviewed By: jknoxville
Differential Revision: D12897151
fbshipit-source-id: b874549925c395ff6356f6745b9706b182d544dd
Summary:
This PR adds the barebone of a crash reporting plugin in android. Since there is no easy way to stack the PR's in git, creating a new PR, but this depends on the [iOS PR](https://github.com/facebook/flipper/pull/322)
Pull Request resolved: https://github.com/facebook/flipper/pull/328
Reviewed By: jknoxville, passy
Differential Revision: D13137447
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 3b86cebbb1ea01601405dd7ba58e1caa2b506065
Summary: This diff wraps all the important places where the java code is called in a try-catch block in order to avoid flipper bringing down an app.
Reviewed By: jknoxville
Differential Revision: D12839504
fbshipit-source-id: 4711bccbe6d50094d76ed7ecd1eb652cefc2a090
Summary:
Adds an optional interface that, when implemented, adds
a "Report Bug" button to the top of the screen.
This is a weird Android-ism that's sadly still the
recommended way of providing hooks into Fragments:
https://developer.android.com/guide/components/fragments#EventCallbacks
In order to keep things vanilla here, let's follow that pattern.
Reviewed By: jknoxville
Differential Revision: D13045578
fbshipit-source-id: 1506fcfc630c2d1183d7d1eaf470d23954e0c097
Summary:
This allows passing in some options in an easy way, like a callback
that contains all debug information for a bug report.
Reviewed By: jknoxville
Differential Revision: D13045282
fbshipit-source-id: 5698228ee9aef31d406313047b6836dc928448cf
Summary: This is a re-do of D9720987. Now that the Litho version has been bumped to 20 in D12838684, this diff can land safely.
Reviewed By: danielbuechele
Differential Revision: D12969979
fbshipit-source-id: b12d14e3b292d8cd110967f84f770f3725a800de
Summary: In the accessibility inspector plugin, the "Enabled" view property was marked at mutable, but would not actually change the clicked. This is because no case for changing this property was implemented. This fixes the issue and allows the property to be mutable.
Reviewed By: jknoxville
Differential Revision: D12944810
fbshipit-source-id: 846547ba1baa481eca3fe1cd949cf252904677bc
Summary:
We have getAndroidContext() instead.
This will probably take a few iterations to land, but getting it out there so that I can try :)
Reviewed By: muraziz
Differential Revision: D12921523
fbshipit-source-id: 038ecf8c411fdbde6831051b219a43716007ac49
Summary:
Just a quick startup test that can save you the time of manually
opening the app.
I don't have any plans of hooking this up in Circle, but it's
still kinda useful to have.
Reviewed By: jknoxville
Differential Revision: D12901590
fbshipit-source-id: a16a1814574d9f27770dcf98c6b238517c589930
Summary:
It's only used in `JavascriptSessionTest`, and seems fine to keep it in tests
Resolves#172
Pull Request resolved: https://github.com/facebook/flipper/pull/309
Reviewed By: passy
Differential Revision: D12840362
Pulled By: jknoxville
fbshipit-source-id: 4ead5a4bf0c08d792abcadef713f907930a3e4e7
Summary: Completes D9667222 to allow force rendering of accessibility in litho when an accessibility service is not actually running.
Reviewed By: ikenwoo
Differential Revision: D9720987
fbshipit-source-id: 000a7413fcbe775a525ca3aca64443c3669cdf9e
Summary: Was set to view previously and blocked the ability to edit view attributes.
Reviewed By: sjkirby
Differential Revision: D10865495
fbshipit-source-id: 8db043bdc8725b2b56f037d7d8467233db524f5e
