Summary:
{F226170897}
Color picker based on Lite's color table
We can't use standard color picker because of FB Lite's limitation: color set is predefined and sent from the server
'extra' field and 'color-lite' type are added to field description
Reviewed By: jknoxville
Differential Revision: D19330480
fbshipit-source-id: 695d288b4b8409e8b63a9e461a41914379d75a8c
Summary: The new type defs make use of TypeScript 3.7 assertion functions which means they actually have a semantic effect on the rest of the lexical unit, which is quite neat.
Reviewed By: mweststrate
Differential Revision: D19348035
fbshipit-source-id: 3c7a21b5bece091c32f8879fed12d8e46e205ea4
Summary:
Filter type enum works differently than what I understood; its value is not inside the column.
Move the enum checking to before others because text matching relies on column value.
In addition, change the behavior when there is no column (from ignoring the search to causing all row to disappear due to mismatch ing)
Reviewed By: mweststrate
Differential Revision: D19345758
fbshipit-source-id: d49bc0e29d7a3d36f3aad20213791211c2c3065b
Summary: React 16 is not compatible with react-emotion 9 (it prints warnings, see also https://github.com/emotion-js/emotion/issues/644). So we should upgrade to 10.
Reviewed By: mweststrate
Differential Revision: D18905889
fbshipit-source-id: c00d2dbbadb1c08544632cb9bfcd63f2b1818a25
Summary: Puts a context menu in the sidebar for the network plugin. Before, user was not able to select the text from sidebar
Reviewed By: passy
Differential Revision: D18808544
fbshipit-source-id: bdbc86972cd1d508e9b7d96da9df5c8e53bec991
Summary: Add a quick banner to give some more context on the bug report feature
Reviewed By: jknoxville
Differential Revision: D18807556
fbshipit-source-id: b2de614ccfd30a22f418b60d6f08066c57759deb
Summary:
Some lifecycle methods are deprecated now. Where they can be replaced easily I replaced them. Where they can't be updated easily I marked them as unsafe, as if a bigger refactoring is required for those components, we'd better convert them to function components instead.
Didn't update the plugins as they are ideally updated by their owners.
Didn't update styled components, there is a separate task for that.
Reviewed By: jknoxville
Differential Revision: D18780579
fbshipit-source-id: 132a3789875ab6a3caee582b0e5f7feb7dc4a4c1
Summary:
Slightly improves the support form interactions / code flow:
* When uploading, input fields are hidden
* WHen upload succeeded: Show link to final post
* When upload succeeded: be able to start a new bug report
* Styled error messages, and unified error flow
* Don't support report if errors occurred
Reviewed By: priteshrnandgaonkar
Differential Revision: D18779791
fbshipit-source-id: 28e873d0509865c66d861fe9cedb62a31f0e8bae
Summary:
The Markdown component wasn't rendering a single component, so I put it in a container.
Also added a margin bottom so it didn't look out of place. There's probably a nicer way to do that.
Reviewed By: mweststrate
Differential Revision: D18749381
fbshipit-source-id: ea7827dc7e6141fb0dbd5886356736da4b50f5dc
Summary:
Nobody moves the hackathon!
Fixed some circular deps warnings while waiting for another Diff to land
Reviewed By: priteshrnandgaonkar
Differential Revision: D18749645
fbshipit-source-id: 225fbea428dca02f0f4c920ee47b4ece3c3e370b
Summary:
* Added a button to clear Diff selection
* Added icons and color to the recording button
* Made App input field readonly
Reviewed By: priteshrnandgaonkar
Differential Revision: D18748538
fbshipit-source-id: 00ffb5d5c36f8f5394a353602f182aabd8237ee7
Summary: The previous table was ugly, and weirdly interactive. This diff changes it to a static layout
Reviewed By: priteshrnandgaonkar
Differential Revision: D18744712
fbshipit-source-id: 9060da07eae836a94ce6d8bb2ebb8a6a54470daa
Summary:
Applies some additional styling to the support details form, and implemented the screenshot / video styling.
Probably needs some more fixes in the future, once we have a real report to import :)
Reviewed By: jknoxville
Differential Revision: D18658388
fbshipit-source-id: dc9207ec08b3f4360c96d8d14980710c57d6b5ec
Summary: Mimicking the workplace markdown style so people feel more familiar with it and don't get surprises when posting.
Reviewed By: passy
Differential Revision: D18639041
fbshipit-source-id: 0097087b8ae4da8e29609604eeffd5b349ebe7ab
Summary:
The spacing above headings didn't look right.
Also workplace purposely limits the different heading sizes to 2 to encourage using notes for large posts. So I'm changing this to match. If we need to have arbitrary depth in future, we can add a `workplaceMode` toggle, but so far that's the only use case we have.
Reviewed By: mweststrate
Differential Revision: D18638861
fbshipit-source-id: 3949a37515e4282bb8435c2740ef45a55e5a97cc
Summary:
Adds a side-by-side markdown preview to the support form.
No time spent on UI because it makes sense to do it all together.
There also seems to be a problem with state updates not propagating when values are changed, so currently it never gets updated.
Reviewed By: passy
Differential Revision: D18638025
fbshipit-source-id: c4a49286434c7e2e85d532aef3a36924e02a4467
Summary:
Styles the create support request form similarly to the details form, using the standard UI components.
N.B. Video section styling will be a separate diff
Reviewed By: jknoxville
Differential Revision: D18637989
fbshipit-source-id: f1cc6967b6841a55e770043f330e1a87ac7bfb50
Summary:
This diff makes it possible to apply MC's to a currently running as part of the support form process.
Things _NOT_ done in the diff:
* make sure getUniverses and getGatekeepers returns valid configs (this broke since somewhere last week, opened T57918601 for that. However, before that this worked correctly
* provide a more interactive UI when applying MC's, such as beeing able to see a diff preview, ask confirmation before overriding current config, etc
Reviewed By: jknoxville
Differential Revision: D18452172
fbshipit-source-id: da3f24bccf88260282f86e2564e983a9ee217c2f
Summary:
This diff introduces a set of components:
VBox: use this to group things vertically, it little more than a container that fills the full width and adds bottom margin (see screenshot: creating distance between the boxes)
HBox: use to divide a space horizontal in two, and distribute it over two children, supports growing the right side, left side or both equally. In the image used to reserve the necessary width for the image, and give the remaining space to the text
Info: A component that shows a message, prestyled with one of the four types: info, error, warning, pending.
{F222993480}
Reviewed By: jknoxville
Differential Revision: D18595291
fbshipit-source-id: 1957db1b606b2e44e3104b10d32ad8ce75af6adc
Summary:
- Basic Doctor UI showing issues with installation
- Run healthchecks in background on startup and show warning message if something is wrong
Reviewed By: jknoxville
Differential Revision: D18502599
fbshipit-source-id: 194939a080ba7412ed3293d95c533bfad7031d3b
Summary:
Adds a Markdown component to the component library.
The react-markdown library doesn't work out of the box because elements it outputs don't have any styles, e.g. h1, h2, p, em, etc.
So I've added a custom renderer to give styles to each of these that workplace markdown uses.
The only one I haven't done at the moment that I'm aware of is numbered-lists.
There's probably a way to get back the original styling of these elements so we don't need a custom renderer, but this works for now, and also allows us to customise their appearance.
Reviewed By: passy
Differential Revision: D18533085
fbshipit-source-id: a4332a11d34d577a6300074e4dde126362d46a6b
Summary:
Created as standard layout that can be used for both the import and export form
Standardized components used, so that we work towards a Design Framework that is consistent. Took inspiration from some existing plugins.
Also fixed weird sidebar transparency.
Reviewed By: passy
Differential Revision: D18504078
fbshipit-source-id: 7649abf7aa3eba8ba635337a41274bba93738e81
Summary:
Currently most components are shown anonymously in the component tree, because using `styled` creates unnamed components, shown as the HTML elements they result in.
This has two downsides:
1. React errors / warnings are really vague and it is hard to locate where they are coming from
2. The React Devtools don't show which components are rendering.
3. The effect of the latter it is hard to copy-from-example when developing plugins. This leads to a lot of inconsitency and duplication in the layouts of components
Reviewed By: jknoxville
Differential Revision: D18503675
fbshipit-source-id: 5a9ea1765346fb4c6a49e37ffa4d0b4bbcd86587
Summary: Tabs have a weird negative offsite in the mobile config section (they have everywhere by default, to escape their containers in a mac-style but it does hide them in this specific case)
Reviewed By: priteshrnandgaonkar
Differential Revision: D18448191
fbshipit-source-id: 792daa5a3ef1aa91df730bd185124076471e42d3
Summary: This diff sets up the create form for the new support request project. The current screen is very basic. I will be iterating through it in the upcoming diffs.
Reviewed By: passy
Differential Revision: D18327464
fbshipit-source-id: af01fc10f68a135f32f0ae98551986852019e8aa
Summary: This diff lands improved sidebar navigation. The old functionality to order plugins based on last-recently-used, and cropping at 5 items has been removed. Instead, items can be starred and their position will be fixed. Together with the app switcher introduced this should lead to a cleaner, stabler, and more customizable UI.
Reviewed By: jknoxville
Differential Revision: D18299401
fbshipit-source-id: 29b7eb3a4130933c637f7c81834558bf738d5bf0
Summary: Simple implementation of searching through request/response body on "network" tab
Reviewed By: passy
Differential Revision: D18268026
fbshipit-source-id: 39386d2d6ec50b47c3ca3dec976821282b51636f
Summary:
Uses a slightly modified version of the deep expansion. In testing, there were a few issues due to the function in Inspector::onElementExpanded is essentially a toggle. I added an optional parameter to override this toggle behavior for child elements, and also flipped the order of root and child actions during collapsing, as the child state otherwise didn't persist properly (due to the component being unmounted, would be my guess?) This change should be non-breaking to other uses of the method that don't use the `deep: true` parameter
close https://github.com/facebook/flipper/issues/223
Reviewed By: passy
Differential Revision: D18225057
fbshipit-source-id: 53e840f07bf648249b5a4b36d115918dba215ff8
Summary: This diff shows marketing bar for support feature when someone inspects the litho view. Once it is inspected it will shown for the rest of the time till the plugin is unmounted.
Reviewed By: jknoxville
Differential Revision: D18086347
fbshipit-source-id: cb906614f571e8ece2293b028f809d1aa5c211e5
Summary: Improved the display of error messages. Where previously only one error message could be displayed (quite obtrusively), with this change multiple errors can now be displayed and stack traces and further info can be hidden.
Reviewed By: passy
Differential Revision: D18036569
fbshipit-source-id: 2bc3dfa7a5196f931370a6e6dbf27c55b6cfb2bf
Summary: A significant proportion of CPU time when doing a target selection in the layout plugin, was spent rendering Glyphs. They shouldn't really be doing anything expensive in render, but since they already are, this will make sure they don't re-render unnecessarily.
Reviewed By: passy
Differential Revision: D17906723
fbshipit-source-id: ece143f65fd46d8582e21455732049368f301186
Summary: Not a fan of the long lines, but if that's where prettier is going, let's roll with it.
Reviewed By: jknoxville
Differential Revision: D17905599
fbshipit-source-id: c4232d46d2ec0b7c743f6afd8349106c85f013b9
Summary:
This should be an encapsulated component, not returning the building blocks of one.
So I'm changing the default to return a single component that contains the fragment previously returned.
Now elements appear side by side, are vertically aligned, and onClick works on the label as well, by default. This doesn't break anything in any of the uses inside the flipper code base, because only one used a label (regex search in Searchable.tsx), and these properties are all desirable there.
This could potentially break any plugins that aren't included in the flipper codebase, if they already have a label and don't layout the elements side by side. There are probably no such cases.
Reviewed By: passy
Differential Revision: D17810386
fbshipit-source-id: 588d7ed3243a9f0e5bcad805a3480393c031ff55
Summary:
For "primary" and "danger" buttons, you previously couldn't see any difference between disabled and enabled ones.
This fixes that by greying them out when disabled.
Reviewed By: passy
Differential Revision: D17738031
fbshipit-source-id: 82e16b8881f3d404aafae8a7837151090bb6bbee
Summary: When copying elements from the layout inspector its much more useful to copy all associated attributes rather than just the name and an implementation detail id.
Reviewed By: jknoxville
Differential Revision: D17727520
fbshipit-source-id: 8ac1828059cc10f7f9faf0bdc72eb3d57c881121
