Summary:
Changelog: Creating an Android screen recording no longer includes meta information like frame rate.
Context: https://fb.workplace.com/groups/flippersupport/permalink/1088379648309359/
Before:
{F454408806}
Reviewed By: mweststrate
Differential Revision: D26765408
fbshipit-source-id: 560d7ba4ff4ccff1b4a17f1c1073efe7638e397a
Summary:
Bumps [fresco](https://github.com/facebook/fresco) from 2.2.0 to 2.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/fresco/releases">fresco's releases</a>.</em></p>
<blockquote>
<h2>Version 2.4.0</h2>
<p>No release notes provided.</p>
<h2>Version 2.3.0</h2>
<h1>Highlights</h1>
<ul>
<li>
<p><strong>Bumped Fresco's minSdk to 14.</strong> We did not remove any Gingerbread-specific code yet, but will do so soon. 091e8b7c4cd11a6cc5b535dd84d8e21a1e243ac0</p>
</li>
<li>
<p>Proper nullability annotations for some classes by using new Infer annotations - this improves Kotlin support and null-safety.</p>
</li>
<li>
<p>Improved Java-only Fresco setup. 4a9961559c8240cbb88eeecf2303f956d0185120</p>
</li>
<li>
<p>Lots of debug logging improvements: More reliable image origin, new MEMORY_BITMAP_SHORTCUT origin, more debug information available. These are available via <code>ImagePerfData#getExtraData()</code></p>
</li>
<li>
<p>Added experimental option to recover from OOMs: f43d5990600c9ac6c3a18e14e4d3c260cf78b462</p>
</li>
<li>
<p>Added option to force a single image pipeline instance: 5f5c076fe26b17a849498c27c7541550c3ef3984</p>
</li>
<li>
<p>Disk cache support for the Fresco Flipper images plugin.</p>
</li>
<li>
<p>Bumped SoLoader version to 0.9.0.</p>
</li>
<li>
<p>Use <code>buildSrc</code> for Fresco's internal dependency management.</p>
</li>
<li>
<p>WIP: Lots of improvements for our new Fresco Vito UI components.</p>
</li>
</ul>
<p>Pull requests:</p>
<ul>
<li>Fixed resource leak problem while using BlurPostProcessor. Thanks <a href="https://github.com/FrancescoJo"><code>@FrancescoJo</code></a> for the PR.</li>
<li>Make sure there is at least one overlay in GenericDraweeHierarchy. Thanks <a href="https://github.com/dengweichao"><code>@dengweichao</code></a> for the PR.</li>
<li>Removed unused padding value. Thanks <a href="https://github.com/erenulas"><code>@erenulas</code></a> for the PR.</li>
</ul>
<h1>Cleanup</h1>
<ul>
<li>Removed Drawee-Volley module. If you're using Drawee-Volley, you can still continue using it by just copying the files removed with 7c2517edee7d4080fab0daf54fd4ac4eca6a8497 into your project. We did not significantly change these in a long time, so this has been stable.</li>
<li>Removed OkHttp2 image pipeline artifact. See deba7d1c3c218377a5b67e58f269914d8f8a88be</li>
</ul>
<p>Full changelog: <a href="https://github.com/facebook/fresco/compare/v2.2.0...v2.3.0">https://github.com/facebook/fresco/compare/v2.2.0...v2.3.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="be9cb64a97"><code>be9cb64</code></a> Bump version to 2.4.0</li>
<li><a href="3364e6e8aa"><code>3364e6e</code></a> Annotate public APIs as <a href="https://github.com/Nullable"><code>@Nullable</code></a></li>
<li><a href="21e43cfc22"><code>21e43cf</code></a> report the number of inflight requests when the request was created</li>
<li><a href="0aa2f094f3"><code>0aa2f09</code></a> Fix issues caused by use of FB internal things (<a href="https://github-redirect.dependabot.com/facebook/fresco/issues/2574">#2574</a>)</li>
<li><a href="0dcdfc5642"><code>0dcdfc5</code></a> Update giflib to address stack buffer overflow issue. (<a href="https://github-redirect.dependabot.com/facebook/fresco/issues/2571">#2571</a>)</li>
<li><a href="4178929873"><code>4178929</code></a> Add nullable annotations and mark classes nullsafe</li>
<li><a href="b49891bdb4"><code>b49891b</code></a> narrow fbcore proguard rule (<a href="https://github-redirect.dependabot.com/facebook/fresco/issues/2519">#2519</a>)</li>
<li><a href="0ec9738d8d"><code>0ec9738</code></a> Update gradle wrapper to 6.7.1 so it's compatible with AGP 4.1.1 (<a href="https://github-redirect.dependabot.com/facebook/fresco/issues/2572">#2572</a>)</li>
<li><a href="1c1feaa181"><code>1c1feaa</code></a> Add Infer Annotations to testCompileOnly (<a href="https://github-redirect.dependabot.com/facebook/fresco/issues/2573">#2573</a>)</li>
<li><a href="d7ef94ad97"><code>d7ef94a</code></a> Update libpng to address CVE-2019-7317 (<a href="https://github-redirect.dependabot.com/facebook/fresco/issues/2570">#2570</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/fresco/compare/v2.2.0...v2.4.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2009
Reviewed By: mweststrate
Differential Revision: D26843912
Pulled By: passy
fbshipit-source-id: f8a240e8f228746dab95c11d85c0c68d754a3bc0
Summary:
Got really annoyed with Boost *always* downloading the tar ball on every
build. We had some methods annotated to only run whenever our cache
is out of date and for others we relied on a catch-all at the end which
actually didn't do anything.
If anyone knows Gradle better, please give it a shot.
Pull Request resolved: https://github.com/facebook/flipper/pull/2025
Test Plan:
Changed the URL to something that doesn't exist and it still didn't
re-fetch. Haha, got you!
Reviewed By: mweststrate
Differential Revision: D26843903
Pulled By: passy
fbshipit-source-id: 8c8cf60440d6bf6d7a93eebb7871858b1e6c6509
Summary:
Only a minor bump, but the IDE was pretty insistent I do this.
Pull Request resolved: https://github.com/facebook/flipper/pull/2026
Test Plan: IDE
Reviewed By: mweststrate
Differential Revision: D26843904
Pulled By: passy
fbshipit-source-id: 53a18e75dc9230421e8f9318885af29e8c8a4bdd
Summary:
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p>
<blockquote>
<h2>JUnit 4.13.2</h2>
<p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.2.md">release notes</a> for details.</p>
<h2>JUnit 4.13.1</h2>
<p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p>
<h2>JUnit 4.13</h2>
<p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md">release notes</a> for details.</p>
<h2>JUnit 4.13 RC 2</h2>
<p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p>
<h2>JUnit 4.13 RC 1</h2>
<p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p>
<h2>JUnit 4.13 Beta 3</h2>
<p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p>
<h2>JUnit 4.13 Beta 2</h2>
<p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p>
<h2>JUnit 4.13 Beta 1</h2>
<p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="05fe2a64f5"><code>05fe2a6</code></a> [maven-release-plugin] prepare release r4.13.2</li>
<li><a href="ff57344f71"><code>ff57344</code></a> Add build for JDK 17-ea</li>
<li><a href="02aaa01b8f"><code>02aaa01</code></a> Improve check that thread is stopped</li>
<li><a href="e9a75f4be7"><code>e9a75f4</code></a> Merge test for exception type and message</li>
<li><a href="d27ad52592"><code>d27ad52</code></a> Rename DelegateStatement to DelegatingStatement</li>
<li><a href="b83dc2e8c4"><code>b83dc2e</code></a> Better name for test that stops statement</li>
<li><a href="527f3a3d0d"><code>527f3a3</code></a> Replace InfiniteLoop with RunForASecond</li>
<li><a href="2db6394288"><code>2db6394</code></a> Tidy up FailOnTimeoutTest</li>
<li><a href="64634e1c3e"><code>64634e1</code></a> Update 4.13.2 release notes to document pull 1654</li>
<li><a href="f8ee412316"><code>f8ee412</code></a> Fix serialization of AssumptionViolatedException (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1654">https://github.com/facebook/flipper/issues/1654</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.12...r4.13.2">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2007
Reviewed By: mweststrate
Differential Revision: D26843915
Pulled By: passy
fbshipit-source-id: 94f52da0efdd601382bc85a8ad5f4d9d60bd517c
Summary: Fixed an error which happens on second and subsequent device connection to Flipper
Reviewed By: passy
Differential Revision: D26829255
fbshipit-source-id: 17eb603647626a2168e330ec67f4a89783219356
Summary:
This should fix https://github.com/facebook/flipper/issues/1968
Pull Request resolved: https://github.com/facebook/flipper/pull/1999
Test Plan:
Built our sample app; built the sample app provided in the repo as part
of the issue; locally released the Flipper artifacts and built the RN
app against it.
Reviewed By: fabiomassimo
Differential Revision: D26817589
Pulled By: passy
fbshipit-source-id: c6db5f947c08e4236442b08306791e45b4d15ec3
Summary:
I don't fully understand how dependabot works with Android but it seems to only look at the literal fbjni version number based on the logs and we're actually outdated on a bunch of dependencies which Gradle doesn't handle very well.
Pull Request resolved: https://github.com/facebook/flipper/pull/1997
Test Plan: Tested on my fork and I've got a ton of PRs because of this. Brace yourselves.
Reviewed By: mweststrate
Differential Revision: D26784112
Pulled By: passy
fbshipit-source-id: 98ebd0b899a0603868d4b6bc0866e557c87fecd5
Summary: In dev mode a (further harmless) error will be triggered if the self inspection plugin is loaded, since the device_id is empty. empty device id's however are fine; the represent the host device (Mac / Win devices)
Reviewed By: passy
Differential Revision: D26814269
fbshipit-source-id: 281fc591c1df47092011b4140099fc7138718b43
Summary:
Fixing the previous resulted in a next exception, where blur / focus might be triggered directly as side effect of some running logic. I think this happens when entering a debugger statement causing the window to loose focus in favor of the devtools.
Wrapped the logic in setImmediate to make sure that it runs on its own stack, since this will prevent any potential future issues with programmatically focussing / blurring as well.
Reviewed By: jknoxville
Differential Revision: D26814270
fbshipit-source-id: 5ca430653a219d3c98d8bf925277de67d8a9eb20
Summary: The state recorder was never updated for Sandy, nor is that really needed since Sandy offers better testing abstractions, and this was a stop gap with potential privacy concerns (due to recording real data). The feature didn't result in any actual test cases, so it seems we won't be missing out with this :)
Reviewed By: passy
Differential Revision: D26813798
fbshipit-source-id: 48ec11516fbc1a47a349a5799713ad05a7e1c73a
Summary: As reported a few times in the internal chat
Reviewed By: passy
Differential Revision: D26813161
fbshipit-source-id: 8b834c7807a7634f23c3ab922bb43e288ea4bd68
Summary: This should have been automated, but I think the diff that landed the script and the actual release missed each other, so next time this should be automated
Reviewed By: passy
Differential Revision: D26782442
fbshipit-source-id: 205ab2e63bdff33f1ecea0a041d88a0a6ec6ae2d
Summary: This diff adds documentation for using physical devices to connect to Flipper. It also talks about simulators and emulators
Reviewed By: jknoxville
Differential Revision: D26780077
fbshipit-source-id: 47a08cec55c510abd36c2fc776f4ce05ff0ea4d0
Summary:
Not sure if I made this clearer or even more confusing,
but it's a try.
Reviewed By: mweststrate
Differential Revision: D26781610
fbshipit-source-id: d68b30ffe6b24d537473c2d85b2b74f425068a96
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1996
Erm, I'm a bit of a dummy. I didn't mock the access check, so it would actually
rely on idb being installed to run the tests correctly. Without, we'd fail like here
on GitHub: https://github.com/facebook/flipper/runs/2021551466
I couldn't quite figure out how to mock `fs.promises.access`, so I made the constructor
configurable, which doesn't seem that bad, actually.
Reviewed By: mweststrate
Differential Revision: D26778428
fbshipit-source-id: 120b8060ad3ccb1cecd8ce2b208733d5e1090a72
Summary: Create a constant to hold all valid origin prefixes, for incoming WebSocket requests. This is to make it easier to add additional origins.
Reviewed By: mweststrate
Differential Revision: D26778708
fbshipit-source-id: b89bd8c8d8925b2863f12c319c6ecbeeb265fc42
Summary: Not allowed within an iframe.
Reviewed By: jknoxville
Differential Revision: D26779338
fbshipit-source-id: e201002cb705ca890d6a8fa8470a391e71d8d46c
Summary:
The previous attempt kept the vulnerable dependency around in `yarn.lock`. Now
it's being resolved to the "fixed" version.
Reviewed By: mweststrate
Differential Revision: D26778354
fbshipit-source-id: 17d8e2f1bbcd28939d85e5a976da0bd074ea25e2
Summary: Added some pointers for everyone who is as iOS noobish as me.
Reviewed By: priteshrnandgaonkar
Differential Revision: D26777687
fbshipit-source-id: 1ba3bb08b5a7b3a3ba937176d4c4c9b5e765a977
Summary: The React Native example project was broken for iOS. Fixed this by upgrading cocoapods locally, and bumping the Flipper version.
Reviewed By: passy, priteshrnandgaonkar
Differential Revision: D26777641
fbshipit-source-id: 889ff4f9de7c44240fe0a1b5d7d3c7c0b688d8ad
Summary:
Upgraded Metro to 0.65.2 which contains the fix for regression which blocked us previously (https://github.com/facebook/metro/issues/641).
Also upgraded Babel to the latest available versions as anyway most of its packages were upgraded together with Metro.
Reviewed By: passy
Differential Revision: D26777168
fbshipit-source-id: f325e0ba46a95e15605a7b15a793d714b1027061
Summary: Minimal tweak to the soft crash error reporting: include the version number
Reviewed By: passy
Differential Revision: D26754416
fbshipit-source-id: d517d0bdb6bcf5c58b492c60b5bb8cc5f6b288f6
Summary: I've modified migration to ensure it never produces "undefined" state. Before that this happened when migration is performed from version 0.75- to 0.77+ without 0.76 in between.
Reviewed By: mweststrate
Differential Revision: D26749830
fbshipit-source-id: 3a6599e80935060e8784103363abd617a7f1b7bd
Summary: This is just an early start of centralising some ad-hoc logic we've got all over the place right now. Memoised do-we-have-idb calls with concatenated shell invocations. This gives us the opportunity to do a bit of testing, too.
Reviewed By: mweststrate
Differential Revision: D26694863
fbshipit-source-id: cd2b9883f90397802bbaae6030f7cb3881c565c2
Summary:
Packaged KaiOS apps have "app://" as their origin prefix (see the "origin" section in the documentation - https://developer.kaiostech.com/getting-started/main-concepts/manifest).
Accept WebSocket connections from any "app://" origin, so can connect to Flipper from apps running on KaiOS devices.
Reviewed By: priteshrnandgaonkar
Differential Revision: D26728925
fbshipit-source-id: 05f15fe464bf0dc977665fba1dd2b8d61a399fa6
Summary:
Fixes https://github.com/facebook/flipper/issues/1989
We had some self healing side effect that would destroy devices when registering a new device with the same serial, if they weren't yet. Redux isn't too happy about that, causing the attached crash.
Instead introduced a utility to destroy devices, and log an error if the device life cycle isn't respected by the device implementations, rather than crashing we will now just waste some memory.
Changelog: Fix a crash when disconnecting metro devices
Reviewed By: passy
Differential Revision: D26749214
fbshipit-source-id: 4c185ac521d44c1337fac8a9145440123b8b784c
Summary: Make sure that ReactNativeFlipper example is bumped automatically, so that testing becomes easier
Reviewed By: priteshrnandgaonkar
Differential Revision: D26723361
fbshipit-source-id: 7c72d541f9f210f4932b325c9d83ffa686e22bda
Summary:
Bumps [async-mutex](https://github.com/DirtyHairy/async-mutex) from 0.2.6 to 0.3.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/DirtyHairy/async-mutex/blob/master/CHANGELOG.md">async-mutex's changelog</a>.</em></p>
<blockquote>
<h2>0.3.1</h2>
<ul>
<li><code>withTimeout</code>: make Jest happy and cancel timer when the mutex is acquired.
Thanks to cantoine for the PR.</li>
</ul>
<h2>0.3.0</h2>
<ul>
<li>
<p>Deprecate <code>Mutex::release</code> / <code>Semaphore::release</code> and remove them from the
documentation. The methods are still available in 0.3.x, but will be removed in
0.4.0.</p>
<p>I don't like breaking existing APIs, but using those methods is inherently
dangerous as they can accidentially release locks acquired in a completely
different place. Furthermore, they are mostly useless for semaphores. I consider
adding them an unfortunate mistake on my end.</p>
<p>A safe alternative is the usage of <code>runExclusive</code> which allows to execute
blocks exclusively and automatically manages acquiring and releasing the
mutex or semaphore.</p>
</li>
<li>
<p>Add <code>Mutex::cancel</code> / <code>Semaphore::cancel</code> for rejecting all currently pending
locks.</p>
</li>
<li>
<p>Add <code>tryAcquire</code> decorator for lock-or-fail semantics.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="93f1ff7d6d"><code>93f1ff7</code></a> Changelog, bump version.</li>
<li><a href="3aad9351d7"><code>3aad935</code></a> Bump version.</li>
<li><a href="eed47b0425"><code>eed47b0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/DirtyHairy/async-mutex/issues/34">https://github.com/facebook/flipper/issues/34</a> from cantoine/clear-timeout-fix</li>
<li><a href="38e59ba3b4"><code>38e59ba</code></a> Add clearTimeout and tests</li>
<li><a href="76fb6185d3"><code>76fb618</code></a> Point badge to action on gh.</li>
<li><a href="330854af56"><code>330854a</code></a> Typo.</li>
<li><a href="73992fee3a"><code>73992fe</code></a> Ups.</li>
<li><a href="b3870af6b6"><code>b3870af</code></a> Badge.</li>
<li><a href="13ad461682"><code>13ad461</code></a> Another stab at coveralls.</li>
<li><a href="3e5daebbb7"><code>3e5daeb</code></a> Remove travis, add coveralls to github workflow.</li>
<li>Additional commits viewable in <a href="https://github.com/DirtyHairy/async-mutex/compare/v0.2.6...v0.3.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1984
Reviewed By: passy
Differential Revision: D26724090
Pulled By: mweststrate
fbshipit-source-id: 71a59fe1df200198fc437d2a87f72dde82ba4fa4
Summary:
Bumps [types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 17.0.0 to 17.0.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1986
Reviewed By: passy
Differential Revision: D26724087
Pulled By: mweststrate
fbshipit-source-id: 7e6e2ec26fbd3aba794f4279e7ce4af016efa750
Summary:
Bumps [react-color](https://github.com/casesandberg/react-color) from 2.18.1 to 2.19.3.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/casesandberg/react-color/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1987
Reviewed By: passy
Differential Revision: D26724081
Pulled By: mweststrate
fbshipit-source-id: c7b136546206dadfbd1a793360953b14586b219b
Summary: When exploratory testing Flipper, I generally see quite some React key warnings. So it seems that plugin devs often miss them. This diff will configure linting more aggressively to address that (it's not fool proof, but will find the most common cases).
Reviewed By: nikoant
Differential Revision: D26722707
fbshipit-source-id: e0d2b56de2422e1147f52c8e9150d00c7ee64bd2
Summary:
Bumps [babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.12.5 to 7.13.8.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/runtime's releases</code></a>.</em></p>
<blockquote>
<h2>v7.13.8 (2021-02-26)</h2>
<p>Thanks <a href="https://github.com/luxp"><code>@luxp</code></a> and <a href="https://github.com/pigcan"><code>@pigcan</code></a> for your first PRs!</p>
<h4>🐛 Bug Fix</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12909">#12909</a> chore: do not provide polyfills on bundling babel/standalone (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12891">#12891</a> fix(eslint-parser): merge input <code>estree</code> options (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-compat-data</code>, <code>babel-preset-env</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12901">#12901</a> Fix Module not found: Error: Can't resolve 'core-js/modules/es6.array.concat.js' with <a href="mailto:compat-data@7.13.x">compat-data@7.13.x</a> (<a href="https://github.com/luxp"><code>@luxp</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12893">#12893</a> Allow <code>require()</code> of runtime helpers in Node.js 13.2-13.6 (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>💅 Polish</h4>
<ul>
<li><code>babel-helper-create-class-features-plugin</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12898">#12898</a> Do not warn for <code>loose</code> of class features in <code>preset-env</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li><code>babel-core</code>, <code>babel-helper-transform-fixture-test-runner</code>, <code>babel-register</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12820">#12820</a> [internal] Keep the <code>.cjs</code> extension when compiling source files (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12883">#12883</a> Improve <code>babel/runtime</code> esm stability (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🔬 Output optimization</h4>
<ul>
<li><code>babel-plugin-proposal-object-rest-spread</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12899">#12899</a> Skip <code>_extends</code> helper for <code>{…x}</code> with modern targets (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 6</h4>
<ul>
<li>Alan Lu - 川古 (<a href="https://github.com/luxp"><code>@luxp</code></a>)</li>
<li>Babel Bot (<a href="https://github.com/babel-bot"><code>@babel-bot</code></a>)</li>
<li>Bogdan Savluk (<a href="https://github.com/zxbodya"><code>@zxbodya</code></a>)</li>
<li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li>
<li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
<li>pigcan (<a href="https://github.com/pigcan"><code>@pigcan</code></a>)</li>
</ul>
<h2>v7.13.7 (2021-02-24)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>
<ul>
<li><a href="cfdbdc0d1c"><code>cfdbdc0</code></a> Add back export maps for the <code>helpers/esm</code> folder (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 1</h4>
<ul>
<li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
<h2>v7.13.6 (2021-02-23)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12877">#12877</a> Define fallback <code>exports</code> for <code>babel/runtime</code> on old Node (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/runtime's changelog</code></a>.</em></p>
<blockquote>
<h2>v7.13.8 (2021-02-26)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12909">#12909</a> chore: do not provide polyfills on bundling babel/standalone (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12891">#12891</a> fix(eslint-parser): merge input <code>estree</code> options (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-compat-data</code>, <code>babel-preset-env</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12901">#12901</a> Fix Module not found: Error: Can't resolve 'core-js/modules/es6.array.concat.js' with <a href="mailto:compat-data@7.13.x">compat-data@7.13.x</a> (<a href="https://github.com/luxp"><code>@luxp</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12893">#12893</a> Allow <code>require()</code> of runtime helpers in Node.js 13.2-13.6 (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>💅 Polish</h4>
<ul>
<li><code>babel-helper-create-class-features-plugin</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12898">#12898</a> Do not warn for <code>loose</code> of class features in <code>preset-env</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li><code>babel-core</code>, <code>babel-helper-transform-fixture-test-runner</code>, <code>babel-register</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12820">#12820</a> [internal] Keep the <code>.cjs</code> extension when compiling source files (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12883">#12883</a> Improve <code>babel/runtime</code> esm stability (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🔬 Output optimization</h4>
<ul>
<li><code>babel-plugin-proposal-object-rest-spread</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12899">#12899</a> Skip <code>_extends</code> helper for <code>{…x}</code> with modern targets (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h2>v7.13.6 (2021-02-23)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12877">#12877</a> Define fallback <code>exports</code> for <code>babel/runtime</code> on old Node (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li><code>babel-compat-data</code>, <code>babel-preset-env</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12850">#12850</a> Update compat table (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h2>v7.13.5 (2021-02-23)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-compat-data</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-preset-env</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12870">#12870</a> Add <code>es6.array.slice</code> in corejs2 builtins (<a href="https://github.com/eligao"><code>@eligao</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>, <code>babel-plugin-proposal-decorators</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-preset-env</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12869">#12869</a> Ensure that <code>babel/runtime-corejs3</code> imports are injected (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h2>v7.13.4 (2021-02-23)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12867">#12867</a> Don't enable class features by default in <code>estree</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12865">#12865</a> Always load the CJS helpers when using <code>require</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h2>v7.13.2 (2021-02-23)</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e2abc19c4c"><code>e2abc19</code></a> v7.13.8</li>
<li><a href="bb558aaf28"><code>bb558aa</code></a> Allow <code>require()</code> of runtime helpers in Node.js 13.2-13.6 (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-runtime/issues/12893">#12893</a>)</li>
<li><a href="6a471decc3"><code>6a471de</code></a> Improve <code>babel/runtime</code> esm stability (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-runtime/issues/12883">#12883</a>)</li>
<li><a href="c39082ab74"><code>c39082a</code></a> v7.13.7</li>
<li><a href="cfdbdc0d1c"><code>cfdbdc0</code></a> Add back export maps for the <code>helpers/esm</code> folder</li>
<li><a href="30a89c969a"><code>30a89c9</code></a> v7.13.6</li>
<li><a href="ac7ac540ee"><code>ac7ac54</code></a> Define fallback <code>exports</code> for <code>babel/runtime</code> on old Node (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-runtime/issues/12877">#12877</a>)</li>
<li><a href="e940b8c4b9"><code>e940b8c</code></a> v7.13.4</li>
<li><a href="a2114d452c"><code>a2114d4</code></a> Always load the CJS helpers when using <code>require</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-runtime/issues/12865">#12865</a>)</li>
<li><a href="bcd70d988f"><code>bcd70d9</code></a> v7.13.2</li>
<li>Additional commits viewable in <a href="https://github.com/babel/babel/commits/v7.13.8/packages/babel-runtime">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1980
Reviewed By: priteshrnandgaonkar
Differential Revision: D26723638
Pulled By: mweststrate
fbshipit-source-id: 64d160d6156d02b5a2154bb288b82f0416edb150
