Summary:
After updating the internal properties of CKInsetComponent we didn't update some KVO magic being used in Flipper which caused some crashes:
https://fb.workplace.com/groups/componentkit/permalink/4986354281413147/
Reviewed By: fabiomassimo
Differential Revision: D25946704
fbshipit-source-id: 5995cda20d12b18f7520507cb6ede897fddf2670
Summary:
This PR adds github actions to validate the pods, so that the changes which breaks the validation is not made. This PR also downgrades the version update of OpenSSL, as it doesn't validate the Folly podspec. I have [raised](https://github.com/krzyzanowskim/OpenSSL/issues/113) an issue on the repository which manages the openssl dependency.
## Changelog
- Added githubaction for dependent pod validation
- Downgraded the openssl version, as with upgraded version the folly pod didn't validate.
Pull Request resolved: https://github.com/facebook/flipper/pull/1834
Test Plan: CI
Reviewed By: passy
Differential Revision: D25939525
Pulled By: priteshrnandgaonkar
fbshipit-source-id: f70d043f1f6b2c79028212d8f56c6b8632092e33
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1835
Reviewed By: priteshrnandgaonkar
Differential Revision: D25944782
Pulled By: passy
fbshipit-source-id: c0375df1ac8030f3bdfeaa9ac846031499bc9d5e
Summary:
This PR fixes the crash mentioned [here](https://github.com/facebook/flipper/issues/1674#issuecomment-754402609) in the https://github.com/facebook/flipper/issues/1674 . The issue was that logging `NSLog(@"%@", [self valueForKey:@"_methodDescription"]);` in the swizzled network delegate class used to cause a crash. The cause of this was the nil `methodDescription.types` sent to `class_addMethod`.
In the following change we do not add a method to the class which doesn't implement the selector, we will anyway listen for those events from the base NSURLSession class. Removing the `class_addMethod`, fixes both the issue mentioned
[here](https://github.com/facebook/flipper/issues/1674#issuecomment-754402609) in https://github.com/facebook/flipper/issues/1674.
This PR also fixes an issue where no network calls where logged in Flipper when the iOS version was 14, the reason was that the URLSessionResume task was not properly swizzled for 14.
## Changelog
- Do not add a runtime method to the delegate which doesn't implement a responder
- Fix swizzling logic of the URLSession task resume method for ios 14
Pull Request resolved: https://github.com/facebook/flipper/pull/1810
Test Plan:
- I ran the sample app and checked that the network calls are logged.
- I copy pasted the changes in RN project and verified that the issues mentioned in https://github.com/facebook/flipper/issues/1674 doesn't happen and also verified that the network calls being hit from JS and Native code gets logged in Flipper. Verified with IsolatedSwizzles.zip mentioned over [here](https://github.com/facebook/flipper/issues/1674#issuecomment-754726174). Also verified by copy pasting the code in the fresh RN project.
Reviewed By: fabiomassimo
Differential Revision: D25801510
Pulled By: mweststrate
fbshipit-source-id: 53ef574696d2abbdbfc2b6d94769327cdfa8aa2b
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1813
Reviewed By: mweststrate
Differential Revision: D25804192
Pulled By: passy
fbshipit-source-id: 2ea3d582d31c82ad8d4dc812b49129884c8d86bf
Summary:
As it is stated in `OpenSSL-Universal`'s release notes: 1.1.180 has "macOS Catalyst support".
In order to use Flipper for Mac Catalyst apps, we need to remove dependency blockers.
## Changelog
- Upgrade OpenSSL-Universal to 1.1.180
Pull Request resolved: https://github.com/facebook/flipper/pull/1774
Test Plan:
Build this project using iOS target.
In order to test Mac Catalyst, other blockers `CocoaLibEvent` need to be fixed.
Reviewed By: cekkaewnumchai
Differential Revision: D25681881
Pulled By: passy
fbshipit-source-id: 1e45e875b943fd0bcffb541f58ed87ce3584e593
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1754
Reviewed By: nikoant
Differential Revision: D25461675
Pulled By: mweststrate
fbshipit-source-id: 60fa85a6ec762be4d09b649cb17c012461ab0be1
Summary:
This should fix the react-native issue with building on Xcode 12: https://github.com/facebook/react-native/issues/29984
## Changelog
Upgrade OpenSSL-Universal dependency on the one that includes arm for iPhone Simulator: https://github.com/krzyzanowskim/OpenSSL/releases
Pull Request resolved: https://github.com/facebook/flipper/pull/1735
Test Plan: This PR is not intended to be merged directly, as more version bumping and propagation through the other pods will be needed.
Reviewed By: mweststrate
Differential Revision: D25302713
Pulled By: passy
fbshipit-source-id: ac8e7e4652800ab00255398fe227e58af3ad0c5c
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1739
Reviewed By: mweststrate
Differential Revision: D25333594
Pulled By: passy
fbshipit-source-id: 6328aff1af963fef5116e27f8c6fe8e342f1209f
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1732
Reviewed By: passy
Differential Revision: D25241631
Pulled By: nikoant
fbshipit-source-id: 788a5752208113170410271afa65a60163d2fe73
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1692
Reviewed By: passy
Differential Revision: D25065989
Pulled By: nikoant
fbshipit-source-id: 17b4ef33bbccb9ab40926ce1415aa75f78221bbd
Summary: The sample iOS project can't be built by `buck` because the internal(?) reference codes aren't available anymore. This diff change the way to instantiate the components and add CK dependency (not sure if the correct one or not).
Reviewed By: passy
Differential Revision: D24782764
fbshipit-source-id: 809245771fc3b542fe63dfccdc8bbc6913aa63af
Summary: This adds macOS compatibility to Flipper client along with some of the standard plugins.
Reviewed By: jknoxville
Differential Revision: D24644439
fbshipit-source-id: dc15636a6ac1bf684fa1c89735f51f0e97667b62
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1652
Reviewed By: jknoxville
Differential Revision: D24710268
Pulled By: nikoant
fbshipit-source-id: 6f387d715a51127dc09c2f01852a84d583fe9eec
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1610
Reviewed By: nikoant
Differential Revision: D24505996
Pulled By: passy
fbshipit-source-id: f959e173e69d4857d3694d11590da8563d0b9cf9
Summary: Updates the OpenSSL dependency. Enabling bitcode as the latest version of OpenSSL has bitcode support.
Reviewed By: mweststrate
Differential Revision: D24276537
fbshipit-source-id: 6f135659d64e8849dcf68266458a8f24ef795be7
Summary:
This should fix build failures with prod config. The symbols should only be in internal builds and not the prod ones.
```
stderr: Undefined symbols for architecture arm64:
"_OBJC_CLASS_$_SKNamed", referenced from:
...
"_OBJC_CLASS_$_SKComponentLayoutDescriptor", referenced from:
...
```
Reviewed By: rzito
Differential Revision: D24250749
fbshipit-source-id: 68c3d066a76baf4b1646f27dac0fd081bcaff41b
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1593
Reviewed By: cekkaewnumchai
Differential Revision: D24253146
Pulled By: nikoant
fbshipit-source-id: 60a0878b27d2cbc65d0b530fbc48aca228c898ac
Summary:
This diff renames the plugin identifier of the NT State plugin to `flipper-plugin-bloks-state`.
WWW side changes are here D23991116
Distillery: D24136550
[NOTE]: LAND IT IN WEEKEND TO AVOID CLIENT AND SERVER IN AN UNSYNC STATE
Differential Revision: D23932149
fbshipit-source-id: 1d9d28f83581be48c218150fe2a5cff26e5d846e
Summary: This tripped me up for a bit. Add some docs.
Reviewed By: Andrey-Mishanin
Differential Revision: D24160934
fbshipit-source-id: a36ac6b205a9edeeb0698f44476456583146907c
Summary:
We have some "internal-only" stuff we want to put in the attribute of a layout node.
This allows us to do so a way that keeps it out of open-source and avoid the clunky subclassing.
Reviewed By: adamjernst
Differential Revision: D24162047
fbshipit-source-id: 518ab9fbf0b4274076f5b0ae1b249e197563fa7f
Summary:
Changelog: [iOS][Network] Network plugin now supports iOS 14
Network plugin stopped working for iOS 14 as reported in https://github.com/facebook/flipper/issues/1534.
The fix is based on the origin Flex network observer, as seen in https://github.com/FLEXTool/FLEX/pull/451
- NetworkPlugin supports iOS 14+
Pull Request resolved: https://github.com/facebook/flipper/pull/1543
Test Plan: Verified manually that before this fix the network plugin broken on iOS 14, and after it, it initializes correctly.
Reviewed By: passy
Differential Revision: D24136401
Pulled By: mweststrate
fbshipit-source-id: 87e0e0fa4bc927d082387d937390b1e728125753
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1577
Reviewed By: cekkaewnumchai
Differential Revision: D24136300
Pulled By: mweststrate
fbshipit-source-id: dff95d2d0e0c7c2a27707b39201599ec1217a464
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1564
Reviewed By: cekkaewnumchai
Differential Revision: D24046974
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 2722a6a6598c20494a345da8c1c7f51194a40b31
Summary: Send data to NT/Bloks plugin instead of Bloks plugin. There are changes on the distillery side as well D23873230, which needs to land together with this diff.
Differential Revision: D23903952
fbshipit-source-id: 2b748e73116f10d69ec1cf810075882bb8fa09a6
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1542
Reviewed By: mweststrate
Differential Revision: D23888791
Pulled By: cekkaewnumchai
fbshipit-source-id: 75e0de6ea8f4d356fc1d3fca88127351d9164bba
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1529
Reviewed By: nikoant
Differential Revision: D23733948
Pulled By: passy
fbshipit-source-id: 57d3eeafee518a92fca6dc31a87b5b65c291cae8
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1522
Reviewed By: mweststrate
Differential Revision: D23600088
Pulled By: passy
fbshipit-source-id: 4634b682d50d448b2f31b6bddee4d0022c6da890
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1511
Reviewed By: priteshrnandgaonkar
Differential Revision: D23473025
Pulled By: nikoant
fbshipit-source-id: 16b36f2d952f47186b261b27b0bf2cabaab6a0c7
Summary:
Related diff [Litho]: D23243009
This diff adds support for a protocol for layout messages where the type is recursively encoded as:
```
{
kind: "type",
data: ???
}
```
We check if the message adheres to the new encoding, otherwise we fall back to the old behavior. If it's the new encoding, the message is traversed recursively flattening the types to EditorValue using the type hints provided.
Reviewed By: Andrey-Mishanin
Differential Revision: D23319619
fbshipit-source-id: 79e8886f8f5a0aea4ec32938f1d5cd2fd645a297
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1500
Reviewed By: jknoxville
Differential Revision: D23343573
Pulled By: mweststrate
fbshipit-source-id: 2193996ad1cb9983a64ce41851ee9ff4e49404d3
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1485
Reviewed By: priteshrnandgaonkar
Differential Revision: D23241704
Pulled By: passy
fbshipit-source-id: 025947bdf480bdee800717396c1317a5926c6210
Summary:
This diff adds a toggle setting in wilde which will enable certificate exchange through www.
Right now it just sends the information about which medium to be used for cert exchange to Flipper JS and its client side. But its implementation is not done yet.
### Flow for Wilde
Whenever user changes the setting(or when user logs out) we set the state of exchange medium and accordingly set/reset authtoken. Note at no given point we remove already existing certificates.
### Context for OSS
With this diff we introduce another way to do certificate exchange. Before this diff, we did certificate exchange by accessing the file system of app. But it turns out it's not possible to do that in applications signed by enterprise certs. Thus with this diff one can write their FlipperKitCertificateProvider and fetch the certificate from WWW.
Reviewed By: jknoxville
Differential Revision: D22896320
fbshipit-source-id: 55aef7028a62e71ba9c02f9f79acaab41d09c0c6
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1444
Reviewed By: nikoant
Differential Revision: D22998104
Pulled By: passy
fbshipit-source-id: a36d2e8bcf618dabea05e65228433ee33fa78a0d
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1439
Reviewed By: mweststrate
Differential Revision: D22925823
Pulled By: passy
fbshipit-source-id: c08f31513b715441a1837963de1e36bf938acb39
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1400
Reviewed By: mweststrate
Differential Revision: D22739816
Pulled By: nikoant
fbshipit-source-id: 7d098b8b99ea764cecde720eb607337e2d354895
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1371
Reviewed By: nikoant
Differential Revision: D22502894
Pulled By: passy
fbshipit-source-id: a9a7fded3fac39810e9cec327be9fb5c3c8e4ef9
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1324
Reviewed By: mweststrate
Differential Revision: D22389097
Pulled By: passy
fbshipit-source-id: 54e4d43c85298f0e7929ce33ff67c3e2e2327a49
Summary: This field is going to be removed in a subsequent version of the struct. Showing it is not that important, so let's just remove it.
Reviewed By: kevin0571
Differential Revision: D22335170
fbshipit-source-id: 0916927ee30757678f847cd0f826caa1d4a6c7cc
Summary:
Converted the Seammammals plugin to use Sandy plugin infra (but the old components). Also updated lock file.
Added unittests have been added as well. The UI snapshots in there are kinda overkill, but nice demo that it works.
This completes the full roundtrip of the new Sandy infra, so this will be the last diff of this stack. I promise. I think.
Reviewed By: nikoant
Differential Revision: D22308265
fbshipit-source-id: 260e91a1951d486f6689880fe25281e80a71806a
Summary:
`CKComponentAccessibilityContext::operator==` can be extremely expensive; it may invoke the `accessibilityLazyTextBlock` for its `CKComponentAccessibilityTextAttribute` members, and that can do a lot of string construction.
I could refactor this to make it cheaper, e.g. by migrating to a function-pointer-and-context-object approach. But the easiest thing to do is to simply remove it; I don't think it's meaningfully used.
Reviewed By: kevin0571
Differential Revision: D22322108
fbshipit-source-id: 82a0548d6dd28ec4adf2f3ba85705eabf665d100
