Summary:
This is a change which I am not fully confident in, but I think it will make things better;
previously favorite plugins where stored per device. This means that when ...
- switching between devices
- switching between apps
- when viewing disconnected devices
- when loading devices from flipper traces
... the starred plugin preference would reset (especially for the last two: they have generated unique device names, so there would never be preferred items)
This Diff changes the plugin preferences to be global, so on every app and every device you have the same preferences (if they support the plugin). This assumes most people work mostly with the same limited set of plugins
Reviewed By: jknoxville
Differential Revision: D18780965
fbshipit-source-id: 3a560393b81e7d65ae01fb737938f8562843af13
Summary:
Some lifecycle methods are deprecated now. Where they can be replaced easily I replaced them. Where they can't be updated easily I marked them as unsafe, as if a bigger refactoring is required for those components, we'd better convert them to function components instead.
Didn't update the plugins as they are ideally updated by their owners.
Didn't update styled components, there is a separate task for that.
Reviewed By: jknoxville
Differential Revision: D18780579
fbshipit-source-id: 132a3789875ab6a3caee582b0e5f7feb7dc4a4c1
Summary:
Was getting a react warning whenever the feedback prompt opens.
This stops it from happening.
Reviewed By: mweststrate
Differential Revision: D18780008
fbshipit-source-id: e4635f7a8322e25a3eea1c201974a100d1f1327a
Summary: All subfolders of src/plugins/ need to have a title in their package.json, in this case it doesn't add anything but it's a rare case, so at least stops the linter from complaining.
Reviewed By: mweststrate
Differential Revision: D18764161
fbshipit-source-id: 7a3d7e3dba7633107d9e43c021986ecdf22d3c28
Summary: When user comes from a deeplink we will check if the user is part of the new GK, then we will open the new form otherwise old form.
Reviewed By: mweststrate
Differential Revision: D18764892
fbshipit-source-id: 512401f0370c3d4b16c9d88e16e8a4ca06148854
Summary: This diff refactors the way appName is shown. We populate the appName through selectedApp, thus keeping different redux prop is not needed. This diff gets rid off the appName prop from the redux store and makes sure that appName gets updated on client change.
Reviewed By: mweststrate
Differential Revision: D18764685
fbshipit-source-id: 5ff94c83f84b03bbee34518aface46d4544af77f
Summary:
Slightly improves the support form interactions / code flow:
* When uploading, input fields are hidden
* WHen upload succeeded: Show link to final post
* When upload succeeded: be able to start a new bug report
* Styled error messages, and unified error flow
* Don't support report if errors occurred
Reviewed By: priteshrnandgaonkar
Differential Revision: D18779791
fbshipit-source-id: 28e873d0509865c66d861fe9cedb62a31f0e8bae
Summary:
* Make sure uploadIDs are converted into CDN urls and displayed
* Changed type of uploadID's to strings, as numbers are
Reviewed By: priteshrnandgaonkar
Differential Revision: D18762974
fbshipit-source-id: d94af61b0bc114b5f0cc2bfcde98fd491058e971
Summary: This diff refactors the MediaComponent and moves it's upload logic to the support component. Also the state of the media component is stored in the redux store, so this solves the caching issue.
Reviewed By: mweststrate
Differential Revision: D18754736
fbshipit-source-id: b937f34180405025a6eb437bf2c2d589743e341b
Summary: Slightly refactored JS api to make it work with new js app launcher
Reviewed By: jknoxville
Differential Revision: D18761757
fbshipit-source-id: edb8e5907765a9354e4c636be97d3cf6df63ee98
Summary:
The Markdown component wasn't rendering a single component, so I put it in a container.
Also added a margin bottom so it didn't look out of place. There's probably a nicer way to do that.
Reviewed By: mweststrate
Differential Revision: D18749381
fbshipit-source-id: ea7827dc7e6141fb0dbd5886356736da4b50f5dc
Summary:
Nobody moves the hackathon!
Fixed some circular deps warnings while waiting for another Diff to land
Reviewed By: priteshrnandgaonkar
Differential Revision: D18749645
fbshipit-source-id: 225fbea428dca02f0f4c920ee47b4ece3c3e370b
Summary: Includes a preview of the JS-only plugin API. This is experimental and might break in future releases.
Reviewed By: mweststrate
Differential Revision: D18757712
fbshipit-source-id: a3c238ffbe3d5d80ca8e750cf5ef89b7a7436c62
Summary:
* Added a button to clear Diff selection
* Added icons and color to the recording button
* Made App input field readonly
Reviewed By: priteshrnandgaonkar
Differential Revision: D18748538
fbshipit-source-id: 00ffb5d5c36f8f5394a353602f182aabd8237ee7
Summary: The previous table was ugly, and weirdly interactive. This diff changes it to a static layout
Reviewed By: priteshrnandgaonkar
Differential Revision: D18744712
fbshipit-source-id: 9060da07eae836a94ce6d8bb2ebb8a6a54470daa
Summary: This diff adds exporting UI in the support form itself. It replaces the "Export as File and Link" buttons with a submit button, which uploads media and then initiates flipper export.
Reviewed By: mweststrate
Differential Revision: D18714630
fbshipit-source-id: ccbb9b2d47687e77a0fdb5449c18e91a5bd5f96e
Summary:
This diff adds the media files into the redux store. In the redux store they are stored as the following {fbid: description}, where fbid and description are integer and string respectively.
Ignore the rows getting highlighted automatically, there seems to be a bug in the ManagedTable. Talked to Michel and we agreed to replace it.
Reviewed By: mweststrate
Differential Revision: D18708815
fbshipit-source-id: 0aaf1b672c230312203691538091a717d69fb5ad
Summary: This diff refactors the `exportpersistedstate` and few of the functions in exportData.tsx to just expect the Redux State instead the store object.
Reviewed By: mweststrate
Differential Revision: D18733011
fbshipit-source-id: 56739917b49142ba4b6e79e7c16378fe60d6ac3b
Summary: This diff makes Listview agnostic to the logic of the sharing.
Reviewed By: mweststrate
Differential Revision: D18711095
fbshipit-source-id: 75541dee0b5740c9951c46118d96292e28979507
Summary: Another bump for npm. Easiest way to test this, unfortunately.
Reviewed By: mweststrate
Differential Revision: D18726533
fbshipit-source-id: 40d241a24ef5c0cdf8656b054280410b5bcda863
Summary:
Original commit changeset: ff84080d43fa
This re-adds JS client support. The original version had a small bug that inadvertantly wrapped support for Android emulators in the dropdown in a GK that was only meant to cover JS clients. This is addressed here.
Reviewed By: timur-valiev
Differential Revision: D18707485
fbshipit-source-id: ceea8e279a21111f96073f8b784e852f6313e2a4
Summary:
Applies some additional styling to the support details form, and implemented the screenshot / video styling.
Probably needs some more fixes in the future, once we have a real report to import :)
Reviewed By: jknoxville
Differential Revision: D18658388
fbshipit-source-id: dc9207ec08b3f4360c96d8d14980710c57d6b5ec
Summary:
Original commit changeset: eddfbb3571c7
Original commit changeset: f7300f527b65
Pains me to do this, but probably our best chance right now to get a release out.
Reviewed By: cekkaewnumchai
Differential Revision: D18687890
fbshipit-source-id: 05d13aca71457ca6dd19f5b45d58158ae223e66f
Summary: Removes android_home check, which is included in android_sdk check
Reviewed By: passy
Differential Revision: D18689233
fbshipit-source-id: 378b316b4bfddcf660af5d91a5271b47df441d88
Summary:
Original commit changeset: 56d1ca1a60ed
This broke Android support in some instances. We haven't had a chance to investigate this yet, but this should cleanly reapply, so we can figure out what happened after the release.
Reviewed By: cekkaewnumchai
Differential Revision: D18688590
fbshipit-source-id: ff84080d43fa481cc8c8c669a76aed15d0f8aa56
Summary: This was a failed attempt to fix invalid initialization, but just means it fails elsewhere, so undoing this change.
Reviewed By: passy
Differential Revision: D18685054
fbshipit-source-id: fc460ee7cacc8cb89ee2a22243f9738383cbba43
Summary:
## The dependency [rsocket-tcp-server](https://github.com/rsocket/rsocket-js) was updated from `0.0.17` to `0.0.18`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [stevegury](https://www.npmjs.com/~stevegury)
**License:** BSD-3-Clause
[Find out more about this release](https://github.com/rsocket/rsocket-js).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/652
Reviewed By: passy
Differential Revision: D18672992
Pulled By: cekkaewnumchai
fbshipit-source-id: 790f3234c36c227427c4eb8aeb46f25310aba7d5
Summary:
## The dependency [rsocket-core](https://github.com/rsocket/rsocket-js) was updated from `0.0.17` to `0.0.18`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [stevegury](https://www.npmjs.com/~stevegury)
**License:** BSD-3-Clause
[Find out more about this release](https://github.com/rsocket/rsocket-js).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/651
Reviewed By: passy
Differential Revision: D18672983
Pulled By: cekkaewnumchai
fbshipit-source-id: 6da4c900a1d1c1b5589f35c21128cf2ffc6db48f
Summary:
If something calls FlipperClient.getInstance(), it will start a new thread and try to start the client. If this is in a context that will fail, like a process that hasn't loaded the .so, then it will fail, but we don't know who started the thread. This adds logging before spawning a new thread so we can see the stack trace of the culprit.
It might want to throw an error instead, that will help track down the culprit of such initializations, but this is a less intrusive change to just stop the failures from happening, to start with.
Reviewed By: cekkaewnumchai
Differential Revision: D18658972
fbshipit-source-id: 2433d4d6ef411d4fb28f31e27bcef702c5a8f4db
Summary: We're seeing some cases of initHybrid failing when the C++ class hasn't been registered. I don't think we should be attempting to init in these cases, so gating it by the same logic as when we load the static library.
Reviewed By: priteshrnandgaonkar
Differential Revision: D18658101
fbshipit-source-id: b29592135dcf637a8c0d40aee30e383f4f35e527
Summary: in FlipperRSocketResponder::handleFireAndForget, a responder object was being conditionally (for requests with an "id" field) created, resulting in a null pointer passed into FlipperClient::onMessageReceived when no id was present. FlipperClient::onMessage received, in the meantime, unconditionally dereferences that pointer, resulting in a segmentation fault. This change creates the responder object regardless of whether or not the "id" key is present in the request object, thus avoiding passing a null pointer into FlipperClient::onMessageReceived.
Reviewed By: jknoxville
Differential Revision: D18583898
fbshipit-source-id: 2112c45bc0cd639cec908d0039d6bdaed2f61491
