Summary:
This change will allow us to display correct stack traces in flipper UI as well as send them to scuba.
Currently correct stack traces are only displayed in the console and we do not have access to them.
Reviewed By: ivanmisuno
Differential Revision: D50015827
fbshipit-source-id: 2a60315dd5c06b2635ce0414f612ff1fdca0e489
Summary: Show an unsupported modal for Electron builds (FB employees only)
Reviewed By: antonk52
Differential Revision: D49770083
fbshipit-source-id: 3616dce3206e976f2fdccd834b2c57748f19fcb0
Summary: No need to check for updates on Electron builds.
Reviewed By: antonk52
Differential Revision: D49821903
fbshipit-source-id: d836e4254bbe793921bb4a627220fee961c1c402
Summary: There are reports in which kill as is doesn't kill the process. Using the '-9' flag does, so update troubleshoot message.
Reviewed By: LukeDefeo
Differential Revision: D49537427
fbshipit-source-id: a062c92528589cecf0f41e1c344c5d0ae1c3345d
Summary:
> "Hi, kids, do you like violence?"
Alrighty, in flipper-frontend-core we have the **base** implmenetation of flipperLib (the thing exposed to the plugins). This base implementation is never used directly by the plugins, rather it is shared code used by the real consumers - flipper-ui-core (regular Flipper with UI) and flipper-server-companion (the thing that allows hosting plugins on the server).
These real consumers actually run the plugins and expose flipperLib to the plugins.
In flipper-ui-core we have a more sophisticated logic of calling the intern graph - we check for VPN connection and authn. Therefore, to expose the same way of handling intern graph requests we **override** intern graph calls provided by flipper-frontend-core.
*Ideally*, we should move checking for VPN connection and authn to flipper-frontend-core, but currently it is a lot of effort for very little gains:
1. flipper-frontend-core does not have a notion of a user
2. Even if we move the authn-related logic there the only real consumer of that effort if flipper-server-companion that is used only by UIQR (which in its turn is barely used in the headless mode and do not require authn-related logic).
Thus, we just override intern graph request on the flipper-ui-core side since it is the simplest and the most impactful thing to do at the moment.
Reviewed By: LukeDefeo
Differential Revision: D49494922
fbshipit-source-id: 6f1d521af7ca5bd50549b7bc328d6b8fcab98389
Summary: Used last year to GK server usage. This is obsolete so is safe to remove.
Reviewed By: ivanmisuno
Differential Revision: D49414625
fbshipit-source-id: 9eeff932c59c90dff829e4c6c83bad43a0fd74e3
Summary:
We had our stack traces broken for a long time. They always pointed at the bundle.js file. With this change the stack traces **in the console** will be pointing at the actual source files. This will save a lot of time for engineers instead of manually looking for the source of errors.
Why this didn't work before?
When we were calling `console.error(error.toString())` the browser was not applying sourcemaps to the stacktrace as it interpreted as a random string. However, when you pass an actual instance of Error constructor, the sourcemaps will be applied and we get correct stack traces to the source files.
I looked at the code of the Logger and it is already handles the Error instances, so I think this should be fine also for the logs that go to scuba. CC passy
Reviewed By: LukeDefeo, passy
Differential Revision: D49275025
fbshipit-source-id: 2addc601f45622e35890d7d0e1992f4bca41a338
Summary: The `visible` prop is marked as deprecated in favour of `open`
Reviewed By: passy
Differential Revision: D49226821
fbshipit-source-id: 4a4a7d03a1c8ff860c4e4cd02e19071185a8554e
Summary: Shows up in the console as a warning. Easy to fix.
Reviewed By: lblasa
Differential Revision: D49189263
fbshipit-source-id: 40428434803db708789811352b76004549d8c086
Summary: A few improvements to the installation wizard.
Reviewed By: antonk52
Differential Revision: D49145069
fbshipit-source-id: 1aadd85e1d187bd61983a0b4201b530cbdbf509a
Summary:
A typo in the settings page has been fixed.
Pull Request resolved: https://github.com/facebook/flipper/pull/5102
Reviewed By: ivanmisuno
Differential Revision: D48948584
Pulled By: passy
fbshipit-source-id: 2469a25d2deb7c6c128f7d88a68fd5d147aad428
Summary:
A little hacky because we currently have too many implementations for getting devices but lblasa is working on cleaning this up. Once that's done, we should add some tests for this.
Changelog: Show the iOS version of simulators in the launcher window
Reviewed By: lblasa
Differential Revision: D48777923
fbshipit-source-id: 18846520feba8eb10b6417f87bd802ffaabb1dff
Summary: It removes the ScribeLogger found in flipper-ui-core and also updates its references to point to the type defined in flipper-common.
Reviewed By: passy
Differential Revision: D48556328
fbshipit-source-id: 525d9e8ee9a80f68aecb8b8b2e25ffd4714649bd
Summary: The log tailer is already defined in flipper-common, use that instead.
Reviewed By: passy
Differential Revision: D48524909
fbshipit-source-id: 1c0674276f08893ea80dc2fc9f8b45679f33e93e
Summary:
Session Id should be shared between client and server, but it was defined deep in the client (redux store).
The proposed solution presented below is to move the session id to the server configuration. By doing this, it becomes available to both server and client VERY early in the application life-cycle for both Electron and non-Electron builds.
Reviewed By: LukeDefeo
Differential Revision: D48520367
fbshipit-source-id: ca959b27ab18b1a2e4cd2fac1d28545664f1b514
Summary:
This updates minor and patch level dependencies. Frustratingly, I had to revert a bunch
of changes in that version range that still caused incompatibilities and test failures.
If I find time, I'll dig a bit deeper.
Reviewed By: ivanmisuno
Differential Revision: D48433210
fbshipit-source-id: 9ab12e774c1992d4f22cc1428d34f102ce820b75
Summary: This change only adds the PWA as capable of handling files with the ".flipper" extension.
Reviewed By: aigoncharov
Differential Revision: D48353437
fbshipit-source-id: fd78942ac4dffb7d26d5ca5be826290018465b93
Summary: These two functions were not enabled for the browser experience.
Reviewed By: antonk52
Differential Revision: D48315991
fbshipit-source-id: 2944a386d9de8a06b043305e7ceb8a6c41e11209
Summary: Implementation was missing for the browser. This provides a default implementation.
Reviewed By: aigoncharov
Differential Revision: D48311198
fbshipit-source-id: fd067600f571234e0fbccfb90853b62f175ff8fb
Summary: Not really a connectivity related log, so removed [conn] from it.
Reviewed By: passy
Differential Revision: D48266546
fbshipit-source-id: e384301d6301940366b594b4bc612349cc2264ce
Summary: Combine the two used commands as will make things easier for our users.
Reviewed By: passy
Differential Revision: D48266474
fbshipit-source-id: 1ee5c568ff001dc5ba3f11e21b09a2a6ab430ac7
Summary: Also removing topLevelSelection as it is no longer used in flipper
Reviewed By: aigoncharov
Differential Revision: D48069386
fbshipit-source-id: 6e4cdd6aab67d2cd30ac1884118703520125bf84
Summary: This is a continuation of flipper redesign. Next diff will mov notification and connectivity into modals as well
Reviewed By: LukeDefeo
Differential Revision: D48066573
fbshipit-source-id: 3b4a22462221d8da13b07ad1738e05de849e00c4
Summary: Feedback from support group said it wasnt clear when recording was on
Reviewed By: antonk52
Differential Revision: D48027414
fbshipit-source-id: db61a9806da285610e8f550ceff5af4d7b7acb47
Summary: Add an option to kill the debugging bridge directly within Flipper.
Reviewed By: antonk52
Differential Revision: D47990786
fbshipit-source-id: 30cd8ca1d55e8b2ade03700d884e5d849a2dadbf
