0de4f11e154a14ba3d4b51c2e453db81a6990b31
1383 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
dependabot[bot]
|
824cd8b9f8 |
Bump eslint-plugin-react from 7.21.5 to 7.23.1 in /desktop (#2131)
Summary: Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.21.5 to 7.23.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md">eslint-plugin-react's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/yannickcr/eslint-plugin-react/compare/v7.23.0...v7.23.1">7.23.1</a> - 2021.03.23</h2> <h3>Fixed</h3> <ul> <li>version detection: support processor virtual filename (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2949">#2949</a>[] <a href="https://github.com/JounQin"><code>@JounQin</code></a>)</li> </ul> <p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2949">#2949</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2949">yannickcr/eslint-plugin-react#2949</a></p> <h2><a href="https://github.com/yannickcr/eslint-plugin-react/compare/v7.22.0...v7.23.0">7.23.0</a> - 2021.03.22</h2> <h3>Added</h3> <ul> <li>[<code>jsx-no-target-blank</code>]: add fixer (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2862">#2862</a>[] <a href="https://github.com/Nokel81"><code>@Nokel81</code></a>)</li> <li>[<code>jsx-pascal-case</code>]: support minimatch <code>ignore</code> option (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2906">#2906</a>[] <a href="https://github.com/bcherny"><code>@bcherny</code></a>)</li> <li>[<code>jsx-pascal-case</code>]: support <code>allowNamespace</code> option (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2917">#2917</a>[] <a href="https://github.com/kev-y-huang"><code>@kev-y-huang</code></a>)</li> <li>[<code>jsx-newline</code>]: Add prevent option (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2935">#2935</a>[] <a href="https://github.com/jsphstls"><code>@jsphstls</code></a>)</li> <li>[<code>no-unstable-nested-components</code>]: Prevent creating unstable components inside components (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2750">#2750</a>[] <a href="https://github.com/AriPerkkio"><code>@AriPerkkio</code></a>)</li> <li>added <code>jsx-runtime</code> config, for the modern JSX runtime transform (<a href="https://github.com/ljharb"><code>@ljharb</code></a>)</li> </ul> <h3>Fixed</h3> <ul> <li>[<code>jsx-no-constructed-context-values</code>]: avoid a crash with <code>as X</code> TS code (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2894">#2894</a>[] <a href="https://github.com/ljharb"><code>@ljharb</code></a>)</li> <li>[<code>jsx-no-constructed-context-values</code>]: avoid a crash with boolean shorthand (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2895">#2895</a>[] <a href="https://github.com/ljharb"><code>@ljharb</code></a>)</li> <li>[<code>static-property-placement</code>]: do not report non-components (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2893">#2893</a>[] <a href="https://github.com/golopot"><code>@golopot</code></a>)</li> <li>[<code>no-array-index-key</code>]: support optional chaining (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2897">#2897</a>[] <a href="https://github.com/SyMind"><code>@SyMind</code></a>)</li> <li>[<code>no-typos</code>]: avoid a crash on bindingless <code>prop-types</code> import; add warning (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2899">#2899</a>[] <a href="https://github.com/ljharb"><code>@ljharb</code></a>)</li> <li>[<code>jsx-curly-brace-presence</code>]: ignore containers with comments (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2900">#2900</a>[] <a href="https://github.com/golopot"><code>@golopot</code></a>)</li> <li>[<code>destructuring-assignment</code>]: fix a false positive for local prop named <code>context</code> in SFC (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2929">#2929</a>[] <a href="https://github.com/SyMind"><code>@SyMind</code></a>)</li> <li>[<code>jsx-no-target-blank</code>]: Allow rel="noreferrer" when <code>allowReferrer</code> is true (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2925">#2925</a>[] <a href="https://github.com/edemaine"><code>@edemaine</code></a>)</li> <li>[<code>boolean-prop-naming</code>]: add check for typescript "boolean" type (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2930">#2930</a>[] <a href="https://github.com/vedadeepta"><code>@vedadeepta</code></a>)</li> <li>version detection: Add tests that verify versioning works for sibling and child projects (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2943">#2943</a>[] <a href="https://github.com/jcrosetto"><code>@jcrosetto</code></a>)</li> <li>[<code>jsx-curly-newline</code>]: Update error messages (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2933">#2933</a>[] <a href="https://github.com/jbrower2"><code>@jbrower2</code></a>)</li> </ul> <h3>Changed</h3> <ul> <li>[Docs] [<code>jsx-no-constructed-context-values</code>][]: fix invalid example syntax (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2910">#2910</a>[] <a href="https://github.com/kud"><code>@kud</code></a>)</li> <li>[readme] Replace lists of rules with tables in readme (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2908">#2908</a>[] <a href="https://github.com/motato1"><code>@motato1</code></a>)</li> <li>[Docs] added missing curly braces (<a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2923">#2923</a>[] <a href="https://github.com/Muditxofficial"><code>@Muditxofficial</code></a>)</li> </ul> <p><a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2943">#2943</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2943">yannickcr/eslint-plugin-react#2943</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2935">#2935</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2935">yannickcr/eslint-plugin-react#2935</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2933">#2933</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2933">yannickcr/eslint-plugin-react#2933</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2930">#2930</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2930">yannickcr/eslint-plugin-react#2930</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2929">#2929</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2929">yannickcr/eslint-plugin-react#2929</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2925">#2925</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2925">yannickcr/eslint-plugin-react#2925</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2923">#2923</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2923">yannickcr/eslint-plugin-react#2923</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2917">#2917</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2917">yannickcr/eslint-plugin-react#2917</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2910">#2910</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2910">yannickcr/eslint-plugin-react#2910</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2908">#2908</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2908">yannickcr/eslint-plugin-react#2908</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2906">#2906</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2906">yannickcr/eslint-plugin-react#2906</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2900">#2900</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/pull/2900">yannickcr/eslint-plugin-react#2900</a> <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2899">#2899</a>: <a href="https://github-redirect.dependabot.com/yannickcr/eslint-plugin-react/issues/2899">yannickcr/eslint-plugin-react#2899</a></p> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
6d90ef403f |
Bump @typescript-eslint/parser from 4.14.2 to 4.19.0 in /desktop (#2129)
Summary: Bumps [typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.14.2 to 4.19.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser's releases</code></a>.</em></p> <blockquote> <h2>v4.19.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.18.0...v4.19.0">4.19.0</a> (2021-03-22)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [member-delimiter-style] correct invalid fix for multiline with params on the same line (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3177">#3177</a>) (<a href=" |
||
|
dependabot[bot]
|
d31847be1e |
Bump open from 7.4.2 to 8.0.4 in /desktop (#2128)
Summary: Bumps [open](https://github.com/sindresorhus/open) from 7.4.2 to 8.0.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sindresorhus/open/releases">open's releases</a>.</em></p> <blockquote> <h2>v8.0.4</h2> <ul> <li>Fix the <code>app.argument</code> option (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/237">https://github.com/facebook/flipper/issues/237</a>) e127ae8</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v8.0.3...v8.0.4">https://github.com/sindresorhus/open/compare/v8.0.3...v8.0.4</a></p> <h2>v8.0.3</h2> <ul> <li>Hide PowerShell window on Windows (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/235">https://github.com/facebook/flipper/issues/235</a>) 53faf7f</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v8.0.2...v8.0.3">https://github.com/sindresorhus/open/compare/v8.0.2...v8.0.3</a></p> <h2>v8.0.2</h2> <ul> <li>Fix a regression in v8.0.0 (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/232">https://github.com/facebook/flipper/issues/232</a>) 26ee3d2</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v8.0.1...v8.0.2">https://github.com/sindresorhus/open/compare/v8.0.1...v8.0.2</a></p> <h2>v8.0.1</h2> <ul> <li>Fix Node.js 12 compatibility (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/229">https://github.com/facebook/flipper/issues/229</a>) 71777b1</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v8.0.0...v8.0.1">https://github.com/sindresorhus/open/compare/v8.0.0...v8.0.1</a></p> <h2>v8.0.0</h2> <h3>Breaking</h3> <ul> <li>Require Node.js 12 cde5c79</li> <li>Removed deprecated <code>url</code> option</li> <li>The <code>app</code> option now accepts an object instead of a string/array:</li> </ul> <pre lang="diff"><code> await open('https://sindresorhus.com', { - app: 'firefox' + app: {name: 'firefox'} }); </code></pre> <pre lang="diff"><code> await open('https://sindresorhus.com', { - app: ['chrome', '--incognito'] + app: {name: 'google chrome', arguments: '--incognito'} }); </code></pre> <h3>Improvements</h3> <ul> <li>Add <a href="https://github.com/sindresorhus/open#openapps"><code>open.apps</code></a> constants, which lets easily open Chrome and Firefox without cross-platform issues</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.4.2...v8.0.0">https://github.com/sindresorhus/open/compare/v7.4.2...v8.0.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
224ee178f1 |
Bump @babel/parser from 7.13.12 to 7.13.13 in /desktop (#2126)
Summary: Bumps [babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.13.12 to 7.13.13. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/parser's changelog</code></a>.</em></p> <blockquote> <h2>v7.13.13 (2021-03-26)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12441">#12441</a> Disallow await before exponential (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13031">#13031</a> Correctly handle relative <code>browserslistConfigFile</code> paths (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13028">#13028</a> Resolve <code>.browserslistrc</code> as a project-wide file (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-constant-elements</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13054">#13054</a> fix: constant variables only enable constant react elements (<a href="https://github.com/cgood92"><code>@cgood92</code></a>)</li> </ul> </li> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13046">#13046</a> fix(types): add missing range for BaseNode (<a href="https://github.com/JounQin"><code>@JounQin</code></a>)</li> </ul> </li> <li><code>babel-node</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13037">#13037</a> fix: make babel-node spawned process bubble msg (<a href="https://github.com/lambertkevin"><code>@lambertkevin</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13037">#13037</a> fix: make babel-node spawned process bubble msg (<a href="https://github.com/lambertkevin"><code>@lambertkevin</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12933">#12933</a> fix(ts): parenthesized assert and assign (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-cli</code>, <code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12954">#12954</a> Do not bail on SHOW_CONFIG_FOR matches (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13021">#13021</a> Remove lodash sortBy use (<a href="https://github.com/jridgewell"><code>@jridgewell</code></a>)</li> </ul> </li> <li>Other <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13055">#13055</a> Replace CircleCI badge by GitHub CI (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13044">#13044</a> Expand type definitions for path.{get,set}Data to cover symbols (<a href="https://github.com/addaleax"><code>@addaleax</code></a>)</li> </ul> </li> </ul> <h4>🏃♀️ Performance</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13040">#13040</a> Set <code>rootMode: "root"</code> in <code>loadPartialConfig</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Michel Weststrate
|
1b0d01ef38 |
Give clear messages on how to connect to physical devices
Summary: Give clearer instructions when connection to (physical) device fails, rather than just logging errors. Fixes https://github.com/facebook/flipper/issues/1942 Also removed throwing errors for known problems, as they can be remediated by users. Reviewed By: passy Differential Revision: D27360575 fbshipit-source-id: 311d27178d4d205dff725201c7c60f116f0eb319 |
||
|
Michel Weststrate
|
d5fbe9a5b9 |
Support physical device logging
Summary: Changelog: Logs plugin now supports physical iOS devices As reported in https://github.com/facebook/flipper/issues/262 and linked papercut. This diff adds support for iOS device logs through idb. Since idb doesn't respect `--json` flag at the moment, we perform the parsing in Flipper itself. Reviewed By: passy Differential Revision: D27346262 fbshipit-source-id: 3b314716f48bb9a7fe709370303396a51893359c |
||
Pritesh Nandgaonkar
|
2132163d20 |
Add native tree information in sidebar
Summary: This diff adds the native tree information in the side bar. It reuses the the Layout Plugins Inspector Sidebar UI. Reviewed By: timur-valiev Differential Revision: D27387714 fbshipit-source-id: 46941fdaaaf9fea78dab32f0f8bf7b3dec8286c6 |
||
|
Michel Weststrate
|
8dadf28125 |
Fix layout regression in sidebar
Summary: D27233899 (
|
||
Pascal Hartig
|
e4a814502a |
Mass bump deps
Summary: Bumping everything that's just a patch version behind or safe-looking minor change. Just hoping to get ahead of dependabot's next run. Reviewed By: fabiomassimo Differential Revision: D27367567 fbshipit-source-id: 1bf8bad02e5a9f07f5982466254f9906581230cf |
||
generatedunixname89002005306973
|
979c49b18d |
Flipper Release: v0.82.1
Summary: Releasing version 0.82.1 Reviewed By: passy Differential Revision: D27360493 fbshipit-source-id: 683605461956d39fdc20560d3a045fd42325e5fb |
||
|
Pascal Hartig
|
00442cff4a |
Update xmldom (security fix)
Summary: Fixes https://github.com/facebook/flipper/security/dependabot/desktop/yarn.lock/xmldom/open. This is pulled in via electron-builder. Reviewed By: jknoxville Differential Revision: D27338307 fbshipit-source-id: e57cb0123289bb53d1f1d9e5957485fb7f65488a |
||
Pascal Hartig
|
a0a28c2e21 |
Fix ts-node for Windows (#2101)
Summary: Somehow referring to the parent directory doesn't work on Windows. Please don't ask me why. Given that we run a script from outside the package doing it on the top-level seems more consistent anyway. Pull Request resolved: https://github.com/facebook/flipper/pull/2101 Test Plan: Yarn on Windows succeeds: https://github.com/facebook/flipper/pull/2101/checks?check_run_id=2195613718 Reviewed By: fabiomassimo Differential Revision: D27335250 Pulled By: passy fbshipit-source-id: aaccdb3f7e78ca264b371a7723c9bad065919d45 |
||
|
Pascal Hartig
|
8c85da5bc8 |
Bump deps
Summary: Just trying to get ahead of dependabot and bump some easy dependencies all at once. Reviewed By: fabiomassimo Differential Revision: D27326687 fbshipit-source-id: 0c724c8e3a688aa9777945fcd46061284fd77969 |
||
|
dependabot[bot]
|
5f082d9267 |
Bump react-player from 1.15.3 to 2.9.0 in /desktop (#2015)
Summary: Bumps [react-player](https://github.com/CookPete/react-player) from 1.15.3 to 2.9.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/cookpete/react-player/blob/master/CHANGELOG.md">react-player's changelog</a>.</em></p> <blockquote> <h4><a href="https://github.com/cookpete/react-player/compare/v2.8.2...v2.9.0">v2.9.0</a></h4> <ul> <li>Adds previewTabIndex property to light mode <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1169"><code>[https://github.com/facebook/flipper/issues/1169](https://github.com/CookPete/react-player/issues/1169)</code></a></li> <li>Update YouTube URL pattern (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1170">https://github.com/facebook/flipper/issues/1170</a>) <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1171"><code>[https://github.com/facebook/flipper/issues/1171](https://github.com/CookPete/react-player/issues/1171)</code></a></li> <li>Support Kaltura's HTML5 player <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1082"><code>[https://github.com/facebook/flipper/issues/1082](https://github.com/CookPete/react-player/issues/1082)</code></a></li> <li>Fix suspense check for nextjs <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1165"><code>[https://github.com/facebook/flipper/issues/1165](https://github.com/CookPete/react-player/issues/1165)</code></a></li> <li>Add kaltura player types <a href=" |
||
|
generatedunixname89002005306973
|
9bccaf3951 |
Flipper Release: v0.82.0
Summary: Releasing version 0.82.0 Reviewed By: mweststrate Differential Revision: D27328585 fbshipit-source-id: 720bc154078611295664a34a567299a94a790711 |
||
|
Michel Weststrate
|
740fbe57fd |
Fix release build issue
Summary:
D24358369 (
|
||
|
Michel Weststrate
|
f095a00c78 |
Fix Flipper crashing when decoding partial encoded requests
Summary:
Changelog: Fixed an issue where Flipper would crash when decoding large partial requests.
The current processing of partial requests assumes that the proviced base64 string is always an utf-8 string, which is incorrect as it might contain binary data as well. This causes `atob` build in to throw errors when trying to decode binary base64 strings with the following exception:
{F538782963}
However, what is worse, if those strings were larger than ~2 mb, it would completely crash Electron rather than on the JS level, with reports like:
```
Crashed Thread: 0 CrRendererMain Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: EXC_I386_GPFLT
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [85268]
Thread 0 Crashed:: CrRendererMain Dispatch queue: com.apple.main-thread
0 com.github.Electron.framework 0x000000011155b16f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 22324575
1 com.github.Electron.framework 0x000000011155e811 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 22338561
2 com.github.Electron.framework 0x00000001117e2e62 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 24978002
3 com.github.Electron.framework 0x000000010fa32660 v8::internal::ClassScope::ResolvePrivateNamesPartially() + 14944
4 com.github.Electron.framework 0x000000010fa322b5 v8::internal::ClassScope::ResolvePrivateNamesPartially() + 14005
5 com.github.Electron.framework 0x000000010fa31933 v8::internal::ClassScope::ResolvePrivateNamesPartially() + 11571
6 com.github.Electron.framework 0x000000011007ef58 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 451400
```
Reproduced this JS issue by lowering the `MAX_BODY_SIZE_IN_BYTES` in `NetworkFlipperPlugin.java` to 10KB, which causes all requests to be processed as partials.
Reproducing the the Electron crash is a lot harder, as it requires a surface that makes large, binary requests (more than a few mb), that is still intercepted by the Network layer. The best example I could find is sending large pictures or videos through a messenger for android chat. In that case it is still hard to produce due to caching though.
Fun fact, you can crash your own flipper and get the above crash by running this command:
`btoa(require("fs").readFileSync("/Users/mweststrate/Desktop/Screen Recording 2021-03-24 at 16.08.27 crop.mov", "binary"))`, where the provided file must be a few mb's large (this one is 10).
A result of fixing this issue, is that images that were send as partials can now be correctly previewed in the Network plugin again.
Reviewed By: jknoxville
Differential Revision: D27302961
fbshipit-source-id: 1ac86840f7268062bb59c789f3904537df3c51fa
|
||
|
dependabot[bot]
|
2622c084df |
Bump eslint from 7.21.0 to 7.22.0 in /flipper-js-client-sdk (#2054)
Summary: Bumps [eslint](https://github.com/eslint/eslint) from 7.21.0 to 7.22.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p> <blockquote> <h2>v7.22.0</h2> <ul> <li><a href=" |
||
|
dependabot[bot]
|
d575f2d388 |
Bump @types/express from 4.17.8 to 4.17.11 in /desktop (#2065)
Summary: Bumps [types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.8 to 4.17.11. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2065 Reviewed By: passy Differential Revision: D27230321 Pulled By: priteshrnandgaonkar fbshipit-source-id: cbdad9eb0b58b9c232b798d5d90a123a7c3ebe71 |
||
|
Michel Weststrate
|
c7c75a082f |
Fix failing perf test
Summary: made a typescript booboo, and broke the test thereby. Also reduced the test set to avoid OOMs Reviewed By: passy Differential Revision: D27261187 fbshipit-source-id: bcb61bf95419421d9c33e7e0a944717797f96dfe |
||
|
Michel Weststrate
|
ba8232f30d |
Move DetailSidebar to flipper-plugin
Summary: This moves `<DetailSidebar>` component to `flipper-plugin` and documents it. No semantic changes. Reviewed By: passy Differential Revision: D27234575 fbshipit-source-id: 74640602d718f84ad999f5dac0420089796ed7fb |
||
|
Michel Weststrate
|
dd1f2fdeaa |
Move Sidebar to flipper-plugin
Summary: This diff deprecates the Sidebar concept, and copies the implementation to Sandy (tried moving first, but since existing plugins use the Sidebar in non-flex (Layout) contexts, that the layout of several plugins, so rather deprecated the old implementation. Instead of exposing `Sidebar` explicitly, one can now put the `resizable` flag on a Layout.Top/Left/Bottom/Right, which makes building layouts even simpler, see demo. The gutter logic was moved to the new implementation, since that was only used by the Sandy chrome anyway. Changelog: Layout.Top / Left / Bottom / Right now support a resizable option Reviewed By: passy Differential Revision: D27233899 fbshipit-source-id: fbbdeb2ebf30d49d0837705a00ea86bb07fc2ba2 |
||
|
dependabot[bot]
|
256b025630 |
Bump rsocket-flowable from 0.0.23 to 0.0.25 in /desktop (#2069)
Summary: Bumps [rsocket-flowable](https://github.com/rsocket/rsocket-js) from 0.0.23 to 0.0.25. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
453499568d |
Bump @types/react-transition-group from 4.4.0 to 4.4.1 in /desktop (#2066)
Summary: Bumps [types/react-transition-group](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-transition-group) from 4.4.0 to 4.4.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-transition-group">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2066 Reviewed By: passy Differential Revision: D27230132 Pulled By: priteshrnandgaonkar fbshipit-source-id: 21b2276f21b63bd98f3169559590985de795dc64 |
||
|
Pascal Hartig
|
d19eeb2a53 |
Demote android emulator "errors"
Summary: Really not errors at all. I'm getting warnings here about my Vulkan support not working. That shouldn't be logged as a Flipper error. Reviewed By: mweststrate Differential Revision: D27260607 fbshipit-source-id: 6f9d2ab0da3fe37bb5c8c185ad627ef0d581e5d5 |
||
|
dependabot[bot]
|
df71f14c77 |
Bump electron-builder from 22.9.1 to 22.10.5 in /desktop (#2068)
Summary: Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 22.9.1 to 22.10.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases">electron-builder's releases</a>.</em></p> <blockquote> <h2>22.10.5</h2> <p>We have a new maintainer — welcome Mike Maietta (<a href="https://github.com/mmaietta"><code>@mmaietta</code></a>)!</p> <p><strong>electron-updater</strong> 4.3.8 contains fix for <a href="https://github.com/electron-userland/electron-builder/issues/5595">#5595</a>. This version is a pre-release.</p> <h3>Bug Fixes</h3> <ul> <li>Look for the Amazon cred header to remove auth header (<a href="https://github.com/electron-userland/electron-builder/issues/5594">#5594</a>) (<a href=" |
||
|
dependabot[bot]
|
6589aee6f1 |
Bump @emotion/styled from 11.0.0 to 11.1.5 in /desktop (#2067)
Summary: Bumps [emotion/styled](https://github.com/emotion-js/emotion) from 11.0.0 to 11.1.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/styled's releases</code></a>.</em></p> <blockquote> <h2>emotion/styled@11.1.5</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href=" |
||
|
dependabot[bot]
|
fd9b5b562a |
Bump spectron from 11.0.0 to 14.0.0 in /desktop (#2071)
Summary: allow-large-files Bumps [spectron](https://github.com/electron/spectron) from 11.0.0 to 14.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron/spectron/releases">spectron's releases</a>.</em></p> <blockquote> <h2>v13.0.0</h2> <p>No release notes provided.</p> <h2>v12.0.0</h2> <p>No release notes provided.</p> <h2>v11.1.0</h2> <p>Upgraded webdriverio to 6.1.20 <a href="https://github.com/electron/spectron/issues/631">https://github.com/facebook/flipper/issues/631</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/electron/spectron/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2071 Test Plan: Imported from GitHub, without a `Test Plan:` line. yarn test-e2e Test Suite Succeded after running yarn test-e2e Reviewed By: passy Differential Revision: D27230110 Pulled By: priteshrnandgaonkar fbshipit-source-id: d6d2d6c1482fa563b9dde9472467f918496e2cea |
||
|
dependabot[bot]
|
12717e1b9d |
Bump app-builder-lib from 22.9.1 to 22.10.5 in /desktop (#2072)
Summary: allow-large-files Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder) from 22.9.1 to 22.10.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases">app-builder-lib's releases</a>.</em></p> <blockquote> <h2>22.10.5</h2> <p>We have a new maintainer — welcome Mike Maietta (<a href="https://github.com/mmaietta"><code>@mmaietta</code></a>)!</p> <p><strong>electron-updater</strong> 4.3.8 contains fix for <a href="https://github.com/electron-userland/electron-builder/issues/5595">#5595</a>. This version is a pre-release.</p> <h3>Bug Fixes</h3> <ul> <li>Look for the Amazon cred header to remove auth header (<a href="https://github.com/electron-userland/electron-builder/issues/5594">#5594</a>) (<a href=" |
||
|
dependabot[bot]
|
afa98856e7 |
Bump @types/rsocket-core from 0.0.5 to 0.0.6 in /desktop (#2073)
Summary: Bumps [types/rsocket-core](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/rsocket-core) from 0.0.5 to 0.0.6. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/rsocket-core">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2073 Reviewed By: passy Differential Revision: D27230092 Pulled By: priteshrnandgaonkar fbshipit-source-id: f98022c5c002a415b705d6833844b341882c2657 |
||
|
Michel Weststrate
|
ea0cc7f15b |
Update to Immer 9 for better type inference
Summary: Per title Reviewed By: passy Differential Revision: D27202660 fbshipit-source-id: 074c44275a93c3fb35d2f491b51d82aa9792dd70 |
||
|
Michel Weststrate
|
8f90deda55 |
Minor UI improvements
Summary: Addresses feedback from: https://github.com/facebook/flipper/issues/2076 - fix filtering non-string columns - fix overflow in filter dropdown - hide app column on all devices - show pid column on android, to simplify filtering per app Reviewed By: passy Differential Revision: D27188458 fbshipit-source-id: b6180fb5a8d0a47e50dd5dc3533da3ff1b0a1a2e |
||
|
Michel Weststrate
|
c648c58825 |
Support RegEx search
Summary: Changelog: Restored the possibility to use Regex in logs search Fixes: https://github.com/facebook/flipper/issues/2076 https://fb.workplace.com/groups/flipperfyi/permalink/912753022824327/ Reviewed By: passy Differential Revision: D27188241 fbshipit-source-id: 38ae2972c7dd3dd5cf24df87535d5ad74598cd88 |
||
|
Pascal Hartig
|
2ae7d13a64 |
Strip application path from stack traces
Summary: Stacktraces right now always contain the `/home/$USER/.cache/flipper-launcher/v1.2.3/...` (or equivalent) which makes deduping and reading harder. This strips the paths. Reviewed By: mweststrate Differential Revision: D27130251 fbshipit-source-id: c0e8d5eb1575c6269d49a6aee0e8a5e93996d223 |
||
Rubén Norte
|
28480ac891 |
Format Metro log messages using printf format
Summary:
In browsers and Node.js, console methods accept a printf format string as a first argument:
```
console.log('Hello %s', 'world');
//> Hello world
```
This is not currently supported in Flipper, which just renders the log messages as they come from Metro (as an array of values, most often strings).
This adds support for it in Flipper by using the `util.format` function from Node.js (which is the same method used by the console under the hood).
It is implemented in Flipper and not in Metro so we have the flexibility to format the values as we want in the future (e.g.: numbers with a specific color).
Reviewed By: yungsters, mweststrate
Differential Revision: D27154864
fbshipit-source-id: e807b67900ddaf3a7e8cd86795589bed088beecd
|
||
Anton Nikolaev
|
bb827f14ea |
Normalize import path
Summary: Just a small fix to normalise import path to make typescript happy when this code is located in "flipper" folder (e.g. after installing "flipper" package as dependency) rather than "app" folder. Reviewed By: jknoxville Differential Revision: D27156167 fbshipit-source-id: 24495d6b1a756b20fadf62eec18bfe6665eb78e2 |
||
|
Pascal Hartig
|
9b44305f1c |
Remove logger dependency
Summary: Found that one of the parameters wasn't used for anything making it harder to make sense of the construct and test it. Reviewed By: nikoant Differential Revision: D27117591 fbshipit-source-id: f4c796dd37b0bd75497710fb9f88c923181f90e1 |
||
|
Pascal Hartig
|
414dd4d5ff |
Demote errors in crash reporter
Summary: Not fatal errors and actually very, very high-firing. Something about the serialisation here is wrong so I can't tell the exactly number right now. Reviewed By: priteshrnandgaonkar Differential Revision: D27117067 fbshipit-source-id: d9ce8c736ca2228acedeadeb2e7ee6744d766265 |
||
|
Pascal Hartig
|
81252edf33 |
Upgrade to Electron 12.0.1
Summary: Changelog: Upgraded to Electron 12.0.1 Reviewed By: fabiomassimo Differential Revision: D27084184 fbshipit-source-id: 5d45c632f7fec78635287f1919ef1cf0b2b458ad |
||
|
Anton Nikolaev
|
f468f0e07d |
Produce tsc typings for "flipper" package
Summary: This diffs refactors tsc projects structure and structure of our custom typings to allow producing typescript typings for "flipper" package. In next diffs I'm going to use the produced typings to check compatibility of plugins with certain versions of Flipper, e.g. to check whether plugin is compatible with current "stable" and "insiders" version. Reviewed By: passy Differential Revision: D26997158 fbshipit-source-id: a0416c7139bf08ec9d175730da4c4c2a8768eeb7 |
||
|
generatedunixname89002005306973
|
0293a2a5fb |
Flipper Release: v0.81.0
Summary: Releasing version 0.81.0 Reviewed By: priteshrnandgaonkar Differential Revision: D27114449 fbshipit-source-id: bcf89ccb61aedc7413d4031da42b10971e3808fa |
||
|
Michel Weststrate
|
4f70219a47 |
Dispose iOS logs if logs plugin is not connected
Summary: See D27047041 (
|
||
|
Michel Weststrate
|
9d3c48fd84 |
Logs2 -> Logs
Summary: Use Logs2 plugin now as the default logs plugin (by overwriting it). See the rest of this stack Changelog: The device logs plugin has been fully rewritten. It is faster and more reponsive, formats urls and json, and supports line wrapping and text selection. Beyond that it is now possible to sort and filter on all columns and pause and resume the log stream. Reviewed By: nikoant Differential Revision: D27048528 fbshipit-source-id: e18386fec6846ac3568f33a3578f4742213ecaca |
||
|
Michel Weststrate
|
d293b2b0e5 |
Dispose adb logcat connection if there are no listeners
Summary: Flipper used to always subscribe to the adb logs. This change makes the log subscription lazy, which means if there are no plugins listening to the logs, we don't subscribe to the adb logs at all. As you can see in the recording (prod build) this lowers CPU usage significantly: without logs plugin disabled it is now ~5-8 %, with the plugin enabled ~12-18%. Before this change we would never stop listening to the log output, even when the plugins were disabled, causing a constant background noise which people complain regularly about. The pause / resume button in the new log plugin will now cleanup the connection as well, so that a simple 'pause' click will already boost performance, without needing to disable the logs plugin (if crash reporter is not enabled) In this diff we also will clear the logs when reconnected. Previously we didn't reset the logs after connecting, we means Flipper would try to gets up with all past logs first, which could be a few 100 K entries. Further future optimizations could involve using logcat smarter; by actually passing filters on app or loglevel to the command (not sure if that is actually faster, or just a convenience api that does the same filtering as we do) Changelog: Flipper will now use less CPU if logs & crash reporter plugins are disabled by no longer tailing adb logcat. Reviewed By: nikoant Differential Revision: D27047041 fbshipit-source-id: 251a04dcc6f488f220cb56fe50a26788d795e38c |
||
|
Michel Weststrate
|
de92495f04 |
Table optimizations
Summary: Performance fine tuning. Did some performance fine-tuning primarily by creating a production build, and verifying the responsiveness of searching, tailing etc in the logs plugin while generating a lot of load, and finetuned based on that. For example stopped using requestAnimationFrame which is too sensitive of starving Flipper under high load, as it doesn't leave room for other events to be processed. Also made scrolling smoother by making an append 'high prio' update while taililng. Also debounced changing the (search) filters, as that is an expensive operation we don't want to trigger on every key press Reviewed By: passy Differential Revision: D27046726 fbshipit-source-id: c3efe59eb26e2d9e518325d85531a0e4a6b245ca |
||
|
Michel Weststrate
|
6a30899803 |
Kill onRegisterDevice
Summary: `onRegisterDevice` device abstraction was only used by the CrashReporterPlugin, and since with Sandy plugin lifecycles every plugin can do 'on-load' logic, we don't need it anymore. Reviewed By: priteshrnandgaonkar Differential Revision: D27046711 fbshipit-source-id: 16c567c60ed29a50017d525a2b707ee696a99e62 |
||
|
Michel Weststrate
|
87c5fab607 |
Convert crash reporter plugin to Sandy (non UI only)
Summary: This diff converts the CrashReporter plugin to Sandy. The main driver is that it allows us to fix the connection management of logs in a next diff. There are few changes to highlight: * A bunch of the old unit tests are removed, as they primarily verified that persistedState abstraction works, a concept that doesn't exist anymore with Sandy (as a result all the logic in error handling and crash reporter plugin has become a lot more trivial as well) * Added additional unit tests to verify that the integration with notifications from Sandy, and the integration of crashes in combination with CrashReporter plugin works (this wasn't the case before) * Plugin errors were always suppressed in production builds of Flipper. However, that makes error reporting pretty pointless in the first place, so enabled it by default, but made it a setting in case this results in too many errors suddenly. * The integration with clicking OS crash notification -> bringing the user to a sensible place _doesn't_ work, but it didn't work before this diff either, so will address that later * This doesn't upgrade the Crash reporter UI to sandy yet, will do that later in a separate diff Changelog: Crash reporter will now report errors triggered from the device / client plugins by default. This can be disabled in settings. Reviewed By: priteshrnandgaonkar Differential Revision: D27044507 fbshipit-source-id: 8233798f5cce668d61460c948c24bdf92ed7c834 |
||
|
Michel Weststrate
|
7093a932f8 |
expose client.writeTextToClipboard
Summary: per title Reviewed By: priteshrnandgaonkar Differential Revision: D27044508 fbshipit-source-id: 8af99f66ec8203b76ccb3d880e1a184193a389c7 |
||
|
Michel Weststrate
|
4e2383cdb0 |
Introduce showNotification API
Summary: Introduced `showNotifcation` to the Sandy API. Reviewed By: jknoxville Differential Revision: D27012001 fbshipit-source-id: d3f237910a478400b0f925f0362af485c96072bb |
||
|
Michel Weststrate
|
2ca52f81d2 |
Introduce pluginKey
Summary: Exposed the `pluginKey` to sandy plugins (which we will use later for storing table preferences per plugin). And a little moving code around because circular deps problem roared its ugly head again. Reviewed By: nikoant Differential Revision: D27009721 fbshipit-source-id: 7ad29e72ff8028c9daae270c4749b657bd8ff049 |