Summary:
Update our README file with an announcement of our distribution change. I will pair the announcement with an update to our GitHub workflow as to not produce any more Electron builds for future releases.
Changelog: Flipper Electron distribution change announcement.
Reviewed By: aigoncharov
Differential Revision: D51616454
fbshipit-source-id: 5ff513b3d99c8100ed8241d1bdafebf1d6dcfa10
Summary:
This diff switches to `softprops/action-gh-release@v0.1.15` for creating a release since `actions/create-release` is *archived* and is **NOT maintained**.
### Ref.:
- `actions/create-release` archived and not maintained notice: https://github.com/actions/create-release
- `softprops/action-gh-release@v0.1.15` changelog: https://github.com/softprops/action-gh-release/releases/tag/v0.1.15
## Changelog:
[GENERAL] [SECURITY] - [Actions] `release` - Switch to `softprops/action-gh-release@v0.1.15` to create a release
Pull Request resolved: https://github.com/facebook/flipper/pull/4870
Test Plan: - Workflow should run and work as usual.
Reviewed By: lblasa
Differential Revision: D47829486
Pulled By: passy
fbshipit-source-id: fea3b9ed7b76736bcc85d6bd1fa43a14d10a8763
Summary:
It's currently failing and a few according to [the docs](https://github.com/benc-uk/workflow-dispatch) the token we supply shouldn't be necessary.
Pull Request resolved: https://github.com/facebook/flipper/pull/4495
Test Plan:
Sadly only one way:
testinprod
Reviewed By: lblasa
Differential Revision: D42989714
Pulled By: passy
fbshipit-source-id: e758340a583e351ff4e384514b70fecdf8bb3129
Summary:
The release workflow is using a version of the github release action that is broken, due to ghr now being dynamically linked and not compatible with Alpine Linux's minimal version of libc. The fix is to use the version of the action which installs gcompat so that ghr can run on the docker image.
## Changelog
Update release workflow to use version of action compatible with latest version of ghr.
Pull Request resolved: https://github.com/facebook/flipper/pull/4220
Test Plan: N/A
Reviewed By: nikoant
Differential Revision: D40443738
Pulled By: aigoncharov
fbshipit-source-id: 7765420fbe034aa80ce07c698ff83773c81ed52f
Summary:
The publish job in the release workflow has been failing, but an issue has failed to be created due to the template file not being found. As per the error message, the template file isn't found because we need to check out the repo first.
## Changelog
Fix problem with auto-creating issue upon publish failure.
Pull Request resolved: https://github.com/facebook/flipper/pull/4209
Test Plan: Not able to run this locally, so we will need to wait upon the next release to ensure the issue gets created.
Reviewed By: mweststrate
Differential Revision: D40341329
Pulled By: aigoncharov
fbshipit-source-id: a9ad0a52a41ca13757fdd674937a075a024f618f
Summary:
This is really stupid but the download creates a directory with the same name before putting the file in it. I think `v2` no longer does but hey, this is the devil we know.
You can look at the actions further down to see that we reference all the other downloads by `filename/filename` as well, so this should do it.
Pull Request resolved: https://github.com/facebook/flipper/pull/3366
Test Plan: Another release, I'm afraid. This is a step you cannot dry-run.
Reviewed By: cekkaewnumchai, aigoncharov
Differential Revision: D33842700
Pulled By: passy
fbshipit-source-id: d6f7a4a711ec056ba16f13c72f2c550e9a632ac0
Summary:
It's late Friday now and we still don't have a release out.
Let's revert this once we've got one stable build out.
Pull Request resolved: https://github.com/facebook/flipper/pull/3291
Reviewed By: fabiomassimo
Differential Revision: D33584907
Pulled By: passy
fbshipit-source-id: 1117a177c8eb12c7db69a53ad0bc949b53aaf04f
Summary:
This previous attempt didn't work. Not even sure what happens now, it seems to just return the result of a boolean evaluation? Cool.
Still haven't verified that this works in the release build but noticed that we do effectively the same in the build step. By upgrading to the same revision of the action we use and then switching from `&&` to simply `;`, we can be reasonably sure that this will work now.
The alternative would be to switch to `pwsh` which appears to be the new name. `powershell` is the default shell and seems to be an older version without support for `&&`. I honestly never want to touch this or read about it again, so let's go with the simpler option.
Pull Request resolved: https://github.com/facebook/flipper/pull/3289
Reviewed By: aigoncharov
Differential Revision: D33582853
Pulled By: passy
fbshipit-source-id: 7c70ff360a5c327139b6ecb5463e85883a2caf9d
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3211
The GH retry action did ate all the stdout / stderr, so if the retry fails, it was completely unclear why. This was fixed in a newer version of the action
Reviewed By: antonk52
Differential Revision: D33308437
fbshipit-source-id: a599161e0c72b95b35e6ecab8cd84c6fa7027cd3
Summary:
I've been investigating the now persistent upload issue for our artifacts and it appears to come down to artifacts being uploaded and downloaded as folder structures while they used to be individual files.
Annoyingly, the `ghr` tool we use for uploading throws a cryptic and misleading error: https://github.com/facebook/flipper/runs/4314584032?check_suite_focus=true
There is some more control in the `v2` version of the actions but for now, this seems like the safer option to fix this problem.
{F682461661}
Reviewed By: lblasa
Differential Revision: D32649218
fbshipit-source-id: 47ebefc434cb3b928b82a9fe8da3002b7b8465b6
Summary:
Fixed an issue with the setup of the retry script:
31ee58a796
Reviewed By: nikoant
Differential Revision: D32644463
fbshipit-source-id: 23ac1508784f24e9403e0bca0091f05847a9e91d
Summary:
We've done this for the "release" part of the workflow
before but need to handle the "publish" branch separately.
Pull Request resolved: https://github.com/facebook/flipper/pull/3071
Test Plan: _eyes
Reviewed By: nikoant
Differential Revision: D32532348
Pulled By: passy
fbshipit-source-id: 622ed99ba509d4eaf7671e9b6ff3adbab277ab4e
Summary:
We're seeing some spurious failures, unrelated to any changes on our end.
I've upgraded the action to do two things:
- Retry on failure (up to three times): b0dfcdf1c7
- Replace the artefact if it's already present (otherwise this might fail subsequent retries): 92bec0ba48
Pull Request resolved: https://github.com/facebook/flipper/pull/3070
Reviewed By: nikoant
Differential Revision: D32532277
Pulled By: passy
fbshipit-source-id: f1899c89c405772490958674fa7f46f479c666f9
Summary: I upgraded the docker image which should pull the latest GHR release (https://github.com/tcnksm/ghr).
Reviewed By: lblasa
Differential Revision: D31442256
fbshipit-source-id: 0f9fa81ec1be1285aea3da621b7ef5a1e63c3e84
Summary:
I believe that matches what we have internally. This has been causing some upgrades to fail.
Pull Request resolved: https://github.com/facebook/flipper/pull/2928
Reviewed By: aigoncharov
Differential Revision: D31324394
Pulled By: passy
fbshipit-source-id: eec38dcc6322e3e8957bbc20bf74d343855be8c0
Summary: Adds an action for publishing packages to npm. Secret was added as part of T80403944.
Reviewed By: nikoant
Differential Revision: D25195740
fbshipit-source-id: 51d43d9f5e84a25a67b637233b2c62a9a1a15063
Summary: Just a small mispelling in step specification
Reviewed By: mweststrate
Differential Revision: D25053437
fbshipit-source-id: 39e7c9c578a448495b92f8aa3632b2843d79490c
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1687
I cleaned up and tagged both of the custom actions.
It's much better to pin them down properly so that
future changes on `main` don't break anything.
Reviewed By: nikoant
Differential Revision: D24996462
fbshipit-source-id: 6d63e76b758439ba8df4ef2f5b77992789744e7b
Summary:
GitHub only issues one push event for multiple commits.
This causes things to behave weirdly. My action now
looks for a commit with a certain message and runs
the subsequent steps on it. If there's more than one
matching commit, it uses the last one. Not great, not terrible.
Pull Request resolved: https://github.com/facebook/flipper/pull/1678
Test Plan: Ran it on my fork: https://github.com/passy/flipper-1/actions/runs/360332680
Reviewed By: nikoant
Differential Revision: D24955986
Pulled By: passy
fbshipit-source-id: 6dcbe11e69bf77c803e3907ced3185ca85483ec8
Summary: Had the `PERSONAL_TOKEN` put in place by the OSS oncall. Still won't know if it has the right permissions until we run this. :/
Reviewed By: nikoant
Differential Revision: D24833829
fbshipit-source-id: 4fbf6e0b0abbc50d0b9a1e9b7ca8b02f6e1f5171
Summary:
Noticed that the icon download fails occasionally from GitHub.
This adds a few retries in case that happens.
Reviewed By: nikoant
Differential Revision: D24647690
fbshipit-source-id: 3ed84cb0972b7715fd87c8b1e1e1bca9f89485a9
Summary:
As part of our release confidence effort, this replaces the flaky internal task that creates the tag, promotes it to a release and uploads the artifacts to it.
Instead, we do all this in one lengthy GitHub Action. There seems to be some duplication here but this is because of the unfortunate restriction GitHub Actions imposes to avoid recursive Actions. I.e. we cannot create a tag/release and have another, independent Action pick up from there to do the building and releasing.
The `passy/` references were necessary because existing Actions didn't quite what we wanted to:
- `tag-version-commit` expected the title of the commit to match the precise tag to create. However, we want to use a regex to *extract* from the "Flipper Release: vA.B.C". My fork allows specifying a grouping regex for that.
- `github-upload-release-artifacts-action` relied on being triggered by a tag. As described above, that's not possible with this setup. Instead, this takes an existing tag and attaches to it.
Reviewed By: nikoant
Differential Revision: D24627518
fbshipit-source-id: 8121df6aa7bd36bda28e0d3cb207a002cd127647
