Summary:
Original commit changeset: ff84080d43fa
This re-adds JS client support. The original version had a small bug that inadvertantly wrapped support for Android emulators in the dropdown in a GK that was only meant to cover JS clients. This is addressed here.
Reviewed By: timur-valiev
Differential Revision: D18707485
fbshipit-source-id: ceea8e279a21111f96073f8b784e852f6313e2a4
Summary:
Original commit changeset: 56d1ca1a60ed
This broke Android support in some instances. We haven't had a chance to investigate this yet, but this should cleanly reapply, so we can figure out what happened after the release.
Reviewed By: cekkaewnumchai
Differential Revision: D18688590
fbshipit-source-id: ff84080d43fa481cc8c8c669a76aed15d0f8aa56
Summary:
### Connecting Flipper with JS apps by using electron's BrowserWindow and IPC
1. UI: there is a menu item in Devices tab which opens JS Emulator Launcher Sheet. Here we can configure URL to open and initial size of the window.
2. BrowserWindow, preloaded js: there is SupportJSClientPreload.js which initialize communication between flipper and app via electron's ipc
3. On flipper's side there is src/utils/js-client/serverUtils.tsx which contains most of JS emulator related code
4. Extracting of FlipperClientConnection: since we don't use RScocket to communicate with JS app I extracted needed methods to FlipperClientConnection (located in Client) and partly implemented them in JSClientFlipperConnection (requestResponse is just send a message now, doesn't return actual result)
Reviewed By: jknoxville
Differential Revision: D18572882
fbshipit-source-id: 56d1ca1a60ed2e51329b917021a09382cbb1ceec
Summary:
- Basic Doctor UI showing issues with installation
- Run healthchecks in background on startup and show warning message if something is wrong
Reviewed By: jknoxville
Differential Revision: D18502599
fbshipit-source-id: 194939a080ba7412ed3293d95c533bfad7031d3b
Summary:
Found some unused code from the rating prototype before switching to itsr.
Deleting it.
Reviewed By: cekkaewnumchai
Differential Revision: D18298155
fbshipit-source-id: 3529db17494f4f5bf7d7841460203d1c3856299a
Summary: This diff moves support form related redux prop to a separate reducer under separate supportForm property.
Reviewed By: passy
Differential Revision: D18272436
fbshipit-source-id: b64c4e041d8dacd305a71db255752a310a46b0d1
Summary:
This diff introduces the following improvements which I got as a feedback from the user
1) Before this diff the text entered used to vanish away when one switched tabs and came back to the support form. This diff takes care of that.
2) With this diff user can rexport the flipper trace to override the previous cached state too.
- For this I had to update the UI to show flipper trace a separate input box, rather than appending it in the question field.
- This avoided the the appending of the text in flipper trace and facilitated the easy override of the trace
3) With this diff one can also override commit_hash without appending multiple text.
WWW changes: D18250494, Do not land until this diff is landed.
Reviewed By: passy
Differential Revision: D18257524
fbshipit-source-id: 119edadf90ac95cb296c10520239513f1fef905d
Summary: This diff adds the support to close the dialog automatically for the support form.
Reviewed By: passy
Differential Revision: D17899862
fbshipit-source-id: 9d9cd14556a4cebe60f8cc1d082be3e439998e9c
Summary:
Queries xcode-select on ios dispatcher startup, to see if it's installed.
If it is, carry on with the ios device tracking, if not, don't bother.
This should stop it from emitting errors trying to track devices when things aren't installed.
I think it should also stop those install prompts from popping up.
Sets it in app state so we can tell the user about it, and maybe gate some other things too.
Reviewed By: passy
Differential Revision: D17830696
fbshipit-source-id: 960d09a9c5267afabf5e5e222379a0a7ed2cc444
Summary:
Adds a simple UI for editing settings, a reducer and persistance config for the data.
These values aren't yet used for anything.
Reviewed By: passy
Differential Revision: D17684490
fbshipit-source-id: e76ac43ffa17d3606e59f4a1ccb940e8d9fbd9e8
Summary: Shows status messages for the Support Form
Reviewed By: passy
Differential Revision: D17601944
fbshipit-source-id: a2a8ad392dfbaf467625eb809020d687d066da57
Summary:
This diff adds a status bar, which can be used to show the status messages, for example for Litho Support Form.
The logic for the status bar is as follows:
It maintains the array of the messages. At any point it shows the last pushed message. It will keep showing that message until it is being removed, once removed it will show second last message. The messages will be removed as and when its corresponding task/Promise is fulfilled.
Reviewed By: danielbuechele
Differential Revision: D17551495
fbshipit-source-id: 96b2f401599b9ee8a472607e6a2f027e63b3b807
Summary: This diff sets up Flipper to attach flipper trace to the support form. This diff adds a property named `exportResult` in the redux store. This will hold the export url or the path of the export, depending on the type of the flipper export. Once the exportResult is populated, we listen for this change and update the button style and fill the comment box.
Reviewed By: passy
Differential Revision: D17478491
fbshipit-source-id: 10dd5e130a9e3df5f41afde42b92b08959d9ed9e
Summary: Adding the plugin installer to the plugin sheet as a second tab
Reviewed By: passy
Differential Revision: D17450842
fbshipit-source-id: 211c9f15ed2614a1dd46d974b86f50c825f81fb0
Summary: Setting up a sheet to list plugins that can be installed from NPM
Reviewed By: jknoxville
Differential Revision: D17394824
fbshipit-source-id: 26c6ffea9de9cf3fe8488ea1a757eae7b7aaa7ef
Summary:
Pritesh and I both decided to re-add these functions without knowing that the other person had already re-added them.
Got through to master and now master won't build.
Reviewed By: priteshrnandgaonkar
Differential Revision: D16762774
fbshipit-source-id: 4a05d9e03cb043a6f398f57f2652a3ec15bd8985
